GitLab

Updates postMessage() to clone FileSystemFileHandle and
FileSystemDirectoryHandle objects for same origin targets.  Including
a FileSystemHandle object with a cross origin message fails by
dispatching a 'messageerror' event instead of 'message' event.

The change consists of four parts:

(1) Updates V8ScriptValueSerializerForModules to serialize
FileSystemFileHandle and FileSystemDirectoryHandle into
blink::SerializedScriptValue, by following these steps:

 * Write a tag for the handle type (file or directory).

 * Write the name of the file or directory.

 * Creates a mojom::blink::NativeFileSystemTransferTokenPtr  by calling
   blink:NativeFileSystemHandle::Transfer().  This token informs the
   storage::NativeFileSystemManagerImpl that a transfer is in progress.
   The NativeFileSystemManagerImpl creates a
   NativeFileSystemTransferTokenImpl to store the information required
   to clone the handle.

 * Stores the token in
   blink::SerializedScriptValue::native_file_system_tokens_.  This
   array tracks all cloned FileSystemFileHandle. The
   blink::mojom::CloneableMessage struct is also updated to hold this
   array for MessagePort and BroadcastChannels.

 * Write the index of the token in the native_file_system_tokens_
   array.

(2) Updates V8ScriptValueDeserializerForModules to deserialize
FileSystemFileHandle objects when creating clones for the message
targets.  This is the inverse of (1).  Deserializing uses
mojom::blink::NativeFileSystemManager to redeem the token, which
creates the mojom::blink::NativeFileSystemFileHandlePtr or
mojom::blink::NativeFileSystemDirectoryHandlePtr using the info
stored by NativeFileSystemTransferTokenImpl.

(3) Updates content::NativeFileSystemManagerImpl to support token
transfers.  To redeem a token, NativeFileSystemManagerImpl receives
a mojo message that includes the token as well as a request for a
handle interface like mojom::blink::NativeFileSystemFileHandlePtr.
NativeFileSystemManagerImpl finds the token and then binds the request.
Token redemption does not return any results.  Token redemption should
never fail, unless a render process is misbehaving.
NativeFileSystemManagerImpl performs a few sanity checks before binding
the mojo request, including a token existence check, a handle type
check and an origin check.  If any of the sanity checks fail,
NativeFileSystemManagerImpl silently fails closing the redeemed
FileHandle's pipe.

(4) Adds a cross origin check to window and message port messaging.
Most message targets, like dedicated workers, are same origin only.
However, both windows and message port messages can go cross origin.
When a cross origin message includes a FileSystemHandle, the message
must fail with a 'messageerror' event to prevent cross origin access
to the FileSystemHandle.

Messaging between windows already included origin information before
this change. This change adds a NativeFileSystem origin check before
dispatching a message event to a window.  The message event is
replaced with  a message error when a cross origin NativeFileSystem
object exists in the message data.

For message ports, no sender origin information existed before this
change.  This change updates the CloneableMessage structs to
include a 'sender_origin' url::Origin property.  Message ports use
this property to perform the same cross origin NativeFileSystem
check as the window.

The NativeFileSystemManagerImpl performs an additional origin check
before binding the FileSystemHandle mojo request.  The
NativeFileSystemManagerImpl cannot trust the postMessage() origin
check performed in the render process.

Bug: 955192
Change-Id: Ieeb76bd8102067d70c5d7719622ecd4930c3a88f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791942
Commit-Queue: Steve Becker <stevebe@microsoft.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709407}

This reverts commit 4fcce6d7.

Reason for revert: SCBadgeTestCase.testBadgesVisible is failing consistently after this CL:
https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/5469

Original change's description:
> [ios] Fix BadgeViewController interpretation of badgeState
> 
> Since BadgeState is a mask, a direct equality comparison to
> BadgeState values for the BadgeItem properties is not the correct
> way to assess if a badge is accepted.
> 
> To add testing support for this case, accepted a11y identifiers
> for BadgeButtons are created, and they will be properly set
> in setAccepted: in BadgeButton.
> 
> Bug: 976901, 1016793
> Change-Id: Id17eb82e0764fbbf80b871df0b974fe148c2339f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872938
> Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709037}

TBR=pkl@chromium.org,sczs@chromium.org,thegreenfrog@chromium.org

Change-Id: I7cc7f67cbb24a962388c2079a71e9e168c32fdfb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 976901, 1016793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880029Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709406}

In the other reftests the width of the marker text is not known, so the
references have to rely on some tricks with the ::before pseudo-element.

This patch adds a test that uses the Ahem font, so that the width of the
characters is known. Then the result can be checked with a simpler
reference file.

Note it fails in LayoutNG due to the lack of scrollbar (bug 1012294),
but it passes in legacy.

Bug: 687946
Change-Id: I7fd0856e93d4e489af65b5c767ec81c109804c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879067
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709405}

GCC build fixes because of missing include of <memory>:
../../chrome/browser/ui/views/bubble_menu_item_factory.h:20:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
 std::unique_ptr<views::LabelButton> CreateBubbleMenuItem(

Bug: 819294
Change-Id: I1c48566175e313e964e4a474daa444eb4fccf3bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879229
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709404}

Trivially moves all helper functions and classes to the existing
bookmarks_helper namespace.

Bug: None
Change-Id: I9947b8437bc28e84de0b905a3e1bd4e9ef3292af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879912
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#709403}

This reverts commit b3a546fe.

Reason for revert: 
On Win and Linux rel builder and others:

ninja explain: output gen/third_party/blink/renderer/bindings/core/v8/v8_example.cc doesn't exist

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898644624214693520/+/steps/compile_confirm_no-op/0/stdout

Original change's description:
> bind-gen: Support generation of function definitions.
> 
> This is just a first step to support the code generation
> of bindings callback functions.
> 
> Introduces CodeGenerationContext for convenience, and
> also demonstrates make_common_local_vars().
> 
> Bug: 839389
> Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709389}

TBR=peria@chromium.org,yukishiino@chromium.org

Change-Id: I99f572736c546f5f7078c6653d963264e6622512
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879933Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709402}

This is a reland of 93e10d47. The original
change was reverted due to a clusterfuzz report, but this CL seems innocent so
I'm relanding this.

Original change's description:
> Introduce QuicTransport
>
> This is the first CL to implement QuicTransport. This CL
>  - creates a directory in blink,
>  - introduces a new blink runtime feature flag, and
>  - defines QuicTransport IDL interface behind the flag,
>
> Bug: 1011392
> Change-Id: Id432cee2b6d5df6ab4a4c3e8aa6828d5a7937dd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868569
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707303}

TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,tkent@chromium.org

Bug: 1011392, 1016436
Change-Id: Iad9e785cd5886c7b2d2e25fe55f3b5f327727f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880502
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709401}

This collects metrics for the length of phone numbers and the number of
digits in them. These are collected when shown to the user and when the
user actually selects a device to send that number to a device. We also
distinguish between the entry points of right and left click on links
and text selections.

The new metric name is built like this:
Sharing.ClickToCallPhoneNumber{Length,Digits}.
  {LeftClickLink,RightClickLink,RightClickSelection}.
  {Sending,Showing}

Bug: 1001033
Change-Id: I59ed705170153b8adcbe00021cedb5118f1cf27b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878198Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709400}

This replaces the png versions with vector images. In a local debug
build this saves about 15kb. Both vector images have the same content
except their colors. This could potentially be further optimized using
alpha blending so we only need the image once and it blends onto the
background.

Bug: 1013099,999976
Change-Id: Ic56b40c87dc5011a9babba787a3545b42df5d459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863025Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mitsuru Oshima (slow) <oshima@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709399}

GCC build fix as build fails with this:
../../base/profiler/register_context.h:31:1: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
 uintptr_t& AsUintPtr(T* value) {
 ^~~~~~~~~
 intptr_t
../../base/profiler/register_context.h:110:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
   uintptr_t stack_pointer;
   ^~~~~~~~~
   intptr_t
../../base/profiler/register_context.h:111:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
   uintptr_t frame_pointer;
   ^~~~~~~~~
   intptr_t
../../base/profiler/register_context.h:112:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
   uintptr_t instruction_pointer;
   ^~~~~~~~~
   intptr_t
../../base/profiler/register_context.h:115:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
 inline uintptr_t& RegisterContextStackPointer(RegisterContext* context) {
        ^~~~~~~~~
        intptr_t
../../base/profiler/register_context.h:119:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
 inline uintptr_t& RegisterContextFramePointer(RegisterContext* context) {
        ^~~~~~~~~
        intptr_t
../../base/profiler/register_context.h:123:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’?
 inline uintptr_t& RegisterContextInstructionPointer(RegisterContext* context) {
        ^~~~~~~~~
        intptr_t

Bug: 819294
Change-Id: I49567b00a6f021686c52053a22fb9c502c84f1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879908Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#709398}

Until today, 105 CLs were submitted, and 40 CLs were
reviewed by me for platform/loader and OOR-CORS projects.

Change-Id: Ia3051e06bc7d1e2604c3ee190a308e7d9ff5a5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880496Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709397}

ScopedVAImage release()s the unique_ptr of ScopedVABufferMapping on destruction.
However, release() doesn't execute ScopedVABufferMapping()'s dtor because it
just passes someone the ownership. We should call reset other than release.

Bug: 1018085
Test: camera.*JPEG
Change-Id: Ifc4b2133b33b2c7b0f08c899cb714881f9ffbaab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880891
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709396}

according to specs

Bug: 1017117, 1017173
Change-Id: I1301d9fe730ba63234367f812175d02cc0def1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876349
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709395}

Currently only ChromeOS platform uses VideoFrameConverter. This CL
moves the related files to //media/gpu/chromeos.

BUG=chromium:1012587
TEST=gn check on kevin and eve
TEST=ninja chrome on kevin and eve
TEST=ninja media_unittests

Change-Id: I73334bec4b9eee812c3b4c88f3a0230b5a003cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877493
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709394}

In particular, it doesn't depend on the mojo preferences service, so
eliminate those includes.

Forward declare a couple things in pref_service_syncable.h as well.

Bug: none
Test: compiles
Change-Id: If7d70388fb5903fb932bd4928a993d1a80cea55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879568
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709393}

https://skia.googlesource.com/skia.git/+log/ad5be17f5599..24a409611f24

git log ad5be17f5599..24a409611f24 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b2885bc4a40f..77fba58c9658 (16 commits)

Created with:
  gclient setdep -r src/third_party/skia@24a409611f24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: chromium:None
Change-Id: Icf604895d9dda00fa5ff0a9a2f871fbffc53c4d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709392}

Add two tests (localhost and 127.0.0.1) for module service workers.

Bug: 954853
Change-Id: Ic530766c58807491e10c6de8b53cd047299891ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880500
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709391}

Parse ::marker as a valid pseudo-element, behind an experimental flag.
The actual logic of ::marker will be implemented in follow-up patches.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8v7pouXxxAc

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

Bug: 457718

TEST=external/wpt/css/css-pseudo/parsing/tree-abiding-pseudo-elements.html
TEST=external/wpt/css/css-scoping/slotted-parsing.html

Change-Id: Ia4014afdbf5d0f2a642f349641140b03dfceee22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876407
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709390}

This is just a first step to support the code generation
of bindings callback functions.

Introduces CodeGenerationContext for convenience, and
also demonstrates make_common_local_vars().

Bug: 839389
Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709389}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93afefce3091..e4822cdce35a


Created with:
  gclient setdep -r src-internal@e4822cdce35a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Iea8da03e8839c65761b131a6c00674a74c4fe2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880696Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709388}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/910988b619..33455d1c48

TBR=bmeurer@chromium.org

Change-Id: Ibec0f9bf8069e58efaf0077e90686045def2d449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879251Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709387}

Fixed: 1009510, 1009509, 1009511
Change-Id: I1697126d12d3822d19778c4930317118be76356a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878196Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709386}

DownloadRequestLimiterTest.HistoryBack
DownloadRequestLimiterTest.HistoryForwardBack
SafeBrowsingBlockingPageTest.NavigatingBackAndForth
SafeBrowsingBlockingPageTest.PageWithMalwareResourceDontProceed
SafeBrowsingBlockingPageTest.PageWithMultipleMalwareResourceDontProceed
SafeBrowsingBlockingPageTest.PageWithMultipleMalwareResourceProceedThenDontProceed
TaskTabHelperUnitTest.TestTaskIdBackButton


Bug: 1015328
Change-Id: Ie1f0655f871496ba697ed8653be197103073450c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880499Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709385}

The previous version of this test had some issues and were the
source of flakiness:
* It used non-secure contexts and register() seemed not working.
* It used a mock object for service_worker_unregister_and_register()
  and the mock object silently consumed rejections of register().
* It didn't wait for iframe loading completion.
* It didn't clean up iframes.
* It didn't handle error cases correctly and the test passed
  in an unexpected way.

This CL rewrites the test to fix above issues:
* Use secure contexts.
* Use existing test helpers which provide better error handlings.

As a consequence we stop using addressspace-test.js in the test
but I think the new test is easier to read and understand.

This CL should de-flake the test.

Bug: 988074
Change-Id: I3d16c61742d819c08cadcff20a017b7336508efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877876
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709384}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ie54fb81c1bfe0c9df8fad8e58c2f1b63183c8ed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880693Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709383}

Current document does not explain an 'extraHeaders' use case
to deceive the CORB inspection.

This patch updates to explain this, starting from m72.

Bug: 933893
Change-Id: I465a548de0450243d599937c20f442fa2a941017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878268
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709382}

A workaround for vector-dynamic-indexing-swizzled-lvalue.html.

Bug: 709351
Change-Id: I544583b26055a8ff2d62e81fcf06bbde769aa886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877817
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709381}

Please see attached bug. Appears to have been flaky for awhile.

TBR=markusheintz

Bug: 1018064
Change-Id: I350719fbc26fee88ae2f6cb9a1f6820fcaace6f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880497Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709380}

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I481e135e3e7ffec2a384aea9fb1a80956bc68750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875348Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709379}

TBR=govind@chromium.org

Change-Id: Ib4c49cf9e7948ed3bb7145c6aad9fffd1be56aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880690Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709378}

This CL tells apart the navigation sheet invoked from gesture UI and
that from long-press on back button, and log the event separately.
Also logs a new action that indicates that the arrow turns blue i.e.
swiped beyond the threshold that would trigger navigation.

Bug: 1013405
Change-Id: Ife3f83af56b0742a00ab5d3394d4522ff391809a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871720
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709377}

The queue's support is currently checked in the video decoder but the
queue should be responsible to check whether it does support requests or not.
This patch moves the check for the request support to the V4L2Queue
constructor.

BUG=chromium:1009921
TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie-kernelnext.
TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie-kernelnext.
TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie-kernelnext.
TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie-kernelnext.
TEST=ran tast with video.DecodeAccelVDVP8ResolutionSwitch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVDH264ResolutionSwitch on veyron_minnie.
TEST=ran tast with video.DecodeAccelVDVP8 on veyron_minnie.
TEST=ran tast with video.DecodeAccelVDH264 on veyron_minnie.
Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
Change-Id: Icdceab06d3b263d0ce68993b3ee753bd650706dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880208
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709376}

Currently only ChromeOS platform uses VideoDecoderPipeline. This CL
moves the related files to //media/gpu/chromeos.

BUG=chromium:1012587
TEST=ninja chrome on kevin and eve
TEST=ninja video_decode_accelerator_tests on kevin and eve
TEST=gn check on kevin and eve

Change-Id: Ic2b22535981803e0f425d98fcb220a3e62f57b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877494
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709375}

This fixes the MSVC build in ANGLE.

Bug: 961769
Bug: 1017514
Change-Id: I40b5590bb700dd2d729a15a8088b97c13ebb1df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879319
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709374}

Remove macro-generated functions for [SaveSameObejct] and replace them with new GetSymbol using SymbolKey

This CL removes macro-generated functions for [SaveSameObject] and replaces them with the new GetSymbol function, which uses an instance of SymbolKey created in CL1877490 as a key.

Bug: 715418
Change-Id: I8fb8901028fcbd24223cecc71a4b9f0bdd7f757b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880240
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709373}

To better bind the lifetime of the camera proxy activity with CCA,
we should close CCA when camera proxy activity is manually destroyed.

The corresponding CL on ARC++ side is:
http://ag/9481116

Bug: 980812, 967611, b/131809655, b/134635999
Test: Tested with Hangouts app and CCA is closed as Hangouts closed.
Change-Id: I0050ba69ec8771c3064308131cdfdbc123adca4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835072
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709372}

https://skia.googlesource.com/skia.git/+log/28a8f28b3eaf..ad5be17f5599

git log 28a8f28b3eaf..ad5be17f5599 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 883e817b14bf..6d69aae0e1ab (3 commits)

Created with:
  gclient setdep -r src/third_party/skia@ad5be17f5599

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: chromium:None
Change-Id: I582f7350f686b169072d906e2fd0c03eaf68682e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880689Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709371}

This reverts commit 0068fa1b.

Reason for revert: CookieManagerImplTest.ReconnectToNetworkContext has been failing flakily: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64

Original change's description:
> [Watch flakes]: Fix flakes from NetworkService.
> 
> This CL cause NetworkService::CreateForTesting to
> use a mock NetworkChangeNotifier which does not observe network changes
> 
> Bug: 1011275
> Change-Id: I6de34b7a5f6c5af5128cfc000ed63481f3351325
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864359
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709257}

TBR=etiennep@chromium.org,ericorth@chromium.org

Change-Id: I2ae778c2f1d8f28cba45c4e8fd24b1597ea1a504
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880246Reviewed-by: Meredith Lane <meredithl@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709370}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4271e070be6..93afefce3091


Created with:
  gclient setdep -r src-internal@93afefce3091

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I6e0cc659f0168a826b57f15c642215a5fbd28e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880688Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709369}

This change contains the prototype implementation of EditContext
event APIs. For more details about this change please refer to
https://chromium-review.googlesource.com/c/chromium/src/+/1591870
EditContext simplifies the process of integrating a web app with advanced
text input methods such as IME, VK shape-writing, speech recognition etc.
EditContext decouples text input from the HTML DOM view.
Rather than having the web platform infer the data required to enable
sophisticated text input mechanisms from the HTML DOM, the author will
provide that data explicitly through the API surface of the EditContext.
Additionally, EditContext communicates events driven from text input UI
to JavaScript.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/
master/EditContext/explainer.md

Bug: 999184

Change-Id: Ice8c14b931e1253101ff96592b9b47e60b07ad01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864318Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#709368}