- 22 Oct, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
bug: 1138710 Change-Id: I9c1c787837d6c64e7ef88c66bf9070bb7d073547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477236Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#819816}
-
Reilly Grant authored
These tests were broken by User Activation v2 because they assumed that an activation is inherited by cross-origin child frames. The tests have been updated to use test_driver.click() in the iframe to create their own activation. Bug: 860713 Change-Id: I5b3d6d17d97098eaa1689e77f5fc112002f76795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491683 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819815}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ded46963acfa..4492cf287a23 2020-10-22 yangguo@chromium.org [ts] Type-check DOMStorageItemsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79edc4380cb34c8d5325e35e4443ea112a476642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819814}
-
Palak Agarwal authored
Change-Id: I5b7ee18f7f497d787998bde8408d46987a45a6eb Bug: 1136714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463833 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#819813}
-
Matt Menke authored
Add NetworkIsolationKey to Network Error Logging policies. This CL modifies the NelPolicy struct representing a NEL policy, by replacing the origin field with a (NetworkIsolationKey, origin) tuple. The policies are stored in the NetworkErrorLoggingService map of policies by this new key, instead of just origin. Bug: 993805 TBR: msramek@chromium.org Change-Id: If5e8d61aec8cf6325e2cf707b12e5b5a79fb67a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485531 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819812}
-
Tanmoy Mollik authored
The test failed because of 4 pixel mismatches on the corners of the rendered images. To the naked eye they look identical. Enabling the test as it might be golden render issue. This is a reland of 7201dc96 Original change's description: > [Android] Add render test for sync promo in MainSettings > > This cl adds a render test to check that sync promo is shown when the > user has signed in with without sync consent. > > Bug: 1105800 > Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817018} Bug: 1105800 Change-Id: Iacdd454607f1f755c38f25531dd9a8bc8fd0dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484431Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819811}
-
Andrew Grieve authored
This reverts commit b47e9c83. Reason for reland: Updated more .pydeps files. Original change's description: > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > This reverts commit 49fdeca1. > > Reason for revert: Breaking presubmit due to stale .pydeps file: > android_webview/tools/run_cts.pydeps > > Original change's description: > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > Bug: 1120190 > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819489} > > TBR=agrieve@chromium.org,bpastene@chromium.org > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819668} TBR=agrieve # reland Bug: 1120190 Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819810}
-
Danila Kuzmin authored
Bug: 1134822 Change-Id: I8fdae2162564b787a9d484b58cb687cf6c8d5b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470878Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#819809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d74754378f09..1c7f0284516a 2020-10-22 lexa.knyazev@gmail.com Vulkan: Fix invalid clamping of ES3 clear stencil values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I70098b4bf6c9d9f42b4850528332331d99f0a4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491354Reviewed-by:
-
Josh Nohle authored
Before this CL, failed or cancelled send attempts resulted in duplicate share targets in the UI on the next send attempt. The root cause of this behavior was that the share target from the failed/cancelled attempt was overwritten in the endpoint-ID --> outgoing-share-target map during the second share attempt (using the same endpoint ID), and observers were not notified that the previous share target was removed. In this CL, we handle removal of outgoing share targets in a consistent way. The removal process is as follows: - The share target is removed from the |outgoing_share_target_map_|. - File payloads are released. - The share target info is removed from |outgoing_share_target_info_map_|. - Send-discovery observers are notified that a share target was lost. Fixed: 1133824 Change-Id: Ia5faf674ae50e86a1d813d4e2f58d770248c95b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491221Reviewed-by:James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#819807}
-
W. James MacLean authored
These UMA metrics have expired, so this CL removes them. Bug: 988806 Change-Id: Ia59e475097e5b5eb8dd4b6e5b79b4835ce87d987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490246Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#819806}
-
sandromaggi authored
Previously, each step resolved the element anew. Now the element is resolved once and used throughout the action to perform actions on. Bug: b/168107066 Change-Id: I4def429d89251cda5831cd5ca8268cf2bcf0ebab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485211 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819805}
-
Peter Kasting authored
This includes changing some ButtonPressed overrides to callbacks as well as updating various comments. Bug: 772945 Change-Id: I404e8715ad8aff3078b9e525a77ca921e1941186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490844Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819804}
-
Jordan Oroshiba authored
Removing the button for clearing cookies to make the cookie line item have a trash can icon and do the delete action. Screenshots: https://crbug.com/1077766#c76 Bug: 1077766 Change-Id: I85f98871a74c18a07624e4a5db4b5634026736be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472923 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#819803}
-
Kazuki Takise authored
Although PIP windows are not supposed to be resized by Chrome, because of vaious off-by-one issues, some bounds move events for PIP windows are currently considered to be BOUNDS_CHANGE_REASON_RESIZE, and Android rejects those events as the window is already in PIP. BUG=b:171361297 TEST=Manually confirmed the bounds of PIP matches between Android and Chrome Change-Id: I62d2909f32143e5369587de2ea8abf5748b82233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488263 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#819802}
-
Ramin Halavati authored
ProfileManager unittests are updated to cover ephemeral Guest profiles, and Guest profile names are updated to be different from regular profile names. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I11b868925e47135e6773b75f0d298f3311f52e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483827Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Summary: Jinja2 already supports python3, but templates must be aware of environment they're run on. This commit fixes 'str object' has no attribute 'values' error when template is rendered using python3 Bug: 1138872 Change-Id: Iaf2f660369ff4857ee3307825944cf1d2accef3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475118 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#819800}
-
Morten Stenshorne authored
This is a reland of 772dfcc1 See crbug.com/1140604 - Pretty sure this was unrelated to this CL, but now it's been fixed anyway. Original change's description: > Enable "gn check" for //third_party/blink/renderer/core > > Bug: 800764 > Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818849} Bug: 800764 Change-Id: I6c451a2c4637471170c64b378c06c09a5aa0814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491361Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819799}
-
Rohit Agarwal authored
This CL: 1) Explicitly makes use of getPrimaryOTRProfile for tests relying on primary OTR profile instead of getOffTheRecordProfile. 2) Adds a tests for non primary OTR profile. 3) This CL also simplifies OfflinePageBrideTest by not launching the incognito CCT and just creating the non primary OTR profile. Bug: 1060940 Change-Id: I0adbddbcb0435e55d4f15f79d0823ea920d20f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489988Reviewed-by:
-
Keishi Hattori authored
Temporarily use CHECK in SetFreelistHead to debug a crash. Should be reverted after a Canary release. Bug: 1137799 Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Introduce a new mixing 'ios_cpu_x64_x86' used to configure fat builds with "x86_64" and "i386" architecture instead of using two mixins. This will allow changing how fat builds are configured to use a special value for `target_cpu` instead of using two separate variables. This should be a no-op on the bots since the generated args.gn will be identical after the change. Bug: 1040487 Change-Id: I46ebd383ee13449a3ccb1e1b3eccbc486b2fbe9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489907 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#819796}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603291852-8226e53db1ad923442028152d5859381e4c42533.profdata to chrome-win64-master-1603335567-5b7ae75a80b56b2c3e08e562ca96c9be42987f9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8584eb98eece32007aab9f354377ca639367a944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490859Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9be16a326a9b..ef6970472eb9 2020-10-22 landrey@webrtc.org Get rid of redundant async in token state update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: oysteine@google.com Change-Id: Ie8cb2769ff7709c604dc307bcf80ec5593ff2282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491920Reviewed-by:
-
Simon Zünd authored
Various places in Chromium collect and symbolize V8 stack traces. This could be DevTools or heavy ads instrumentation. To get better insights we want to add some trace events around stack trace capturing and symbolization under a new, disabled by default, tracing category. Corresponding V8 CL: https://crrev.com/c/2491028 R=petermarshall@chromium.org Change-Id: I266b0783dcf6266efc512503b7b13044bd8b71c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490044Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819793}
-
Boris Sazonov authored
Changes AccountPickerBottomSheetCoordinator argument from Context to Activity. This ensures that the view is never inflated using an themeless context. This is a tentative fix for an intermittent issue when AccountPickerBottomSheetView rows don't have a ripple animation. Bug: 1141000 Change-Id: Idc63fdac6dde06e912d57bcf8ef0bc1572ca968d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489904 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819792}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I17cb6028040ca5e89d806acc85863ccf6e9ad9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491512Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819791}
-
Sergey Poromov authored
In order to support partial window screen capture we need to track events when some confidential content appears in the captured area. This is done via observing OcclusionState for the corresponding windows. Bug: 1133324 Change-Id: Ia0ffa3ca79a2b58ccef1902acc8b6772df773b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456606Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819790}
-
chrome://usb-internalsdpapad authored
Bug: 1028829,1139849 Change-Id: I1ce5bdbd9e48004cec66f60cf952b0d95207c3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480262 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819789}
-
Morten Stenshorne authored
When constraining an inner multicol against its definite block-size or max-block-size, we need to subtract the space already consumed in previous fragments. Bug: 1141136 Change-Id: I2fb678549ab967d88ece5b15679986f997bb7859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489893 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819788}
-
Andrew Grieve authored
Noticed these were missing when doing binary size review. Bug: None Change-Id: I8177a8e2138b58a68c036300a89fa2e4073f11a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484046 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#819787}
-
Keishi Hattori authored
This reverts commit 90815a3a. Reason for revert: Real bug was identified and change is no longer necessary. crbug.com/1108676 Original change's description: > Add extra check for not_loaded_image_resources_ modifications while iterating > > not_loaded_image_resources_ is being modified while iterating. > If this CHECK doesn't catch anything, it means weak processing is triggering while iterating even though it shouldn't be. > > Bug: 1108676 > Change-Id: Iae00862b28fe3e324ac654c1e57834071ce5ddc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392021 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804078} TBR=haraken@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108676 Change-Id: Ia46490f0abafafc5afac9b1971740b0afa21b10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490967Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2485087 Bug: chromium:1127956 Change-Id: I7cc7a3db0056bf3978d08cfeeb6bb25e9ec4509d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489641Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819785}
-
Olesia Marukhno authored
Updated dedicated row buttons background color to match its row background. Added new color for buttons border color (it needs to be distinctly visible on selected row background). Bug: 1137445 Change-Id: Ib5b7cad19034e6e83500197bd9e61d9b28fae512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466241Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#819784}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cab003ff2dd9..ded46963acfa 2020-10-22 alexrudenko@chromium.org Enable TypeScript for PaintProfilerView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I036fe370280fdec2cf32e179cfddb1730c4b8891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491353Reviewed-by:
-
Benoit L authored
This reverts commit aa18dd9f. Reason for revert: Not the cause of breakage, as the bot is still broken. As there was a suspicion this wasn't the culprit to begin with, relanding. Original change's description: > Revert "[base/allocator] Support mallinfo() for PartitionAlloc-Everywhere." > > This reverts commit 98e662e4. > > Reason for revert: this seem to break Win7 builder > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85993 > > > > Original change's description: > > [base/allocator] Support mallinfo() for PartitionAlloc-Everywhere. > > > > mallinfo() is used by MallocDumpProvider, and ProcessMemoryMetrics. The > > first one can also use the extended API of PartitionAlloc to report > > data, but the second one uses mallinfo(). To support both, implement > > mallinfo(). > > > > Bug: 998048 > > Change-Id: I9d71cd3a7bbf5c766cfc3771907c2f51ac17cace > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426708 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819010} > > TBR=lizeb@chromium.org,wfh@chromium.org > > Change-Id: Ibfbc278d7057808ce1a66150e2a8f516bdaab230 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 998048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489626 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819368} TBR=lizeb@chromium.org,wfh@chromium.org,apotapchuk@chromium.org # Not skipping CQ checks because this is a reland. Bug: 998048 Change-Id: I8b558903c6a1b94c3db472d200472a03c97b8322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489909Reviewed-by:
-
Viktor Semeniuk authored
This change fixes crash when simultaneously editing/deleting the same password on multiple windows. Bug: 1139295, 1139210 Change-Id: I3e3a016f6f41b889e8915feda297bea23f87561a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487127Reviewed-by:
-
Hajime Hoshi authored
Until committing finishes, |dom_content_loaded_| should represent the old document's state, but this is now reset at CommitNavigation. This means that |dom_content_loaded_| is reset at committing starts. This CL fixes the timing of resetting |dom_content_loaded_| to DidCommitNewDocument so that |dom_content_loaded_| is reset when the committing finishes. Bug: 1137725 Change-Id: I386c9bb855b45a94e4f2ae36e04f3f09b8f20610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483550Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819780}
-
Henrik Boström authored
This is a simple C++ wrapper of VTPixelBufferTransferSession, which together with PixelBufferPool can easily be set up to do a large range of conversions and scaling directly in the capturer process. The bulk of this CL is testing. This CL: - Implements PixelBufferTransferer. - Adds testing utility methods in the anonymous namespace of the unittest file for creating YUVS buffers from RGB and verifying the RGB color of YUVS buffers. This is done with the help of libyuv. - Add tests for copying, rescaling and verifying the color with YUVS. - Add tests for converting YUVS -> X -> Y -> YUVS and verify we end up with the original color. We do this for all X and Y: YUVS, NV12, UYVY, I420. Starting and ending with YUVS is done so that the test utilities only have to read and set colors based on this format, rather than implement conversions for all formats. // TBR for media/capture/BUILD.gn changes. TBR=guidou@chromium.org Bug: chromium:1132299 Change-Id: If61f05d93dbb419992670d315b78e27f1f287ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438250Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819779}
-
Daniel Cheng authored
This is needed because wasm-eval is not yet standardized, yet it remains useful for allowing something stricter than unsafe-eval. Bug: v8:7041 Change-Id: I7d45f4b4f2bb930536af56a25082f6a938d4b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488389 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#819778}
-
Yu-Hsuan Hsu authored
Fix a small type: AudioManagerCras -> AudioManagerCrasBase Change-Id: I17decae7ed93b953c4376a7ce319a8c647c56a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483543 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819777}
-
