- 28 Aug, 2018 40 commits
-
-
Boris Sazonov authored
Previous divider implementation looked thicker than the standard ones (see the bug for screenshots). This CL fixes the issue by using listDivider theme attribute instead of explicitly specifying divider size and color. This CL also introduces a couple of textApperance styles to overcome presubmit errors. Bug: 877482 Change-Id: Iab448228ca34cd1d6fd443768fe009b14d7f9e3e Reviewed-on: https://chromium-review.googlesource.com/1191703 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586789}
-
Vaclav Brozek authored
This CL runs clang-format on chrome/utility/importer/ie_importer_win.cc, to separate the behaviour-affecting changes of https://crrev.com/c/1174711 from style changes enforced by presubmit checks. This CL does not introduce any functional changes. Bug: 456119 Change-Id: I27a52f047c95a16648c550c045a2699fa1b40c61 Reviewed-on: https://chromium-review.googlesource.com/1193223 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586788}
-
Saman Sami authored
This reverts commit af0b9e0e. Reason for revert: the original CL was for diagnostic purposes and is not needed anymore. Original change's description: > Check DrawQuad is given a valid pointer to SharedQuadState > > Bug: 852294 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb > Reviewed-on: https://chromium-review.googlesource.com/1133579 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574366} TBR=fsamuel@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852294 Change-Id: I2001b68cc4b2a685517c5149302e6e8aacd081eb Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1194248Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#586787}
-
Philip Rogers authored
Page color overlays are used for extension "deemphasized" effects. These were integrated outside the blink lifecycle update but they can be moved entirely into blink now. This patch moves the page color overlay from WebViewImpl to Page and puts the update and paint calls in the blink document lifecycle. Bug: 870422 Change-Id: I92586ebeca29be24dfe35e033ca4099852d93ce4 Reviewed-on: https://chromium-review.googlesource.com/1192120Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586786}
-
Yue Li authored
Bug: b/78190629 Test: Manual Test Change-Id: Ia24c946348544f3ebe4a9edc17972895fbc0df60 Reviewed-on: https://chromium-review.googlesource.com/1189709Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#586785}
-
Kai Ninomiya authored
A few more changes, following up to the previous commit which added the WebGPU command buffer. Bug: 868192 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iade27669c2bdebb598463b579a8dfaa6b91fbb9b Reviewed-on: https://chromium-review.googlesource.com/1192411Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#586784}
-
Farah Charab authored
Records the number of resource loading tasks split by net priority. Recorded each time a resource's request priority changes. Bug: 870349 Change-Id: Idef96f2e9e0a08045387b8bf78874727b2deeb91 Reviewed-on: https://chromium-review.googlesource.com/1185596Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#586783}
-
Nico Weber authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/a1750dbc79a8..9977619490e1 $ git log a1750dbc7..997761949 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 thakis Move src.git/build/secondary/third_party/libjpeg_turbo in-tree. 2017-07-26 agable Upload libjpeg_turbo reviews to Gerrit by default Created with: roll-dep src/third_party/libjpeg_turbo Also remove now-unused build/secondary/third_party/libjpeg_turbo/BUILD.gn Bug: none Change-Id: I688b3c5f6d0250ba9f568203169d9bb504c49dd9 Reviewed-on: https://chromium-review.googlesource.com/1194482Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#586782}
-
Dan Harrington authored
Previously, offline content suggestions would show on any net error page. Now they only show on the dino page, as intended. As a beneficial side-effect, the error strings (available on page load) will indicate whether offline content may be inserted to the page later. This is important for implementing the final UI because, for instance, we need to hide error help suggestions to make room for content. I moved the feature flag from browser/ to chrome/common so that it is accessible from the error page code. This code was previously reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1185282 and needed move to another issue for an OOO reviewer. Bug: 852872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I86392d2b10d1f243525f043e0627b04f41f83b96 Reviewed-on: https://chromium-review.googlesource.com/1194245Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#586781}
-
Finnur Thorarinsson authored
Bug: 877948, 656015 Change-Id: Ifc19e9a8566094adccf39ef953d909e7b5218dd8 Reviewed-on: https://chromium-review.googlesource.com/1190023Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#586780}
-
Pavel Feldman authored
This is a follow up to r586485. Bug: 877697 Change-Id: Ie4cbcf90d3fd626ffe8d66832535ab8a0a9b227c TBR: trivial Reviewed-on: https://chromium-review.googlesource.com/1192698Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586779}
-
Filip Gorski authored
This reverts commit 8f6992ac. Reason for revert: Broke Build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/87180 Original change's description: > Add VulkanSurface::SetSize() to implement resize. > > This method will recreate VulkanSwapChain in VulkanSurface with the new size. > This CL also adds a new param old_swap_chain for VulkanSwapChain::Initialize(), > so we can create a SwapChain correctly. > > Bug: 866914 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I2042f389c69a591a325f7b530fff1e554cca5e66 > Reviewed-on: https://chromium-review.googlesource.com/1184977 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Victor Miura <vmiura@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586776} TBR=penghuang@chromium.org,rjkroege@chromium.org,spang@chromium.org,ccameron@chromium.org,vmiura@chromium.org Change-Id: I0d502444e96f68341f35f405d1cb027b21404ad5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866914 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1194664Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#586778}
-
Min Chen authored
- Make fling from top and inside snapping area have different velocity thresholds. - Update the value of velocity threshold, the old value is too small. Bug: None Change-Id: I44493c061640ed7a0c163b42e3a686c237de0d84 Reviewed-on: https://chromium-review.googlesource.com/1192700 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Peng Huang authored
This method will recreate VulkanSwapChain in VulkanSurface with the new size. This CL also adds a new param old_swap_chain for VulkanSwapChain::Initialize(), so we can create a SwapChain correctly. Bug: 866914 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2042f389c69a591a325f7b530fff1e554cca5e66 Reviewed-on: https://chromium-review.googlesource.com/1184977Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#586776}
-
Nico Weber authored
We haven't been DEPS'ing in third_party/nss for a long time, so having the build file there is misleading. Since it uses pkg-config, put it in build/config/linux, where most other pkg-config-using system dependencies live. TBR=stevenjb Bug: none Change-Id: Iaa32ba43898303a5072edb2b183beb89a220d78a Reviewed-on: https://chromium-review.googlesource.com/1193965 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#586775}
-
Reid Kleckner authored
This reverts commit 45116fe1. Reason for revert: Does not pass in official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/91358 Original change's description: > [NTP] Test EmbeddedSearch APIs for custom backgrounds > > Check that the embeddedsearch APIs for custom background correctly > update the ThemeBackgroundInfo when called. > > Bug: 857256 > Change-Id: I7c71ddbbdc30fa9fbcf4a2afc8387affcc39693c > Reviewed-on: https://chromium-review.googlesource.com/1189082 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586394} TBR=kristipark@chromium.org,kmilka@chromium.org Change-Id: I756c849a01dfdda6f1c8074a21e0613fc0062fdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857256 Reviewed-on: https://chromium-review.googlesource.com/1194571Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#586774}
-
Joshua Bell authored
Use ".any.js" tests [1] rather than redundant files for window and worker variations, and increase coverage where window-only tests existed. Also use ".worker.js" and ".window.js" to eliminate some boilerplate. The one manual test is left untouched for ease of running... manually. [1] https://web-platform-tests.org/writing-tests/testharness.html Change-Id: I7be790e0134854c804dbf82072589f07fa6e0bfb Reviewed-on: https://chromium-review.googlesource.com/1194324Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586773}
-
Martin Robinson authored
This change exposes the AtkText interface on all accessibility elements and uses the, now shared, ComputeHypertext in order to compute composite text for elements that have multiple children. Once we start exposing the hypertext interface, we can start testing the embedding of objects into the hypertext itself. The plan is also to eventually expose the interface on objects that need it. Unfortunately, since hypertext computation is now triggered by the content code, we must move the existing AtkText unit test to content as well alongside the new one. Bug: 866337 Change-Id: I8cc738dd0e14cf95ecdffa2370d242fb447aa9b6 Reviewed-on: https://chromium-review.googlesource.com/1190782 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#586772}
-
Ryan Cui authored
Updated filter file from jamescook@ Also adds PictureInPictureWindowControllerBrowserTest\ .OpenInFrameWithDevToolsDoesNotCrash to blacklist to fix failure on FYI bot. Bug: 874090 Change-Id: I737511e2cb0214a586326ac68889e71ced9e79cf Reviewed-on: https://chromium-review.googlesource.com/1192334 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586771}
-
Reilly Grant authored
This is a follow-up to r583089 as it was pointed out that the original patch did not handle connection errors caused by a network service process restart. In this case we can simply try to reinstall the cookie change listener. Bug: 792663 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ef4b038b942a47c8aa1f8cc485327ba14f2fa28 Reviewed-on: https://chromium-review.googlesource.com/1192022 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586770}
-
Xiaohan Wang authored
In places where dependency on the constants defined in widevine_cdm_common.h is needed, we should include widevine_cdm_common.h directly, instead of depending on the include of widevine_cdm_version.h. This also clears the way for us to remove the include of widevine_cdm_common.h in widevine_cdm_version.h, and potentially the removal of widevine_cdm_version.h altogether in the future. Bug: 349182 Test: No functionality change Change-Id: I49a8d6bc976272ca6730e5f7ec4a52aa46c4a456 Reviewed-on: https://chromium-review.googlesource.com/1192350Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#586769}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/component_updater. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=laforge@chromium.org Bug: 874080 Change-Id: If7aa633ca41f4bdf0836c2b25977b3cc0df9607a Reviewed-on: https://chromium-review.googlesource.com/1191100Reviewed-by:Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586768}
-
Kyle Horimoto authored
(1) HostVerifierImpl::IsHostVerified() returned true if the device had previously been verified but was pending removal. If a device is pending removal, the user has explicitly requested that it be removed as the host device, so it should not be considered verified. (2) RemoteDeviceCache::SetRemoteDevices() skipped overwriting device metadata if that data was not newer than the previously-stored data. However, there is currently a bug on the CryptAuth back-end which does not update the device metadata update time when a feature has been changed from supported to enabled or vice versa. Thus, this check has been temporarily removed until the back-end bug has been fixed. Bug: 870069, 824568 Change-Id: Ie748e5d662a9ea00cf1b5e6a42fc8354c986d61e Reviewed-on: https://chromium-review.googlesource.com/1192417Reviewed-by:James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586767}
-
Ian Clelland authored
This queues a report through the Reporting API whenever getCurrentPosition is called from a frame in which geolocation is not allowed according to feature policy. Bug: 867471 Change-Id: Ib8d6bc794e5cdda07add3246580d858edc10a38d Reviewed-on: https://chromium-review.googlesource.com/1191407 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#586766}
-
Becca Hughes authored
Fix Android jumbo build. BUG=876227 Change-Id: Iabe7d634e2019ac15993ac53570b7c20e581549f Reviewed-on: https://chromium-review.googlesource.com/1192118Reviewed-by:
-
Nicolas Ouellet-Payeur authored
This CL *introduces* 4 policies that will allow admins to control what data gets gathered and reported. Later on, these should be made to use the old extension policies as fallback values. The 4 policies created here are mapped to prefs, but they do *not* actually control Enterprise Reporting. That will come in a follow-up CL. Bug: 877120 Change-Id: I75316c64a0579d013489f4f75535d441bd7ddd24 Reviewed-on: https://chromium-review.googlesource.com/1187066 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#586764}
-
Mirko Bonadei authored
WebRTC is planning to change the way metrics and field_trial are excluded from the WebRTC build. As of today binaries are forced to pick an implementation because the default is not provided. In the next few weeks this will change and there will be 2 GN arguments to explicitly exclude the default implementation. These arguments will be transparent to Chromium (Chromium wants to use its own implementation, the one under //third_party/webrtc_overrides so the default WebRTC implementation will always be excluded). While searching for *_default build targets these two dependencies showed up and they can probably be deleted since Chromium doesn't need the anymore. Bug: webrtc:9631 Change-Id: Iec36040e288c68ce6c385b7dbe20d46ba2547a4d Reviewed-on: https://chromium-review.googlesource.com/1193343Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#586763}
-
Ian Clelland authored
This queues a report through the Reporting API whenever the WebUSB API is invoked from a frame in which the 'usb' feature is not allowed according to feature policy. Bug: 867471 Change-Id: Ib1b3c70f3d22c0446b8f8cc1dba7d6df3c44d763 Reviewed-on: https://chromium-review.googlesource.com/1191669 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586762}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ba12eb7b376..f190cb208a69 git log 3ba12eb7b376..f190cb208a69 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 dproy@google.com Move mithril redraws to rafScheduler 2018-08-28 dproy@google.com Merge "Panel refactoring: part 2" Created with: gclient setdep -r src/third_party/perfetto@f190cb208a69 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9330b0638887f3fb4f53c988841e6c0f324a24f2 Reviewed-on: https://chromium-review.googlesource.com/1194262Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586761}
-
Jérôme Lebel authored
Adding call to super from -[UnifiedConsentViewController viewDidAppear:]. Since crrev.com/c/1186739, -[SigninEarlGreyUI signinWithIdentity:] doesn't need to open the identity chooser. To fix the tests, the tap on identity button in the unified consent view, is removed. This CL enabbles: GoogleServicesSettingsTestCase /testOpeningServicesWhileSignedIn /testOpeningServicesWhileSignedInAndConsentGiven /testOpenManageSyncedDataWebPageWhileSignedIn /testToggleNonPersonalizedServices Tests disabbled with: crrev.com/c/1192242 Bug: 827072, 878119 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iab757d210d3ed916017b0c62f16a7ed4887c98e5 Reviewed-on: https://chromium-review.googlesource.com/1193366Reviewed-by:Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586760}
-
Mike Dougherty authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I04a54dc6d3a6b2b6e7da7da2460817299ea23c10 Reviewed-on: https://chromium-review.googlesource.com/1191811Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#586759}
-
Mohsen Izadi authored
Otherwise, the GL setup may leak to the next test that happen to run after the current one which is generally not expected. This is specially problematic if tests are run with --single-process-tests flag. BUG=779614 TEST=services_unittests --single-process-tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id37eb35530be3519e7e1d8e47c1908bf6999839f Reviewed-on: https://chromium-review.googlesource.com/1192592Reviewed-by:
-
Koji Ishii authored
The test says: All the vertical-lr cases are off by 4px in the x direction. See http://webkit.org/b/71193. LayoutNG fails these tests because it doesn't have the bug. This patch fixes expectations for LayoutNG, and add a script for legacy to pass by adding margins to correct the unexpected offsets. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib8f17cae0e12d40ce511886d4ee93dff64d87b57 Reviewed-on: https://chromium-review.googlesource.com/1193865 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586757}
-
Farah Charab authored
Bug: 852076 Change-Id: Ifd09780228d512f0016fab62803b9117b3999e6c Reviewed-on: https://chromium-review.googlesource.com/1177716 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586756}
-
Jun Mukai authored
A new CL requires browser windows to have kAppType window property with AppType::BROWSER, which isn't propagated to ash yet. Since the value enums are defined in ash/public, this property registration is done in ash/public/cpp/window_properties. Also, some part of ash code assumes that this property is set on the views::Widget of ash -- which is actually the root window of the browsers. So make it so. Bug: 878037 Test: manually done Change-Id: I6da9bf77570c5bcde03df1fe0651103496b55e90 Reviewed-on: https://chromium-review.googlesource.com/1191924Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#586755}
-
Marton Hunyady authored
Add warning level logging when: - It's detected that update_engine is downloading a rollback image or switching channel. - Notification about the rollback or channel switch to a more stable channel is shown. Bug: 871759 Change-Id: I930b7a23def82ff239ec8da4feeff9daaf960b37 Reviewed-on: https://chromium-review.googlesource.com/1190882 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
-
Matt Menke authored
Crashing the network service just after completing a network request can corrupt the cache. Bug: 878346 Change-Id: Ic5dbc1ce88c7bb2b7b9ef3849e3cee2d8a45bf38 Reviewed-on: https://chromium-review.googlesource.com/1193967Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586753}
-
Farah Charab authored
The loading stack only notifies Blink with any increase in the request priority. Add support to notify the scheduler with the initial priority as well. Bug: 870349 Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b Reviewed-on: https://chromium-review.googlesource.com/1185593 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#586752}
-
Geoff Lang authored
This test is flaky but occasionally hits the retry limit, mark as always failing. TBR=zmo@chromium.org NOTRY=true BUG=814905 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id0bcf0a33434008efebafeaed41cead9c21252c0 Reviewed-on: https://chromium-review.googlesource.com/1191025 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#586751}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec5e6e7a. With Chromium commits locally applied on WPT: fbb650b3 "Add WPT serialization tests for wasm modules" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23542 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib668d791a77d8f16cf51ae012d2b2eb3b0edf030 Reviewed-on: https://chromium-review.googlesource.com/1193751 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586750}
-
