- 06 Jun, 2018 40 commits
-
-
Alice Boxhall authored
Change-Id: I7f467623d5476f717d73aeeaecdc69399c6b65f5 Reviewed-on: https://chromium-review.googlesource.com/1074584 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#564977}
-
B. Menegola authored
Leave the flag in place so we can revert the state in case we have any blockers. R=escordeiro@chromium.org, xiyuan@chromium.org Bug: 848827 Change-Id: I448a6e695b9e01ba232ee832e239074a0bd397b6 Reviewed-on: https://chromium-review.googlesource.com/1089134Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: B. Menegola <menegola@chromium.org> Cr-Commit-Position: refs/heads/master@{#564976}
-
danakj authored
Adds lots of comments explaining how to hold cc::Layer and what various methods do or values mean. Some cleanup while there, removing redundant child_at() and unused SetChildren(). Also noticed SafeOpaqueBackgroundColor() is not safe if the root color is non-opaque since that is what it inherits from. That occurs on the ChromeOS lock screen, but there are no opaque layers there since everything is trying to appear like widgets over the transparent space so we're lucky right now. It would be a bug to try use non-opaque colors to clear an "opaque" PictureLayer though, so I fixed it to ensure the color is opaque even coming from the root layer. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I325e3b03c4b4090068bbd1f453bf99a8cbfcd91c Reviewed-on: https://chromium-review.googlesource.com/1087419Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#564975}
-
Nico Weber authored
This ensures that the memory and clang tot bots run the same tests as the main waterfall bots. Everything running on the main waterfall should also be tested under ASan, and it must be tested with clang/tot too to make sure compiler updates don't break anything. This change makes it impossible for things to get out of sync (on mac). If https://chromium-review.googlesource.com/c/chromium/src/+/1088754 hadn't been reverted, this would've been behavior-preserving. As-is, it adds headless_browsertests and headless_unittests to the mac asan bot and the clang tot bots (which is fine). Bug: 843511 Change-Id: I5e3cea35d99d630d7eb41154984abc23defe6219 Reviewed-on: https://chromium-review.googlesource.com/1089136 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564974}
-
Weidong Guo authored
Changes: 1. Load item list with "page break" items into paged view structure which will be displayed to the user. 2. Add "page break" item based on the changed paged view structure after user operations (Add, Remove, Move an item). 3. Since model index (item view's index in view model) is no longer the same as item index (item's index in item list), separate them. BUG=848917 Change-Id: I5d4c750ab87045a0e4930e549a066f24a1c1cf66 Reviewed-on: https://chromium-review.googlesource.com/1083492Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564973}
-
Sen Jiang authored
This is a new metric added in http://aosp/681827. Bug: b:77884453 Change-Id: I0035cd3e50c440564640aae90e68d2ad7a891017 Reviewed-on: https://chromium-review.googlesource.com/1086280Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sen Jiang <senj@chromium.org> Cr-Commit-Position: refs/heads/master@{#564972}
-
Tommy Steimel authored
This reverts commit f832578e. Reason for revert: GetOverflowStringName is firing a DCHECK on audio elements. Note that audio elements have the picture-in-picture button (it's just hidden), so the code will need to handle that case Original change's description: > [Media Controls] Add Exit Picture-in-Picture button. > > This makes sure clicking the native Picture-in-Picture button (after > entering Picture-in-Picture) exits Picture-in-Picture and that video > controls are reflected when entering and exiting Picture-in-Picture. > > Screenshot: https://i.imgur.com/081Xbmb.png > > Bug: 840516, 806249 > Change-Id: I410a4a06cc4eea62dae8e1d368e4d05394f13c86 > Reviewed-on: https://chromium-review.googlesource.com/1084833 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: apacible <apacible@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564807} TBR=beaufort.francois@gmail.com,mlamouri@chromium.org,apacible@chromium.org,jochen@chromium.org Change-Id: Ie6373e9c2e77bb41ac6a5e9a32f59a2b6ce3bf03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840516, 806249 Reviewed-on: https://chromium-review.googlesource.com/1089209Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564971}
-
bsheedy authored
Implements two fixes that were causing testStartActivityTriggersDoff* to fail 100% of the time. 1. Waits until the UI is quiescent after starting the activity, as previously, clicks were being sent before the DOFF prompt was visible, causing the test to time out. 2. Applies a small deadzone to the head offset used for repositioning the VR controller on 6DOF devices. Even on 3DOF devices, the offset drifted within a very tiny area, which cause the controller to be perpetually dirty and prevent the UI from reaching quiescence. Bug: 831589, 848074 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ic912dd3aa92ac2102c34e4acc330447a3ce0ca8d Reviewed-on: https://chromium-review.googlesource.com/1087723 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#564970}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/3f7e6cc02044..87386826a95f $ git log 3f7e6cc02..87386826a --date=short --no-merges --format='%ad %ae %s' 2018-06-05 jianj vp9: Move up reset of cyclic refresh under dynamic resize. 2018-05-25 lu_zero force-inline the convolve functions 2018-06-01 jzern test,cosmetics: fix func/member naming, decl order 2018-06-01 jianj vp9-svc: Allow usage of second (long term) temporal reference. 2018-05-28 lu_zero Unbreak the force inline directive for gcc Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I0cf5ac87ea7b6477a0fe18d1e4ebe371fc923e87 Reviewed-on: https://chromium-review.googlesource.com/1089192Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#564969}
-
Scott Chen authored
Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iae1036e0a8975f65a37ff9ccc7b6084b4a6d45ef Reviewed-on: https://chromium-review.googlesource.com/1081243 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#564968}
-
chrome://flagsBruno Kim Medeiros Cesar authored
This does not enable the whole feature, which also requires being in a server-side whitelist. Bug: 836246 Change-Id: I6be61a5a18ba1e102d9dceaf801ecdf24931dd9d Reviewed-on: https://chromium-review.googlesource.com/1088930Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org> Cr-Commit-Position: refs/heads/master@{#564967}
-
Scott Violet authored
BUG=837700 TEST=covered by tests Change-Id: Ie188a430a9596a520e0643083d89aaf4f09f4215 Reviewed-on: https://chromium-review.googlesource.com/1089112 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Jonathan Brandmeyer authored
BUG=chromium:721891 Change-Id: Ief16bef5e035b3a8cc767395cd220938c7cbf329 Reviewed-on: https://chromium-review.googlesource.com/1081428 Commit-Queue: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#564965}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/096a6c8..2bd1fab git log 096a6c8..2bd1fab --date=short --no-merges --format='%ad %ae %s' 2018-06-06 geofflang@chromium.org Update dEQP expectations after June 2018 roll. 2018-06-06 jiajia.qin@intel.com Fix the divide by zero exception in BindBufferRange Created with: gclient setdep -r src/third_party/angle@2bd1fab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I168b1cee72607705c91eab87f8f53a6b1fe70645 Reviewed-on: https://chromium-review.googlesource.com/1089170Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564964}
-
Friedrich Horschig authored
With this CL, the KeyboardAccessory uses the 'uifood' flag next to the already existing 'passwords-keyboard-accessory' flag to enable all passwords-related keyboard accessory activity. (Currently, that is only the PWD generation and a still invisible bottom sheet.) In order to do that, the uifood flag was exposed to Android. Also: one-line (maybe temporary) null check to prevent crashes for the experimental implementation of the generation feature. Bug: 828832, 811747 Change-Id: I8cd2645dff6a4cc760e8309e60ba5190d6da25e1 Reviewed-on: https://chromium-review.googlesource.com/1085464 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Victor Costan authored
base::Time already has a null value, so adding mojo's nullable type support on top of base::Time is more confusing than useful. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6016a46b48b4efc4e9b584bc5c3062849dab60a0 Reviewed-on: https://chromium-review.googlesource.com/1087539Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#564962}
-
Michael Giuffrida authored
Rationale for owner choices: keep-alive seem mostly related to browser UI and Chrome apps. I eliminated OWNERS from chrome/browser/ui who were already listed in >20 OWNERS files. Bug: None Change-Id: I4769e2c5dafc809d500b1e71669decfd745adda6 Reviewed-on: https://chromium-review.googlesource.com/1086303Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564961}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 94392859. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19122 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap TBR=foolip No-Export: true Change-Id: I81f80ce0d6ac31e83b4c670669fc1fbda68043ac Reviewed-on: https://chromium-review.googlesource.com/1089034 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564960}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/830256ae..9930a7e4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id946ae8801e8d90ac16619aa0f4bc3afa3fb1392 Reviewed-on: https://chromium-review.googlesource.com/1088994Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#564959}
-
Manu Cornet authored
Bug: 834392 Change-Id: I4b7f51e74b08e49199b8fd88137b15184db77043 Reviewed-on: https://chromium-review.googlesource.com/1086600Reviewed-by:
-
Quan Nguyen authored
Bug: 839610 Change-Id: I4a4ee5e8c80a57a32f8368fe3716803c82148183 Reviewed-on: https://chromium-review.googlesource.com/1086068Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564957}
-
Lukasz Anforowicz authored
After this CL, the CORB warning should be suppressed for: - Responses with 'Content-Length: 0' response header - Responses with 204 http status. Bug: 844178 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I320c9e221d94c3deeef26b96a5ff70b41ea1c2a8 Reviewed-on: https://chromium-review.googlesource.com/1070551 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#564956}
-
Xida Chen authored
When the page zooms, for example, to 200%, the offset of the shadow remains the same as when the page scale is 100%. The problem here is that whenever we zoom the page, we queue a paint call back. Then the new paint call back will set the shadow offset with the size that doesn't account for the page zoom. The fix is to override the BaseRenderingContext2d::setShadowOffset method with the zoom. This CL also includes a layout test to verify the correctness of the fix. Bug: 849706 Change-Id: I427209fca397a7540936bccd9e8fb18ba7c018ba Reviewed-on: https://chromium-review.googlesource.com/1087874Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564955}
-
David Black authored
Adds a minimize button to the caption bar which forces Assistant into mini UI mode. Mini UI mode is exited when mic opens or UI is dimissed. Display string in Mini UI is dependent upon input modality. See bug for demo. Bug: b:109707911 Change-Id: Ic33799a5a7a771611e5bf3f81a443ac82b5ace8d Reviewed-on: https://chromium-review.googlesource.com/1086508Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#564954}
-
Jonathan Backer authored
TextureManager does some validation and will reject a bad glTexImage2D before it gets issued to the driver. We should prefer to check tex_image_failed (which is set by TextureManager) over glGetError. This issue was found by clusterfuzz. I added a gpu_unittest that fails without this change because it hits DCHECKS in texture_manager.cc when we call SetImmutable in raster_decoder.cc. I have confirmed locally that this CL resolves the clusterfuzz issue. Bug: 850056 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibedec4ccc9ec4e3758eb38292642a8671ee8f975 Reviewed-on: https://chromium-review.googlesource.com/1089030Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564953}
-
James Cook authored
This will measure the time from Ctrl-Shift-/ keystroke to dialog show. This CL works with the non-mojo-app shortcut viewer we're using today. When we switch to the app version we'll need to pass the keystroke time over mojo to the app, perhaps via a Toggle() method. Adding the mojo Toggle() interface is tracked in crbug.com/847615 Metric is Keyboard.ShortcutViewer.StartupTime Bug: 847615, 847613 Test: added to ash_unittests, manually checked chrome://histograms Change-Id: I425f44d0b71543f225d73857365d050be0e1b446 Reviewed-on: https://chromium-review.googlesource.com/1087779 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#564952}
-
Justin Cohen authored
NOTRY=true Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibfc9e785a0846c458eeb230e6545603fef5c13d2 Reviewed-on: https://chromium-review.googlesource.com/1089139Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564951}
-
Javier Fernandez authored
This is just a refactoring, so no there is no behavior change in this patch. We want to avoid issues like the one described in bug 847839, so that functions that depend on the AvailableSize() result must be used only after having set up the algorithm. In the rare cases where we need to figure out the track size, we must use the RawGridTrackSize function, which retrives the info directly from the style. Change-Id: I22061c6063cf557cc23e8492f625f0b2299f1ccd Reviewed-on: https://chromium-review.googlesource.com/1087465 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#564950}
-
Parastoo Geranmayeh authored
Credit card test added to the ui tests. Renaming DynamicFormInteractiveTest to AutofillDynamicFormInteractiveTest so that we can run the tests at once using regex. Bug: 848760 Change-Id: I4c18d917ea9e27f03727af25ebfd15ede9b1984a Reviewed-on: https://chromium-review.googlesource.com/1087167 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564949}
-
Tetsui Ohkubo authored
This CL removes reference to runtime flags from MessageListView, and moved the option to the constructor. Direct reference to flag led to unit test failure in MessageCenterViewTest.SizeAfterUpdateOfRepositionTarget. TEST=out/Release/ash_unittests '--gtest_filter=*MessageCenter*' \ --enable-features=SystemTrayUnified BUG=847104 Change-Id: I82d33c827d79bf5fc53d30453e8ac91b18396356 Reviewed-on: https://chromium-review.googlesource.com/1088329Reviewed-by:
-
Hector Carmona authored
This reverts commit af486664. Reason for revert: Suspected cause of compile error: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/12405 See: https://crbug.com/844865 Original change's description: > Run headless_browsertests, headless_unittests on more bots. > > Run headless_browsertests, headless_unittests on the the clang tot bots, > and on some memory bots. Both suites are very leaky, so they don't run on > asan bots, and headless_browsertests is also very racy so it doesn't run under > tsan, but headless_unittests runs under tsan. Both run under msan and cfi. > They also run under asan/mac, which seems to be happy. > > This is part of an effort to reduce the number of test configurations. > Originally reviewed as part of https://chromium-review.googlesource.com/1061795, > which I'm now landing in smaller pieces. > > TBR=kbr > > Bug: 843511,843732,843734 > Change-Id: I3ba57446830d44f3651100e216f1d546ee7532b6 > Reviewed-on: https://chromium-review.googlesource.com/1088754 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564931} TBR=thakis@chromium.org,kbr@chromium.org Change-Id: Ie784cbd8138b0096d538c3e2212d45bdfd18255d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843511, 843732, 843734 Reviewed-on: https://chromium-review.googlesource.com/1089211Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#564947}
-
Peter Boström authored
Instead of using a fully transparent ripple on Mac, this uses the same active-ripple effect as other platforms, but instantly animates to them. This effectively makes use of the active color in the ripple effect but without using the animation (flood-fill effect). This fixes a recent regression where MacViews + Refresh got ink-drop ripples on toolbar and bookmark buttons. It also effectively adds active-state color that was missing on Mac both for toolbar buttons and secondary UI MdTextButtons. Bug: chromium:848767 Change-Id: Ia28d26c128dff12d2181c4dea41a0d4418a9d47c Reviewed-on: https://chromium-review.googlesource.com/1087949Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564946}
-
Jenny Zhang authored
Bug: 849594 Change-Id: Idcfd987a4e2d3357a81905b1f003ab1e81302298 Reviewed-on: https://chromium-review.googlesource.com/1087749Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
-
John Budorick authored
Also fix up some ordering issues in those configurations. Bug: 844014 Change-Id: I2a138cfdd1c48246eb96bdc830046f64270b4a2d Reviewed-on: https://chromium-review.googlesource.com/1082833Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#564944}
-
Alex Newcomer authored
Move the LAUNCH_APP_SHORTCUT_FIRST and LAUNCH_APP_SHORTCUT_LAST enums so they overlap properly with it's app list counterparts. The problem was that AppContextMenu::CommandId enums start at 100, and they are recorded using the same enums.xml entry as launcher would be mis-recorded in UMA as AppContextMenu::CommandId's. LauncherContextMenu: :MenuItem. This means that the app shortcuts in the Bug: 848491 Change-Id: I7b1e1d09eda3114842a349eab93a1c91d960ab4f Reviewed-on: https://chromium-review.googlesource.com/1082977 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Christian Fremerey authored
This had been reverted because of a test failure on webrtc Win10 Tester for a test that uses a real webcam. Patchset 1 is the code as previously reviewed and reverted. Patchset 2 adds a fix for the test failure. Fix description: The test failure revealed a mistake in the new code. Instead of operating the Mojo connection to the jpeg decoder on the main task runner of the video capture service, it would operate it from the thread the delivers the video frames from the camera. On Windows, this thread is not a Chromium thread and as such does not allow base::ThreadTaskRunnerHandle::Get(). The fix is to pass the correct task runner to the factory code, see Patchset 2. Original CL description: * Move/rename class content::VideoCaptureGpuJpegDecoder to media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order to make it reusable for the video capture service. (I was unable to convince Gerrit that this is a move/rename. Sorry for this making it harder to review.) * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface ui.mojom.GpuMemoryBufferFactory * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface ui.mojom.GpuMemoryBufferFactory. * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService from Browser into video capture service when starting up the service. * Enable the existing-but-disabled test cases for accelerated jpeg decoding in combination with video capture service Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* Bug: 820608, 720604 Change-Id: I6c77ce570aa8f0c3a54a12e0d3f14648c58005ac TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org Change-Id: Id3493742537fa8a016dad391ee12e2869febf080 Reviewed-on: https://chromium-review.googlesource.com/1087867 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#564942}
-
Amy Qiu authored
Move tough_pinch_zoom_cases into the rendering folder and refactor to inherit from RenderingStory Bug: 849392 Change-Id: I6496aacc50aa730843d677e73c89f3025b0799ba Reviewed-on: https://chromium-review.googlesource.com/1087726 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#564941}
-
Alex Newcomer authored
As per request from ux, anchor touch and mouse menus similarly. Previously touch menus were anchored based on the app icon, and mouse menus were anchored on the click point. Now we will anchor all menus on the app icon. Bug: 846939 Change-Id: I6d2aea28096701c0109081059be40dca5a9ce93c Reviewed-on: https://chromium-review.googlesource.com/1077308 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Alex Clarke authored
Our usage pattern is unfortunate for existing queues such as base::circular_deque. We tend to fill up an empty queue and then drain all those tasks until it's empty. This means the queue yo-yos in size which confuses the memory reclamation schemes of most queues. As an optimisation we introduce a deque specialised for TaskQueueManager's usage patterns. For performance (memory allocation isn't free) we don't automatically reclaim memory when the queue becomes empty. Instead we rely on the surrounding code periodically calling MaybeShrinkQueue, ideally when the queue is empty. We keep track of the maximum recent queue size and rate limit how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary churn. This yields a nice win on our microbenchmark: Patch: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 Average 35812.1871 35430.24471 35636.02188 36204.63076 ToT: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 Average 37942.951 37481.78685 36983.47337 36634.15632 Percentage improvement 5.61570422 5.473437399 3.643388159 1.172472933 NB the reason the improvement goes down with the number of queues is because we're saving malloc overhead in the queue, but a constant number of tasks are posted across N queues. This means the more queues we have in this test, the less loaded the queues are individually. Change-Id: I75be9c1f266700ac76003ae0191ce0a59539298a Reviewed-on: https://chromium-review.googlesource.com/1080792 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#564939}
-
Tetsui Ohkubo authored
ShelfViewTest's way of triggering overflow button in Shelf sometimes didn't work depending on the width of the StatusArea. It led to test failures with a launching flag which changes Shelf width. Failing tests (with --enable-features=SystemTrayUnified): OverflowButtonActiveInkDropTest.TouchDragOut OverflowButtonActiveInkDropTest.TouchDragOutAndBack OverflowButtonInkDropTest.TouchDragOut OverflowButtonInkDropTest.TouchDragOutAndBack TEST=ash_unittests --enable-features=SystemTrayUnified BUG=847104 Change-Id: I00f64255936ca32daba375832c0b39ccc3e27014 Reviewed-on: https://chromium-review.googlesource.com/1088532 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
