- 29 Jan, 2019 40 commits
-
-
Xiaocheng Hu authored
Change-Id: Ic49dc197b0502211667d6121c609dfa7d3603ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1441532 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#626864}
-
David Staessens authored
This CL adds a test that decodes multiple videos simultaneously, using the new video decoder test framework. TEST=ran new VDA tests on nocturne BUG=905953 Change-Id: Idceb9a3a12c9487946e6e2d5d427f0c9a9b37da4 Reviewed-on: https://chromium-review.googlesource.com/c/1428859 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626863}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from identity_apitest.cc and uses IdentityManager instead of it. Bug: 922752 Change-Id: I5f4029fa675fc40ddd088fe5f488d6e634cc4c76 Reviewed-on: https://chromium-review.googlesource.com/c/1436783 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626862}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Ia232f9011c3b92ab3a291851f43a3c85ddb13c26 Reviewed-on: https://chromium-review.googlesource.com/c/1440063Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#626861}
-
Dale Curtis authored
Adds a YouTube encode of tulip w/o audio to our test rotation for end-to-end playback, seeking, and MSE tests. These tests are only added to the media.desktop suite, since we don't have AV1 decoding enabled for ARM or Android at this time. BUG=924240 TEST=tools/perf/run_benchmark --verbose --browser=exact \ --browser-executable=out/Release/chrome --story-tag-filter=av1 \ media.desktop Change-Id: Iab63f81b2448fb9ffc810a8b2b646d2406eb0413 Reviewed-on: https://chromium-review.googlesource.com/c/1441491 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#626860}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a482e1f9802d..57a2246b527f git log a482e1f9802d..57a2246b527f --date=short --no-merges --format='%ad %ae %s' 2019-01-29 thestig@chromium.org Slightly simplify CPDF_NPageToOneExporter::MakeXObject(). 2019-01-29 tsepez@chromium.org Types used with SharedCopyOnWrite<> need private constructors. 2019-01-29 thestig@chromium.org Fix a crash inside FPDF_ImportNPagesToOne(). 2019-01-29 thestig@chromium.org Remove GetPageOrganizerPageContent(). 2019-01-29 tsepez@chromium.org Split off CFX_RetainableGraphStateData from CFX_GraphStateData 2019-01-29 tsepez@chromium.org Split off CFX_RetainablePathData from CFX_PathData. 2019-01-29 thestig@chromium.org Speed up CBC_OneDimWriter::RenderResult(). Created with: gclient setdep -r src/third_party/pdfium@57a2246b527f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925981,chromium:925415 TBR=dsinclair@chromium.org Change-Id: I8cc10d4cfb3379a13de0b5f0fb69f3771aef45bc Reviewed-on: https://chromium-review.googlesource.com/c/1441531Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626859}
-
Reka Norman authored
This CL makes the ExtensionApps class a content settings observer. This allows live updates to the app management permissions page for a PWA when the site settings corresponding to that PWA are changed. Bug: 906508 Change-Id: I9c1a50765b492903e6540d87d7bdb3cb3bedb7bb Reviewed-on: https://chromium-review.googlesource.com/c/1420499Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#626858}
-
Eric Karl authored
OOP-D equivalent to: https://chromium-review.googlesource.com/c/chromium/src/+/1397321 Although we don't send the fatal message during GPU proc shutdown, Viz is already notified of GPU proc shutdown and will re-create the context based on that signal. Bug: 925929 Change-Id: I3add03ae9e65e09b6d2b124e25095c98a0b4362b Reviewed-on: https://chromium-review.googlesource.com/c/1437992 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#626857}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=miu@chromium.org Bug: 925652 Change-Id: I40e4dd8ac032fe37137f7bd2aafc25677d0e9a1a Reviewed-on: https://chromium-review.googlesource.com/c/1438327Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#626856}
-
Tony de Luna authored
This cl sets up all the dependencies needed for creating a screen locker object in unit tests. Adds TestAccessibilityFocusRingController and TestLoginScreen classes that override ash mojo services in ServiceManager. Tests verifies that ScreenLocker notifies Ash through SessionController.NotifyChromeLockAnimationsComplete. Bug: 804505 Change-Id: Ic868a4f603403617ad91b0949fef693ba1d32dad Reviewed-on: https://chromium-review.googlesource.com/c/1419014 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#626855}
-
dpapad authored
Convert typecasts to {detail: SomeTypeHere} to a CustomEvent<SomeTypeHere> parameter. Bug: 924733 Change-Id: I7dda195143e3603640dce7a45bf8a6dd25318760 Reviewed-on: https://chromium-review.googlesource.com/c/1440462 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#626854}
-
Reilly Grant authored
This change implements a new ChooserContextBase subclass for managing serial port permissions. For now only ephemeral port permissions are supported so no data is saved across browser restart. This allows navigator.serial.getPorts() to be implemented end-to-end. The embedder interfaces for the Serial API are now consolidated into a SerialDelegate interface that can be requested from the ContentBrowserClient. Bug: 908836 Change-Id: I4fd8afe88fceacb4b08af410930fbcdddbc2457e Reviewed-on: https://chromium-review.googlesource.com/c/1417116 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#626853}
-
Kenichi Ishibashi authored
Before this CL ServiceWorkerContextClient called BEGIN macro on the main thread but called END macro on worker thread. Call BEGIN macro on worker thread so that it can have matching BEGIN/END pair on worker thread. Bug: 926031 Change-Id: Ic078cae5b7347d4e68e21f088b1c28277fd47f6b Reviewed-on: https://chromium-review.googlesource.com/c/1441572 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#626852}
-
Xianzhu Wang authored
The BlinkGenPropertyTrees project is a large refactoring of the blink and compositor integrations. The goal of this Finch trial is only to gather early metrics before enabling the feature by default. The Chromium implementation is tracked in https://crbug.com/836884. This testing config is required before we enable 1% field trial on beta channel (cl/230805970). Bug: 836884 Change-Id: I5c8d4d70987d15ad4a99d6f94525cf55a21c727a Reviewed-on: https://chromium-review.googlesource.com/c/1437182Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626851}
-
Takuto Ikuta authored
This is a reland of 3c031af0 I changed libassistant to use lld when lld is used to build chrome in: https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/800068 Original change's description: > build: Default use_lld to true on ChromeOS for x64 > > This is a partial reland of 12b1bbff > > I confirmed current lld can link chrome with the same config of previously failed build. > https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59619 > > Original change's description: > > build: Default use_lld to true on ChromeOS. > > > > As of https://chromium-review.googlesource.com/c/1372768 ChromeOS > > chrome is always linked with lld. Because ChromeOS's build system > > always overrides the value of use_lld this change should have no > > effect on official ChromeOS builds, but it should make ChromeOS on > > Linux more consistent with "real" ChromeOS. > > > > Bug: 701659 > > Change-Id: I447e1b2dfb6cc970f2c2dd64d396b5ba58bc2ef2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1377139 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#616485} > > Bug: 701659, 923168, 917504 > Change-Id: Iedb48cfe5b3b9c189dcf1b4c04bea998ee009d2c > Reviewed-on: https://chromium-review.googlesource.com/c/1419558 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624005} Bug: 701659, 923168, 917504 Change-Id: Ibdb678d59313d7defdb3238e307bbf525dd94dfa Reviewed-on: https://chromium-review.googlesource.com/c/1437040Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#626850}
-
Doug Turner authored
Bug: 897312 Change-Id: Ibbfc4ee379f7c044358bc62359b43da493ce4c90 Reviewed-on: https://chromium-review.googlesource.com/c/1435591Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626849}
-
Cecilia Ni authored
This CL changes all chrome://apps HTML import to its relative path. Bug: 906508 Change-Id: Iab67b3e5120c4907b6e3d9b5422a1c19f266aaaf Reviewed-on: https://chromium-review.googlesource.com/c/1440804Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f4b730aae2..0cde480ef34f Created with: gclient setdep -r src-internal@0cde480ef34f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic774d59a23ed2f026300efeb98974e6330a90b42 Reviewed-on: https://chromium-review.googlesource.com/c/1441291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626847}
-
Saman Sami authored
|texture_target_exception_list| in GpuPreferences and GpuCapabilities contains every pair of format and usage that is supported natively. However, it is not true that every native buffer needs to be bound to the platform-specific target. For example, certain RGB formats can be bound to GL_TEXTURE_2D because they need to be attached to a framebuffer, and we already implicitly assume that this is OK (see WebGL's drawing_buffer.cc). Make this implicit assumption more explicit by not including these formats in |texture_target_exception_list|. Bug: 882591,916728 Change-Id: I155a64bdeb994b3a388078666c769bd8d6adc876 Reviewed-on: https://chromium-review.googlesource.com/c/1423457 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#626846}
-
Keishi Hattori authored
Use MemoryUsageMonitor from OomInterventionImpl and CrashMemoryMetricsReporter Bug: 920922 Change-Id: Iff9f69d87b870ea6acc6c760058745de0d1a052a Reviewed-on: https://chromium-review.googlesource.com/c/1411392 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#626845}
-
dstockwell authored
A separate Viewport interface is split out to break a cyclic dependency. Bug: 721073 Change-Id: I11a690cafcf59ce40095b0fc5f25915c18d68e43 Reviewed-on: https://chromium-review.googlesource.com/c/1416801 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626844}
-
Noel Gordon authored
CL:907991 added arrow key controls for QuickView, but no test. At some point that debt needs to be payed. Bug: 641609 Change-Id: I49c4c4448c3b46f515599a4b96e1a9cc422f03a0 Reviewed-on: https://chromium-review.googlesource.com/c/1436617 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#626843}
-
sczs authored
The main Objective of this CL is to create the files and architecture necessary to present an Infobar banner, and iterate/experiment on these while the new messages UI is being developed. Some implementation details such as Presentation logic, Animation Values, View Content, etc. are not final and will be updated once specs are finalized. Screenshot https://drive.google.com/open?id=1AAbYAsqt3fW0iZlq8JUDcZCSMv6mokZw Video https://drive.google.com/open?id=1z--lrIOf1q35YNUaXsneSn_5bW4obpCw Change-Id: I3cac3aeba05e31d9a07ddabf96e2e1eec4307409 Reviewed-on: https://chromium-review.googlesource.com/c/1387686Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#626842}
-
Trent Apted authored
In its current form, this feature causes existing pages with working logic to handle `MediaPlayPause` events to become flaky. The feature should be fixed, or a workaround announced, before it launches on by default. The audio test is re-enabled. The video still flakes (~1-in-10), likely due to a Chromecast integration that isn't used for the audio player. Bug: 902519, 926035 Change-Id: Iac838690b54c18267be59b8230066db2093ae7fc Reviewed-on: https://chromium-review.googlesource.com/c/1441571Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#626841}
-
Alexey Baskakov authored
Use dedicated utility functions to control some very different things: - Can web apps technically exist and be used. - Should we record metrics for web apps. - Are users allowed to install web apps. Bug: 921468 Change-Id: Idf9ee5532e85af32db885fa36355c3c82c225091 Reviewed-on: https://chromium-review.googlesource.com/c/1415054 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#626840}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1c0b0474c1a0..79ff8bead909 git log 1c0b0474c1a0..79ff8bead909 --date=short --no-merges --format='%ad %ae %s' 2019-01-28 fjhenigman@chromium.org DEPS: Roll SPIRV-Headers and SPIRV-Tools. Created with: gclient setdep -r src/third_party/dawn@79ff8bead909 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If420585f03e5ca8483efaa3220c22325da3771e9 Reviewed-on: https://chromium-review.googlesource.com/c/1441191Reviewed-by:
-
Xiyuan Xia authored
RWHVAura observes focus change of its window by means of aura::client::SetFocusChangeObserver. EmbeddedFocusClient should notify that focus change observer as well. Bug: 924459 Change-Id: If47aae379ec3756e7e3bb5b12fe9c74939393ba3 Reviewed-on: https://chromium-review.googlesource.com/c/1440506 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#626838}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /content/browser/renderer_host/render_widget_host_view_mac_unittest.mm. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 925652 Change-Id: I9e3dac1ef364569271f8b7edf5c067521ead4d62 Reviewed-on: https://chromium-review.googlesource.com/c/1437345 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#626837}
-
Akihiro Ota authored
This change creates a new attribute called detectedLanguage within automation. The attribute value is set by a call to AXNode::GetLanguage() in automation_internal_custom_bindings.cc and can be exposed via |AutomationNode|.detectedLanguage. Change-Id: I1c9e2679c53a4a2e88db91bc1280ca9490a3c8d6 Bug: 923068 Reviewed-on: https://chromium-review.googlesource.com/c/1430919Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#626836}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 925652 Change-Id: Ia7f636f8100f7706e652a0ccb6be7724a4988be0 Reviewed-on: https://chromium-review.googlesource.com/c/1438335 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Alex Newcomer authored
Highlight the submenu area of an actionable submenu when the keyboard is used to focus the submenu area (right (left in rtl) arrow). Bug: 880800 Change-Id: I7f28493561dbea1d77d8e3eff6a6a91c6ddc0e31 Reviewed-on: https://chromium-review.googlesource.com/c/1437334Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626834}
-
Rob Schonberger authored
Update fake app instance to reflect new mojom call. Bug: 911427 Change-Id: Ie782d372b53490ed1c94e92c9e16aa78b236113c Reviewed-on: https://chromium-review.googlesource.com/c/1440805Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Auto-Submit: Rob Schonberger <robsc@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#626833}
-
Andrew Xu authored
handwriting input Handwriting/voice input or emoji generates fake pressing/releasing key events. But pressing/releasing key events use different key code. As result, the accelerator history fails to remove the fake pressing event after receiving the fake releasing event. In fact, key events with key code of ui::VKEY_PROCESSKEY have no effect on accelerator processing. So in this CL, stop tracking those key events in the accelerator history. Meanwhile, refactor the accelerator history code. Test: ash_unittests Bug: 918317 Change-Id: Iafdc5658c93fc029942dbdc20571558ed84a3eb3 Reviewed-on: https://chromium-review.googlesource.com/c/1427439 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
Since we are not loading main resources in blink anymore, we can get rid of kMainResource type and all the code related to main resources. Removing kMainResource from probe::willSendRequest requires splitting that probe into two: one for subresources, and one for navigation request. We now pass different parameters to these functions and handle them separately. Bug: 855189 Change-Id: I67624e40d9ffddabd685805c0e35acb699685c1c Reviewed-on: https://chromium-review.googlesource.com/c/1434074Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#626831}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6bf2d799..6e89f8f5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0658c329b9e3b453bd3e2571f9641d9129cd647e Reviewed-on: https://chromium-review.googlesource.com/c/1440508Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626830}
-
siyua authored
Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1364695 got reverted because: In test setup saving card to personal_data_manager is an asynchronous process, if we don't wait it to finish before moving on with the test, the card used will be labeled as new card. Then no migration request will be sent. This causes time-out issue. Have fixed this by re-using the function in autofill_uitest_util.* in the SaveLocalCard() and SaveServerCard(). No other change was made. Have run the tests for over 500 times. All passed. Bug: 897998 Change-Id: I7c1e1172214773bc31cd93ef9da43fc68fd9a9f2 Reviewed-on: https://chromium-review.googlesource.com/c/1437267Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#626829}
-
Daniel Rubery authored
In preparation for pinging on unknown file types, start tracking the most common known safe file types. This is a no-op (except for some metrics) since the files used to fall into the default case, which is SAMPLED_PING. Bug: 918991 Change-Id: I7f599bae29f6bb4b2a9e3fc6033c890c26c97861 Reviewed-on: https://chromium-review.googlesource.com/c/1440911Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#626828}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/556d7714fda3..eae881c2a8ba git log 556d7714fda3..eae881c2a8ba --date=short --no-merges --format='%ad %ae %s' 2019-01-28 lakshmana@google.com Add APIs to cros interface and cros platform backend class. 2019-01-28 benjhayden@chromium.org Add api handler to assign alerts to existing bug. Created with: gclient setdep -r src/third_party/catapult@eae881c2a8ba The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I3d01173ac5457d5c4911a7491041c3cb58ad7609 Reviewed-on: https://chromium-review.googlesource.com/c/1440747Reviewed-by:
-
Luciano Pacheco authored
Fix moving files/folders to MyFiles: it was failing because it was passing VolumeEntry to |moveTo| API, so unwrap to get the native Entry before passing to this API. Fix test to use "cut" command for moving files because this is the right name for "move" so the final "paste" works. Change DirectoryTree to add attribute volume-type-icon for MyFiles to be able to use the same testing helper |selectVolume|. Once we remove the MyFilesVolume flag we can remove this thus the TODO. Change transfer tests to ignore file size and modified time when comparing files in the file list, because LinuxFiles and PlayFiles don't work for these properties. Also fix a problem in waitForFiles which was mutating the expected value. In many cases that's a global variable and was interfering with subsequent tests. Bug: 925175 Change-Id: I13a12191491a648867d6d28cae09143da86763a7 Reviewed-on: https://chromium-review.googlesource.com/c/1436468 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#626826}
-
Daniel Rubery authored
With one exception, we now pass: gn check //chrome/browser/safe_browsing/* The exception is that the advanced_protection target depends on //chrome/browser, but explicitly declaring that creates a new circular dependency. This will be fixed by future refactoring work. Change-Id: I8966e877a699444417d45980068e4a9d04ff2cb3 Reviewed-on: https://chromium-review.googlesource.com/c/1439963 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
