- 16 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/587c24edf8c9..d9fa7597dbe5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com,bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117244,chromium:1128710,chromium:912681 Tbr: dalecurtis@google.com,bcwhite@google.com Change-Id: I533063604d5fc22cd5d70bbc0c767e3838594799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414603Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807681}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b1620f36648..db4a9fbc6532 2020-09-16 herb@google.com verify there are no glyph searches 2020-09-16 michaelludwig@google.com Reland "Enable novel GrClipStack on bots, disable elsewhere" 2020-09-16 brianosman@google.com Remove swizzle helper function for type creation 2020-09-16 johnstiles@google.com Avoid redundant zeros and ones in swizzle constructor. 2020-09-16 herb@google.com simplify setMetricsAndImage API 2020-09-16 adlai@google.com Remove SkSurface::getContext 2020-09-16 michaelludwig@google.com Use SkClipOp::kIntersect instead of kReplace_ClipOp 2020-09-16 ethannicholas@google.com Revert "moved BinaryExpression's data into IRNode" 2020-09-16 johnstiles@google.com Migrate swizzle tests to golden SkSL files. 2020-09-16 mtklein@google.com good codegen for Op::mul_q14x2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ifd83997383a14f396f554a0b0e38280c28b8acf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807680}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/804db2dde3f1..bb25c561dcf2 2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1519d2c4..a6c88d89 (807375:807489) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7995fd4a2ff5cc3d3ab861fd2df1fcb5155956cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415018Reviewed-by:
-
Alex Danilo authored
Feedback panels display operations in progress with the source and destination visible. In cases where the destination string is empty (e.g. copying to a USB drive with " " as its name), the feedback message should be grammatically correct. Adds new strings for display when there is no destination string. Changes the string generation code to detect empty destination string and use the appropriate string for formatting. Bug: 1076312 Tests: Manually tested for all cases, with transfer progress as well. Change-Id: I72a162d8e0a18a4415d043501bee3cb53b802b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409560Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#807678}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I4addb2af5cf2f592f214f269f179874563042d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415131Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#807677}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69e49314..d17b524f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I35222eed0fbd5b37ba116ca738a9491694ea3c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807676}
-
Alexander Alekseev authored
This CL changes ui::ScopedAnimationDurationScaleMode to accept arbitrary duration multipliers and implements dynamic animation duration control in Ash HUD. This CL also implements SliderMovementController and splits views::Slider into ContinuousSlider and DiscreteSlider. HUD animation speed control UI is using DiscreteSlider. UI screenshot: https://screenshot.googleplex.com/4xco9FhnDAsH5sJ.png Bug: 1112706 Change-Id: Ic5bc32d3a900f35ead51e5acedf787e1fc050452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393623 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#807675}
-
Elly Fong-Jones authored
This platform sometimes has a spare BRK #1 at the end of IMMEDIATE_CRASH, for secretive compiler reasons. Allow for that here. Bug: 1128436,1121871 Change-Id: I86cb8d015b2ec6c5b6160a6db28682faa9dc4c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415092 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807674}
-
Swapnil authored
The browsertests related to hide webstore icon policy are moved to a separated file. Bug: 1128681f Change-Id: I9524e448b994ba79003587a66c4c39c3b27443a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414388Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#807673}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cb190dce089b..4cb0981f2d4b 2020-09-16 bpastene@chromium.org devil: Try safely handling 'connect for root closed' errors when rooting 2020-09-16 hypan@google.com Skip the root attempts for devices with "user" build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052434,chromium:1126536,chromium:1127009 Tbr: oysteine@google.com Change-Id: Ife93bcc08a99f94dff1fad2a162765be357ff7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415017Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9d95499e1533151d82d06f17ed5be5eb5fd847f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414503Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ife22d3faf7d10289469367080065ff5cffe93e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385359Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807670}
-
Haiyang Pan authored
Bug: 1111436 Change-Id: I8292f16d83847cd2cf3489e9aa6771dcb11a4a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413112Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#807669}
-
Lukasz Anforowicz authored
RenderFrameHostImpl::UpdateSubresourceLoaderFactories method is called after NetworkService process crashes and recreates/resends URLLoaderFactory objects to the renderer process. Before this CL, the recreated factory was always based on the |last_committed_origin_| (and |last_committed_client_security_state_|, etc.). This resulted in creating a factory with a wrong |request_initiator_origin_lock| to a frame that was in the process of committing a navigation. A similar problem (using |last_committed_origin_| rather than the target origin of an in-flight/in-commit NavigationRequest) has already been known (had to be addressed in https://crbug.com/1047436) but the known scenario and the fix (e.g. RFHI::GetExpectedMainWorldOriginForUrlLoaderFactory) focused on isolated world factories. In this CL, the previous fix is made more generic by splitting GetExpectedMainWorldOriginForUrlLoaderFactory across FindLatestNavigationRequestThatIsStillCommitting and ExtractFactoryParamsFromNavigationRequestOrLastCommittedNavigation methods. While working on the CL, all callers of RFHI::CreateURLLoaderFactoryParamsForMainWorld and RFHI::CreateURLLoaderFactoriesForIsolatedWorlds have been inspected and most of these callers have been switched to basing factory parameters based on the in-flight NavigationRequest if one exists. (all except RFHI::CreateNetworkServiceDefaultFactory that is exposed via //content/browser/public and we assume has an expectation of working with the last committed origin). Bug: 1056949 Change-Id: I3cadd28ec71d8a203117a314d084314e60babc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399184 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807668}
-
Swapnil authored
ForceInstalledMetrics::ReportMetrics is a large method and it would be good to break it down into smaller sub-methods. This CL adds a new method to report detailed failure reasons for force installed extensions which failed to install after 5 minutes. Bug: 1127908 Change-Id: Ic4df742779a6cc8658ee857f8167e43ac6603f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410399Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#807667}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3504e85b742c..a2ba0ce189ca 2020-09-16 treehugger-gerrit@google.com Merge "tp: switch from using libprotoc to libprotobuf-full" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I879064d262331136b5ac9aee219e747291a4a42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414496Reviewed-by:
-
Hui Yingst authored
This CL adds event handlers for downloading attachments, and replace |attachmentToken| with |messageId| in |SaveAttachmentDataMessageData| since now the controller uses |messageId| to locate the resolver. Bug: 177188 Change-Id: I9f88c916d5eff997a2b03c91bf646c8dfa6a66e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337408Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807665}
-
Mohamed Amir Yosef authored
... persisting and removing compromised credentials records. Bug: 1119286 Change-Id: I1899c6802e2fff955bfc0f1cdb6942a787784e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410492 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807664}
-
Sunny Sachanandani authored
Trace tests don't take extra browser args specified by the corresponding pixel test into account. Most tests don't have any extra browser args, but a few disable gpu compositing and don't depend on the browser args for correctness. However, an upcoming pixel test will need its browser args for correctness: https://chromium-review.googlesource.com/c/chromium/src/+/2402192 Bug: 1077211 Change-Id: Ieaaa5fd0c466c8f3b52291ae903d8ab5ec7d43d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415088Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#807663}
-
Nikita Podguzov authored
Bug: 1108908 Change-Id: Iff1c506befb6e7703f8858246cdade1493b87f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409915 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807662}
-
Mario Bianucci authored
Right now, the delegated ink metadata remains on a CompositorFrameMetadata even after it has been used. This can result in the same metadata being used to draw the same trail on multiple frames. A delegated ink trail should only ever exist for a single frame, so this is a bug. This CL fixes this by just resetting the delegated ink metadata on the surface's FrameData after it has been used exactly once. Bug: 1052145 Change-Id: If2ac527a30344cc0bb0a70c405860e5b724f7102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402290Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#807661}
-
Reilly Grant authored
This change implements automatic blocking of requests for the "idle-detection" permission from incognito profiles in order to prevent the feature from being used to correlate incognito and non-incognito sessions. As for requests for the "notifications" permission rather than simply automatically denying the request (which would be an incognito oracle) this patch waits a random amount of time before triggering the denial. The code from the NotificationsPermissionContext is cleaned up and reused for this. Bug: 878979 Change-Id: I57c57f39457932f570d7094882dc00d9c0eafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360943 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807660}
-
Akihiro Ota authored
This test ensures that the lessons shown depends on the category the user chooses. For example, the lessons shown for 'New User' and 'Experienced User' are different. It also adds logic to compute the header for the lesson screen, which will be localized in a follow-up (see TODO). Bug: 1127034 Change-Id: Ib523205368593c7b782a9491c17f3f6608c7f491 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404150Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#807659}
-
Mike Dougherty authored
A scroll search action needs to be used in order to find the Payment Methods button in settings on small devices. AutofillEditCreditCardTestCase/testValidNickname is failing on https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/14177 and these other tests have been disabled due to this same problem. Bug: 1108809 Change-Id: I37716c9db5d96d856039aab4496305e027ac9348 Fixed: 1106734, 1106766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414558Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#807658}
-
Aaron Colwell authored
This change introduces the ability to differentiate between an invalid process lock (i.e. default constructed) from one that is explicitly willing to allow any site to be placed within it. Historically it was not possible to differentiate these two cases despite the fact that we might want to treat them differently for security purposes. This change introduces code that represents the new concepts and updates the locking code to explicitly transition a process from the invalid state to the "allow_any_site" state. SiteInstanceImpl behavior has changed as follows: 1. Previously, if a SiteInstance didn't require a dedicated process, its process wasn't locked to anything at all, and its lock remained empty. Now, such a SiteInstance will *also* lock its process to the new allow_any_site type of lock. Hence, after this change, any process that has rendered web content *should* have a valid process lock, either an allow_any_site lock or the traditional site-specific lock. Legacy code that still depends on ProcessLock::is_empty() will still work as before because invalid and allow_any_site locks are both considered empty. This will be updated in follow-up changes. 2. Previously, we used to only lock the process *once*, at the first time where we had both the site and the process set. Now, LockProcessIfNeeded() could be called twice for a single process, once when the process is locked to an allow_any_site lock (when a siteless SiteInstance gets a process assigned in SetProcessInternal), and later when the lock is "upgraded" to a site-specific lock (when the SiteInstance calls SetSite). Bug: 1085275 Change-Id: I6c87ab12bd55a05451165943b008d7dc8b09226f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410662 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by: -
Akihiro Ota authored
This change allows a user to turn ChromeVox off, even if UserActionMonitor is active. This is useful in the tutorial, where some lessons block ChromeVox execution. This change also fixes a closure error in tts_background.js. Bug: 1126135 Change-Id: I583c572dd5017e373022aa6614086dc839e1c9b1 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412631 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807656}
-
Reilly Grant authored
This change implements permissions prompts for the "idle-detection" permission on desktop and Android as well as the necessary site settings UI. Bug: 878979 Change-Id: If5e91bf6fe19ba93c4439ff4eec7fee0ef5fc1d8 TBR: hkamila@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360485 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
-
Dale Curtis authored
This reverts commit 3f2f2acf. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14962? Original change's description: > Android: Add lint regression test > > New API related checks are some of our most valuable lint checks, as > triggering an error causes a crash directly. > > This CL adds compile test targets to ensure that code with API level > errors trigger lint warnings. This prevents lint being accidentally > turned off. > > Also delete now obsolete //build/android/lint directory and remove some > already-fixed suppressions from lint-suppressions.xml. > > Bug: 1108309 > Change-Id: I87e68c85ae6670b1c8a1f0691600e021477c2ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412808 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807625} TBR=wnwen@chromium.org,mheikal@chromium.org Change-Id: I7d9d8ed518861233f1f65095fa614ce88c0f2778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414846Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807654}
-
Thomas Guilbert authored
Currently, when we enter an immersive XRSession, window.rAF calls stops, which means we no longer deliver video.requestVideoFrameCallback calls. This CL adds video.rVFC support to immersive XRSessions. If we find an immersive XRSession, we schedule video.rVFC callbacks there instead of the ScriptedAnimationController (SAC). There can only be one immersive XRSession. If we don't find a session, but we find that the XRFrameProvider exists, we request to be notified when an immersive session start. This allows us to keep callbacks going if the callbacks were already scheduled in the SAC when starting an XRSession. Simmilarly, if the session ends when callbacks were pending in the XRSession, we reschedule ourselves in the SAC. Bug: 1107578 Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406522 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807653}
-
Carlos Frias authored
This CL updates the OsIntegrationManager::UninstallOsHooks() method to accept an additional |os_hooks| parameter to specify which OS Hooks to uninstall. This CL is in preparation to allow Run on OS Login to be enabled/disabled by the user after the web app is installed, via the OsIntegrationManager::UninstallOsHooks() API. Currently there is no way to uninstall an OS Hook (i.e. Run on OS Login) individually. This CL consists of the following changes: 1. Update OsIntegrationManager::UninstallOsHooks() to honor the passed |os_hooks| and only uninstall the specified OS hooks. 2. Add OsIntegrationManager::UninstallAllOsHooks() API to be replaced in places that currently call UninstallOsHooks() with the intention to effectively uninstall all OS hooks. Bug: 1121372 Change-Id: Ie294f61b9518e997bf4192ac1bdcb7db5bf819fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372819 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#807652}
-
Adrienne Walker authored
Given the uncertainty around whether the probabilistic finch-controlled feature can be rolled out to all users before the existing date, move this date forward another six months. This does overlap with the removal of AppCache and the end of the AppCache origin trial (M90) and so hopefully between AppCache being removed and the finch feature rollout, this is the last time this date will need to be moved. Bug: 582750 Change-Id: I8b21da18ba5a39632542aa8dad168ace15564afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414988 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807651}
-
Irina Fedorova authored
This CL renames and updates GetPlaintextCompromisedPassword, ChangeCompromisedCredential and RemoveCompromisedCredential functions to support both weak and compromised credentials. Bug: 1119752 Change-Id: I88cfdbfc6c4628d624fea401a6fb9b687a6e6e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410135Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#807650}
-
Xiaohan Wang authored
This reverts commit a98a8fa4. Reason for revert: causing test failure Original change's description: > media: Trigger Infobar on Mac ARM on EME query failure > > CDM on Mac ARM is not ready yet. When requestMediaKeySystemAccess() > fails on Mac ARM, we reject the promise with "Unsupported platform" and > trigger an infobar to notify user. The infobar will be triggered at most > once per render process. > > Since the infobar can only be triggered in the browser process, a new > mojo service CdmInfobarService is added. Note that even though there > already exists KeySystemSupport service, which is also implemented in > the browser process, we cannot trigger the infobar there, because the > infobar requires a WebContents context, while the KeySystemSupport > service is bound to a render process instead of a render frame. > > Change-Id: Ia85a1f2b097b0c2d26d12cc3e9363c34a25691a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404716 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807631} TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org Change-Id: Ia3e06b8685f70b3e3e000df2bbf24054bcc97ada No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414759Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807649}
-
Ryan Hansberry authored
Includes tweaks to ClientProxy subclasses and the tests that use them, because ClientProxy::OnBandwidthChanged() signature changed. Includes tweaks to BleMedium implementation to account for addition of Fast Advertisement feature, but does not correctly implement their expectations -- that will be done in a subsequent CL. Change-Id: I71fb3f8314abc3439350096243f544cc63e79c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410652 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807648}
-
Mirko Bonadei authored
This CL will allow projects (like WebRTC, see [1]) to configure whether to use XCtest or not on a target by target basis instead of doing it at build level with the GN arg 'enable_run_ios_unittests_with_xctest'. [1] - https://webrtc-review.googlesource.com/c/src/+/184360 Bug: webrtc:11937 Change-Id: Ia227b2f5eb268dc59cfbe5617dbfc4836e6ae372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414169Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#807647}
-
Dirk Pranke authored
The GN template was generating a wrapper using a name different than what we'd expect it to be using. Bug: 1128390 Change-Id: I1f9b0d3c6b4cdcacd2c27d24f87fa3b891d31f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414918Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#807646}
-
Carlos IL authored
This also adapts ssl_browsertest.cc with the new behavior (i.e. not removing the lock icon for mixed forms if mixed form warnings are enabled) and removed mixed content from autofill_interactive_uitest.cc Bug: 1105210 Change-Id: I39f6910ac3bdfbbc7d33b719c1d9eca3b7b8ee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405555 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#807645}
-
Hans Wennborg authored
This makes LLD faster, especially when performing ThinLTO. Reduces link time of chrome.dll with 34% in official builds with ThinLTO enabled. It also makes regular (non-goma) builds 6% faster. Bug: 1111798 Change-Id: I12870d5b14bf559b333260347dbb93c7e4fe8a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398685 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#807644}
-
John Williams authored
Bug: 1126456, b/168119924 Change-Id: Ibf372f4eb7c2a75479626a8f542e5b15de461f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405632Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#807643}
-
Bo Liu authored
If fragment is stopped due to config change, then there is no need check whether views are attached for visibility since we want to maintain that the active tab is visible in that case. And remove the call to destroy attachment in detach, which is not needed anymore to maintain visibility. And it's probably the source of some crashes caused by destroying attachment too early before all views are detached and the activity destroyed. Bug: 1127246 Change-Id: I863ae612d1015dee433fbabd16dc7c81d82e60c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414668 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
