- 09 Jan, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2faec18..b6f9b1b9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1094319e5825965040b348a107c67d24e21112f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992535Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729753}
-
danakj authored
Since some code needs to unconditionally move the callback before it can tell if the ownership should actually stay with the caller, and it has no way of getting it back, we must turn the OnceCallback into two callbacks, and trust the code to only run it once given the current design of the system. R=eseckler@chromium.org Bug: 1035444 Change-Id: Ib18da9dd948b90a5f18ce0ed165a75a9b6f6e21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992500Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#729752}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3aa0411a4cb6..6a46fc9f347c git log 3aa0411a4cb6..6a46fc9f347c --date=short --first-parent --format='%ad %ae %s' 2020-01-09 szuend@chromium.org Properly await {Breakpoint._refreshBreakpoint} 2020-01-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-09 tvanderlippe@chromium.org Reland "Migrate timeline/ to ESM" 2020-01-09 liviurau@chromium.org Revert "Whitespace to trigger builders" Created with: gclient setdep -r src/third_party/devtools-frontend/src@6a46fc9f347c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I369f65fb4179ea2727385f7752c35361bfbf513b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729751}
-
Manuel Rego Casasnovas authored
The change in r702352 was causing issues in some situations, when an inline element has some changes that cause an overflow that should be visible in a scroller. Problem is that we're no longer calling MarkSelfPaintingLayerForVisualOverflowRecalc() after r702352 and the visual overflow is never recalculated. This revert changes the call in NGBlockNode::CopyFragmentDataToLayoutBox() to the original one, to SetNeedsOverflowRecalc(). Due to that change we need to disable NeedsLayoutOverflowRecalc unit test as it's now failing. We added a new test case to prevent a similar regression in the future. BUG=1036644,941180 TEST=fast/overflow/visual-overflow-recalc.html Change-Id: If205d08281ca0186559715a788b132850e3cbdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992423Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729750}
-
kylechar authored
The VizDisplayCompositor feature is no longer checked so it can be removed from the test command line arguments. Bug: 936425 Change-Id: I2eab4f68664de40c87f0aa8e696f6117d4f4e1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992622 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#729749}
-
kylechar authored
The histogram didn't end up being useful. Fixed: 1037114 Change-Id: I57237d7617dd3beea8ad51476a30f86ac493a2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988856 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#729748}
-
Michael Achenbach authored
No-Try: true Bug: 1011279 Change-Id: I1cae4cc52793848009175c56d932b5512ef9e959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989756 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#729747}
-
Mia Glaese authored
In browsing mode: New Tab menu item: show homepage New Incognito Tab menu item: show homepage in incognito New Tab Button: show homepage Known issues: Tapping the + button on the Homepage leads to no action and the button being disabled. There is a CL underway to remove the + button in the HomePage, so this won't be an issue. Bug: 982018 Change-Id: I0eb71ccb2685778f422dcb9045496c8f2a0da79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983559 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#729746}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b19eb399cb53..26e1b7ac0175 git log b19eb399cb53..26e1b7ac0175 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 danilchap@webrtc.org Delete RtpDepacketizerVp8 in favor of VideoRtpDepacketizerVp8 2020-01-09 jonaso@webrtc.org Add field trial to base stable target rate on loss based target rate Created with: gclient setdep -r src/third_party/webrtc@26e1b7ac0175 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I31dd969ab49afc180f42c193716dae7d70fc9142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991955Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d457b7d9533..f5bc8fba9573 git log 1d457b7d9533..f5bc8fba9573 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 kjlubick@google.com [canvaskit] Create an SkImage from a frame of an SkAnimatedImage Created with: gclient setdep -r src/third_party/skia@f5bc8fba9573 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: Ic7e3dbd83de1f48d1c8075bb149079815254fc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991953Reviewed-by:
-
Fredrik Söderquist authored
If the <img> element in the image document has had it's source cleared out (by having its 'src' changed or by moving it to an inactive document or similar cases) we may not have any image content associated with it when we reach ImageDocumentParser::Finish (when the original image data finishes loading). Check if image content exists before updating the title of the document et cetera. Bug: 1036686 Change-Id: I5d0e2e52e9373c541e64d33bbaa6c67dd0535092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989755Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#729743}
-
Lucas Gadani authored
Bug: 870815 Change-Id: I710213238a0164cf26cfac57953f8adc6406a75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992592Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729742}
-
Antonio Gomes authored
The class ivar that holds the GURL value is not used anywhere. Hence, this CL simply removes it altogether. BUG=787254 R=haraken@chromium.org Change-Id: I7538901a567388c56774ee5cdb8426132603b811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992534Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#729741}
-
Matt Menke authored
In order to isolate network activity from different sites, we're splitting the DNS cache by NetworkIsolationKey. In the case of Pepper, this means it just needs to grab the NetworkIsolationKey from the RenderFrame associated with the ResolveHost call. Bug: 997049 Change-Id: I880c629d42afbe6fa3426f30dca24c3ae6976815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958498Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#729740}
-
Elly Fong-Jones authored
These are the last overrides in //chrome :) Bug: 1011446 Change-Id: I6310fb004719143708fa193c3604630c2c5ebfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992211Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729739}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/77c89ff847b6..73bcece48b0c git log 77c89ff847b6..73bcece48b0c --date=short --first-parent --format='%ad %ae %s' 2020-01-09 swiftshader.regress@gmail.com Regres: Update test lists @ 77c89ff8 Created with: gclient setdep -r src/third_party/swiftshader@73bcece48b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If77e01648c105f465c1a3e7bc92ff73cd8ee3da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993275Reviewed-by:
-
Bo Liu authored
Variable allocator generally implies app zygote is being used, which only supports allocating 100 services at the same time. So add this limit to VariableSizeAllocatorImpl by refactoring the implementation for FixedSizeAllocatorImpl into the common parent class. Change-Id: I58230b9d0f445863bfca0ec9aad8ca9489e4ccfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980555Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729737}
-
sebsg authored
This reverts commit 7076daa4. Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 Original change's description: > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > Test was producing a minor image diff, has been triaged. > > Bug: 1040202 > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729597} TBR=kbr@chromium.org,bajones@chromium.org Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729736}
-
Mike Reed authored
bug: skia:9768 Change-Id: Ic366b14972c13625fc83f44f6f0782bc4052f44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988721Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#729735}
-
Yuichiro Hanada authored
The histogram is still useful for us to track Android IME support usage on ARC++. Bug: 911354 Change-Id: I280704e50df1829115ffe5b7da23cdf905371b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989605 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#729734}
-
Gauthier Ambard authored
The Settings used to have CollectionViews instead of TableViews. Now that the use of CollectionView has been removed, we can remove the classes used to implement it. Bug: 894800 Change-Id: I0865b61f884760d956855d0771f5524e12662a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993281 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729733}
-
Yutaka Hirano authored
QuicTransport.ConnectWithError has a wrong TODO led by my misunderstanding of the spec. Remove the TODO and add additional checks. Bug: 1011392, 1037752 Change-Id: Ia75f2c5ade51c8cd0a44d0cf48dff18ccf98ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981949Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#729732}
-
Kent Tamura authored
This reverts commit 9fc859a3. Reason for revert: It was a wrong approach. https://bugs.chromium.org/p/chromium/issues/detail?id=1037728#c11 Original change's description: > Restoring control state should dispatch 'input' and 'change' events. > > According to the last two paragraphs of [1], UA should dispatch 'input' > and 'change' events if it fills control values on behalf of a user. > > [1] https://html.spec.whatwg.org/C/#common-input-element-events > > Bug: 1037728 > Change-Id: Ic389cc4e3bc4523f740b0164ac863baba66dcd35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981241 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727843} TBR=tkent@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037728 Change-Id: I504d202de886e4278369ab3da37c41b70b773f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993078Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#729731}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a4e536a0953d..3aa0411a4cb6 git log a4e536a0953d..3aa0411a4cb6 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 liviurau@chromium.org Whitespace to trigger builders 2020-01-09 sigurds@chromium.org [network] Change signature of empty protocol message handler Created with: gclient setdep -r src/third_party/devtools-frontend/src@3aa0411a4cb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032063 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If21fb5bcf68210cebc62a0702d584dea613cf9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993269Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af272d6eb830..b19eb399cb53 git log af272d6eb830..b19eb399cb53 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 danilchap@webrtc.org Delete obsolete unused rtp header extension conversion Created with: gclient setdep -r src/third_party/webrtc@b19eb399cb53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idcb7c385329f9990e2d0e14482385612619e98bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993274Reviewed-by:
-
Mythri A authored
https://chromium-review.googlesource.com/c/chromium/src/+/1986844 re-recorded browse:social:tumblr_infinite_scroll:2018 story. This was disabled for multiple reasons. With the current recording the pinpoint jobs on pixel2, android-go, linux, windows and mac platform ran successfully. So re-enabling this on all platforms. Bug: chromium:1027686, chromium:961417 Change-Id: I47ece821103e485faa7b0378a3a680cc93275a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991422Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#729728}
-
Olivier Robin authored
This reverts commit 738d6a13. Reason for revert: This Cl breaks ios-simulator bot https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/51842 Original change's description: > Enable HistoryServiceUsesTaskScheduler by default > > Change-Id: Iaee9edf31fd2303a28bbeedc155cb7dd9381cdb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960467 > Auto-Submit: Oliver Li <olivierli@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Oliver Li <olivierli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728929} TBR=sky@chromium.org,olivierli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I13aad198a6783d207513d3f4d07500d22ebe8316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991627Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729727}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 835781a4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iaec054cf83a770da4320293e6f22dc32a9ec14f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729726}
-
Tomasz Dobrowolski authored
This unit test uncovers a problem with WebPageNotifierController, which is not working properly with anything else than full URL patterns (in scheme://url format). Most test cases are disabled for now (see test_patterns vector), until the problem is fixed. Bug: 989845 Change-Id: Ifb514d603e489fc3775fe0d3c9e4e419b47dc722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811122 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#729725}
-
Luca Hunkeler authored
Print screen: https://screenshot.googleplex.com/xnR0bvVCEhQ Bug: b/146145185 Change-Id: I44c5c87906d6f2755a6bd0c3370f0306c5b0d6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969344Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#729724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65793110f5f1..42d8fcc5f877 Created with: gclient setdep -r src-internal@42d8fcc5f877 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I96ec8127dd0cceacb0904d2ce8ed384b3f572a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993266Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729723}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1186eac..d2faec18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5de8f2f8698c5d1a6fd8e265aec504e125423bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992533Reviewed-by:
-
Yuki Shiino authored
After the unified heap, lifetime control in v8_message_channel_custom.cc should be no longer needed. Removes the custom bindings. Change-Id: Icc0228509a490efc3bc53afd3db1d2019eef185d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993070Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#729721}
-
Mikel Astiz authored
This reverts commit d35a5b72. Reason for revert: suspect of causing crashes. Bug: 1040498 Original change's description: > Bookmark sync: use GUID as temporary server ID during commit > > This patch effectively relands the logic reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which > caused crashes in the past (CHECK failures). > > In this new form, the underlying issue is addressed: for users that > don't use GUID-based merging of bookmarks, local GUIDs are reassigned > randomly to avoid GUID collisions in the local bookmark model. > > Bug: 978430,1004205 > Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729405} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: Ia25a087dacc36e8ca6ad351a4664e9478b1ba23a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978430, 1004205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991628Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729720}
-
W. James MacLean authored
This CL adds an 'isolation' key to OriginPolicy, as per the proposal at https://github.com/domenic/origin-isolation#example. Bug: 900995 Change-Id: I8b676070d5a38dfb394427c244cf10936072c229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975992 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/debe1986ce2c..85c4a438f6f1 git log debe1986ce2c..85c4a438f6f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 phoglund@google.com Add support for sending histogram.proto JSON to /add_histograms. Created with: gclient setdep -r src/third_party/catapult@85c4a438f6f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: oysteine@google.com Change-Id: I57cb5f630c4873a496583edd712e7b0c3c339310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993270Reviewed-by:
-
Tomasz Moniuszko authored
Bug: 1020136 Change-Id: I313a479663dda83c4bdf7d882911b029bbbe2cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901466 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729717}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9553930c2093..6c26eac37f09 git log 9553930c2093..6c26eac37f09 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 eseckler@google.com Merge "ui/extension: Record using Chrome's browser DevTools target" Created with: gclient setdep -r src/third_party/perfetto@6c26eac37f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6c7f0bf4a3b3d618b694711d7f7ea504f41e43a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993268Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.18-1578309018-benchmark-81.0.4016.0-r1 to 81-3987.18-1578309018-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f495f8c28427fb55415306d595b9435d493b52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993273Reviewed-by:
-
Mia Glaese authored
Screenshots here: https://drive.google.com/drive/folders/17MCAlDrQidwqYw1sDP1gJAeQZB2FGxbl?usp=sharing Bug: 982018 Change-Id: Id682d6544b123fe6bb7c9777c319aff8c85458b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989994Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#729714}
-
