- 04 Sep, 2014 40 commits
-
-
Viet-Trung Luu authored
We don't need to do deep copies -- shallow copies will do. However, for structs and such, we need to carefully work around the shared_definition nonsense. R=jamesr@chromium.org BUG=406156 Review URL: https://codereview.chromium.org/535333002 Cr-Commit-Position: refs/heads/master@{#293352}
-
prasadv authored
BUG=409875 NOTRY=true Review URL: https://codereview.chromium.org/536553003 Cr-Commit-Position: refs/heads/master@{#293351}
-
dmazzoni authored
This broke due to r285254 (http://crbug.com/391008), the fix is trivial. BUG=408809 Review URL: https://codereview.chromium.org/540583002 Cr-Commit-Position: refs/heads/master@{#293350}
-
Jun Mukai authored
This is separated from https://chromiumcodereview.appspot.com/535373002/ just for CQ safety. TBR=yoz@chromium.org TEST=None BUG=407777 Review URL: https://codereview.chromium.org/536323005 Cr-Commit-Position: refs/heads/master@{#293349}
-
maxbogue authored
BUG=378035 Review URL: https://codereview.chromium.org/537083002 Cr-Commit-Position: refs/heads/master@{#293348}
-
Matthew Dempsky authored
Rework the seccomp_bpf compiler internals to work in terms of a single general masked-equality condition instead of the variety of limited condition operators previously supported. All of the peephole optimizations previously applied continue to be supported so similar instructions should be emitted, but the handling of upper/lower words is more cleanly structured now. The old sandbox->Cond() interface continues to be supported for now so that the old seccomp_bpf_unittests continue to give us assurances that the new code generator is still correct. Meanwhile, we provide a new lower-level sandbox->CondMaskedEqual() method that bpf_dsl can now use. BUG=408845 R=jln@chromium.org Review URL: https://codereview.chromium.org/530133003 Cr-Commit-Position: refs/heads/master@{#293347}
-
srawlins authored
Review URL: https://codereview.chromium.org/538733002 Cr-Commit-Position: refs/heads/master@{#293346}
-
mef authored
BUG=409926 Review URL: https://codereview.chromium.org/520093002 Cr-Commit-Position: refs/heads/master@{#293345}
-
prasadv authored
BUG=405274 NOTRY=true Review URL: https://codereview.chromium.org/538093002 Cr-Commit-Position: refs/heads/master@{#293344}
-
Andrew Scherkus authored
This removes the hacky fall-back-to-interpolated-time code when audio ends before video. Considering we're still getting audio render callbacks during this time, we can simply account for how much silence we've written to compute the media time. More importantly, this brings AudioRendererImpl's TimeSource implementation in line with how WallClockTimeSource operates and gets us one step closer to removing TimeDeltaInterpolator entirely. BUG=370634 R=dalecurtis@chromium.org, xhwang@chromium.org Review URL: https://codereview.chromium.org/518613002 Cr-Commit-Position: refs/heads/master@{#293343}
-
nednguyen authored
Context: see https://codereview.chromium.org/511653002/ BUG= Review URL: https://codereview.chromium.org/540483004 Cr-Commit-Position: refs/heads/master@{#293342}
-
lazyboy authored
There were couple issues that were fixed: 1. If oninput listener fires before the guest is requested to "wait for oninput", we would timeout. This is taken care of by a flag. 2. TextInputClient::SetCompositionText() call sends an IPC to the renderer/, if the next JavaScript step runs before the IPC is sent then that would fail the test. This is taken care of by sending executing empty JavaScript code on the embedder. BUG=387956 Test=Internal test only change, nothing visible. Review URL: https://codereview.chromium.org/532883003 Cr-Commit-Position: refs/heads/master@{#293341}
-
nyquist authored
Changes are needed for Chrome for Android using nano protobufs. Full list of changes: r339 Adding forwarding implementation of WakeLockManager in its original location (temporary workaround for Chromium) r338 * Updating example code to use nano protos instead of lite protos * Addressing Android lint warnings r337 Removing unused ticl.ProtoWrapper class and moving example code r336 Android cache invalidation client release August 2014 Depends on https://codereview.chromium.org/532303003/ BUG=377891 Review URL: https://codereview.chromium.org/513293002 Cr-Commit-Position: refs/heads/master@{#293340}
-
zeeshanq authored
This change will make it so that a fake UserGestureIndicator is not set for every javascript execution request triggered by the browser. This was interfering with how the virtual keyboard handles programmatic focus() calls on load. This is part 2 of 3, depends on blink change: https://codereview.chromium.org/516753002 BUG=408426, 406336 Review URL: https://codereview.chromium.org/518583003 Cr-Commit-Position: refs/heads/master@{#293339}
-
thestig authored
Review URL: https://codereview.chromium.org/525513003 Cr-Commit-Position: refs/heads/master@{#293338}
-
Zach Kuznia authored
BUG=None R=achuith@chromium.org, zelidrag@chromium.org Review URL: https://codereview.chromium.org/539733002 Cr-Commit-Position: refs/heads/master@{#293337}
-
kkimlabs authored
In the new enhanced bookmark UI, Uncategorized items are bookmarks under mobile and others node. BUG=386785 Review URL: https://codereview.chromium.org/533363002 Cr-Commit-Position: refs/heads/master@{#293336}
-
qsr authored
R=blundell@chromium.org Review URL: https://codereview.chromium.org/539023002 Cr-Commit-Position: refs/heads/master@{#293335}
-
pgal.u-szeged authored
Removed tailing \ character from the example usage to make GCC to forget the multi-line comment warning. BUG=410777 TEST=build with gcc Review URL: https://codereview.chromium.org/534383003 Cr-Commit-Position: refs/heads/master@{#293334}
-
spang authored
Looks like there's fewer bitmaps than cursor types. On CrOS X11 we fallback to left pointer, so do the same here. BUG=410870 TEST=manual on link_freon NOTRY=true Review URL: https://codereview.chromium.org/540103002 Cr-Commit-Position: refs/heads/master@{#293333}
-
magjed authored
BUG=409636 Review URL: https://codereview.chromium.org/532533002 Cr-Commit-Position: refs/heads/master@{#293332}
-
stevenjb authored
BUG=279351 Review URL: https://codereview.chromium.org/540613002 Cr-Commit-Position: refs/heads/master@{#293331}
-
chrome://sync-internalsahest authored
BUG= Review URL: https://codereview.chromium.org/537893002 Cr-Commit-Position: refs/heads/master@{#293330}
-
machenbach authored
TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/545443002 Cr-Commit-Position: refs/heads/master@{#293329}
-
yoshiki authored
- Add null-checks - Return an empty mime/thumbnailUrl instead of error if request is succeeded (media_manager.js) - Make savedVolume_ consistent (media_controls.js) BUG=none TEST=manual Review URL: https://codereview.chromium.org/537863002 Cr-Commit-Position: refs/heads/master@{#293328}
-
iseki authored
BUG=360088 TEST=content_unittests passed Review URL: https://codereview.chromium.org/522543002 Cr-Commit-Position: refs/heads/master@{#293327}
-
jkarlin authored
Reland of https://codereview.chromium.org/477973002/ There was a memory leak. EndEnumeration wasn't called on the iterator. Fixed and tested with ASAN. The leak was detected because SimpleCache doesn't clean up its enumerators on deletion, but it should. See https://code.google.com/p/chromium/issues/detail?id=410276 BUG=392621 Review URL: https://codereview.chromium.org/528233003 Cr-Commit-Position: refs/heads/master@{#293326}
-
Andrew Scherkus authored
During development I noticed that the clips we were using contained audio, which would mean changes to audio-only code were impacting these benchmarks. This will cause our tests to use a new baseline, but that's OK. R=rileya@chromium.org Review URL: https://codereview.chromium.org/543703003 Cr-Commit-Position: refs/heads/master@{#293325}
-
reillyg authored
Add tests for interrupt and bulk USB transfers using a gadget device that echos packets back to the host. This change depends on the removal of the //content dependency in usb_service so that it no longer depends explicitly on BrowserThread::FILE for I/O operations. BUG= Review URL: https://codereview.chromium.org/516003002 Cr-Commit-Position: refs/heads/master@{#293324}
-
zty authored
R=friedman@chromium.org, navabi@chromium.org Review URL: https://codereview.chromium.org/521823003 Cr-Commit-Position: refs/heads/master@{#293323}
-
zmo authored
BUG=410560 TEST=about:gpu page R=piman@chromium.org,davemoore@chromium.org,sadrul@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/540643002 Cr-Commit-Position: refs/heads/master@{#293322}
-
cjhopman authored
These tests are deleting out/Debug when run. TBR=navabi NOTRY=true BUG=410936 Review URL: https://codereview.chromium.org/542803002 Cr-Commit-Position: refs/heads/master@{#293321}
-
Evan Stade authored
The intent of this patch is to create something small and harmless for merging to M38. The prompt will be reenabled as soon as the logic for showing it is updated. BUG=408695 R=erikchen@chromium.org Review URL: https://codereview.chromium.org/535243002 Cr-Commit-Position: refs/heads/master@{#293320}
-
jianli authored
This fixed the bug that signing out and then signing in again does not restart GCM. BUG=393043 TEST=new test added Review URL: https://codereview.chromium.org/535393002 Cr-Commit-Position: refs/heads/master@{#293319}
-
mtklein authored
Apparently it's fatal for GN to try to remove something that doesn't exist, but not for GYP... the GYP list is way out of date. SkTaskGroup{.cpp,.h} are not currently listed in utils.gypi, so there's no need to remove them. https://skia.googlesource.com/skia/+log/0c88d8233ba3a8baa9b4dd6ef515def6b3749980..a17aac8bd4c755c3a24befc7fd297969c0bb0861 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg Bots seem to be failing before and after this CL. NOTRY=true BUG= Review URL: https://codereview.chromium.org/537363002 Cr-Commit-Position: refs/heads/master@{#293318} -
Erik Arvidsson authored
Revert of Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/540023002/) Reason for revert: breaking all gpu bots see https://code.google.com/p/chromium/issues/detail?id=410885 Original issue's description: > Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/539713002/) > > Reason for revert: > Breaks telemetry_perf_unittests on Mac. > Likely culprit is http://src.chromium.org/viewvc/blink?revision=181336&view=revision > > ASSERTION FAILED: (HashTableKeyChecker<HashTranslator, KeyTraits, HashFunctions::safeToCompareToEmptyOrDeleted>::checkKey(key)) > ../../third_party/WebKit/Source/wtf/HashTable.h(645) : const ValueType *WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup(T) const [Key = blink::FontPlatformData, Value = WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, Extractor = WTF::KeyValuePairKeyExtractor, HashFunctions = blink::FontDataCacheKeyHash, Traits = WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, KeyTraits = blink::FontDataCacheKeyTraits, Allocator = WTF::DefaultAllocator, HashTranslator = WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, T = blink::FontPlatformData] > 1 0x5045c9b7 WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > const* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData) const > 2 0x5045c8fc WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData) > 3 0x5045fed9 WTF::HashTableIterator<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator> WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData const&) > 4 0x5045fe51 WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find(blink::FontPlatformData const&) > 5 0x504556e8 WTF::HashMap<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int>, blink::FontDataCacheKeyHash, blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::DefaultAllocator>::find(blink::FontPlatformData const&) > 6 0x50454b28 blink::FontDataCache::get(blink::FontPlatformData const*, blink::ShouldRetain) > 7 0x50446962 blink::FontCache::fontDataFromFontPlatformData(blink::FontPlatformData const*, blink::ShouldRetain) > 8 0x504467f1 blink::FontCache::getFontData(blink::FontDescription const&, WTF::AtomicString const&, bool, blink::ShouldRetain) > 9 0x5046298f blink::FontFallbackList::getFontData(blink::FontDescription const&, int&) const > 10 0x504620c9 blink::FontFallbackList::fontDataAt(blink::FontDescription const&, unsigned int) const > 11 0x50461d9d blink::FontFallbackList::determinePitch(blink::FontDescription const&) const > 12 0x4384da35 blink::FontFallbackList::isFixedPitch(blink::FontDescription const&) const > 13 0x4384d6b9 blink::Font::isFixedPitch() const > 14 0x43841394 blink::RenderText::widthFromCache(blink::Font const&, int, int, float, blink::TextDirection, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>*, blink::GlyphOverflow*) const > 15 0x4383c04d blink::RenderText::computePreferredLogicalWidths(float, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>&, blink::GlyphOverflow&) > 16 0x4383ad0c blink::RenderText::computePreferredLogicalWidths(float) > 17 0x4383a603 blink::RenderText::trimmedPrefWidths(float, float&, bool&, float&, bool&, bool&, bool&, float&, float&, float&, float&, bool&, blink::TextDirection) > 18 0x4365b7ab blink::RenderBlockFlow::computeInlinePreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) > 19 0x435f3d3c blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const > 20 0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths() > 21 0x4367488e blink::RenderBox::minPreferredLogicalWidth() const > 22 0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const > 23 0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const > 24 0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths() > 25 0x4367488e blink::RenderBox::minPreferredLogicalWidth() const > 26 0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const > 27 0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const > 28 0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths() > 29 0x438059b1 blink::RenderTableCell::computePreferredLogicalWidths() > 30 0x4367488e blink::RenderBox::minPreferredLogicalWidth() const > 31 0x435766c8 blink::AutoTableLayout::recalcColumn(unsigned int) > > Original issue's description: > > Blink roll 9d34a87:9a051c52 > > > > https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf > > TBR=tkent@chromium.org,arv@chromium.org > > > > Committed: https://chromium.googlesource.com/chromium/src/+/203622e5b22fd772320684b7f8a1aa1fa4afc25b > > TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://chromium.googlesource.com/chromium/src/+/3c503fbc25dc383874c83b1fc2c6a72fdfbf4bfc TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org,dslomov@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/544733002 Cr-Commit-Position: refs/heads/master@{#293317}
-
tonyg authored
Revert of [Telemetry] Re-enable page_cycler.typical_25 on windows. (patchset #1 id:1 of https://codereview.chromium.org/534313002/) Reason for revert: Still failing Original issue's description: > [Telemetry] Re-enable page_cycler.typical_25 on windows. > > The underlying issue has been fixed. > > BUG=273986 > TBR=andrewhayden@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/f6d8edcc3dd0fb90b43ffb2524eecdf8983a38cd TBR=andrewhayden@chromium.org NOTREECHECKS=true NOTRY=true BUG=273986 Review URL: https://codereview.chromium.org/537093003 Cr-Commit-Position: refs/heads/master@{#293316}
-
earthdok authored
BUG=410891 TEST=compile NOTRY=true TBR=pkasting@chromium.org Review URL: https://codereview.chromium.org/544703002 Cr-Commit-Position: refs/heads/master@{#293315}
-
jbauman authored
BUG= Review URL: https://codereview.chromium.org/539783002 Cr-Commit-Position: refs/heads/master@{#293314}
-
jbauman authored
This is needed for vsync message filtering and latencyinfo BUG= Review URL: https://codereview.chromium.org/511423002 Cr-Commit-Position: refs/heads/master@{#293313}
-
