- 12 Feb, 2020 40 commits
-
-
Rossana Monteriso authored
This CL adds the grid-gutters-and-alignment test to the WPT project, adapted from browser specific tests. The corresponding outdated test is being removed from the fast/css-grid-layout folder. Change-Id: I07acf8ad8ccdd7e2ec8b12e76899e2135b99e068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047031 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#740779}
-
Li Lin authored
Bug: 1050763 Test: unit tests Change-Id: Ib0b2f97ee7233789b4209cc3a72833a5c07ac5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048026Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740778}
-
Daniel Rubery authored
This CL makes two improvements to the CSD model management. First, it allows a customizable threshold in the ClientSideModel, rather than hard-coding 0.5. It also allows the user to run a custom model for testing with the command-line flag: --csd-model-override=/path/to/model Fixed: 1029975, 1030723 Change-Id: I0bd5814ca1c0ba615c292b4566b731629f70bd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040432 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#740777}
-
Kenichi Ishibashi authored
ServiceWorkerDatabase::RegistrationData will become a mojo struct. As a preparation, this CL changes the type of |used_features| from std::set to std::vector as the mojo IDL doesn't provide a set. Bug: 1046335 Change-Id: I6fdcb12e2930f3f74e8b2e4eeae9a52efc072a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040795 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740776}
-
Xing Liu authored
NotificationIntentInterceptorTest is used to be an instrumentation test that calls into real Android notification API to show notification in tray. This is super flaky due to unexpected behavior or bugs in Android code. Now we change this to junit tests with Robolectric shadows which is much more flexible than current instrumentation setup. Also improve the test coverage. Bug: 910870 Change-Id: Ifd759b57c82010349316f2b6a928ad67799348ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045142Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740775}
-
Manu Cornet authored
Change-Id: Iebcfc406962d222d2f652cc21774f60686813dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050000Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740774}
-
Vladislav Kuzkokov authored
Every other function in JSONReader already uses JSON_PARSE_RFC. Change-Id: I04f00f1df8c6e46626c0341721dbad8f965d8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052124 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#740773}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/33b1e31e7efa..92b00ca88263 git log 33b1e31e7efa..92b00ca88263 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 courtneygo@google.com Roll deqp to get some test fixes 2020-02-12 amaiorano@google.com Update comment to reflect changes in ea0dcd4bda188 Created with: gclient setdep -r src/third_party/angle@92b00ca88263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I69633a45ef771a68f789da023baefee8ab6d06fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740772}
-
James Vecore authored
Fixes warnings in network_proxy.js produced when this CL is patched in https://crrev.com/c/2006413 which does stricter type checking on mojom structs from colsure. Fixed: 1047848 Change-Id: If699e69a2df7f285aec848ba01c8d24dc4138462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049829Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#740771}
-
Yu Han authored
Previous to this CL, adding carriage returns to placeholder text either via attribute or through javascript don't display. This error happens for both string char "\r", unix code hex "
 and "\r\n" pairs. The spec, https://html.spec.whatwg.org/multipage/form-elements.html#attr-textarea-placeholder, "All U+000D CARRIAGE RETURN U+000A LINE FEED character pairs (CRLF) in the hint, as well as all other U+000D CARRIAGE RETURN (CR) and U+000A LINE FEED (LF) characters in the hint, must be treated as line breaks when rendering the hint." The problem is that carriage returns are treated as white spaces and they are removed when placeholder text are inserted into DOM as a text node. The fix to replace them with new line characters "\n". Bug: 791194 Change-Id: Ifc947048bc858ade91827cd49460a579fd11245e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051175Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740770}
-
Hidehiko Abe authored
So that we can control this feature by gn args. BUG=chromium:1043804 TEST=Build chrome. Change-Id: I1e405faf404cc7ae75d4a5af851cdcf1e2f7227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051790Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740769}
-
Rahul Arakeri authored
CL updates the default body of the constructor/destructor to "=default" Change-Id: I10a76e8825e594488a9f7dd96b3b302d743766d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049832Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740768}
-
Marc Treib authored
All invalidations clients have migrated to the new infrastructure, so the old implementation is now unused and can be cleaned up. This CL deletes *most* of the code. Still left to be done: - DeprecatedInvalidatorRegistrar is still used by some tests (via FakeInvalidationService), which should be migrated off. - InvalidationServiceAndroid and the corresponding Java code is still around. This reduces Android binary size by about 4kB: Normalized APK Size: -4184 bytes Bug: 1029481 Change-Id: Ic414f0b099eb5ad76bcded15a75e84299ba5f746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989750Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#740767}
-
Wez authored
Change-Id: Ide75f4dd1a30f343b6de33753e496e7ecba185a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051274 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#740766}
-
Nikita Podguzov authored
Deprecate the policy and remove all internal usages of it. Bug: 813107 Change-Id: I44134d5fedbbb53a92ed144b63f139979a24b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041755Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740765}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify enum histogram recording by changing the enum metric to be an enum class and defining kMaxValue where needed. Bug: 742517, 1047547 Change-Id: I8db8405076975992a02efb8a73e6a692e3678d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046534Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740764}
-
Alex Cooper authored
When the Permissions Prompt is dismissed due to navigation, the callback passed to it may not be run. Due to the fact that this callback owns the mojo RequestSessionCallback, that callback ends up getting dropped, and then DCHECKs since the associated pipe is still open. This change causes the SessionRequestData struct to attempt to run the callback when it is destroyed. Given that the exact reason for the callback being dropped is unknown, a new generic error type is also introduced. Bug: 1051228 Change-Id: Ib388c7c7a513759d373fed2af1a040adf9d3cd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050035Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#740763}
-
Oleh Lamzin authored
Change BatteryChargeMode default value from Standard to Adaptive. BUG=b:147869098 TEST=chromeos_unittests && ash_unittests Change-Id: I3163b5c16b54af23d5b3b29f2d779f97a07a0c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007410Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#740762}
-
Kristi Park authored
[Sheriff] Disable SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_SignatureExpire on Linux TSan Example flakes: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50958 https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50960 TBR=horo@chromium.org Bug: 1050879 Change-Id: I2f03a1d714d06759947ce54847c2ec78bfe1dd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052203Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740761}
-
Michael Spang authored
This removes libevdev and gestures from third_party. Nobody should be using these; they haven't been updated since being added 3 years ago. Having them is causing confusion as we actually use these libraries via sysroot (either Chrome SDK or Chrome OS chroot environment). We can add them back later if we need them, but they need some portability fixes before we can even do that (I tried rolling them first, but they don't even compile with our compiler). This reverts commit 968d2048. Bug: 888172 Change-Id: I297ce60796225e32e947ef9977c8c63207f0a2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048906 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740760}
-
Daniel Cheng authored
Change-Id: I7f751a0fbfc049636a110b1edf0f5515ec1f6108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048275 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740759}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e54f66edc586..378c0f1b0817 git log e54f66edc586..378c0f1b0817 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jacktfranklin@chromium.org [Unittests] Add tests to `StaticContentProvider` 2020-02-12 tvanderlippe@chromium.org Add test for showing document storage values 2020-02-12 szuend@chromium.org [utilities] Replace {valuesArray} with {values} and/or spread operator 2020-02-12 tvanderlippe@chromium.org Migrate protocol_monitor/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate resources/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate security/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Add test to verify multiple workers are shown as different entrypoints 2020-02-12 liviurau@chromium.org [doc] Updated branches handling Created with: gclient setdep -r src/third_party/devtools-frontend/src@378c0f1b0817 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1009443,chromium:1044632,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I259d7e39d7a2c72b516794f299b77348c9bb88a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740758}
-
Victor Costan authored
This CL adds a crbug component and team mailing list for the Storage Service. It also fixes the crbug component for //components/services. Bug: 994911 Change-Id: I8c3448ca350e7534aba02336c09ea4065925725d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051814 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#740757}
-
Aaron Leventhal authored
The property aria-goog-editable was really added for a single odd case in Google Slides, and isn't a great candidate for a new ARIA property. It exists to avoid double speaking in NVDA with the tree view used for Google Slides' thumbnail view. This issue goes away if the tree items are not considered editable (they really aren't), but there is no standard ARIA attribute to state that. The reason the tree items need to inside a contenteditable is because that enables pasting in slides to work. This also requires setting DOM selection on each tree item / thumb. The double speaking occurs because aria-activedescendant is also used to point to the currently active tree item. This is necessary in order to get more than just the selected text to be spoken -- to get the full tree item treatment. This CL removes aria-goog-editable, and instead clears IA2_STATE_EDITABLE in the odd situation where an editor has a subwidget like a tree item or list option, and the editor uses an active descendant. The requirement for an active descendant on the editor means that a subwidget can still be made editable in an HTML editor use case. Bug: 1049746 Change-Id: Icd67b825b49712ac3fda7ba57f7ba93b4cd99a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042282 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#740756}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7270d81dce8a..f440b92c2422 git log 7270d81dce8a..f440b92c2422 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 fmayer@google.com Fix query for unsymbolized frames. 2020-02-12 treehugger-gerrit@google.com Merge "profiling: put proto enums into namespace" 2020-02-12 fmayer@google.com Merge "Improve error message when llvm-symbolizer is missing." 2020-02-12 skyostil@google.com Increase timeout for PerfettoTest.VeryLargePackets 2020-02-12 treehugger-gerrit@google.com Merge "traced_perf: add to android build by default (initially disabled)" Created with: gclient setdep -r src/third_party/perfetto@f440b92c2422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0986ce588bdc4f87ab01d371d8249c4518e9a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740755}
-
Hongchan Choi authored
The repro case creates an AudioWorkletNode after the ExecutionContext goes away. (detached iframe) AudioWorkletNode is equipped with a MessageChannel which requires a valid ExecutionContext. AudioWorkletNode is not fully functional without message ports anyway, so we can throw an exception in this case. Test: Locally confirmed the ASAN build doesn't crash with the repro anymore. Bug: 1050419 Change-Id: I52af9f877e2ad31923c6380dc0732eb6c97ab407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051386Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740754}
-
Shimi Zhang authored
This reverts commit 9c078ea7. Reason for revert: The fix isn't memory efficient enough. Original change's description: > [Printing] Write file to file descriptor directly on Android > > Android's policy doesn't allow to exchange file ownership. It should be > caught by our test but we don't have up-to-date bots setup in Chromium > yet. > > Bug: 1050064 > Change-Id: I26c82e538817e68fd49f40c0c7c414c5a76078b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048271 > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740491} TBR=thestig@chromium.org,ctzsm@chromium.org Change-Id: Ie33bf740f4221072059e2cd82eedc53c1974286f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049836Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#740753}
-
Mark Yacoub authored
DrmOverlayValidatorTest calls MockDrmDevice::InitializeState one time in SetUp and another in the test itself when the default crtc state needs to change. MockDrmDevice::InitializeState creates a new HardwareDisplayPlaneManager every time it's initialized, which destructs all planes used by ScreenManager controllers. BUG=987274 TEST=DrmOverlayValidatorTest* Change-Id: I42ef144377fb3b304573becd9be1467ad1636af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051198Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#740752}
-
Rahul Arakeri authored
Enables a virtual test for mouse-interactions-dsf-2.html on Mac. Bug: 1009892 Change-Id: I0af1f4122fa1ef9519c21a01ec5f5e365558680b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048849Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740751}
-
Brandon Wylie authored
This reverts commit 786379ee. Reason for revert: Broke "generate_build_files" step for release builders. Original change's description: > [proguard] Include proguard info in sourcefile attribute. > > Instead of setting the sourcefile to PG when obfuscating Java, set it > to :chromium:{mapping file}:{channel}:{version code} so that > > a) We can recognise chrome/webview stack frames by this string > b) The information required to uniquely identify the proguard mapping > file in question is directly available in stack traces. > > Bug: 1044585 > Change-Id: Ib4fabccfb7693e5e97edc6f29be1cd6cb61fa1e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036091 > Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740625} TBR=torne@chromium.org,agrieve@chromium.org,tobiasjs@chromium.org,bialpio@chromium.org Change-Id: Iad5e489fbb13b1d9b89545bc648e94206e0c7c90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050022Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740750}
-
Rahul Arakeri authored
This CL prepares content_browsertests for when the feature is turned on by default. The fix here is make DoesScrollbarScrollOnMainThread rely on the base::Feature rather than just returning a hardcoded value. Bug: 1049814 Change-Id: I0055df6d1abcb31b928a7985dad7eecf7882ad7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042762Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740749}
-
Ahmed Fakhry authored
Switching users can lead to a display reconfiguration. We used reapply the current color temperature immediately on display config changes with disregard to the possibility of an on-going animation towards the same temperature. As a result the target value was incorrectly set in the middle of the animation, then the animation continues towards that target value, resulting in a blue flash. This CL fixes this issue. BUG=999395 TEST=Manually, switch users (one with NL on, and the other off) and see no blue flashes. Change-Id: Ib41dadcd3e45defbc5b09f32d1a8c0c2aa49e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051525Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740748}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/7d8b92dfc7b5..6b138fb083cf git log 7d8b92dfc7b5..6b138fb083cf --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jophba@chromium.org Fix linux-rel bot in Chromium autoroller 2020-02-12 miu@chromium.org Reland "Cast Streaming Sender: Introduce SenderPacketRouter." 2020-02-12 jophba@chromium.org Add IP address argument to standalone receiver 2020-02-12 jophba@chromium.org Cleanup ffmpeg, libsdl2 deps scripts 2020-02-11 btolsch@chromium.org Move WeakPtr to util/ 2020-02-10 rwkeane@google.com Discovery E2E Test 2020-02-10 rwkeane@google.com mDNS: Address Top-Level Threading Concerns 2020-02-10 mfoltz@chromium.org Revert "Cast Streaming Sender: Introduce SenderPacketRouter." 2020-02-08 miu@chromium.org Cast Streaming Sender: Introduce SenderPacketRouter. 2020-02-07 mfoltz@chromium.org [Open Screen] Allow PlatformClientPosix to take a TaskRunner. Created with: gclient setdep -r src/third_party/openscreen/src@6b138fb083cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia89bb09d41636400b3df8c2aecc9c8c1caebbd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740747}
-
Mohammad Refaat authored
while at it i removed tabModel mentions from perf_test_with_bvc_ios Also i deleted tests from tab_model_unittest that are sessions related and moved the one related to NTP to session_restoration_agent_unittest, however it's disabled as it needs to be converted to eg test. Bug: 1050110, 1045226, 1049843 Change-Id: I84e137efa14258bed002094ad87dd0db6ca7ea74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045759Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#740746}
-
Etienne Bergeron authored
Adding trace events for the database functions. SQLite is suspected to have higher impact on IO than previously expected. We are suspecting LockFile contention and Flush contention. Adding these trace events will help seeing the interaction between these tasks and other tasks in chrome via slow-reports. Bug: 1051180 Change-Id: Ife21c619bd8fafc6e892d6e9d45818d0813018c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050167 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740745}
-
En-Shuo Hsu authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/0024e74067a1..b2cdc6cc701d $ git log 0024e7406..b2cdc6cc7 --date=short --no-merges --format='%ad %ae %s' 2020-02-05 kevinptt runtime_probe: Add network-related fields in protos 2019-12-18 cylai system_api: remove SetSystemSalt from attestation 2020-01-14 dverkamp system_api: vm_concierge: add ResizeDiskImage method 2020-01-16 andrewlassalle dlcservice: Move the definition of kDlcMetadataRootpath 2020-02-06 enshuo system_api: Add CRAS battery changed constants 2020-01-07 garrick system_api: Add plugin vm messages for patchpanel. 2020-02-05 dtor system_api: vm_concierge: add option to generate digest when exporting a VM Created with: roll-dep src/third_party/cros_system_api Bug: chromium:785758,b:140783217 Change-Id: I7ce344da4b20102ce809439b4e6c7d50d4fde265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051791 Auto-Submit: En-Shuo Hsu <enshuo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#740744}
-
Kevin Schoedel authored
Previously, an element could be removed from the current_render_widget_set_ while still observing it, which would cause a crash after the WebContentController was destroyed. Bug: b/149197915 Change-Id: I830c5caba702ce2d9e94a33c669cf05cb2d354a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050009 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#740743}
-
Eric Orth authored
This reverts commit d22ad89d. Reason for revert: Crashes in SetProbeSuccess() Original change's description: > Track DoH probe results per-context > > DoH probes are now run for every created NetworkContext. > > Swap to using per-context DoH probe results stored in the > ResolveContext and delete old probe result tracking in DnsSession. Some > interfacing back to DnsSession where we're still storing non-probe > failure tracking and ServerStats, but that will be moving over to > ResolveContext too in a subsequent CL. > > Bug: 1022059 > Change-Id: Ib2db72340f9fc5dd5b0ec0024f1cef60f1ba7465 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001144 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740422} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: Icb3267ae7e433d2609898032c21ed9f6398a96a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022059,1051399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050749 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#740742}
-
Henrique Nakashima authored
Introduce key overrides for existing cached values in SharedPrefs so the behavior does not change. These overrides can be removed when all variations using it are removed. Bug: 1012975 Change-Id: Ie392f3bb830a082dbb2a736efad3fa492653e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044921 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#740741}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/125d3820d6b5..55b137ca7dd9 git log 125d3820d6b5..55b137ca7dd9 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jvanverth@google.com More tweaks to iOS build instructions. 2020-02-12 egdaniel@google.com Update generated effects to use views. 2020-02-12 herb@google.com Simplify SkStrike ctor 2020-02-12 nihohit@gmail.com This change allows users of PropertyObserver to compose a full keypath for each of the modified properties. Created with: gclient setdep -r src/third_party/skia@55b137ca7dd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I4b8c178e107d58f184040543655b6e4a1698e334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740740}
-