- 02 May, 2018 40 commits
-
-
Michael Lippautz authored
Includes incremental garbage collection infrastructure in regular builds. Does not enable incremental marking at runtime! This CL may cause throughput regressions and is an attempt to collect a broad range of potential performance issues. Bug: chromium:757440 Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed Reviewed-on: https://chromium-review.googlesource.com/980753 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555449}
-
Koji Ishii authored
Following bot results are included. 5 lines were removed and 5 lines were deflaked by consecutive results since 5098. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I210dc6127b151a14d93308981c19336de6981477 Reviewed-on: https://chromium-review.googlesource.com/1040065 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555448}
-
Patrick Monette authored
Change-Id: I72ae36f24a7930b70ac9fa098f5cf1b20cb5d9bb Reviewed-on: https://chromium-review.googlesource.com/986981 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555447}
-
Dave Tapuska authored
Replace OnScreenKeyboardDisplayManager on Windows with the InputMethodKeyboardController class. Do this so that there is no longer a singleton but InputMethodKeyboardControllers are associated with the InputMethodWinBase object. This is needed for a later change that uses InputPane which listens to changes to the associated window handle. Using a singleton causes a bunch of confusion with classes that need to be associated with a HWND. BUG=817501 Change-Id: I4fe8471c5eb84aa707136477c83b07cbf1acf7bb Reviewed-on: https://chromium-review.googlesource.com/978841 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555446}
-
Evan Stade authored
This allows chrome/ to use those utilities on the proto returned by PowerManagerClient. BUG=756095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3a7f3143ec82ea871ca70dd8fe6d7270c00d9f0 Reviewed-on: https://chromium-review.googlesource.com/1013271Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555445}
-
Sergey Poromov authored
While the original domain name remains unchanged after domain rename, the new name is provided as "displayDomain" and should be shown in UI. BUG=b/67784447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e083f31ca2492fd6c32d401a024e4da4b54794e Reviewed-on: https://chromium-review.googlesource.com/1038503 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555444}
-
Ran Ji authored
Reland "Load resources.pak earlier in service manager main" This is a reland of 13dfb327 Original change's description: > Load resources.pak earlier in service manager main > > We need to use the content in resources.pak in service manager, but at > that time resource bundle has not been initialized. Create data pack to > load resources.pak and append the data pack to resource bundle during the > initialization. > > Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. > > Bug: 729596, 815230 > Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 > Reviewed-on: https://chromium-review.googlesource.com/962679 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Ran Ji <ranj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554500} Bug: 729596, 815230 Change-Id: Id963d1e64c70a22a29e94d8186ea0d4bcb1455fd TBR=sky@chromium.org, yfriedman@chromium.org, rockot@chromium.org Change-Id: Id963d1e64c70a22a29e94d8186ea0d4bcb1455fd Reviewed-on: https://chromium-review.googlesource.com/1034133 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555443}
-
https://chromium.googlesource.com/angle/angle.git/+log/9aef81c7cec0..d8ffd75616c1 $ git log 9aef81c7c..d8ffd7561 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 cwallez SystemInfo.h: add some documentation Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6ea4b68bbc3246d09a577d854109f53dbe617241 Reviewed-on: https://chromium-review.googlesource.com/1039771 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555442}
-
Christopher Grant authored
Also, tweak the overall width to match the current spec. BUG=838939 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4727da0c669b6b59add3ce96e3b0b1276c4050e6 Reviewed-on: https://chromium-review.googlesource.com/1039873Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#555441}
-
Sergey Volk authored
Bug: b/78193551 Test: played some videos and checked video stream resolution Change-Id: I79f7400675f91a424e7bf9b449f5acb10bf41e8b Reviewed-on: https://chromium-review.googlesource.com/1036731 Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555440}
-
Saman Sami authored
Currently we only use video capture API for screencasting when VizDisplayCompositor is enabled. Also use video capture API when UseVideoCaptureApiForDevToolsSnapshots is enabled. Bug: 813929 Change-Id: Ia3018eed1eda785a260227f89024d20b13da1a97 Reviewed-on: https://chromium-review.googlesource.com/1035616Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#555439}
-
Ken Rockot authored
Explicitly reference README.md in links to other docs. Without this, the destination page includes a directory index preceding the actual README.md contents which can be confusing especially for directories with lots of files. TBR=dcheng@chromium.org TBR=jcivelli@chromium.org Bug: None Change-Id: I81222dde7fe60d4af53abb7c720cd451f02f0c60 Reviewed-on: https://chromium-review.googlesource.com/1040108 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555438}
-
John Budorick authored
Bug: 731426,826895 Change-Id: Ice68f17dae6cb0bacc923fc1a5c2d3dd130584d5 Reviewed-on: https://chromium-review.googlesource.com/1038807Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555437}
-
Fady Samuel authored
The renderer has an existing mechanism for repaint: ViewMsg_Repaint that is separate from ViewMsg_SynchronizeVisualProperties and needlessly complicates code. This CL uses browser-side LocalSurfaceId allocation to repaint. LocalSurfaceId allocation triggers a commit and draw now even if the LocalSurfaceId itself does not get used by cc (because surface synchronization is off): https://chromium-review.googlesource.com/c/chromium/src/+/1028727 In a subsequent CL, the old repaint code path will be deleted. Change-Id: I73cbc2f537974ad51a353ac86f33ef691fc99c4f Bug: 672962 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1037911 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#555436}
-
Varun Khaneja authored
global.cpp was removed in crrev.com/c/984113 because it uses `pragma hdrstop`. This CL removes that directive when building Chromium. Bug: 750327 Change-Id: I8d6af052bc6c9a9c10a6b824fd499b548c7714a6 Reviewed-on: https://chromium-review.googlesource.com/1037917Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555435}
-
Mounir Lamouri authored
Fixes the crash. Original change's description: > Media Controls: remove window event listener and listen to event on popup. > > This is moving the logic to hide the popups to the popup element class. > It will hide when the popup no longer has focus, when the window is > resized or scrolled. It slightly improves memory usage by only creating > the event listener object on demand. > > Bug: 833461 > Change-Id: I979f0882108fcd89fdf84b2612437209b080eb95 > Reviewed-on: https://chromium-review.googlesource.com/1023345 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555083} TBR=mlamouri@chromium.org Change-Id: Id5fa81b6370dcb49d6ae7b0c958e07a4e0c23a4a Reviewed-on: https://chromium-review.googlesource.com/1039587 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#555434}
-
Egor Pasko authored
Bug: 760498 Change-Id: I937c5a123bbd4d3d5844f9e2916fd0a7dcfd1e81 Reviewed-on: https://chromium-review.googlesource.com/1039590Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555433}
-
Artur Khachatryan authored
Enabling tests for Android Chromium build bot on Waterfall. The following tests from ChromeDriverTest class are enabled: testTouchDoubleTapElement, testTouchLongPressElement, testTouchSingleTapElement, These tests were failing for older Chrome browsers running on Android devices and in the most recent builds tests are passing, so we are enabling these tests. Bug: chromedriver:2388 Change-Id: I270cca8631f97ad7820b1f416578ccc8656562f1 Reviewed-on: https://chromium-review.googlesource.com/1022510 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555432}
-
yoshiki iguchi authored
This crash is caused because it refers the control buttons view which may be null. This CL adds a null-check. Also this refactors related code with IsCloseButtonFocused and RequestFocusOnCloseButton. These methods do same thing among child classes so that no need to be virtaul. Bug: 836523 Test: none Change-Id: I2f10d77b0772cc3bca51048473352daed5317589 Reviewed-on: https://chromium-review.googlesource.com/1037064Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555431}
-
Biao She authored
Bug: 837647 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb Reviewed-on: https://chromium-review.googlesource.com/1035208 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555430}
-
Pavel Feldman authored
Change-Id: I193440a6de9252e239d91a1028e02be141d5f32b Reviewed-on: https://chromium-review.googlesource.com/1038690 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555429}
-
spqchan authored
The button actions container logic was recently refactored so that the padding is now baked inside the extension icon view bounds: https://chromium-review.googlesource.com/c/chromium/src/+/961722 This caused the extension icons to be chopped because it conflicts with the existing code that sets the vertical padding and height in the browser action container. This causes icon to have an incorrect y offset. This CL fixes the issue by removing the browser action container's padding logic, since that is now done by the extension icon view. Bug: 825157 Change-Id: I43a4ca55fba1af0aba9ead7279a74819ba04f0d9 Reviewed-on: https://chromium-review.googlesource.com/1037764Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555428}
-
Qiang Xu authored
changes: This CL makes ArcAppContextMenu showing Android app shortcuts in app list context menu. TODO list: - Add ArcLauncherContextMenu integration for shelf item. - Add LaunchAppShortcut support. - Add UMA for measuring query & decode time. - Add context menu metrics. - UI adjustments when specs come. video demo: go/appshortcuts-demo-1 Bug: 803291 Test: device test with android side change Change-Id: I30f06d609eebc91c8d493af5bdb64360cdde002a Reviewed-on: https://chromium-review.googlesource.com/1029412 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555427}
-
Adithya Srinivasan authored
Bug: 781655 Change-Id: Ic009ba42a61d3e419d6e4ac449bc6656fdf37321 Reviewed-on: https://chromium-review.googlesource.com/1015785Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#555426}
-
Bernhard Bauer authored
Bug: 829323 Change-Id: I65a6b2631f10a72e2fcb3b4ebe420237a54590d2 Reviewed-on: https://chromium-review.googlesource.com/1039806Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555425}
-
Max Moroz authored
Bug: 834781 Change-Id: I6b21d7313c22e02e0454b36f2977ec11c1f8cfe0 Reviewed-on: https://chromium-review.googlesource.com/1038149 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555424}
-
Rayan Kanso authored
Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/ TBR=avi@chromium.org Bug: 826257 Change-Id: If883c9380a79cad8922ef3a21f2daa4cc73778a6 Reviewed-on: https://chromium-review.googlesource.com/1021516 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555423}
-
danakj authored
gfx::Transform is the ultimate type we want to use for cc, so avoid the intermediate conversions thru WebLayer APIs. R=jbroman@chromium.org, pdr@chromium.org Bug: 838693, 738465 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4774a4ccc8d5cab11712433a6f0933f1dd3719a9 Reviewed-on: https://chromium-review.googlesource.com/1038604 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555422}
-
Xida Chen authored
Currently we return a bool in TouchActionFilter::FilterGestureEvent, this CL change the return value to an enum. This is aimed to improve readability, and to prepare for later changes of unblocking a gesture event when it hits main thread touch action region. This CL contains mechanical changes only, there is no behavior change introduced. Bug: 772130 Change-Id: I72b3c5e1047c22923db2e1dcf58f684ab07aa343 Reviewed-on: https://chromium-review.googlesource.com/1039246Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555421}
-
Scott Violet authored
This way code can call content::BindInterfaceInGpuProcess() and have it correctly wire up DiscardableSharedMemoryManager. BUG=837689 TEST=none Change-Id: I93b1b5fb07bb0b1f0f38ebed03ca8d47c15d1b0d Reviewed-on: https://chromium-review.googlesource.com/1033961Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555420}
-
John Chen authored
Some page load timeout tests are currently flaky on Mac. Adding some debugging output to help diagnose this issue. Bug: chromedriver:2407 Change-Id: Ic16074e77e2b100ea3f9d104bf9eef4599f78b6b Reviewed-on: https://chromium-review.googlesource.com/1036592Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555419}
-
Andreas Haas authored
At the moment, the isolate is allocated and initialized in a single step. This has the downside that the platform cannot register the isolate before the isolate gets initialized, and therefore the platform is not available for the isolate during initialization. With this CL we register the uninitialized isolate on the platform and initialize the isolate after that. This change is needed to allow the creation of task runners already during the initialization of the isolate. The related V8 CL: https://crrev.com/c/1014044 R=yangguo@chromium.org Change-Id: I7a18d1e91f53d728b40a68152e3a3dcb84cf34bb Reviewed-on: https://chromium-review.googlesource.com/1015020Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#555418}
-
Joe Downing authored
This change adds some checks to the keyboard lock API to ensure it was called from within a supported context, otherwise it now rejects the promise. BUG=680809 Change-Id: I3d127422c640d16e43c22adb14755b65eb2cdc6a Reviewed-on: https://chromium-review.googlesource.com/1038888Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#555417}
-
Jennifer Apacible authored
There are two instances where PictureInPictureWindowController is torn down: 1. Tab is closed (controller is tied to the tab's WebContents). In this case, the player is also deleted, so there are no behavioral concerns. 2. A video on a different tab enters Picture-in-Picture mode. In this case, the player from the earlier PiP'd tab may still be playing in that tab, meaning there may be two(+) videos playing. This change would pause the initial video, as the user has indicated they want to PiP a new video. This behavior will be up for further discussion with UX. BUG: 823172 Change-Id: I3e1a58f496f5814a4a8aae40df3de23cd0ee6702 Reviewed-on: https://chromium-review.googlesource.com/1038303Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#555416}
-
Jennifer Apacible authored
Currently, the PictureInPictureWindowController is reset and torn down whenever a new video goes into Picture-in-Picture mode. This is less than ideal since the PictureInPictureWindowController is attached and scoped to the lifetime of a WebContents via WebContentsUserData. Rather, we should allow the natural teardown of the controller when the initiator tabs is destroyed. BUG: 823172 Change-Id: I7e13b8bf45899fd4ff4b3dbd34781d04ab15dc1d Reviewed-on: https://chromium-review.googlesource.com/1034194 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555415}
-
Matthew Cary authored
Removes the mNeedsReload flag in Tab.java which was just a thin and partial wrapper around the navigation controller's needs_reload mechanism. This duplication caused at least one race condition (crbug.com/828400) and will also complicate future LifecycleManager work. All of the checking in Tab.java of mNeedsReload was duplicated by the navigation controller's needs_reload flag, as used in NavigationControllerImpl::LoadIfNecessary. Bug: 829381 Change-Id: Id17c9d9f89088c718ae4a927ea5b8dbe95126e68 Reviewed-on: https://chromium-review.googlesource.com/1006958Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#555414}
-
David Reveman authored
Updated spec for system top bar doesn't have this separator. Bug: 838649 Test: Manual Change-Id: I3ef1b914e2ac830978311bf5a446a8a4888232bd Reviewed-on: https://chromium-review.googlesource.com/1039946Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555413}
-
Philip Jägenstedt authored
Only test was removed in https://github.com/w3c/web-platform-tests/pull/9967. No-Try: true Change-Id: I9cb46906d621d25261476f5de414622f694d4173 Reviewed-on: https://chromium-review.googlesource.com/1039191Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#555412}
-
Tom Anderson authored
Also update base::Bind to base::BindRepeating. Background: I tried using the template form of Start() on a base::MockTimer and was confused because it wasn't working. This was because Timer::Start() was getting called instead of MockTimer::Start. BUG=None R=thestig Change-Id: I15341804f364c9d5fd1f590c5e6d02db1728614c Reviewed-on: https://chromium-review.googlesource.com/1038815Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555411}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dd3fcf9f3eb0..5d4cebe797eb $ git log dd3fcf9f3..5d4cebe79 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 levarum Restore copying cheets_x86_userdebug artifacts Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9aff48d163a37863611212199a05387b30d734d9 Reviewed-on: https://chromium-review.googlesource.com/1039765 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555410}
-