- 14 Jul, 2020 40 commits
-
-
Muyao Xu authored
Bug: 687380, b/154273698 Change-Id: I0b143744da0581abd82251ef001ae02da5d250b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280389 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#788361}
-
Robert Ogden authored
The connect-timing UMA isn't being populated, this is why. Bug: 1105219 Change-Id: Ie59f81dd899e8ec5253b8885397dd6a15a351154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298165Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#788360}
-
Tom Anderson authored
* Remove usage of Xlib from //ui/ozone. Also replace Xlib types with XProto types in function signatures that are used in //ui/ozone. * Rewrite and simplify software non-SHM codepath for drawing images. * Moved PutARGBImage from x11_types.h into x11_util.h and renamed to DrawPixmap since it now takes an SkPixmap. * xcbproto: replaced BYTE with void in PutImage/GetImage so that base::RefCountedMemory can be used. * Got rid of x11_util_internal.h and moved it into x11_util.h. It was originally added to prevent including Xlib.h in x11_util.h, which caused conflicts due to macros, however this no longer appears to be an issue. BUG=1066670 R=nickdiego Change-Id: Ieff52b3748945fbb6a5a42bbd496550ad7862e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285287 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#788359}
-
James Long authored
Vue SFCs (Single File Components) offer many benefits (see website: https://vuejs.org/v2/guide/single-file-components.html). This highly mechanical CL migrates the current Vue components to SFCs by taking the following steps: For each file in src/vue_components: * Rename the file to .vue. * Move the `template` field into a <template/> tag. * Move the imports to the top of a <script/> tag. * Assign the rest of the component to a const in the <script/> tag. * `export default` the previous const at the end of the <script/> tag. Caveat: Sometimes ${} notation was used to insert constants into the template literals. This cannot be done in the <template/> tags, so constants are redeclared as a computed property of the component. For each of the .css files: * If the selector is for part of a component, move it into a scoped <style/> tag in that component. * If the selector is part of a component, but affects a child of that component (eg. autocomplete or d3's auto-generated svg elements), move it into a non-scoped <style/> tag in that component. Bug: 1093962 Change-Id: Id4b6307109cb06bbe195e7ac5668b08782cd487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293180 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#788358}
-
Emily Stark authored
This CL removes the "edit bump" for simplified domain field trials. The edit bump is the tendency of the selection or cursor to move around once you start editing and the URL unelides. We can avoid this in the simplified domain field trials by uneliding to the full URL on hover. This means that most of the time, by the time the user has made a selection, the URL has already been unelided and there is no jump. (Technically it is still possible for the user to select before the animation has finished, resulting in a bump, but the user would have to be rather speedy to do this.) This is implemented by pushing the elision logic from LocationBarModelImpl into OmniboxViewViews (when the field trials are enabled, to avoid introducing any bugs in Chrome's default state). OmniboxViewViews now has the full unelided URL as its display URL, which is what it unelides to on hover. When computing what to elide to, it strips the www subdomain from the host and elides to the result (or to the registrable domain if configured). There is more work to do after this CL for when reveal-on-interaction is enabled. Currently, with this CL and with that flag enabled, we'll unelide and show the full URL on page load (eliding to the simplified domain after interaction). This is a bit of a regression on simplicity/UX; the desired behavior instead is to show the URL with scheme+trivial subdomains elided on page load, and then expand to the full unelided URL if there is a hover before interaction. I'll implement this in a follow-up CL. Bug: 1101486 Change-Id: If7fb9c0418099acdf6016e44171f8a0b3d613a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289218 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788357}
-
Reilly Grant authored
This change cleans up all the calls to base::Bind() so that they are either base::BindOnce() or base::BindRepeating(). It also catches a few cases where base::BindRepeating() was used when base::BindOnce() would have worked. Bug: 834319 Change-Id: I8d63b425633feed42fdcb2267e2495fede6bb84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298119 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788356}
-
Moe Ahmadi authored
Adds a timing histogram in LocalHistoryZeroSuggestProvider to record the time it takes to query normalized search terms from the keyword search term database and sort them. This is added to identify potential performance regressions for the larger age thresholds for local history zero-suggest. Bug: 1096615 Change-Id: Iaa079cc84a496e1eeeab8138a7d5208118e99bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296344Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788355}
-
Garrett Beaty authored
mac-osxbeta-rel was removed from the branches because it is an FYI builder that is not the mirror of any try builders and is red on the branches so it is a distraction for sheriffs. Removing it from the branches causes 'Mac Builder' to fail on the branches when attempting to trigger it. The no-op scheduler job will allow the trigger to succeed. Bug: 1105569 Change-Id: I219a89c559b06106b75921ba678d2ab9eb69ea06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298168 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#788354}
-
Nico Weber authored
Bug: 1105559 Change-Id: Id5f55eb63b83212ceac0dfbd61c22f42a6ee3d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298181 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#788353}
-
Roger Tawa authored
Bug: 1088131 Change-Id: Ib27159284cdacbd83ff5e240905fd0a94d7a9705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296825Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#788352}
-
Katie D authored
AX-Relnotes: N/A Bug: 1103753 Change-Id: Id84fc1d2166f8c451639dc529ad7df6852cc91af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293000 Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#788351}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68978076fdb7..fad2090a5e81 2020-07-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ied36addf615dd1444752039cbbaef4ea77fe87c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788350}
-
Dominique Fauteux-Chapleau authored
Bug: 1068786 Change-Id: I464ecae57cd2e2922bd5e1176e0cea10db4c109c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295999Reviewed-by:
-
Rakib M. Hasan authored
This command line argument will be used to put the wpt_update_expectations.py script into Android mode without having to use the --android-product command line argument. Bug: 1102480 Change-Id: Ia95f7057ee370c03bfc694c1b1e405d891960582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293013Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#788348}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d25eebad303d185dde76679412d2b9a8ddfaea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296896Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:889460,v8:10442 Change-Id: I76c38ecc99e237e72b2be46907e0d4bbeed926ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297960 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#788346}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91280009..8db0c721 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8466561625c25bf93357cf3b1881124092df392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298100Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788345}
-
Joel Hockey authored
Fix code to invoke the CrostiniSuccessCallback if there is an error in OnCrostiniRestarted, or if we show the upgrade dialog. In order to handle the callback for the error case and also call LaunchApplication, the code for OnCrostiniRestarted needed to inline into LaunchCrostiniAppImpl. Removed redundant display_scaled param. Bug: 1092657 Change-Id: Id4928ee5e903b1c2297d6b33c4820516644ed0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294938 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#788344}
-
Mary Ruthven authored
This change adds the version strings for 0.5.4, 0.5.5, 0.6.2, 0.6.3, 0.6.4, and 0.6.5. tpm_hash_gen.py was used to generate version strings for all images. It also updates the 0.3.26 and 0.4.26 descriptions to reflect that we rereleased signed with 0.5.0 and 0.6.0. BUG=chromium:728134 TEST=None Change-Id: I7e102ab36f157c64f74b717b7de398aa82a73a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298025Reviewed-by:
-
James Long authored
A webpack config has been added, allowing us to serve the project locally for development and also build it for distribution. CDN-based dependencies have been removed in favor of using Webpack to bundle local ones from NPM. Bug: 1093962 Change-Id: I5a802449ff1d497c72417fb77b8c502e8af0a419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293214 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
-
Sami Kyostila authored
This reverts commit 0daa7a58. Reason for revert: Made angle_perftests start failing: crbug.com/1105609 Original change's description: > Roll ANGLE from e5c184751160 to d98afb787a24 (2 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/e5c184751160..d98afb787a24 > > 2020-07-13 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension > 2020-07-13 enga@chromium.org Revert "Refactor DisplayGbm::generateConfigs" > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC jonahr@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: chromium:1105208 > Tbr: jonahr@google.com > Change-Id: Ica3ea9561d8d0c52a252a34f26f8d832165aab18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296188 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#788041} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,jonahr@google.com Change-Id: I05a963371e856b93b49e75846e43b9671cb88add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1105208 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297963Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#788341}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594749428-a9bf8891c97f732f274a0fa0ac7b0886b75624ed.profdata to chrome-mac-master-1594752201-0c95582c1872e1e49765b4de426f33851485714b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifc6cea1792b49163e45bcce28ef13d96e1ee679d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298033Reviewed-by:
-
Sebastien Marchand authored
This synthetic Finch trial will allow measuring the impact that the segment heap has on performance. Bug: 1014701 Change-Id: I614f4b94fc11e43878d0d2f16af018490fc170f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283241 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#788339}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cd0af6456eb1..2490b1ae774d 2020-07-14 capn@google.com Undefine Bool after the headers that define them If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I444eb6b3558a4b6ece8f265acaffb1e4f87d4366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298062Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ec6dea4ea19..dcda36de8344 2020-07-14 brgoddar@microsoft.com Grid Testing: Update Elements Test Runner for new Grid Overlay Testing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I349cd802695b8ffd309f4146ec2e1458c56de628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297733Reviewed-by:
-
Dave Tapuska authored
Guidance is to use the mojo enum types directly. We don't have to triply define this enumeration. BUG=1097816 Change-Id: Icb70b2981cefd15c23eedb1fe4611b0a2f44f75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295679Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#788336}
-
Alex Chau authored
- All nearby code are now under chrome/services/sharing/nearby Change-Id: Ibbf5102f20b86fd12d8f5da25dd071b584fe73c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297645 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#788335}
-
James Long authored
To make Webpack setup easier, the source code has all been moved into a src/ directory. This allows us to serve, for example, a generated `package_view.html` on localhost without conflicting with the existing file with that name. Bug: 1093962 Change-Id: I27c421c490f14fa92c7e872cd239f2ff1eb45a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292829Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#788334}
-
Peter Kasting authored
This allows passing fewer args and scoping the functionality next to the code referencing it, slightly simplifying things. Bug: none Change-Id: I0363ebe41e70a973b6f848543cbaff019aec57f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296619 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788333}
-
Zhongyi Shi authored
Bug: 1027274, 1027279 Change-Id: Iffd7d3293d792162781e43c5b9c6aedbcb976378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298219 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#788332}
-
Mitsuru Oshima authored
Bug: b/160268599 Test: covered by unittests Change-Id: I9707810914c1b62a11cd79056d537a4f94cf8b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297748 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#788331}
-
Sorin Jianu authored
The code crashes because there is a race condition between the main sequence and another task runner when the instances of the CrxDownloader are destroyed. On the main sequence, the CrxDownloader is being used to download a file, then the reference to this instance is released. The CrxDownloader is using a task runner to run a blocking task, which validate the file it has just downloaded. This task runner receives a closure which holds a reference to the CrxDownloader. The reference is released after the task is run, and therefore, it results in a race when the dtor of CrxDownloader is being invoked. Besides removing the offending sequence checkers of the destructors of the CrxDownloader classes, this CL changes where the timer of the BackgroundDownloader is destroyed. The timer has sequence affinity and it must always be destroyed on the main sequence. Bug: 1105289,1105460 Change-Id: I78e002502ce6f5501c78d1e849f51b47bf3dc092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297696Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788330}
-
Trent Begin authored
The first pass at these descriptions were very simple and caused confusion during translation. Update the descriptions so they can be more easily translated in the future. Skipping the translation screenshots since these strings have already been translated and this change simply updates the descriptions for the future. Bug: chromium:1098405 Skip-Translation-Screenshots-Check: True Change-Id: I3e575b5ad93655f7a978f6f325cae0db7748c93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288360 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788329}
-
Adlai Holler authored
This is part of the larger effort to de-power GPU SkImages and require users to specify the context they want to use when performing operations on them. See bug for details. Bug: skia:10466 Change-Id: Iad7fc3714f8530f0199dd96f17371dbbda65c249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296632 Commit-Queue: Adlai Holler <adlai@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#788328}
-
Jeff Yoon authored
* recipe has already migrated to --sparse usage for code coverage. pgo defaults to it off * unit tests have been updated to run with default behaviour --sparse off. unit test ensures that --sparse set will indeed set sparse variable to true. Bug: 1077304,1105545 Change-Id: Id95b7a1730f80add0df27a5328fe48b1ac3f98f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296891Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#788327}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: Ib626345158bb56cf95c9e1972796772d349660e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293421Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#788326}
-
Aya ElAttar authored
1. Added ClipboardDataEndpoint to represent both; the source of the data, and the destination (trying to access the data). 2. Added ClipboardDataEndpoint to be a member of ClipboardData. 3. Changed ClipboardScopedWriter to set the source of the data if available. 4. Changed ClipboardHostImpl to set the data source inside ClipboardScopedWriter. Bug: 1096451, 1096571, 1096453 Change-Id: I077898439bfd85ceff354782c9d68e37323b0610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250067 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788325}
-
David Bokan authored
These methods in screen_mac have come up in at least one stack trace captured from slow reports. Add TRACE_EVENT calls so that we can see this even if stack traces aren't able to be symbolized. Bug: 1039833 Change-Id: I1ebfa077a5a360f3596e79229c0597fde58b0448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297705Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#788324}
-
David Black authored
Default mode: http://shortn/_hj9BYfnLUH EDU mode: http://shortn/_N00fMwVfWD Bug: b:2289074 Change-Id: I0c8a052c4ff2e3f25b74ba6d84081c488350be28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290952Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#788323}
-
Albert J. Wong authored
Bug: 1083392 Change-Id: I3fb0fdd5d54e069d4f4e7bd1bf2b8fdc96cc3302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295690Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#788322}
-
