GitLab

The communications path for creating a viewable command buffer used to be directly from the renderer (gpu_channel.cc) to the gpu process (gpu_channel.cc).  This patch makes the browser an intermediary:

- renderer (gpu_channel.cc) makes a synchronous request to the browser (picked up in renderer_message_filter.cc and forwarded to gpu_process_host.cc)

- browser (gpu_process_host.cc) makes an asynchronous request to the gpu process (picked up in gpu_thread.cc and forwarded to gpu_channel.cc) for the command buffer

- gpu process (gpu_thread.cc) sends an ACK with the route_id for the command buffer back to the browser (gpu_process_host.cc)

- browser (gpu_process_host.cc) sends a delayed reply back to the renderer
(gpu_channel_host.cc), which had blocked

There are several motivations for this patch:

- creating an onscreen command buffer requires a window to draw into (which is acquired/locked in the browser); by routing through the browser, we can acquire the get the window beforehand (thereby preventing a deadlock in some other work that I'm doing)

- we can eliminate several separate synchronous IPC messages for obtaining and releasing the window associated with drawing (I've tried to unify the different code paths for Linux, Windows, and Mac)

- in the future, we can have the browser allocate SHM for the command buffer and transfer buffers, allowing us to sandbox the gpu process

BUG=none
TEST=by hand on all 3 platforms, trybots

Review URL: http://codereview.chromium.org/6343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72798 0039d316-1c4b-4281-b951-d872f2087c98

Avoid overlapping class definitions (e.g. MessageLoopQuitListener).

BUG=None
TEST=unit_tests,browser_tests

Review URL: http://codereview.chromium.org/6341013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72793 0039d316-1c4b-4281-b951-d872f2087c98

ADMX policies will have the XML attribute class set to "both", ADM policies will be presented twice, once under CLASS MACHINE, and once under CLASS USER.

BUG=70232
TEST=Add chrome.adm to Group Policy Editor and see if Chrome policies appear both under User Configuration and Machine Configuration, and they can be configured independently. Repeat this with chrome.admx.

Review URL: http://codereview.chromium.org/6327011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72792 0039d316-1c4b-4281-b951-d872f2087c98

2nd attempt with shutdown crash fix (only difference is in browser.cc).

BUG=66413
TEST=None

Review URL: http://codereview.chromium.org/6279012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72791 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows somebody to ask the PrefService for the effective preference values.

BUG=70809
TEST=prefs.PrefsTest.testUnderTheHoodPref and prefs.PrefsTest.testHomepagePrefs of chrome/test/functional/prefs.py will work again.

Review URL: http://codereview.chromium.org/6353015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/6348007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70761
TEST=none

Review URL: https://chromereviews.googleplex.com/2402014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72788 0039d316-1c4b-4281-b951-d872f2087c98

Reason for the refactoring is the need to properly handle disappearing policies.
This situation arises when a managed preference is removed that only has
been registered in one pref store (for example local_store) the notification
is sent to all pref stores though but the profile pref store doesn't have
a default value for that pref and therefore ControllingPrefStoreForPref returns
INVALID_STORE which shouldn't be treated as an exceptional situation (DCHECKed).

BUG=71028
TEST=unit_tests --gtest_filter=*Pref* should give pretty good coverage.

Review URL: http://codereview.chromium.org/6357019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72787 0039d316-1c4b-4281-b951-d872f2087c98

Clear prefs that the server reports TYPE_NULL values for and log a warning if the type is off otherwise.

BUG=none
TEST=compiles and passes tests

Review URL: http://codereview.chromium.org/6288016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72786 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step to being able to re-constitute policy from a non-generic protobuf in a policy request in a fully automated way (i.e. the code for the process can be generated). The non-generic protobuf is required for automatic merging of policy on the server-side.

BUG=68309
TEST=existing policy/provider tests

Review URL: http://codereview.chromium.org/6002015

TBR=danno@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72785 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step to being able to re-constitute policy from a non-generic protobuf in a policy request in a fully automated way (i.e. the code for the process can be generated). The non-generic protobuf is required for automatic merging of policy on the server-side.

BUG=68309
TEST=existing policy/provider tests

Review URL: http://codereview.chromium.org/6002015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72784 0039d316-1c4b-4281-b951-d872f2087c98

(there's an exclusion for _nss on non-linux platforms, however we need
this file for mac and windows as well.)
this is a build fix for http://src.chromium.org/viewvc/chrome?view=rev&revision=72782)

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/6374015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72783 0039d316-1c4b-4281-b951-d872f2087c98

Stubs out SslServerSocket for OpenSSL.

BUG=none
TEST=Sha256Test.TestContext (and compiles with openssl flag).

Review URL: http://codereview.chromium.org/6276002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72782 0039d316-1c4b-4281-b951-d872f2087c98

The WebKit side code will change to use onSuccess(SerializedScriptValue::nullValue()) instead.

BUG=70221
TEST=no new functionality

Review URL: http://codereview.chromium.org/6265027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:11087
TEST=manual

Review URL: http://codereview.chromium.org/6287014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72780 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72776 0039d316-1c4b-4281-b951-d872f2087c98

This change should have been included in
http://codereview.chromium.org/5981001/.

BUG=chromium-os:9682
TEST=make chrome passes

Review URL: http://codereview.chromium.org/6279015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=native_client/tests with --enable-nacl

Review URL: http://codereview.chromium.org/6306015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72768 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6320018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72767 0039d316-1c4b-4281-b951-d872f2087c98

- Been targeted by mass malware.
- Do not yet have a good sandboxing story.

BUG=60458
TEST=http://java.sun.com/products/plugin/1.4/demos/applets/Blink/example1.html with default plug-in settings.

Review URL: http://codereview.chromium.org/6350010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72766 0039d316-1c4b-4281-b951-d872f2087c98

Before the fix, we didn't have any space between a checkbox and the input
method name, which looked bad.

Note that we don't have this problem in other options pages, as our HTML
files are formatted like:

      <input id="foobar" type="checkbox">
      <span i18n-content="foobar">

the line break between two elements make a text node of a single space
inbetween.

BUG=chromium-os:11248
TEST=on chrome os, open the language options, see the input method list.

Review URL: http://codereview.chromium.org/6241016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72765 0039d316-1c4b-4281-b951-d872f2087c98

More specifically, skip thumbnail generation in the following occasions:
- The browser is in the off-the-record mode.
- The URL is not valid for top sites (ex. new tab pages, etc.)
- The existing thumbnail is new and interesting enough.

This patch should reduce the number of thumbnail generations significantly.

BUG=65936
TEST=add unit tests. confirm that the thumbnails are updated as expected.

Review URL: http://codereview.chromium.org/6389001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72763 0039d316-1c4b-4281-b951-d872f2087c98

The OOBE screen is by defaut shown in English, but is also shown in a
different language if "initial_locale" value is set in
/mnt/partner_partition/etc/startup_manifest.json

In this case, the default language name of the language selection menu
should be the one specified by "initial_locale". However, we were always
showing English before this fix.

BUG=chromium-os:11345
TEST=See the instruction at crosbug.com/11345

Review URL: http://codereview.chromium.org/6307015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9355
TEST=Viewed changes on netbook.

Review URL: http://codereview.chromium.org/6343004
Patch from Matt Falken <falken@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72760 0039d316-1c4b-4281-b951-d872f2087c98

team.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6382009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72748 0039d316-1c4b-4281-b951-d872f2087c98

Chromoting host to use a random number to generate self-signed certificate.
This method is still not optimal, in case of collision SSLServerSocketNSS will
fail to start due to NSS rejecting the certificate.

Using a random number is a temporary solution until we can assign certificates
to the host.

BUG=70013
TEST=Connect to the same chromoting host after client is disconnected.

Review URL: http://codereview.chromium.org/6315009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72745 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70829
test=none
Review URL: http://codereview.chromium.org/6382010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72743 0039d316-1c4b-4281-b951-d872f2087c98

TEST=go to ianfette.org 
BUG=70980
Review URL: http://codereview.chromium.org/6342023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5509
TEST=none yet

Review URL: http://codereview.chromium.org/6330015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72741 0039d316-1c4b-4281-b951-d872f2087c98

TEST=built in Debug and Release mode on Lucid 64-bit
BUG=none

Review URL: http://codereview.chromium.org/6379008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72740 0039d316-1c4b-4281-b951-d872f2087c98

also add more output to hopefully prevent confusion in the future.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72738 0039d316-1c4b-4281-b951-d872f2087c98

check.

BUG=none
TEST=Manual test

Review URL: http://codereview.chromium.org/6344015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72737 0039d316-1c4b-4281-b951-d872f2087c98

Implement double/triple click functionality in views textfield. Also changed views::Event::time_stamp_ to a platform independent time stamp.

@beng: please review views::Event changes (event.cc,event.h)
@oshima: please review the rest

BUG=none
TEST=new tests added.

Review URL: http://codereview.chromium.org/6267002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72736 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6278017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72735 0039d316-1c4b-4281-b951-d872f2087c98

In r72682, I removed this line since I assumed it was including the test utils
in the same file, not the unit tests. Put the unit tests themselves back.

BUG=68682
TEST=compiles + chrome_frame_net_tests starts running again.

Review URL: http://codereview.chromium.org/6350018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72734 0039d316-1c4b-4281-b951-d872f2087c98

Add IsBootPath to MountLibrary. Additional boot path check in imageburner so boot drive is not presented as a target.
BUG=chromium-os:6788
TEST=chrome://imageburner should not display /dev/sda

Review URL: http://codereview.chromium.org/6348006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72733 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24672
TEST=trybots

Review URL: http://codereview.chromium.org/6326014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72732 0039d316-1c4b-4281-b951-d872f2087c98

This is because collecting the stats often crashes.

Added a guard to prevent the collection of diagnostics on multiple threads simultaneously.

Renamed GPUInfo::Progress to GPUInfo::Level.

TEST=try, about:gpu does not cause concurrent diagnostics collection
BUG=none

Review URL: http://codereview.chromium.org/6364013

Review URL: http://codereview.chromium.org/6341011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72731 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo
Review URL: http://codereview.chromium.org/6379012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72729 0039d316-1c4b-4281-b951-d872f2087c98