- 12 Jan, 2017 40 commits
-
-
wkorman authored
Essentially a scroll node specific version of http://crrev.com/2612093002 which was only omitted there in the interest of incrementality. BUG=674258 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2623313003 Cr-Commit-Position: refs/heads/master@{#443348}
-
reveman authored
This cleans up the async read pixel code a bit by using weak ptrs instead of cancelable callbacks. BUG=678234 TEST=cc_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2628883004 Cr-Commit-Position: refs/heads/master@{#443347}
-
ftirelo authored
BUG=634434 Review-Url: https://codereview.chromium.org/2622383002 Cr-Commit-Position: refs/heads/master@{#443346}
-
lgrey authored
This was reverted due to crbug.com/679174 which is fixed by using the browser action container view's |animationEndFrame| instead of its frame when calculating the size of the location bar. Browser actions will be reordered in a future change. BUG=648558, 648563, 673362 Review-Url: https://codereview.chromium.org/2607533004 Cr-Commit-Position: refs/heads/master@{#441925} Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001) Review-Url: https://codereview.chromium.org/2631463004 Cr-Commit-Position: refs/heads/master@{#443345}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ed0540fbc6ef..290f611623b2 $ git log ed0540fbc..290f61162 --date=short --no-merges --format='%ad %ae %s' 2017-01-12 hjd [dashboard] Add addEventListener shim Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2631513005 Cr-Commit-Position: refs/heads/master@{#443344}
-
msw authored
Use was removed in https://codereview.chromium.org/2462753002/ BUG=557406 TEST=Compiles R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2622423002 Cr-Commit-Position: refs/heads/master@{#443343}
-
varkha authored
Replaces a tdefault textured layer used for a shield with a solid color layer. BUG=537050 TEST=NONE - no visible change Review-Url: https://codereview.chromium.org/2627153006 Cr-Commit-Position: refs/heads/master@{#443342}
-
vmpstr authored
This patch adds an ability to request an image decode from the compositor. The caller should specify which image (SkImage) to decode and a callback. In return, it gets an id. When the image is decoded, the callback is issued with this id. The decode is then kept alive for 2 compositor frames. Right now, only unittests are using this functionality. R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2537683002 Cr-Original-Commit-Position: refs/heads/master@{#443085} Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae Review-Url: https://codereview.chromium.org/2537683002 Cr-Commit-Position: refs/heads/master@{#443341}
-
gab authored
BUG=553459 Review-Url: https://codereview.chromium.org/2628893005 Cr-Commit-Position: refs/heads/master@{#443340}
-
marq authored
This CL adds an ios_clean_chrome_unittests target and tests for the public and internal APIs of BrowserCoordinator. BUG= Review-Url: https://codereview.chromium.org/2626033002 Cr-Commit-Position: refs/heads/master@{#443339}
-
creis authored
BUG=677716 TEST=See bug for repro steps. Review-Url: https://codereview.chromium.org/2624373002 Cr-Commit-Position: refs/heads/master@{#443338}
-
alito authored
The config class encapsulates the configuration data for the settings reset prompt experiment. BUG= Review-Url: https://codereview.chromium.org/2614773008 Cr-Commit-Position: refs/heads/master@{#443337}
-
fs authored
Previously we were only looking for <link>s with icons within <head>, and since SVG document don't have those, no icons would be found. Instead, for SVG documents (with a root/document element of <svg>), just collect all <link> (HTMLLinkElement) elements, regardless of position in the document, using a pre-order traversal. This appears to match the behavior of Gecko. BUG=385466 Review-Url: https://codereview.chromium.org/2628873003 Cr-Commit-Position: refs/heads/master@{#443336}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/693fdbd6b81a..90ee03b0d177 $ git log 693fdbd6b..90ee03b0d --date=short --no-merges --format='%ad %ae %s' 2017-01-12 liyuqian Revert "Implement Analytic AA for General Paths (with Guard against Chrome)" 2017-01-12 fmalita Fix SkImageFilterCache race 2017-01-11 liyuqian Implement Analytic AA for General Paths (with Guard against Chrome) 2017-01-12 reed fix clipping in rasterhandleallocator BUG=668937 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Review-Url: https://codereview.chromium.org/2629163003 Cr-Commit-Position: refs/heads/master@{#443335}
-
chrome://versionkerrnel authored
This adds a test for the Flash information displayed on the chrome://version page. The test cannot check the actual version or location as it varies per build, or is disabled in Chromium builds. BUG=680273 Review-Url: https://codereview.chromium.org/2629033002 Cr-Commit-Position: refs/heads/master@{#443334}
-
agrieve authored
Revert of Android: Delete rezip in favor of zipalign -p (patchset #2 id:210001 of https://codereview.chromium.org/2612773005/ ) Reason for revert: Broke system webview merging of debug builds. Original issue's description: > Reland of Android: Delete rezip in favor of zipalign -p > > There's no need for a custom alignment tool now that zipalign supports > page-aligning libraries. > > Previously reverted in: > https://codereview.chromium.org/2595233003/ > > Reason for reland: > Contains fix for monochrome (tested merging locally). > > BUG=676029,676589 > > Review-Url: https://codereview.chromium.org/2612773005 > Cr-Commit-Position: refs/heads/master@{#442906} > Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab TBR=michaelbai@chromium.org,jbudorick@chromium.org NOTRY=true BUG=676029,676589 Review-Url: https://codereview.chromium.org/2621353004 Cr-Commit-Position: refs/heads/master@{#443333}
-
sahel authored
To enable latching, MouseWheelEventQueue(MWEQ) uses a timer to send GSE events. When a fling arrives if the timer is running, MWEQ will stop it and won't send the pending GSE. In input_handler_proxy, ScrollBegin is called only once in HandleGestureFlingStart. This ScrollBegin won't do a new hittesting because CurrentlyScrollingLayer already exists (No GSE is sent before fling to clear the CurrentlyScrollingLayer when it's being handled). ScrollEnd won't get called in FlingScrollByMouseWheel for every wheel tick. Instead, it will be called only once in CancelCurrentFlingWithoutNotifyingClient, when the fling is over (last ScrollBy didn't scroll or fling time is terminated). To test locally use the --enable-features=TouchpadAndWheelScrollLatching runtime flag. BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled Review-Url: https://codereview.chromium.org/2625453002 Cr-Commit-Position: refs/heads/master@{#443332}
-
einbinder authored
BUG=none Review-Url: https://codereview.chromium.org/2622613003 Cr-Commit-Position: refs/heads/master@{#443331}
-
xlai authored
Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (patchset #2 id:20001 of https://codereview.chromium.org/2625823006/ ) Reason for revert: Suspecting this CL is causing these tests to fail: fast/workers/worker-shared-asm-buffer.html virtual/sharedarraybuffer/fast/workers/worker-shared-asm-buffer.html From the layout test results, it seems that turning on asm.js will append some console results to the test outcome. Example build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22022 Original issue's description: > [wasm][asm.js] Turn on asm.js -> WebAssembly by default. > > BUG=v8:4203 > R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org > > Review-Url: https://codereview.chromium.org/2625823006 > Cr-Commit-Position: refs/heads/master@{#443289} > Committed: https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88 TBR=jochen@chromium.org,bradnelson@google.com,danno@chromium.org,titzer@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2631543002 Cr-Commit-Position: refs/heads/master@{#443330}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/e7fb8eb3e9f2..db7647083d0a $ git log e7fb8eb3e..db7647083 --date=short --no-merges --format='%ad %ae %s' 2017-01-12 rbpotter Add postscript path Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2626213003 Cr-Commit-Position: refs/heads/master@{#443329}
-
tnagel authored
Revert of Re-enable fetching component policies for login screen apps (patchset #3 id:40001 of https://codereview.chromium.org/2603463003/ ) Reason for revert: I'm very sorry I have to revert this since it's breaking device policy updates. https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7 Original issue's description: > Re-enable fetching component policies for login screen apps > > This CL relands enabling fetching of policies for Chrome OS login screen > apps. > > The originally landed code was temporarily disabled due to DMServer > responding with errors when an unknown policy type was requested. Now > this can be enabled back, after the DMServer got fixed to at least > ignore the new policy type (until it starts to actually provide policies > with this type). > > BUG=644304,666720 > TEST=re-enabled browser tests; > manual test: sign into an enrolled device, go to chrome://policy > and check that the device policies were fetched successfully > > Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3 > Cr-Commit-Position: refs/heads/master@{#441015} TBR=emaxx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644304,666720 Review-Url: https://codereview.chromium.org/2621413007 Cr-Commit-Position: refs/heads/master@{#443328}
-
dschuyler authored
This is a semi-mechanical change to convert i18n-content to $i18n{}. The Non-mechancal changes are some formatting adjustments. BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2626123002 Cr-Commit-Position: refs/heads/master@{#443327} -
dongseong.hwang authored
ImageTexture binding is supported for only immutable texture [1] [1] https://www.khronos.org/opengles/sdk/docs/man31/html/glBindImageTexture.xhtml CMAA needs to use ImageTexture binding, so it checkes internal format is RGBA8. However, in GLES2 context, immutable texture can have RGBA internal format, because of https://codereview.chromium.org/2458103002/ This CL makes it check immutable texture directly. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2543123003 Cr-Commit-Position: refs/heads/master@{#443326}
-
khushalsagar authored
SyncedProperty is used as a synchronization primitive to track state on the impl thread, necessary to resolve conflicts for concurrent main-impl mutations. As such it should only exist on the impl thread. Currently, the ScrollTree creates these on the main thread while they only store the current main thread value. This is unnecessary complexity that can be avoided. This change makes ScrollTree store just the offset on the main thread, and a SyncedProperty for the offset on the impl thread. BUG=662619 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2621403003 Cr-Commit-Position: refs/heads/master@{#443325}
-
petermayo authored
It is unused in Chrome and its tests. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2630483002 Cr-Commit-Position: refs/heads/master@{#443324}
-
xlai authored
Revert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ ) Reason for revert: Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest. Example builds: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962 https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323 Original issue's description: > Stop bad results on first memory benchmark run > > The first memory system-health story ran in a set has been reporting > memory use differently all subsequent runs. This is due to how we > flush the system caches. > > Just before we measure memory we flush the system caches unfortunately > this doesn't immediately take effect, instead the next story run is > effected. Due to this the first story run has anomalous results. > This option causes us to flush caches each time before Chrome starts > so we effect even the first story - avoiding the bug. > > *************** Note to Perf Sheriff **************** > > Regressions across several memory metrics are > expected for system_health.memory_mobile, > system_health.memory_desktop and memory.top10_mobile > as we stop under counting memory use. > > ***************************************************** > > BUG=chromium:671156 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Review-Url: https://codereview.chromium.org/2589173004 > Cr-Commit-Position: refs/heads/master@{#443273} > Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:671156 Review-Url: https://codereview.chromium.org/2627323002 Cr-Commit-Position: refs/heads/master@{#443323}
-
jamescook authored
BUG=none TEST=none Review-Url: https://codereview.chromium.org/2628923003 Cr-Commit-Position: refs/heads/master@{#443322}
-
ryanchung authored
- sheretov@ and vadimgo@ no longer works on cast. - add dougsteed@ BUG= Review-Url: https://codereview.chromium.org/2626053003 Cr-Commit-Position: refs/heads/master@{#443321}
-
jrummell authored
Currently PluginPrivateDataByOriginChecker only deletes all the data for the specified origin if it finds at least one file that matches the time range specified. However, if the origin has no files, it should be cleaned up as well. Adds a test that deletes the file for a particular origin before clearing all PluginPrivate storage to verify it works. BUG=678314 TEST=new content_unittest passes Review-Url: https://codereview.chromium.org/2622403002 Cr-Commit-Position: refs/heads/master@{#443320}
-
mahmadi authored
BUG=602666 Review-Url: https://codereview.chromium.org/2588913002 Cr-Commit-Position: refs/heads/master@{#443319}
-
rnephew authored
BUG=679375 Review-Url: https://codereview.chromium.org/2622003005 Cr-Commit-Position: refs/heads/master@{#443318}
-
ericrk authored
I got the data I wanted from this UMA, and it appears to be causing performance regressions. Removing. R=isherman@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2628833003 Cr-Commit-Position: refs/heads/master@{#443317}
-
tommycli authored
BUG=680544 TBR= Review-Url: https://codereview.chromium.org/2625273004 Cr-Commit-Position: refs/heads/master@{#443316}
-
alph authored
Review-Url: https://codereview.chromium.org/2629503002 Cr-Commit-Position: refs/heads/master@{#443315}
-
xlai authored
The images generated on gpu reference archive are correctly showing blurry edge on enlarged canvas. TBR=zmo@chromium.org BUG=676666 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2625393002 Cr-Commit-Position: refs/heads/master@{#443314}
-
ryansturm authored
This CL adds a count of requests using DRP and information about compression. This will allow us to reconsider UMA (e.g., logging UMA for Mixed content pages (HTTPS pages using DRP from HTTP sub-resources), logging UMA for <50% of network requests using DRP, >50% of network requests using DRP, etc.). This will also allow UMA for size of page in terms of network bytes and in terms of original content length (precompressed bytes from the origin). This will allow a DRP per-page data savings histogram as well. BUG=679893 Review-Url: https://codereview.chromium.org/2619243003 Cr-Commit-Position: refs/heads/master@{#443313}
-
dbeam authored
R=mahmadi@chromium.org BUG=679993 Review-Url: https://codereview.chromium.org/2629083002 Cr-Commit-Position: refs/heads/master@{#443312}
-
michaeldo authored
When the BrowserState is destroyed, the preload controller must be notified to ensure it will be released. This prevents the preload controller from receiving PrefChanged notifications after the browser state has been destroyed. BUG=677126 Review-Url: https://codereview.chromium.org/2629073003 Cr-Commit-Position: refs/heads/master@{#443311}
-
baxley authored
These tests are affected by crashes in the context menu tests. With these tests disabled. They could also be affected by alerts, but We now skip tests with alerts on EG tests. BUG=675400 Review-Url: https://codereview.chromium.org/2624263004 Cr-Commit-Position: refs/heads/master@{#443310}
-
michaelpg authored
Precursor to some possible refactoring to extract the file_handlers API from //chrome to //extensions. BUG=679870 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2621193002 Cr-Commit-Position: refs/heads/master@{#443309}
-