- 27 Oct, 2020 40 commits
-
-
Hai Bi authored
ScopedServicePublisher and ScopedSingleClientServiceBinding were updated to allow the service name to be specified explicitly, but ScopedServiceBinding was missed. Add the missing functionality to the ScopedServiceBinding template. Bug: b/171256428 Test: locally tested and pass unit tests Change-Id: I0623256895da020eaf3a423e28f72936cf843994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499625Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Hai Bi <bihai@google.com> Cr-Commit-Position: refs/heads/master@{#821381}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 20 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-25. TBR=chromium-metrics-reviews@google.com Change-Id: I9c5e0d4b1a9ff375429baa6a4f976c67f3e5bea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503229Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#821380}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I059347137696bd52d27dbe04149f5f0da04dbf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502775Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821379}
-
ssid authored
Android task runner posts Runnable tasks and the tasks are run by native task runner. All these tasks are recorded with posted location as post_task_android.cc. To track the correct posted location, this cl adds new trace events to track the runnable class name. Note that we still track the wrapper task runner in some cases like ChainedTasks and AsyncTask$NamedFutureTask, which needs to be fixed. BUG=1136635 Change-Id: I97b35b003ce7d5571ce4a44c54127da74400cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480715 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#821378}
-
yiyix authored
Add new attribute fontVariantCaps to canvas context 2d. Developers can choose between normal, small-caps, all-small-caps, petite-caps, all-petite-caps, inicase and tiling-caps. Bug: 1141671 Change-Id: I5d047f00773f4f2a38eb25c21e13168a316c29d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490789Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#821377}
-
Nate Chapin authored
Change-Id: I303149a39f40702d6600fa7409f7cfc03146eb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500429 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821376}
-
John Chen authored
This reverts commit 89540fb3. Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930) Original change's description: > Remove SpawnedTestServer from BrowserTestBase. > > The last browser tests using the built-in SpawnedTestServer have > finally been migrated the EmbeddedTestServer, so nothing is using it. > This also helps reduce visibility of the SpawnedTestServer, so makes > accidental use of it harder. > > This CL also fixes a bunch of IWYU issues that the removal unearthed. > > Bug: 492672 > Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821288} TBR=jam@chromium.org,mmenke@chromium.org Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 492672, 1142930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821375}
-
Andre Le authored
- Change the states in enable hotspot to fit new design. - Add a notification when enable hotspot fails. BUG=1106937,1126208 Change-Id: Id9092649d5cfcee9f6153c74a258b869a81f89dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495621 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821374}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77cd4b459b10..ebb6a5523374 2020-10-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ie3908bc414c44abf649193dee51f3235ed2b5a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821373}
-
Joshua Pawlicki authored
Bug: 1098934 Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#821372}
-
bttk authored
Classes implementing LocationBar now explicitly implement FakeboxDelegate as well and provide it with the LocationBar.getFakeboxDelegate() method. Bug: 1139481 Change-Id: I34a1a1400db34460a3f577b83b6efd4dd07a4cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482463 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821371}
-
dpapad authored
- Move preprocess_grit() for cr_components/ under cr_components/BUILD.gn - Add new generate_grd() target in cr_components/ - Remove now obsolete alias in shared_resources_data_source.cc. Note: cr_components/cr_components_images.grdp will be addressed in a follow up CL. Bug: 1132403 Change-Id: Id41f9c08e498d1a014854b1ebc6ee20d6cf7b916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495082 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821370}
-
Toby Huang authored
This CL enables the feature flag for FamilyLinkUserMetricsProvider. Bug: 1136304 Change-Id: I62ad64ad402350f7d0b0415a004b4ca1186745ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495609 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821369}
-
Yue Li authored
Bug: b/170436934 Test: Manual Test Change-Id: I81605b7aff2f0a93a36369a8f46778c3f36178c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491123Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6f87de7c272d..22ef2257c862 2020-10-27 johnstiles@google.com Update the SkSL pool interface to take an allocation size. 2020-10-27 brianosman@google.com Guard traversal of certain kinds of mid-optimization IfStatement 2020-10-27 johnstiles@google.com Pass function arguments using SkSpan instead of count + ptr. 2020-10-27 egdaniel@google.com Add uma histogram tracking for the number of submit render passes. 2020-10-27 johnstiles@google.com Prototype helper functions from FP files before use. 2020-10-27 johnstiles@google.com Mangle function names as a separate step before emitting func-bodies. 2020-10-27 mtklein@google.com remove absl experiment 2020-10-27 mtklein@google.com use ieee divide If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I36a14fa5a94bdb5234174fc7ade1331c3ada37d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502840Reviewed-by:
-
Kristi Park authored
Change-Id: I875a0fb93da41cd6d317b17ec796cded5d1ffbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503828 Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821366}
-
Eugeny Aristov authored
Unlike Clang GCC doesn't allow implicit conversions between vectors which differ by size, type, sign (lax-vector-conversions) by default. Hence introduced usage of suitable interfaces which return values corresponding to given types. Bug: 819294 Change-Id: Iafcf53bc931d5c9ed1b03a79ffb5fbb75828a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501341Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#821365}
-
Ted Choc authored
BUG= Change-Id: Iba9b613656bf8ff6ba4c9e5c4ebdec3854582931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502782Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#821364}
-
Oksana Zhuravlova authored
This CL moves functions related to getting background tracing configuration from field trials out of //chrome into //content/public/browser (BackgroundTracingManager) so that they can be reused by other embedders (in this case, android_webview). Bug: b/170511922 Change-Id: Ia4ffc5f84472d9af00a3b84460d3815b360593eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473057 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#821363}
-
Ryan Heise authored
This test sometimes hangs. Example - https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=48d751774f963fcbdfae61d09bcd342ec023dc30&as=benchmark_log.txt Bug: chromium:1139057 Change-Id: Ib019d9d8d721fcb4de22d2b1f8746d3edefb9d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500484Reviewed-by:
-
Toni Barzic authored
Holding space item views depend on HoldingSpaceItemViewDelegate owned by the HoldingSpaceTray. The delegate is reset with HoldingSpaceTrayBubble when the bubble is closed, which happens before the bubble widget gets torn down. Given that widget is destroyed asynchronously, there's a short time interval where holding space item container views are still around, but the delegate they depend on is destroyed - if a new item gets added at this time, it would cause usage of deleted delegate. (Found by tests added in CL:2493323). To prevent this, remove container views from holding space controller model and controller immediately when the HoldingSpaceTrayBubble gets reset. Change-Id: Icf5c523027ad352adff11ce9856a82bd93a7e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503628Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821361}
-
Ella Ge authored
To make TWA and WebAPK the same. As far as I can tell, there is no visual difference. Since both TWA and WebApk can do it in the shared SplashController, TwaSplashController doesn't need the lifecycleDispatcher anymore. Bug: 1129093 Change-Id: I320ece59b28d2c5b39da0869f97f5ac2baf5f9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414845Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#821360}
-
Leonard Grey authored
This is the boundary between Commander internals and the rest of the system. Also includes the enable check and current logic (command line flag), though nothing will happen until Initialize is hooked up (and nothing *interesting* will happen until the WebUI CL lands). Bug: 1014639 Change-Id: I9063766657fb4bceb8bbf11faab8655b515315a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500245 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821359}
-
Mei Liang authored
This CL annotates the OverviewModeBehavior and OverviewModeObserver interface, and the EmptyOverviewModeObserver class as deprecated to avoid new usage. Change-Id: Ic1f0da301e67a0f302492c9e1f41fab3b2a5fbb3 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501071 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#821358}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47c8f45b..20aa521f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22e0197ef32e327e24eb2696ea4a27f333eb3590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502671Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821357}
-
Wei Li authored
SetFocusForPlatform() was used to override Button and its subclasses' focus behavior. Now the platform default focus behavior becomes Button's default setting. This API is no longer needed. Bug: 1001103 Change-Id: I565e9e85b7146b35794d52a23df2143e7008d3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499421Reviewed-by:
-
danakj authored
Also test that it can IgnoreResult a callback with arguments and the resulting callback will still accept those arguments. R=dcheng@chromium.org Bug: 1140582 Change-Id: If01cd5442f1ef0185fce74f6952cbdf54aaef07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503769Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821355}
-
Kyle Milka authored
Add a few share features to the testing config. These features will be tested in beta soon as the sharing hub is launching. Bug: None Change-Id: I960930af2185b30bb749609084bc1bd76bb03d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495403 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#821354}
-
RJ Ascani authored
The FuchsiaCdmManager needs to create directories for each origin to pass to the platform CDM services to fulfill EME origin isolation requirements. The FuchsiaCdmManager runs on the main thread and the calls to CreateDirectoryAndGetError are potentially blocking. This CL moves the directory creation step to a background task. Bug: 1140655 Change-Id: I060edc909976e7b5a493afc3bc9a2a26e26994be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500532Reviewed-by:
-
Tim Song authored
The new Delegate class is called to open the connected device settings UI. This refactor is allows: * logging the current screen when the button is pressed * a unit test case for pressing the settings button BUG=1138137,1106937 Change-Id: I71af2ec6c00813536c15f684fdb8459f4671cada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501072Reviewed-by:
-
Bartek Nowierski authored
Continuation of crrev.com/c/2463047 This requires moving other structures and functions from partition_alloc.* into their own, new files. Change-Id: I8ceb9966787ef0b4240790f8a77fa46d35efa455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498022 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 111 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-25. TBR=chromium-metrics-reviews@google.com Change-Id: I668f13de1ed48c53a6701d7567244f942d9fdc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502393Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#821350}
-
Adrienne Walker authored
Before adding a fifth schema migration, move the existing migration code into their own separate functions. Bug: 984163 Change-Id: Id36caabf7582e180f70206f28e6e31e8ff3833b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500265Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821349}
-
David Bienvenu authored
This reverts commit 2251f312. Reason for revert: <crbug.com/1142433> Original change's description: > Ensure that devtools stays visible when window is made smaller. > > Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550 > > Original CL didn't account for left and bottom docked dev tools. This > CL handles those cases by looking at the incoming strategy.bounds. > > Bug: 974178 > Change-Id: Ic2b7f0b8b642d884f563815b2ccc94a94d423eeb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472612 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817363} TBR=caseq@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974178 Change-Id: I681deef3e8a0b939f1876190df62bace8946fb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502455Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821348}
-
Nate Chapin authored
NavigatorXR is fairly trivial, and XRSystem can just hang off of Navigator directly. Change-Id: Ied94d8e303c3d407f14531c85c860c366ee2183e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494822Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Zhaoyang Li authored
This is useful for developers to locate a shard from a test name, when there are multiple shards for a suite. Bug: 1047704 Change-Id: Ie107d145036e85ca60fe44305fc33ddb17d30ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495792Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821346}
-
Joe Downing authored
All hosts should now (as of several years ago) be set up using a robot account so the codepath to handle host registration for a person account is no longer useful. Removing it to clean up the logic and prevent future confusion. Change-Id: I7cb813dc05e9eb79a76d04ea37a80470edd66d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495981 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#821345}
-
kylechar authored
The GPU workaround wasn't being passed to Skia when running with Vulkan. In general, GPU workarounds aren't implemented for Vulkan so remove the GPU workaround and add a real flag. Set the GrContextOption based on the flag from GetDefaultGrContextOptions() so it's picked up everywhere. Bug: 1138979 Change-Id: I469a7b38517e62f0577673ac1b8c1430fee9f55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502952Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#821344}
-
David Black authored
This CL pulls the holding space tray icon out into a separate class. Moving forward, the new HoldingSpaceTrayIcon will be modified to add support for a content forward UI and accompanying motion spec. Changes will be gated by a new feature flag (or param to the existing flag). No changes should be visible to the user as a result of this CL. Bug: 1142572 Change-Id: I21f85f37eeb595f7aa9ac3c79a171634b22e939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499376Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821343}
-
Liquan (Max) Gu authored
Changes: * Separated PaymentRequestService#Delegate into the common part (will be shared with WebLayer) and the Chrome part (moved into ChromePaymentRequestService#Delegate). After the change, the Chrome part has the TWA and basic-card related logic (skipUiForBasicCard). * skipUiForBasicCard is used by both java tests and browser tests. The java tests depends on its being overridden in PaymentRequestServiceObserverForTest#onPaymentRequestCreated. The browser test depends on its being overridden in PaymentRequestTestBridge#PaymentRequestDelegateForTest #skipUiForBasicCard (which was buggy as it was not set) Bug: 1142636 Change-Id: I4556f025e5a1c646d26bd4768724ac8ddcf9e874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499323 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821342}
-
