- 02 Feb, 2018 40 commits
-
-
Daniel Bratell authored
This is a preparatory patch for jumbo compilations where several cc files are compiled in the same translation unit. Then you get compilation errors if they all define their own kNumRetries and kBackoffPolicy, kApiPath and so on. This patch gives the 5 different kNumRetries variables and 3 different kBackoffPolicy variables in chrome/browser their own name. It also renames kApiPath, kApiUrl and kApiScope. It also deduplicates a kAuthorizationHeaderFormat string that had 4 different instances. Bug: 746957 Change-Id: Ib14ccaa372d3b28cd505b2e7cec519a5635e3173 Reviewed-on: https://chromium-review.googlesource.com/868335Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534084}
-
https://webrtc.googlesource.com/src.git/+log/c22d6a8f9b3e..debbc7801fbd $ git log c22d6a8f9..debbc7801 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iffd78d0538f4f022154dbbdda7809d4c2f71bb92 Reviewed-on: https://chromium-review.googlesource.com/899562Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534083}
-
Alex Newcomer authored
Add ContextMenuMetrics (User Journey Time, Show Source, and Command Executed) to shelf and desktop. Modified histograms.xml to include "Desktop" and "Shelf" components. TEST=manual Bug: 807035 Change-Id: If54d53ef71b3f4dfe12c144333980ac2a5281bf5 Reviewed-on: https://chromium-review.googlesource.com/896628Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534082}
-
Ricardo Quesada authored
Use WriteHTML for "Copy to clipboard" button, in addition to WriteImage. This is needed by ARC, which for the moment, only support HTML and plain clips from the Clipboard. It cannot see SkBitmap clips. This CL restores the code that was before this one: https://chromium-review.googlesource.com/c/chromium/src/+/781342 while also preserving its functionality. (and adds: #include <utility> required by std::move) TEST=copy-to-clipboard works Ok with Hangouts extension and in ARC++. BUG=808210 Change-Id: I1018d503dfd69d4677c1726c3abb4c0202697fcd Reviewed-on: https://chromium-review.googlesource.com/898424Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#534081}
-
Juan Antonio Navarro Perez authored
Test failing on tablet testers. TBR: ntfschr@chromium.org Bug: 808444 Change-Id: I0f18bded5aa2e5204be8f745b5ec1ae16fcc100a Reviewed-on: https://chromium-review.googlesource.com/899245Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#534080}
-
Koji Ishii authored
This patch fixes the logic whether to generate box fragments for an inline box or not consistent across wrapped lines. Not all inline boxes need to have corresponding box fragments. NGInlineLayoutAlgorithm determines this and avoid creating them when not necessary. NGInlineLayoutAlgorithm used to determine it for each wrapped line, but this made traversing fragments harder. With this change, if traversal finds a box fragment for a LayoutInline, it knows that it can find all other fragments too. wpt/css/CSS2/normal-flow/block-in-inline-empty-00[14] no longer pass with this change. These tests don't pass in Blink/WebKit, and that the fix priority is not high at this moment. Bug: 636993 Change-Id: I58b0f3c5fd95ee743a5ab404c8e8a4b284909616 Reviewed-on: https://chromium-review.googlesource.com/895231 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534079}
-
Benoit Lize authored
"extra_chrome_shared_library_configs" is used to enable code ordering, but is only added for 32 bit webview. Add this config. A downstream change will enable ordering for ARM64, saving: - ~6.9MB of PSS for Chrome ARM64 (not widely released) - ~5MB of PSS in Android Search App on Android N - ~2.5MB of PSS in Android Search App on Android O Similar gains are expected for other webview apps, see attached bug. Bug: 803866 Change-Id: If15d319bf7fbc58c3ac76898a5d7893ba0ade32c Reviewed-on: https://chromium-review.googlesource.com/899362Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1f7fd6d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11526 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0ff9b8b1459a28d2328c133db2ac11dfd1ddd55f Reviewed-on: https://chromium-review.googlesource.com/899102 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#534077}
-
Yutaka Hirano authored
This reverts commit e6395d1c. Reason for revert: performance regressions Original change's description: > Update RendererSideResourceScheduler testing config (Enabled_3_1024) > > This is a reland of > https://chromium.googlesource.com/chromium/src/+/47b8f2451e900fe2c5fc4d94046925f40fea2fc7 > with modester parameters. > > Bug: 785770, 794073 > Change-Id: Icab191e655118ff17aa91759bfe8ce9e1e45f6fb > Reviewed-on: https://chromium-review.googlesource.com/867824 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529644} TBR=isherman@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 785770, 794073 Change-Id: Ibac8672cc5fb780f6c4b94cbde955fd7686a4041 Reviewed-on: https://chromium-review.googlesource.com/899403 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#534076}
-
Justin Cohen authored
Bug: 799345 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6c077be0ac58af923209234c27511b4433b0685d Reviewed-on: https://chromium-review.googlesource.com/896812Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534075}
-
Justin Cohen authored
BUG=799345 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I760f36dcf8cb9f47322ecf8d5134f73957e2bf8f Reviewed-on: https://chromium-review.googlesource.com/897185Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
It was introduced in r488421 to handle the credentials without trailing '/' in signon_realm and origin. Now however, the signon_realm is created correctly by GmsCore. The origin has no '/'. As a result - r488421 is useless with a lot of complexity. - r488421 is harmful because it prevent the credential from being deleted via passwords.google.com. See b/69245513 R=battre@chromium.org Bug: 739101,801918 Change-Id: I20e64481b8dd972e3b43f18a00b0b3078f58c4fe Reviewed-on: https://chromium-review.googlesource.com/897610Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#534073}
-
Sebastien Marchand authored
Bug: 806265 Change-Id: I4820b88096de01aa134715ebbe6cb1556d91b4ec Reviewed-on: https://chromium-review.googlesource.com/888094Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#534072}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/33f6b756..11a430a2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I11667aedc857c246731ef494a5e8b835e65956dc Reviewed-on: https://chromium-review.googlesource.com/899222Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534071}
-
Alex Clarke authored
This patch changes the Sequence interface slightly by introducing DelayTillNextTask which helps work around problems scheduling delayed tasks when TakeTask doesn't have a task to return (due to cancellation). Change-Id: I5935e41ad5bc725b6109a187b329c82ce5a70689 Bug: 783309 Reviewed-on: https://chromium-review.googlesource.com/883346 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534070}
-
François Beaufort authored
Bug: 806249 Change-Id: I46ccd72da19253fdb0ff54d90fd439a8d98ca5a9 Reviewed-on: https://chromium-review.googlesource.com/895447 Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#534069}
-
Amirhossein Simjour authored
This CL enables the Chrome's Javascript Dialog in VR behind a flag. The View from the 2D dialog is converted into a texture and is shown in VR on a quad. The events from the controller are translated to MotionEvents and are sent back to the 2D dialog. It is made possible to replace ModalDialogManager in ChromeActivity. The ModalDialogManager is replaced with a new one when going in VR mode, and is replaced with the old ModalDialogManager when leaving VR. The ModalDialogManager that is used in VR uses VrModalDialogPresenter that shows dialogs on a quad in 3D space in front of the main content. The view from 2D Javascript dialog is attached to the DecorView to make sure that the View will receive all the event. The close button will be added to this dialogs in the follow up CLs. Bug:779126 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaae0147d1711297cc7dd992fe3986642669bc102 Reviewed-on: https://chromium-review.googlesource.com/868552 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#534068}
-
danakj authored
As per the comments at https://chromium-review.googlesource.com/c/chromium/src/+/895806/7/cc/resources/resource_pool.cc#b657 we need to add a GUID so that the resource can be corroborated with the resource in the gpu process. Otherwise the resource will be double- counted between processes. R=ericrk@chromium.org, vmpstr@chromium.org Bug: 807331 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6f66b31b640c0ba86a65b1d40fd49f4da3dd06a1 Reviewed-on: https://chromium-review.googlesource.com/897992 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#534067}
-
https://skia.googlesource.com/skia.git/+log/18c52a7b5221..0f1abf89f043 $ git log 18c52a7b5..0f1abf89f --date=short --no-merges --format='%ad %ae %s' 2018-02-02 rmistry Add Android compile bot as experimental CQ bot Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I22642c822e929a689334a575242dc571427ba360 Reviewed-on: https://chromium-review.googlesource.com/898550Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534066}
-
Ioana Pandele authored
Bug:790982, 789122 Change-Id: I06bc82f7fb2f8f2451baeda178ea829d70aab100 Reviewed-on: https://chromium-review.googlesource.com/899007 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534065}
-
Harald Alvestrand authored
Also add tests on what happens when Unified Plan talks to Plan B in some combinations. Bug: 799030, 802938 Change-Id: I8d17fd42221c5e8f3d34bfc93d6bfe4c99c6ddd1 Reviewed-on: https://chromium-review.googlesource.com/852272 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534064}
-
Peter Boström authored
Conditional titlecase is required for Mac dialogs. Bug: chromium:807886 Change-Id: I0edc79ef9485d1cca541e4c309eb6360d8169109 Reviewed-on: https://chromium-review.googlesource.com/898428 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#534063}
-
Sylvain Defresne authored
To allow the autoroller to work, pin the reference to src/ios_internal in src/DEPS. The hash used was found using "git ls-remote $IOS_INTERNAL refs/heads/master". Bug: 803846,skia:7552 Change-Id: I418a7cfa9db19729f19658ac16baf3e224638c86 Reviewed-on: https://chromium-review.googlesource.com/897950Reviewed-by:
Eric Boren <borenet@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#534062}
-
Devlin Cronin authored
v8::Object::CreateDataProperty is slightly more efficient than v8::Object::DefineOwnProperty when no custom attributes are required. Use CreateDataProperty instead in these cases. Bug: None Change-Id: I2674d6dd5b5f2d9bce8b932a2ee149633f6250a3 Reviewed-on: https://chromium-review.googlesource.com/897741Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534061}
-
Devlin Cronin authored
GetPackageDirectoryEntry has a ModuleSystem::NativesEnabledScope that wasn't quite long enough. We need to ensure that the scope allows the function to generate the callback (fileEntryBindingUtil.getBindDirectoryEntryCallback) to run with natives, since it may require modules in the background page. Expand the natives enabled scope by just enough to make this work. Bug: 653596 Test: browser_tests --enable-features=NativeCrxBindings --gtest_filter=*GetPackageDirectoryEntryApp* Change-Id: I209c4e8f92d0b10955d1ecafe489b68a2b18af88 Reviewed-on: https://chromium-review.googlesource.com/898399Reviewed-by: -
Chris Nardi authored
Import wpt/css/css-images so existing images tests can be upstreamed. No-Export: true Bug: 630597 Change-Id: I034a5c02eb3b1b91aceea9579b3f6f84414a7a41 Reviewed-on: https://chromium-review.googlesource.com/898224 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#534059}
-
Justin Cohen authored
Instead of using the old NewTabPageHeaderView and NewTabPageToolbarController, use a new ContentSuggestionsHeaderView and embed a PrimaryToolbarViewController. Creates a temporary NTPHeaderViewAdapter protocol allow the NTP UI to switch back and forth between each header view. Bug: 805640, 805639 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifb2be48ae38528543b2f8b9a108eec0453e9ddbf Reviewed-on: https://chromium-review.googlesource.com/894147Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534058}
-
Nicolas Pena authored
FPDFPage_New creates a FPDF_PAGE object and adds a page to the FPDF_DOCUMENT. However, the FPDF_PAGE object needs to be deleted by calling FPDF_ClosePage. Bug: 807953 Change-Id: Ib0d7ca46979f855c38a03cf114c20505d825e620 Reviewed-on: https://chromium-review.googlesource.com/897930Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#534057}
-
Gauthier Ambard authored
This CL changes the animations when focusing the omnibox to expand the location bar to take the full width of the screen and hide the buttons. Bug: 804751, 804749 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I71653dddb10323a55f660f4b9432b3ec112584b7 Reviewed-on: https://chromium-review.googlesource.com/899146Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#534056}
-
Koji Ishii authored
This patch rename InlineBlock sub-type of NGPhysicalBoxFragment to AtomicInline, because it actually includes replaced elements. NGPhysicalFragment does not provide a function to distinguish inline block from replaced elements today, and all uses were replaced in this CL. We might add one if needed. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I55362b6956b8ea29853f685961d711fdcb5b6c4a Reviewed-on: https://chromium-review.googlesource.com/898145 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#534055}
-
Raphael Kubo da Costa authored
Remove one of the identical copies of the same check from the code, added in e5bbbb17 ("Bindings: Add ScalarValueString support"). The original check was added a few days before in 65d50ad9 ("Add ByteString support to IDL bindings"). R=haraken, jbroman, yukishiino Change-Id: Ic7cb436200a7c3e15ebd7bd1183c54d16eeae595 Reviewed-on: https://chromium-review.googlesource.com/899183Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#534054}
-
Andrew Grieve authored
It can now proguard, package & finalize the test_apk and apk_under_test at the same time. Bug: 804251 Change-Id: I3709377ef9308ec10bc7c6e456c87240c021425d Reviewed-on: https://chromium-review.googlesource.com/898041Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#534053}
-
Elly Fong-Jones authored
This change removes these files from the polychrome build, removing some symbol conflicts (that seem harmless, at least in my build, but still). Bug: 804950 Change-Id: Idabe98b79106954299a1557db553ffce6efd39cd Reviewed-on: https://chromium-review.googlesource.com/897746 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#534052}
-
Thomas Tangl authored
This CL changes the implementation of the dice sign-in button in the user menu. Instead of a HoverButton the newly implemented DiceSigninButton is used. Changes to DiceSigninButton: - The account icon is passed to the constructor. - An option to not show the drop down arrow is added. Bug: 786369 Change-Id: Ideadb6674ebd356374883968eabfd53cba9e1167 Reviewed-on: https://chromium-review.googlesource.com/891319 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#534051}
-
jonross authored
New tests began failing on the FYI bots, this updates the filters to reflect that. Also the tests have been added to Mac FYI bots, so I'm filtering the first set of filters to look for further flakes. I will triage them and update filter accordingly TBBR=kylechar@chromium.org TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests Bug: 760181 Change-Id: I02b93e7adafa545b01a13d0be67b838987fca1b5 Reviewed-on: https://chromium-review.googlesource.com/898609Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#534050}
-
François Beaufort authored
Bug: 806249 Change-Id: I64d5e3aeea52b04c4f79e5b7d302f6ffe914ff8a Reviewed-on: https://chromium-review.googlesource.com/893461Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Hans Wennborg authored
This reverts commit 1b6c18ab. Reason for revert: This broke two browser_tests in Official Windows builds: SecurityStateTabHelperTest.DefaultSecurityLevelOnFilesystemUrl SecurityStateTabHelperTest.DefaultSecurityLevelOnBlobUrl Original change's description: > Add HTTP-Bad Phase 3 experiment to field trial testing config > > Some browser tests needed to be updated accordingly. I deleted a couple > that were redundant with tests where the field trial is enabled. For a > few others that only made sense in the pre-field trial world, I just > disabled the feature for them, though we'll want to clean them up > eventually after the field trial launches. > > Bug: 807062 > Change-Id: I480b2527375368d6146c1ddace2551dece9ec596 > Reviewed-on: https://chromium-review.googlesource.com/891677 > Reviewed-by: Eric Lawrence <elawrence@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533845} TBR=jwd@chromium.org,estark@chromium.org,elawrence@chromium.org Change-Id: I34688c6ef005ac74e79d78a5b8d451790dba96a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807062, 808424 Reviewed-on: https://chromium-review.googlesource.com/899150Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534048}
-
nikhil authored
CSSNumericArray should be iterable. Spec: https://github.com/w3c/css-houdini-drafts/pull/607 Bug: 807169 Change-Id: If844c89e5c47989ad1c72babaebf535e38677c2e Reviewed-on: https://chromium-review.googlesource.com/892760 Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#534047}
-
Ioana Pandele authored
This is an alert with the title "Preparing passwords..." displayed after the reauthentication step is finished, and while passwords are being serialized and written to the temporary file. The alert offers the user the option to cancel the exporting operation. If the user cancels, the exporter will wait for the async tasks to finish, perform necessary clean-up and then become available again. Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8dd6b9a094e055eef15f5580e3d887e5cf979408 Reviewed-on: https://chromium-review.googlesource.com/897607Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#534046}
-
Ioana Pandele authored
Bug:789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id0417fb700bc955013ca8ab3a1ad2ff7ce82ed54 Reviewed-on: https://chromium-review.googlesource.com/898986 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
