- 17 Mar, 2020 40 commits
-
-
Michael Ershov authored
CertProvisioningWorker class implements core logic for building a CSR with DM server and importing corresponding certificate. Bug: 1045895 Test: CertProvisioningWorkerTest.* Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750986}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/02d73f58b81e..f368dcbb7d8a git log 02d73f58b81e..f368dcbb7d8a --date=short --first-parent --format='%ad %ae %s' 2020-03-17 cepheus@frii.com SPV headers: Bump up to the latest header. Created with: gclient setdep -r src/third_party/glslang/src@f368dcbb7d8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I57df657610b62775843a7a02c78e01552af45bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750985}
-
Olivier Yiptong authored
This change adds read-through caching for font enumeration in FontCache. Invalidation is triggered whenever the invalidation of FontCache happens. The Mac implementation has been changed and the results on my machine are as follows: The enumeration of 591 fonts took ~160 ms and now take an amortized 0.45 ms in a benchmark run with 10k iterations. The performance benefits come mostly from avoiding IPC between the renderer process and fontd. Bug: 1043306 Change-Id: If9543287b26f4552b256bb909593150e32b6cdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#750984}
-
Katie D authored
The manifest was not updated to the proper location of the select to speak options page. This fixes the page by adjusting the manifest. Bug: 1062198 Change-Id: I5f40fe51ffa09f49e23b0500ad0954d039b07d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106962 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750983}
-
Victor Costan authored
The crash in the associated bug has been tracked down and fixed. This CL cleans up the CHECK used for tracking. Bug: 957651 Change-Id: Ie726c01602bddf78807d3b4f2ce03e6eb81aeddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106826 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#750982}
-
David Van Cleve authored
The experimental Trust Token API (https://github.com/wicg/trust-token-api) comprises three operations: issuance, redemption, and request signing. State for redemption and signing is scoped by top-level origin and, as a consequence, we want it to only be available to nested frames with permission from the main frame. This change helps implement this behavior by adding a Feature Policy feature for token redemption (and signing, which is closely related) and passing the feature to URLLoaderFactoryParams, whence the Trust Tokens logic in the network stack will be able to access the state during request handling. Bug: 1042962 Change-Id: I3369a18bdfd53538a47dcaffa79077a5df6966c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085121Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#750981}
-
Victor Costan authored
This CL replaces direct DOMException construction with V8ThrowDOMException::CreateOrEmpty(). No functional change is intended. Bug: 729800 Change-Id: Id3428ee2e8b662862047bb6e75748d26fadc01b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107158 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Robert Sesek authored
This adds the MessagePumpMacTimerInvalidation feature to control whether or not the MessagePumpMac's CFRunLoopTimer invalidation hack is enabled. This will be used to A/B test its efficacy, now that MessagePumpMac has switched to DoSomeWork(). Bug: 925998 Change-Id: I1e62d3a679c7590f4674a8d0f44b936b82856534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036394Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#750979}
-
Alexander Cooper authored
This metric is only used to record the availability of the OpenVr runtime. Rather than expand it to cover the other supported runtimes, it is being removed since this information would not be used to drive any decisions. As a bonus, removing it simplifies refactors to XRRuntimeManager for it to move to content. Bug: 1031622 Change-Id: Id0fbaa57abd4c2115921f3f3c23781aa099989ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106456 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#750978}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c1e52741a15b..42d02fb84d56 git log c1e52741a15b..42d02fb84d56 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 dproy@chromium.org [trace viewer] Speed up selection Created with: gclient setdep -r src/third_party/catapult@42d02fb84d56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: crouleau@google.com Change-Id: I8901d802ab805544f00f7509ce9175c1ea7742ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107280Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a17558c9f702..1facd5e8d114 git log a17558c9f702..1facd5e8d114 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 brianosman@google.com Make persistent cache serialization safer Created with: gclient setdep -r src/third_party/skia@1facd5e8d114 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1062018 Tbr: egdaniel@google.com Change-Id: Ifb1d27eef81e0bf2dd86a1c6f3940cf141004454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107282Reviewed-by:
-
Yury Semikhatsky authored
ServiceWorkerDevToolsAgentHost now stores thread-safe reference to ServiceWorkerContextWrapper instead of ServiceWorkerContextCore that could be deleted asynchronously on the service worker core thread. WorkerDestroyed notification is now sent to the observers of ServiceWorkerDevToolsManager iff the worker version is both stopped and doomed. Each worker can be terminated (and restarted) multiple times and will result in a sequence of targetCrashed/targetReloadedAfterCrash events in the protocol but the instance of its ServiceWorkerDevToolsAgentHost will survive restarts and all connected sessions will be preserved. It fixes the events generated in the protocol for service workers from targetCreated, (detachedFromTarget, attachedToTarget, targetReloadedAfterCrash)* to targetCreated, (targetCrashed/targetReloadedAfterCrash)*, targetDestroyed and avoids inadvertent session terminations when workers are stopped and also spurious targetReloadedAfterCrash events. Bug: none Change-Id: I1125604d08b7842f7f8d74751091193b9af2cb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099590 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750975}
-
Avi Drissman authored
Remove code from Chrome that works around Keystone bugs that were fixed long, long ago. In addition, remove a reference to a feature request in Keystone that was WONTFIXed long ago. Bug: b/2285921, b/2289908, b/2290009 Change-Id: I5eb3f6ee4f4eb79366e5c86c3eed20971d379376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106875Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/620bed1c71a4..95e01a220bc7 git log 620bed1c71a4..95e01a220bc7 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 danilchap@webrtc.org Overwrite dti for vp8 screenshare forced key frame Created with: gclient setdep -r src/third_party/webrtc@95e01a220bc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I90284fb4cbc4ee3eb9aa6f1615a4bf353b6e52c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107281Reviewed-by:
-
Ryan Sleevi authored
macOS 10.15 limits the maximum validity of locally trusted certificates to 825 days, documented at https://support.apple.com/en-us/HT210176 This updates the test certs that interact with the macOS APIs to meet that requirement. In doing so, the CRLSet logic is also updated to be able to create fake CRLSets during testing for serials with the high bit (0x80) set in the first byte of the serial. These have a leading 0x00 in the actual encoded form, to ensure they're positive INTEGERs, while the CRLSet logic expects that leading byte to be stripped for the internal representation. Bug: 1061024 Change-Id: Ie225545b493550cac7e007c0978e843af3b52a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103370Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750972}
-
Xianzhu Wang authored
In a followup, we will check such circles in make_runtime_features.py. Bug: 1061443 Change-Id: I6ab5d87fc9023e8086067a2019322aeb52be4d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104016Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750971}
-
Becca Hughes authored
This is a reland of c5b00d82 Original change's description: > [Media History] Fix watchtime recording > > Media History does not always record watchtime > because the callback might be called after > the WebContentsObserver has been destroyed. > This moves it to WebContentsDelegate and adds > some tests. > > BUG=1051176 > > Change-Id: Ic60066535e3039cee07b2d0994c97e0279bd36e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051289 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749888} Bug: 1051176 Change-Id: I365af299c128d5c68e8387ff55691614da82be71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105404Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#750970}
-
Colin Blundell authored
The current mechanism via which WebLayer intercepts navigations in order to handle launching of external intents is based on WebView's. It turns out that this mechanism (ContentBrowserClient::ShouldOverrideUrlLoading()) was added only due to specific complexities in WebView. It is not the mechanism used in Chrome, and as WebLayer does not inherit WebView's complexities here, it is desirable to instead use Chrome's model for intercepting these navigations. This CL changes WebLayer to follow that model, which is a NavigationThrottle-based approach. As part of this change, we also adapt //weblayer's ExternalNavigationHandler.java where necessary to more closely follow the //components-level that //chrome uses. The current WebLayer logic for determining when to override the navigation (which was also adapted from WebView) is preserved with two exceptions: 1. The current short-circut out if the navigation is not a redirect and is either browser-initiated or a back-forward navigation is changed to be a short-circuit out if the navigation is a back-forward navigation. The reason is that this simplified check follows what //chrome does; nowhere in //chrome's InterceptNavigationDelegateImpl or ExternalNavigationHandler does it check anything about the navigation being browser-initiated, and its ExternalNavigationHandler short-circuit on back-forward navigations does not check whether the navigation is a redirect. 2. There is no longer any check against the request method. Again, in //chrome's navigation interception there is also no such check. These minor changes were made in light of the overall goal of moving WebLayer's logic for intent launching to follow Chrome's; WebLayer will *share* this logic (including these checks) once it is using the //components-level ExternalNavigationHandler rather than the current custom one. This CL also will enable WebLayer to easily adapt (and potentially share) logic in //chrome's InterceptNavigationDelegateImpl.java in followup work. I verified manually that basic intenting out of WebLayer works after this change. Change-Id: I2ca54a802430496f9b9852e7a024eb979c49c93b Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102652Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#750969}
-
Wez authored
Using the AudioCapturer_TestBase allows the TestAudioCapturer to compile even if new APIs are added to the AudioCapturer API, and reduces the amount of boilerplate for APIs which are not expected to be called. This is required in order to unblock the next Fuchsia SDK roll. TBR: sergeyu Bug: fuchsia:48420, 1047390 Change-Id: I15ccc2c50bba2ea6bd30d2508b5d7e6e668d73aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106582 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#750968}
-
Alice Wang authored
This CL replaces ChromeSigninController with IdentityManager in PasswordManagerLauncher. Bug: 1049613 Change-Id: I4d6fc91bbc2a41dad0fa97ac1ddb212f02e9a5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043883 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/24de19ebe70e..c19ea32ca5dd git log 24de19ebe70e..c19ea32ca5dd --date=short --first-parent --format='%ad %ae %s' 2020-03-17 tvanderlippe@chromium.org Fix protocol generator formats 2020-03-17 szuend@chromium.org Properly handle asynchronous update delegates for LiveLocations 2020-03-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-17 tvanderlippe@chromium.org Reland: Move ContentProvider.js and StaticContentProvider.js to text_utils. 2020-03-17 jacktfranklin@chromium.org Add tsickle as a node dep Created with: gclient setdep -r src/third_party/devtools-frontend/src@c19ea32ca5dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idaf9e69dddcf4969447450e443cacd12f325b99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107279Reviewed-by:
-
Delan Azabani authored
DeprecatedEqualIgnoringCase (“DeprecatedEqual”) returns true iff the two given strings are equal under non-Turkic case folding (full iff both strings are 16-bit, simple otherwise). DeprecatedEqual was deprecated in favour of EqualIgnoringASCIICase or EqualIgnoringUnicodeCase [1]. The former is usually the appropriate choice for web platform features that need to check for equality with a constant keyword. This CL migrates a significant subset of DeprecatedEqual calls: those where one of the arguments is an 8-bit literal, containing only ASCII, defined (or ought to be defined) somewhere in the HTML specification. Unlike the last three patches against the same bug, these changes come with web platform tests. This is because they’re author-facing and the values contain the letter “s”, one of the four ASCII characters whose equivalence class would change when switching from simple non-Turkic case folding to ASCII insensitivity [2]. The engine changes are a curated subset of the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"]|(?&escape))*"){0} (?<any>(?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*+(?: (?&literal)\s*,\s*+(?&any) |(?&any)\s*,\s*+(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/* Replace: EqualIgnoringASCIICase$5 [1] https://codereview.chromium.org/2811793004/patch/1/10109 [2] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt Bug: 627682 Change-Id: I5f4279a3f6957d3604357df5da7c67ff2bdcdb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032655 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#750965}
-
Domenic Denicola authored
This implements the algorithm at https://wicg.github.io/origin-policy/#parse-an-origin-policy-header along with supporting data structures to represent the parse result. The parsed header is not yet used by any part of the system, and so these changes are not web-exposed yet; that will be done in a follow-up. Instead the parser has a lot of unit tests. Bug: 1042036 Change-Id: I3b0e117ee9af352fc30b9e63906caf4e98d44b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099082Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750964}
-
Dave Tapuska authored
To be used elsewhere move the definition of the enum to a new header file. Change-Id: I2c79077417273ab5cfcf7ab2ac1e7180545ec293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106241Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#750963}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 64330518. With Chromium commits locally applied on WPT: acbe6d96 "Add timeouts for EventWatchers on CSS animation tests" 6a942cea "[WPT/upgrade-insecure-requests] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1048 and retry the command." 1bb259bc "[WPT/referrer-policy] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 8469 and retry the command." 168319dc "[WPT/mixed-content] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1397 and retry the command." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I34eb6520d4ddd98589027f6928dc4777cb6faec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107393Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750962}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26596343..17637854 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ee79609a00da9a58af4ca69f8b26dace731640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106318Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750961}
-
Kevin Ellis authored
A cancel event must be dispatched as soon as an animation is canceled. Otherwise, an immediate restart will drop the canceled event. This patch addresses the remaining source of timeouts due to dropped transitioncancel events. Support for animationcancel events will be introduced in the next patch. Bug: 1059936 Change-Id: I3f6b306a0199febe62cfe151a414990796886402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107299Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#750960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58bd5d914210..9b395cb8769a Created with: gclient setdep -r src-internal@9b395cb8769a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If32b10251e9ce791a46043241fd6b295c4838a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107277Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750959}
-
Miguel Casas-Sanchez authored
Change-Id: I83fdba6177e08277180380f1ba3dc546ea12f7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105556 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Include gaia_auth_host:browser_tests only if include_js_tests flag is true. Bug: 1061915 Change-Id: I25afe8abd9a94142658d91d916b678663f6a42f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106175Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#750957}
-
Cammie Smith Barnes authored
When an HTMLImageElement is created by an ad script, if async ad tagging is enabled, the HTMLImageElement will be tagged as ad-related. When the image finishes loading, the HTMLImageLoader will check the ResourceRequest via the ImageResourceContent and ImageResourceInfo to see whether the resource was tagged as an ad resource. Eventually we would like to expand the ad-tagging functionality to some other types of elements, notably HTMLDivElements. Tests: blink_unittests --gtest_filter=*ImageLoaded*Async* Change-Id: I5c6115f0b0be180a4647389096983378191cd0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031086Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#750956}
-
Sorin Jianu authored
Updating and committing prefs must happen on the same sequence while the thread pool is still active. This CL introduces an updater::App::Uninitialize virtual to provide a call site for committing prefs and possibly other code that needs to run when the updater process is shutting down. BUG: 1061730 Change-Id: I0c293ced0e5c3ce66f921d1d65062de89f78bfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103755Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750955}
-
Vasiliy Telezhnikov authored
This CL is follow-up to refactoring that allowed SkiaOutputDevice to provide additional semaphores to be submitted at flush time. Before this CL SkiaOutputDeviceVulkan had special pass to submit additional semaphore that can be used for presentation. This CL moves it to GetEndPaintSemaphores to unify code paths. Bug: 1043114 Change-Id: I88092bb0d61ceec9108ab4e9275569af44fa80d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101305Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#750954}
-
Nate Chapin authored
Bug: 1209822 Change-Id: I5aef8983d84ea517aef14134c9d657479dc72e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106533 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750953}
-
Antonio Gomes authored
This CL is the final effort in order to unify both media_devices.typemap and media_devices_for_blink.typemap definitions. BUG=704136 R=guidou@chromium.org Change-Id: I4a004f08eb863984c82d63e23c84dd4884fa7f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105795 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#750952}
-
Brian Liu Xu authored
Implements support for |kIgnored| in |AXVirtualView| so that elements with role or state |kIgnored| are hidden from the accessibility tree without affecting their contents. When an element has |kIgnored| set, that means that its accessible node should not be exposed to the platform. Thus, the accessibility tree shows its descendants instead of the ignored node. |kIgnored| should not be confused with |kInvisible|. Invisible nodes can still appear in the accessibility tree, and the invisible state is inherited by descendant nodes; they are hidden in the sense that a special state is reported to screen readers that understand it. In contrast, ignored nodes do not appear in the accessibility tree, and the state is not inherited; they are hidden in the sense that they are not exposed at all to the platform. This change is a prerequisite to eliminating the hidden root node of |TreeView| so that screen reader users can access descendant nodes using the review cursor. |TreeView| currently uses |kInvisible| to hide the root node, but that results in the entire subtree becoming invisible to screen reader users. We plan to make a subsequent change to move the root node from |kInvisible| to |kIgnored|. Bug: 811277 Change-Id: I9f30c6cc479c64919d1a3c4397a9455d4f1f1988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103714 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
W. James MacLean authored
EnrollmentRecoveryTest.DifferentDomain and EnrollmentRecoveryTest.Success are very flakey on linux-chromeos-dbg. Disabling for now. TBR=rsorokin@chromium.org Bug: 1062248 Change-Id: I0af356e279721ff964116d1d9bc8ecbd549df51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107301Reviewed-by:
-
Anders Hartvoll Ruud authored
There was a bug in CascadePriority, when creating priorities with a 'generation'. This constructor was supposed to _set_ the generation, not bitwise-or with the previous generation. Bug: 947004 Change-Id: Ie3471f6a3052c0f3ca8454151a8f46839558d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106064Reviewed-by:
-
Maxim Kolosovskiy authored
This CL introduces intent verification of a password change flow in order to be sure that a password change flow is triggered by the password manager. The CL does not introduce a triggering itself. Once the proper intent signing is implemented, the verification should be changed (b/151391231). Bug: 1057608 Change-Id: I3f403589e40b729ac2fd3b514d8b7a1d1a5362ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102731Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750948}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23283eb96876..24de19ebe70e git log 23283eb96876..24de19ebe70e --date=short --first-parent --format='%ad %ae %s' 2020-03-17 tvanderlippe@chromium.org Disable NodeURL unittest 2020-03-17 tvanderlippe@chromium.org Disable BezierUI test 2020-03-17 tvanderlippe@chromium.org Disable persistence unit test Created with: gclient setdep -r src/third_party/devtools-frontend/src@24de19ebe70e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8ae89d1877a240269ca989b0d2af4ac9aad45201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107318Reviewed-by:
-
