- 08 Oct, 2020 40 commits
-
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I235a973162915dc7e6ca817c82f7caa7c001b579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453807 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815319}
-
Xing Liu authored
Keep metric "Download.Database.IsAvailable" which is helpful to detect critical issue in download sqlite db. Bug: 1088728 Change-Id: I63be65de5529a1666dd3edfde9a545279da711b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363668Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815318}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dfd855a10fb..887b1346d5af 2020-10-08 syoussefi@chromium.org Vulkan: Add resolve/unresolve counters 2020-10-08 syoussefi@chromium.org Pass in Command::Clear to framebuffer syncState If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I66993196aeb5e016b1bb6402ce5b113dab2b324a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815317}
-
Rune Lillesveen authored
In order to store tree-scoped names/references in ComputedStyle we need to keep track of which TreeScope the MatchedProperties came from during selector matching. We do this by pushing TreeScope pointers for each scoped to MatchResult which maps to the tree_order number stored in each MatchedProperties entry. This mapping will be used during cascading and stored with the name to create a tree-scoped reference on ComputedStyle. Bug: 336876 Change-Id: I416d9b12276917cb17c368909d3d5fd1b9f4f5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453392Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815316}
-
Peter Kvitek authored
It was previously required to prevent chromium_browsertests from crashing, however, that does not seem to be the case anymore. Change-Id: Ibff440948fe268db0cc0e0f635a5766beb032da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454372 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Auto-Submit: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#815315}
-
Malay Keshav authored
This patch adds UMA metrics to track the stages of HaTS that users go through. This helps keep track of number of users who view the UMA survey. Since Chrome OS uses client side logic to roll dice for survey, UMA metrics is required. Test: Manually Bug: 1134413 Change-Id: Ic4981ab97ba3f1b99a588b5a32279bfca03009d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444511 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815314}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/fc5c5ab60b22..1a63c49b4e86 2020-10-08 dsinclair@chromium.org Update structs to allow multiple decorations 2020-10-08 dsinclair@chromium.org [type-determiner][spirv-writer] Add arrayLength support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: I6661c8561b9b2e511761cf4e0a5c4322389173bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815313}
-
Nina Satragno authored
Wire up the WebAuthn largeBlob extension `write` parameter for navigator.credentials.get. At the moment, no compression for the data takes place. This patch also modifies the code that obtains a PUAToken with UV to pass custom permissions so we can request lbw when needed, and has the virtual authenticator DCHECK that the permissions requested are supported. It is also now possible to obtain a PUAToken using the virtual authenticator even if client pin is not supported. This enables using large blobs on uv-enabled virtual authenticators. Finally, the parameter validation is moved from CredentialsContainer to AuthenticatorCommon so they run in the browser process. This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I390d9e1ef0e378ef28054b168f01e1b9f78e3a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453875 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#815312}
-
Andrey Kosyakov authored
Revert "[Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics" This reverts commit 8711fb9a. Reason for revert: broke Cast Audio Linux bot, https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/87604 Original change's description: > [Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics > > Change-Id: I6067aad3959c054181389c1e1b82e464eacd9a4b > Bug: 1135217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441263 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Yashar Dabiran <yashard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815285} TBR=yfriedman@chromium.org,fdoray@chromium.org,rkaplow@chromium.org,ckitagawa@chromium.org,yashard@chromium.org Change-Id: Iba7597dd7f400b21f3e464c7849d4852a69c1b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461900Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815311}
-
Garrett Beaty authored
No-op jobs no longer exist for dummy builders that are named as mirrors for trybots. Those builders can now appear as mirrors in a trybot config but can't specify a parent builder, so they won't be triggered. No-op jobs continue to exist for tester builders where for whatever reason we do not want to run them on the branches. Change-Id: I0a0f5ac5213ff7aef9e1c7e73730428756f3f2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462236 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#815310}
-
John Lee authored
Bug: 1110405 Change-Id: I6de7525fa89373a5d2be46028865cef06b9508f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454393 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815309}
-
Joon Ahn authored
https://screenshot.googleplex.com/6FwB36oBkNRFgnJ Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id812443e5df2121af05e4ab140fca2b31943d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457590Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#815308}
-
Rouslan Solomakhin authored
Before this patch, multiple locations in Web Payment, e.g., PaymentAppServiceBridge, contained WebContents and RenderFrameHost pointers that could become invalid and be used after free. This patch makes Web Contents store GlobalFrameRoutingId and always retrieve and null check the RenderFrameHost from it. If WebContents is needed and the RenderFrameHost is current, then WebContents is retrieved from the RenderFrameHost. After this patch, Web Payment holds a GlobalFrameRoutingId, so the RenderFrameHost and WebContents can be checked for validity before use. Bug: 1125614 Change-Id: I084a062c2a7cad100a6d2d0994c1b0cc9b9efc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422178 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/823a6df243c3..02a7aa75bb24 2020-10-08 fmayer@google.com Merge "Do not abort profile if main thread stack grows." 2020-10-08 primiano@google.com Merge changes Ic7aa1265,I4d418aac 2020-10-08 treehugger-gerrit@google.com Merge "perfetto-ui: Improve record page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5ef2f250416c30e105339578935f00f32fbc8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815306}
-
Anders Hartvoll Ruud authored
When parsing a simple selector, we currently check after-the-fact whether we followed a pseudo-element, and whether or not the simple selector was allowed to follow that pseudo-element. If the simple selector was _not_ allowed to follow a pseudo-element, then parsing failed altogether. This does not work well for nested <forgiving-selector-list>s, which requires partial failure. For example, ::part(foo):is(.a,:hover) shall behave as ::part(foo):is(:hover) (instead of failing). This CL instead checks for simple selector validity in ConsumeSimpleSelector, by storing a "restricting pseudo element" during parsing of the compound containing the pseudo-element. This makes it possible for deeply nested selectors to fail at the appropriate time and trigger the forgiving behavior. Bug: 568705 Change-Id: Icfb20416c008e37279866a688a525b9419437086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450191 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815305}
-
Daniel Hosseinian authored
crrev.com/782283 caused a regression which caused tracked remote instances of PrintRenderFrame to linger after the completion of a print composite request. Consequently, printing the same WebContents with cross process subframes more than once would cause the compositing to never finish. Bug: 1136431 Change-Id: Id0670905d1b4acb7b55f7a043d5a4bfb584ccfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462178Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#815304}
-
Ken Rockot authored
We generate Equals() methods for struct and union wrapper classes. There's not really a good reason to do this instead of operator==, and operator== plays nicely with gmock matchers. This adds operator== to do the same thing as Equals. Bug: 735302 Change-Id: I4ab8c70aa4ba0276aec7a2f64734c710a090d6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456148 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815303}
-
Akihiro Ota authored
Promote createMockKeyEvent to avoid redeclarations in multiple files. Also use KeyCode where possible. This change is a pure refactor. Bug: N/A Change-Id: I300c3cc0e02fd5610092dd8b39672acb7f96c9b6 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459631 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815302}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test cases no longer need to be parameterized. Bug: 1065748 Change-Id: Iff9b0c04df28b7fe87fb6a3ba1bc131c73cb018a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459512 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815301}
-
Stefan Zager authored
This feature is required for isInputPending. The change to compositing_inputs_updater.cc fixes a bug that snuck in via this CL while the feature was disabled: https://chromium-review.googlesource.com/c/chromium/src/+/2283630 The web_test changes are mostly cases where a test has a cross-origin iframe which was not previously composited, and making the iframe composited caused anti-aliasing differences. The mhtml/ test changes are needed because chromium treats the iframes in the encoded-html test files as cross-origin; to ensure consistent text rendering, this CL forces everything in both the test files and the ref test expectations to be composited. BUG=930987 Change-Id: I8f54eeacd333e46f394c08e9bf8366f0e9e2e57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443630 Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815300}
-
Collin Baker authored
The thumbnail scheduler implementation introduced a bug: each time a ThumbnailImage is observed, ThumbnailCaptureDriver will recapture the thumbnail even though it already has a good final capture. This CL fixes the regression. Fixed: 1136247 Change-Id: I825632157802eda70656f9fdb4376942b5febe15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459627 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815299}
-
Will Harris authored
This histogram was no longer being looked at, and had already expired. BUG=1130738,1066103 Change-Id: I9c49879315d8b3296adea1571460f2d68e4befb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458887Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#815298}
-
Wei Li authored
Bug: 772945 Change-Id: I8b5af781812a7baaae83cd59371d67528a3c1a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458812 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#815297}
-
Daniel Libby authored
This adds configs for a manually-triggered trybot that runs release blink_web_tests with --force-renderer-accessibility, in order to start stabilizing serialization/deserialization code for all the content tested by the entire web_tests suite. See corresponding tools/build cl landed here: crrev.com/c/2454398 Bug: 1135251 Change-Id: Ic9db4673a3bf580225864f1aa6b1da6a6e682793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453446Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815296}
-
ckitagawa authored
Improve detection of if a true cold start is happening. If start surface is shown then we should omit cold start metrics as in that case these metrics don't accurately reflect performance regressions. See bug for UMA histograms showing the effect. Bug: 1135566, 1135651 Change-Id: I99bab63f4e4fa3e34133bbe73718520164ff6355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450921 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815295}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8e70787..2a63e856 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib958c21ca94f1ee70ea539a0c392a9f20d8bd11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460798Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815294}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602158210-9de918de8f612323e79e5b6447a9374f3934b014.profdata to chrome-mac-master-1602179909-33e9e654a138340f2ff74cc84be2567f323eeba5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8eae64b862fa2fbe3ee4c3e27341a77ca33395ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815293}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/a5548b3d5782..7c2e104ffbe4 $ git log a5548b3d5..7c2e104ff --date=short --no-merges --format='%ad %ae %s' 2020-10-08 junyer Refactor the RE2::Arg templates for readability. 2020-10-07 junyer Rename namespace internal to namespace re2_internal. 2020-10-07 junyer Address `-Wunused-parameter' warnings. 2020-10-07 junyer Add missing #include. Mea culpa. 2020-10-07 junyer Rework RE2::Arg with templates instead of macros. 2020-10-06 junyer Write `typename' in templates rather than `class'. 2020-09-27 junyer Fix some indentation. 2020-09-27 junyer Set BAZELISK_GITHUB_TOKEN. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I9586928913e614e57ed45e6b56b3d05ac66e0b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460974 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815292}
-
Sylvain Defresne authored
The metrics "Tabs.TabCountPerLoad", "Tab.PageLoadInPortrait" and "Tab.PageLoadInPortrait" stopped being reported in M87 after the refactoring introducing WebStateListMetricsBrowserAgent. Change WebStateListMetricsBrowserAgent to observer WebState in order to properly report the metrics when navigation event occur. Unit test to prevent such regression will be added in a separate CL to simplify cherry-picking this CL in M87 branch. Bug: 1135129 Change-Id: I589aeabdcc058e8dcd6547c44080aebe4d8a8fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461332Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815291}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87d384c09451..ed49e44caa34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:170126006 Tbr: caseq@google.com,tluk@google.com Change-Id: I2bb06a6f55664aadbfd7e5cb68c668b8ff14896b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462141Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815290}
-
Oriol Brufau authored
r789122 tried to solve bug 1103592, which actually was a flex problem unrelated to grid, and was later fixed by r782793. Therefore, r789122 wasn't actually needed, and caused a perf regression. So this patchs reverts its layout changes. The WPT test is kept, and still passes. Bug: 1136474, 1103592 Change-Id: I3788bee4035a43c99b224d39d6f496b6e3dea4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461311 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#815289}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I97ea8f5547f25628e5143f9dafe34451f98d6043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462238Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815288}
-
Darwin Huang authored
Replace all uses of whitelist with allowlist, and all uses of blacklist with blocklist, in //ui. Bug: 842296 Change-Id: Idf44bd9c4c9c78bf5bce1595b1c0dc323e70668a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458368 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815287}
-
Collin Baker authored
Reorganizes New Badge and IPH for Tab Groups into one study to match the associated Finch study. Additionally removes DesktopTabGroups since it is launched. Bug: None Change-Id: I09203587e18f82e3ddd51ebbe4a61c48d5ce4973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459787Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815286}
-
Yashar Dabiran authored
[Paint Preview] Split PaintPreviewCompositor memory metrics from the general Utility process metrics Change-Id: I6067aad3959c054181389c1e1b82e464eacd9a4b Bug: 1135217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441263Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815285}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test case GenerateAppForLink no longer needs to be parameterized. Bug: 1065748 Change-Id: I1893b45f7183ccb24c51149c7189aed62751fa5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459256 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#815284}
-
Eric Willigers authored
OpenInAppAbsentForURLsInNonLocallyInstalledApp was flaky. We re-enable the test, after addressing two causes of test flakiness: - https://chromium-review.googlesource.com/c/chromium/src/+/2454920 - https://chromium-review.googlesource.com/c/chromium/src/+/2454811 Bug: 1119807 Change-Id: Iee88737a8bf5545358fa63bce3a5ceee65330426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459134Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815283}
-
Kartik Hegde authored
Add GetRandomAndFixedHostsWithScheme() which will be used by network diagnostics routines. TEST=none BUG=chromium:956783 Change-Id: Ia5073701ce97786e8ce5676a3db3444ef36b72c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459513Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#815282}
-
Eric Lawrence authored
We should show an indicator in the NetLog tab title to help remind users that their browsing traffic is being recorded. Change-Id: Ia1d2fb5b25c43d39084518656a79884f6149d3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460856 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815281}
-
Henrique Nakashima authored
DefaultTabModelSelectorFactory remains in glue code, binds together features to create a TabModelSelectorImpl. TabModelSelectoryFactory is an interface that is moved into the c/b/tabmodel module. Bug: 1112922 Change-Id: I03e52fd438da7f7f89a7be012115d053a121c4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446352 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#815280}
-