- 01 Aug, 2020 16 commits
-
-
Miyoung Shin authored
This is a reland of 75391394. Reason for reland: - Fixed a flaky test failures in crrev.com/c/2309317 - No changes in this CL between original & reland. Original change's description: > Convert WidgetMsg_WaitForNextFrameForTest to mojo > > This CL uses VisualStateRequest Mojo API in FrameWidget mojo interface > introduced at https://crrev.com/c/2178480 since > WidgetMsg_WaitForNextFrameForTest has the same implementation with > VisualStateRequest Mojo API notifying that the frame swap has occurred. > > Bug: 1071588 > Change-Id: If317b98320ec3fb85fcf7a5d1e39f0fa202d4cde > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216145 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789910} Bug: 1071588 Change-Id: I7ade2819495cddf87862054095db361e0511dcf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309497 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#793839}
-
Connie Wan authored
In order to prevent group IDs from getting split across windows, we need to change the way grouped tabs are restored: rather than restoring into their original windows, they prioritize restoring into their original groups. If the original group does not exist in any window, the tab will follow the same restore behavior. Bug: 1098439 Change-Id: I508587d1eaf7dfe6ef4320fc75f879c03230c58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326632Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#793838}
-
David Van Cleve authored
This change expands the Trust Tokens browser tests to cover additional issuance cases: issuance to issuer with no keys -> expect error issuance, server-side error -> expect error cross-origin issuance -> expect success cross-site issuance -> expect success issuance with number of associated origins at cap -> expect success iff the issuer is associated issuance after keys expire -> should fail cors mode issuance to origin A, redirect to origin B -> obtain origin B token no-cors mode issuance to origin A, redirect to origin B -> obtain origin A token Subsequent changes will add more redemption and signing tests. Bug: 1071293 Change-Id: Id5c0e86fc889551f366db0555d25a6f253f902c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308860 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#793837}
-
Peter Kasting authored
Looks like generate_def_files.py didn't get re-run the last few rolls. Perhaps this will help the broken win32-archive-dbg bot? NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: none Change-Id: Ic2bb5e5eb0ebf3dd5c99c1c25dfd45a5649d4a44 TBR: danilchap Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333381Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793836}
-
Sanket Joshi authored
Many color picker tests run close to (and sometimes exceed) the 60s timeout limit on MSAN builds. These tests are more involved than the tests written for other popup-based controls, such as the date picker and time picker, therefore it is expected that these tests will run slower. To avoid timeouts on the MSAN trybots, this change tags the color controls tests slow. Bug: 2316826 Change-Id: I362078fc1b9d0078a942ba9215632bdf9771cf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330086Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793835}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/828c1805a64b..8eec09fbdd2b 2020-07-31 tmathmeyer@chromium.org Add Download button to right click menu If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:711793 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3d0c08148d6d0c5d69026efb0d0d79e8205520ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793834}
-
Anne Lim authored
Bug: 152444825 Change-Id: Iee49adab138a9fac64f47ddced64b75f4d6a5183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333529 Commit-Queue: Anne Lim <annelim@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#793833}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596193635-02bce97a1becd63464acfea57c5b1e9a80097f4f.profdata to chrome-win64-master-1596218359-57a19df5d5114cb0d95f98687970c851e5ff6452.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1b656998b9fd0c9cec095fed2b1e52b5e2c54f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333332Reviewed-by:
-
Nate Fischer authored
No change to logic. This swaps java_ref.is_null() and java_ref.obj() for boolean conversion where reasonable. This leaves a couple references to is_null() when a boolean value is necessary outside of an "if" expression (this is to avoid a static_cast). Test: autoninja -C out/Default system_webview_apk Test: run_android_webview_unittests -f InputStreamTest.* Change-Id: I9f3329223b44fdb5b2f9216d0a38823999bb8632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332687 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793831}
-
Darwin Huang authored
Change-Id: I5da5e7e66f08590e2c6ce592be70d017bdbbd6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331639 Commit-Queue: enne <enne@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#793830}
-
Daniel Classon authored
Modify beforeDeepLinkAttempt to return whether or not attemptDeepLink should try to showDeepLink. This allows pages like the Internet Page to manually deep link in beforeDeepLinkAttempt and halt execution before showDeepLink reaches an error. Updated bluetooth subpage method. Bug: 1084154 Change-Id: Ic9923f32317ebdb21f3e2b5e0842b89a2a9d7887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333367 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793829}
-
Long Cheng authored
Add lgcheng to owner file of app_shortcut Change-Id: I83c5f28642014ad869a77270400ce1e38819d5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333527 Auto-Submit: Long Cheng <lgcheng@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#793828}
-
Dominic Mazzoni authored
Page popups include the <select> element popup menu and <input type=date> expanded date picker. Page popups are a bit of a special case in Blink accessibility. They have their own document, but we attach them directly to the same accessibility tree as the host document. That means there are two nodes with role=rootWebArea in the tree. We could consider making them separate accessibility trees like iframes, but that would make relationships like aria-controls or aria-activedescendant difficult. This patch fixes a bug in the computation of bounding boxes inside a page popup by taking the relative position of the popup window compared to the host browser window into account. Bug: 1110367 Change-Id: I75e936dd0ccf0f2a2a508eee3ff95c1d5e47816d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332046Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793827}
-
Stephen Roe authored
Bug: 1111544 Change-Id: Ib755c3598aee90665c7f9927d623d143b99c82e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330322Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#793826}
-
Matt Menard authored
In order for PrintServersProvider to be reusable for device policies for setting external print servers, everything related to a user profile needs to be abstracted, thus setting the allowlist and prefs is moved to the ServerPrintersProvider. Bug: b:152908910 Change-Id: I15543454cac6cec1f8d525374e9d8955fa71b689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226301 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793825}
-
David Tseng authored
Speculative fix. TBR=dtseng@chromium.org Fixed: 1111575, 1111686 Change-Id: I9ca440bb371f1ee50cb6d94d2b985c913b36a446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332561Reviewed-by:
-
- 31 Jul, 2020 24 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3dcdde92..5e336253 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6082b01a2a9e359344cc01a7721dbdfb37a2c206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333406Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793823}
-
Jun Mukai authored
When setting the display rotation to kAny (i.e. reverting back to auto-rotation in tablet-mode), it can't say which orientation should be expected. RotateAny supports such situation. See also crrev.com/c/2327175 Bug: b/161253230 Test: tast arc.WMNonresizableTablet arc.WMResizableTablet Change-Id: I2ddc6cbc7f45d002539b9708d1386ec037b70814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327311 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793822}
-
Matthias Körber authored
Disabled test due to a P1 flakiness bug. TBR: wychen@chromium.org Bug: 1111696 Change-Id: Ie6182685d845899c4d8b11b928c1a07ecf9c22e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332440Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#793821}
-
Evan Liu authored
This CL updates the kSpeechRecognition sandbox on Windows to allow the loading of the Speech On-Device API (SODA) DLL. Bug: 1111079 Change-Id: Iddfb74210e55033cb31a783119933592e800e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327469Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Devlin Cronin authored
It has been successfully replaced by WebContentsObserverDelegate (which provides more information, and doesn't require setting the delegate of the target WebContents). Bug: 1034150 Change-Id: I88a9fe666b11d4338be3ea32446bbfc78a23eba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333064Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a683c88a211..fcb7ba035aae 2020-07-31 zepenghu@google.com updated skp fuzzer 2020-07-31 johnstiles@google.com Avoid passing gradient-layout Y coordinate to colorizer. 2020-07-31 herb@google.com specialize addGlyphToAtlas padding to bilerp case 2020-07-31 brianosman@google.com SkSL: Disallow fragmentProcessor variables in several places 2020-07-31 borenet@google.com Remove some non-inclusive language in recipes 2020-07-31 scroggo@google.com Remove "sanity"/"insane" to comply with Android's inclusive language guidance 2020-07-31 scroggo@google.com Remove "dummy" to comply with Android's inclusive language guidance 2020-07-31 jdapena@igalia.com GCC: fix type passed to vcvt_f32_f16 to be a float16x4_t in SkVx.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491,chromium:162536543,chromium:819294 Tbr: borenet@google.com Change-Id: I58bc7f0ed262febe25ae7bc286ba73246f2f5640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332855Reviewed-by:
-
Devlin Cronin authored
Use WebContents::GetLastCommittedURL() in ExtensionWebUI, rather than WebContents::GetURL(). Since the call is using the URL to determine whether a reload is necessary (if the controlling extension was unloaded), the committed URL is correct. Bug: 237908 Change-Id: I34ef7be05710d64cf00aa9ae444407735ce11855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327890 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793817}
-
Miyoung Shin authored
If WebUI's JS is sending the message when we navigate cross-site, then we use the new process ID from WebContents in WebUIImpl::CanCallJavascript and a CHECK crash will happen. This CL changes to use the old process ID from RFH in WebUIImpl::CanCallJavascript. Bug: 1110276 Change-Id: Ie827060b637dbd3aa4c7ad771c0cb4862763ced2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326050Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia184a139fb2e688e1a16ad006ee398d42dc7af5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332984Reviewed-by:
-
Evan Stade authored
Dismiss the OSK before entering fullscreen. Otherwise, the tap that enters fullscreen also dismisses the OSK, and there could be a race between how those two actions affect the page height. I was unable to reproduce the flake so this is a speculative fix. Bug: 1107651 Change-Id: I92e3bb502305fa9468e5639d6411f6a6ecb0ba90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333058Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22b8657a5558..39c302bccf3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I07ffa68ea19aa71569ad5fb1e5ea55efdc70c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332981Reviewed-by:
-
Robbie McElrath authored
This CL makes the native TabImpl delegate its WebContentsDelegate:: GetTopControlsMinHeight/ShouldPinTopControlsToContentTop overrides to BrowserControlsContainerView instead of keeping its own copy. This makes these fields easier to reason about as there's only one copy of them and allows BrowserControlsContainerView to more easily modify them if needed. Bug: 1109035 Change-Id: Iedf6d40b85a3c2f5628ee3280bdd4ab287486285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330993Reviewed-by:
-
Ken MacKay authored
Bug: internal b/153672783 Change-Id: Iae40aeb3f2d5a0b5aa56ad70af3057fd1d4e0093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332326 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793811}
-
Haiyang Pan authored
AVD is generated by https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/68 This AVD includes the changes from crrev.com/c/2146136 and crrev.com/c/2321088 Bug: 1093602, 1110997, 1105697 Change-Id: I9f53cd4de196a4fd68c9df409dbf54080a9300a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333227Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#793810}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7e3ad79800a7..0241a1304fd1 $ git log 7e3ad7980..0241a1304 --date=short --no-merges --format='%ad %ae %s' 2020-07-16 jonathan.wright Fix file path manipulation on Windows 2020-07-15 jonathan.wright Fix header dependency chains in BUILD.gn file 2020-06-30 jonathan.wright Fix guard for unit test target 2020-06-29 jonathan.wright Factor common gtest utility code 2020-06-29 jonathan.wright Move gtest files to separate folder 2020-06-21 jonathan.wright Add gtest wrapper for djpeg tests 2020-06-21 jonathan.wright Refactor djpeg.c to provide test interface 2020-06-23 jonathan.wright Add gtest wrapper for jpegtran tests 2020-06-27 jonathan.wright Add input JPEG images for djpeg and jpegtran tests 2020-06-23 jonathan.wright Refactor jpegtran.c to provide test interface 2020-06-16 jonathan.wright Add gtest wrapper for cjpeg tests 2020-06-21 jonathan.wright Refactor cjpeg.c to provide test interface 2020-06-19 jonathan.wright Write tjunittest output files to sdcard on Android 2020-06-12 jonathan.wright Move tbench logs from stdout to stderr 2020-06-12 jonathan.wright Add gtest wrapper for tjbench tests 2020-06-12 jonathan.wright Reinstate upstream test image data files 2020-06-12 jonathan.wright Refactor tjbench.c to provide test interface 2020-06-11 jonathan.wright Move tjunittest logs from stdout to stderr 2020-06-11 jonathan.wright Add gtest wrapper for tjunittests 2020-06-11 jonathan.wright Refactor tjunittest.c to provide test interface Created with: roll-dep src/third_party/libjpeg_turbo Bug: 993876 Change-Id: I6c1bfb77b0209b4882547477c1101227ad0d9613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299746Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#793809}
-
Josh Nohle authored
Add factory pattern to Nearby Share certificate storage, and create fake implementation. This will help in unit testing for classes that use certificate storage. Bug: b/154865267 Change-Id: I2d310edb4d0726e2cb0fe387dc57543ee81f59e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329885Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793808}
-
Alison Maher authored
This change sets up the basics of handling break tokens for fragmented OOF positioned elements. We are currently starting layout for these elements in the first fragmentainer every time. The unit tests that were added reflect this. However, more complex tests will need to be added once we start to position these elements within the correct fragmentainer. I also realized that I had updated the incorrect constraint space in my previous change: http://crrev.com/c/2274246. As such, this change cleans this up and sets up the correct constraint space for fragmentation. abspos-after-break-after.html and mixed-positioning-stacking-order.html are now crashing because the OOF element in the tests fragments beyond the last fragmentainer in its fragmentation context. This is a known issue, and a TODO was added to handle this. static-becomes-relpos-has-abspos.html is now crashing because we are not skipping over spanning fragments when adding OOF elements. This is a known issue, and a TODO was added to handle this. Bug: 1079031 Change-Id: I6e4fed3a49a0f6d9b4ccd939689580227dbc6df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316885 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793807}
-
Xianzhu Wang authored
This CL addresses the following issues of layout shift tracking: - Changed visual overflows triggered layout shift report (originally filed as crbug.com/1090763). - Descendant layout overflows were not included in ancestor's layout shift report. - Unnecessary descendant layout shift report. - Slow visual rect calculation for LayoutInline and LayoutText. It includes the following changes - Track LayoutBoxes and LayoutTexts only. - Track both old and new starting points and visual representations instead of using location of visual rects as starting points. - For a LayoutBox, the local visual representation is the layout overflow rect if the LayoutBox has layout overflow and doesn't clip overflow. Otherwise use the border box rect. - For a LayoutText, suppose its shift causes shift of all contents in containing block logically below the LayoutText, and use that part of visual representation of the containing block as the visual representation of the shift. - Map both local starting points and local visual representations to the initial containing block and viewport. This has the following benefits: - More accurate starting points and visual representations, conforming to the specs; - Better performance by * avoiding unnecessary layout shift reports of descendants * avoiding slow LayoutInline and LayoutText visual rect calculation. - sizeof(LayoutObject) is reduced by 16 bytes because now we use the previous geometry data in LayoutBoxes for paint invalidation. Bug: 1108622 Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793806}
-
Moe Ahmadi authored
The mojo definitions are located in chrome/browser/ to be accessible by Desktop and Android. A desktop implementation of the handler interface is added which will be bound to the NTP JS in a followup CL. For more information see go/promos-deeplinking-settings Bug: 1106421 Change-Id: Iae8fa63f8464ca2ecd4e45d611537cae1ed94dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327852 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#793805}
-
David Bienvenu authored
On Windows, Chrome doesn't generate a synthetic mouse exit event, see crbug.com/394672. Change-Id: I1b8ae0e43061f2c555c317cfd1f2f683b79db738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316843 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793804}
-
Matthew Denton authored
Turn the CertVerifierService on by default in non-Chrome branded builds for desktop platforms. Bug: 1015134, 1094483 Change-Id: I853155582dde092c39ab1975a0b8081eed994600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324643 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Brian Malcolm authored
This is intended to replace the NoteTakingAppsLockScreenWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1095910 Change-Id: I24c36696091a1a1af3cb125e6521ff709ee4b49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330436 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793802}
-
Abigail Klein authored
When live caption is enabled for the first time, it kicks off downloading the on-device speech model, called SODA. This CL gives the user a progress update as the model is being downloaded. The accessibility settings page webui observes component updater events and sends a localized string containing the percent downloaded to the accessibility settings polymer client to be displayed. This CL also updates the text of the Enable Live Caption messaging according to the latest UX spec. This CL does not make any changes to the ChromeOS settings page. If there is an error when downloading, display an error message and toggle the live caption preference off. Screenshot (red arrow points to the progress update change): Default: https://screenshot.googleplex.com/aSqiAypyGW7 Progress update: https://screenshot.googleplex.com/fH5kxpYE8p5 Error message: https://screenshot.googleplex.com/q3XSUO3EzOZ Bug: 1055150, 1105686 Change-Id: I519a7166cf8543206db2ebd4c8301ac16499ae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310784 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793801}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic98b86ed2de34eeb676aa45d6fdfffafe54d2f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333287Reviewed-by:
-
