- 15 Jun, 2018 30 commits
-
-
Rohit Rao authored
Adds a new image and view spacing when the UIRefresh experiment is enabled. Adds Dynamic Type support as well. Legacy: https://drive.google.com/file/d/1UIIDcwMcpcG-N7-AKox94UtQErhiy1ip/view Refresh: https://drive.google.com/file/d/1hrP-Cgrm1jdaK0K6BM-P-ytMMxBplwlX/view BUG=805166 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9b4ba4aac10b0b91ff38b127bf978db4ee93639d Reviewed-on: https://chromium-review.googlesource.com/1099415Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567521}
-
Yoichi Osato authored
This patch rebases image expectations for - fast/writing-mode/japanese-lr-selection.html since they are styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I015c144effcba7ef57f24d475607f372c3a46a70 Reviewed-on: https://chromium-review.googlesource.com/1100374 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567520}
-
Stuart Langley authored
UMAs already existed for full and directory fetch, so just added a new histogram for TeamDrives. Added UMA for delta fetch for both the default corpus and a TeamDrive. Added expiry dates for the three UMAs. I couldn't find an example of how to test that the correct UMAs are being written in a C++ test, hence there's no tests. Bug: 843446 Change-Id: Ifd000cabc02f1b0e4cd7cf599fe83d9bfa74b8f5 Reviewed-on: https://chromium-review.googlesource.com/1092959 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567519}
-
Jun Choi authored
Implement Cable handshake protocol client logic that dispatches control message to the authenticator and validates incoming control messages from connected authenticator. Handshake message sent to and received from the authenticator should together be used to construct a session key with which the FidoCableDevice use to encrypt/decrypt incoming and outgoing messages. Bug: 849307 Change-Id: I818792c7234e039e43de8425ee8f7a30610073a0 Reviewed-on: https://chromium-review.googlesource.com/1089327 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567518}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91211414086..fce7bc9e0825 git log c91211414086..fce7bc9e0825 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 tandrii@chromium.org Add infradata/config repo to gclient. 2018-06-14 tandrii@chromium.org Revert "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@fce7bc9e0825 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:613739,chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I24e9ff53d5457de436e88160a1e1637cb2b63a1d Reviewed-on: https://chromium-review.googlesource.com/1101723Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567517}
-
Chris Hamilton authored
This is in preparation for surfacing the data in the chrome://discards UX. Change-Id: I64d0f43e6f313cfd96291c3c81adc15a8d78b5a3 Reviewed-on: https://chromium-review.googlesource.com/1099596 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567516}
-
Blake O'Hare authored
When the launcher pops up, the search field has focus. If you do this quickly after the virtual keyboard has been hidden, the transient blur heuristic will cause the keyboard to be re-shown. Backstory: Some text boxes are actively focused (user presses a text field) and some are passively focused (a window has a search box that is auto- focused). The latter cases should not cause the keyboard to show up. However, if the keyboard was recently dismissed, the "transient blur" heuristic will cause any passively focused text field to invoke the keyboard. The primary purpose of this is login flows that require you to type your name on one screen and then your password on the next screen (like the Gaia login flow) where the password field is passively focused. By explicitly dismissing the keyboard, it will clear out the counter for this heuristic and prevent the focused search field in the launcher from causing the keyboard to open if it was previously open in the past few seconds. The most common form this bug manifests is if someone clicks away from the keyboard to dismiss it with the intention of showing the shelf to immediately access the launcher. Bug: 848664 Change-Id: Ibdcb7a64906498be052c0071a611fdb639fc32f5 Reviewed-on: https://chromium-review.googlesource.com/1088450 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567515}
-
Nigel Tao authored
Type checking should already be covered by the existing js_type_check("closure_compile") BUILD.gn target. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3086629f3439237722f8f7b36a41031a7551901 Reviewed-on: https://chromium-review.googlesource.com/1100661Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567514}
-
Sam McNally authored
Using DriveFS requires building and deploying ChromeOS. Add a client for the fake DriveFS launcher to allow the use of a real DriveFS from a ChromeOS chroot to be used with a target_os="chromeos" build of chrome. This connects to the fake DriveFS launcher using mojo over a unix domain socket named by a command-line flag, using the launcher to create DriveFS instances. Bug: 848126 Change-Id: I22dcca154d41bda196dd7c1782bb503f6bcba5b1 Reviewed-on: https://chromium-review.googlesource.com/1098434Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567513}
-
Nicolas Pena authored
This CL adds |processingEnd| to EventTiming, and it is computed as the time when we have finished dispatching an event. The |duration| is fixed to be the time the next swap promise is resolved. It is computed in the WindowPerformance to avoid complicating the lifetime of the EventTiming class and to facilitate grouping multiple event entries into a single swap promise. This CL also fixes the computation of DOMHighResTimeStamp to be aligned with the other entry types: we use MonotonicTimeToDOMHighResTimeStamp to clamp first and then subtract instead of subtracting first and then clamping. The layouttests are modified to force swap promises to be resolved before onload when needed. To allow serving a delayed resource via php, the tests are moved to http/tests . Bug: 841224, 851484 Change-Id: I684b165ef5840b9d4da17258b0a1cc796ec43fcb Reviewed-on: https://chromium-review.googlesource.com/1095736 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#567512}
-
deejay authored
Previously it checked wrong text-style while calling PredicateForSearchKey() in Mac. This patch changes text style from kTextStyleBold to kTextStyleItalic. Bug: none Change-Id: Ib047928fd020ace116fff7a84b4b4c3646906f4b Reviewed-on: https://chromium-review.googlesource.com/1099097 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567511}
-
Yutaka Hirano authored
As the feature is enabled by default, this CL removes unused code. Bug: 794073, 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9064494c83ec189443a0f6493987a4a8d2c5a035 Reviewed-on: https://chromium-review.googlesource.com/1100717Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#567510}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/54899e2b1191..90d481078b9b git log 54899e2b1191..90d481078b9b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 dgarrett@google.com chromeos-config: Move asan's to chrome_informational. 2018-06-14 ahassani@chromium.org paygen: remove work_dir from CreateAndUploadPayload Created with: gclient setdep -r src/third_party/chromite@90d481078b9b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I128fcfb6d7c2424b3677638683809584a41efb62 Reviewed-on: https://chromium-review.googlesource.com/1101721Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567509}
-
Helen Li authored
ProxyResolvingClientSocketFactory's consumers (p2p sockets used by WebRTC) currently use a default-initialized net::SSLConfig struct. This net::SSLConfig doesn't respect admin policies and system settings. This CL uses the SSLConfig from SSLConfigService which has the right SSLConfig. This CL additionally removes one unneeded param (net::ClientSocketFactory*) from the factory's constructor. This CL is to prepare for servicifying ProxyResolvingClientSocket. Bug: 844187 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Idf18c9f27a0080a55b3dca16ba593302be3486bb Reviewed-on: https://chromium-review.googlesource.com/1100340 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#567508}
-
Matt Wolenetz authored
Since upcoming changeType() work will refactor some of the current code that creates and passes callbacks to StreamParser::Init(), this CL modernizes related base::Bind and base::Callback usage to either base::Bind{Once,Repeating} and base::{Once,Repeating}Callback. Note that the encrypted media init data callback is the same underlying type in StreamParser as in Demuxer, so this CL also modernizes the binding for the Demuxer version of that type. base::Bind count in //media: before=1425, after=1384 BUG=714018,751838,605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8c3ef44a836c5bfa3f34ff300da760dd7f552c1 Reviewed-on: https://chromium-review.googlesource.com/1099935Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567507}
-
Helen Li authored
The network:: namespace qualifiers might be an artifact because some of the files were previously in content::. Trivial cleanup so we have consistency between new and old files. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia8575841f9fb4e193e4e5e7a4620684be08db79c Reviewed-on: https://chromium-review.googlesource.com/1101575 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567506}
-
Peter Collingbourne authored
This is a reland of 4a2a5c4a with an additional check for use_xcode_clang. Original change's description: > build: Pass -fcomplete-member-pointers when building with clang. > > This prevents member pointers of incomplete base type from being used in > cases where they might cause problems under the Microsoft ABI. > > Specifically, the Microsoft ABI has different kinds of member pointers with > different sizes, and the choice of member pointer representation depends on > the inheritance hierarchy of the member pointer's base type. C++ allows a > member pointer's base type to be incomplete, so if it is incomplete at the > point where a variable of that member pointer type is declared, that forces > the compiler to pick the most general (i.e. largest) one. That can lead to > ODR violations since the most general representation wouldn't necessarily > be the one that would be chosen if the base type happened to be complete at > the point where the variable was declared. It can also be less size efficient > because the compiler will generally be able to choose a smaller representation > than the most general one if it were complete at the point where it is needed. > > This flag also enables additional semantic analysis that we'll need in order > to correctly implement -fsanitize=cfi for member function pointer calls. This > is because the inheritance hierarchy of the base type must be available in > order to make the CFI checks as precise as possible. > > Note that the flag is a -f flag rather than a -W flag. This is because > requiring member pointer base types to be complete is technically a > non-conforming language extension, as it may, for example, cause templates > to be instantiated which would otherwise not be, which may be observable > after code generation in conforming programs that were crafted to observe > it. However, the effects of this language extension should not be observable > in most ordinary programs. > > Bug: 847724 > Change-Id: I8d823fd4a6f21dfcadba55eefc0a69ef2e0c3479 > Reviewed-on: https://chromium-review.googlesource.com/1098217 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567086} Bug: 847724 Change-Id: I1b97980691914492945d170931d33438c68e8d0b Reviewed-on: https://chromium-review.googlesource.com/1101477Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567505}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/425d9ce2d32c..c91211414086 git log 425d9ce2d32c..c91211414086 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing. 2018-06-14 ehmaldonado@chromium.org gclient: Don't allow None URLs (except in .gclient files) Created with: gclient setdep -r src/third_party/depot_tools@c91211414086 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:839925 TBR=agable@chromium.org Change-Id: I8a9d2c829bf6a650fd793567fa3e122972016a09 Reviewed-on: https://chromium-review.googlesource.com/1101718Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567504}
-
Kenichi Ishibashi authored
ByteConsumer::BeginRead() may return Result::kOK with no available read data. FetchDataLoaderAsDataPipe should handle zero read as other ByteConsumer::Client do. Bug: 807954 Change-Id: I47186ccc01d10c8ff18bdf749376598ee75342a7 Reviewed-on: https://chromium-review.googlesource.com/1096515Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567503}
-
Daniel Murphy authored
R=cmp@chromium.org Change-Id: I0d2b39043d0d3a2ef7478178bc7106dc00337171 Reviewed-on: https://chromium-review.googlesource.com/1101656 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567502}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e16ffd4fc3f2..ee3e3a4f3cba git log e16ffd4fc3f2..ee3e3a4f3cba --date=short --no-merges --format='%ad %ae %s' 2018-06-14 npm@chromium.org Merge 3 methods of CJBig2_GRDProc together 2018-06-14 dsinclair@chromium.org [formcalc] Calculate length of string when calling FXSYS_wcstof 2018-06-14 pcc@google.com Move definition of XFA_SCRIPTATTRIBUTEINFO into cjx_object.h. 2018-06-14 hnakashima@chromium.org Rewrite content stream regeneration. Created with: gclient setdep -r src/third_party/pdfium@ee3e3a4f3cba The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:846104,chromium:847724 TBR=dsinclair@chromium.org Change-Id: Ib391fca7b13757f3b2dc733c4d20fd67d42d1d96 Reviewed-on: https://chromium-review.googlesource.com/1101720Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567501}
-
Ken Buchanan authored
SurfaceHittest finds a target Surface for a point and signals whether there should be additional hit testing done in the renderer. Currently this only happens if there is a Surface quad and a non-Surface DrawQuad under the point, in which case the browser sets query_renderer in order to get a more confident target. However, in cases where the Surface is occluded by a RenderPass that has no DrawQuads in that location, it doesn't set query_renderer because there does not appear to be a reason to do so. Instead, it incorrectly thinks the RenderPass is the correct target. This is problematic because layer squashing can create layers that are much larger than the elements within them. This CL changes this behavior so that it always queries when there is a Surface at the given point. This will increase the number of asynchronous hit tests that are performed in general. Bug: 851802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4e878101533e2794fc44cd16f36ea5cd104e59e2 Reviewed-on: https://chromium-review.googlesource.com/1101579Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567500}
-
Khushal authored
R=piman@chromium.org Bug: 844207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5b324498db07afdb342d555982781f922a3e3b94 Reviewed-on: https://chromium-review.googlesource.com/1101458Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567499}
-
Chong Zhang authored
Disable due to failings on linux-perf, Mojo Linux Perf, and mac-10_13_laptop_high_end-perf. See bug for sample builds. Bug: 852980 Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68 Reviewed-on: https://chromium-review.googlesource.com/1101836Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567498}
-
Robbie McElrath authored
This is the start of a larger refactoring to the way file uploads are handled when the network service is enabled. Currently a file path is given to the network service, which then opens the file and uploads its content. It doesn't currently check if the requester has access to the file, and won't even be able to open files once it's sandboxed, so the plan is to make the network service ask the browser process to open the file for it. The renderer or browser process (whichever wants to do the upload) will pass a file path to the network service, which will then call a new method on NetworkServiceClient. This method will take the file paths that it wants to upload, validate that the originator of the request has permission to open those files (via ChildProcessSecurityPolicy), open the files, and return the handles back to the network service to upload them. This CL defines just the new method, OnFileUploadRequested. Future CLs will add its implementation. Bug: 845612 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9f7d0622db198a33e8f6dcdf9b8f4373d9156e2a Reviewed-on: https://chromium-review.googlesource.com/1095653 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567497}
-
Robert Sesek authored
The main executable now invokes the SeatbeltExecServer when the feature is enabled. This also sets up the OuterBundle and BaseBundleID overrides, which are required to properly find the rohitfork port. Bug: 850735, 749839 Change-Id: Ic02df574a209213d1ca560ab2d1e947be5ae5136 Reviewed-on: https://chromium-review.googlesource.com/1099643Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567496}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42e9609fc92e..b520f6298c3e git log 42e9609fc92e..b520f6298c3e --date=short --no-merges --format='%ad %ae %s' 2018-06-14 csharrison@chromium.org Add support for profile_files_to_copy in PossibleAndroidBrowser 2018-06-14 sullivan@chromium.org Added apps scripts to mail perf sheriffing info to experimental/ 2018-06-14 benjhayden@chromium.org Support multiple story tags in ChartJsonConverter. Created with: gclient setdep -r src/third_party/catapult@b520f6298c3e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:823982 TBR=sullivan@chromium.org Change-Id: I57109c7cae486eef0e69974e9cdb99dedb801c78 Reviewed-on: https://chromium-review.googlesource.com/1101719Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567495}
-
James Darpinian authored
Destroying a transfer buffer now requires only an ordering barrier, not a full flush. This removes a source of unnecessary flushes and makes resizing the transfer buffer more efficient. Bug: 850271, 835353, 828363 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9bfe43c46c00f8e9fc29e6450da788f86e74bc52 Reviewed-on: https://chromium-review.googlesource.com/1093580Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#567494}
-
kristipark authored
Tiles with missing/small favicons will display fallback icons instead, which consists of a colored circle and the first letter of the tile title. The fallback color will either be gray for missing favicons or the dominant color of the small favicon. This change depends on https://crrev.com/c/1096670. Screenshot: https://screenshot.googleplex.com/dbu8dxk97sX.png Bug: 837798 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie6ddf538396bcf8fbfd11cb9e9f0bad075301edd Reviewed-on: https://chromium-review.googlesource.com/1096680 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#567493}
-
Nasko Oskov authored
Reloading an URL usually does not change its SiteInstance, however there are a couple of exceptions - hosted apps and recently isolation of error pages. In both of these cases, a commit for a specific URL can happen in SiteInstance A and a subsequent reload results in a change to SiteInstance B. With error page isolation, this can happen easily due to timeout or some other transient network error on the initial navigation to the URL, which ends up in an error page process. A later successful reload then results in a different SiteInstance for the same URL. Session history navigations are similar in behavior. When navigating back/forward, the navigation can be redirected cross-site, resulting in a SiteInstance change. This CL changes ClassifyNavigation to account for these and classifies them as NEW_PAGE with replacement. It ensures that when an entry's SiteInstance changes, which means the security context has changed, we don't reuse and update the existing entry, but rather we replace it with a newly constructed one. The CL adds a specific test for session history navigations that are redirected and adds session history length checks to the existing test of reloading a hosted app, which changes SiteInstances. Bug: 840485, 848446 Change-Id: Iabacc60ce5726d5d919877b6e65e5d2f51dff3e2 Reviewed-on: https://chromium-review.googlesource.com/1086876 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567492}
-
- 14 Jun, 2018 10 commits
-
-
Helen Li authored
linux_mojo has been switched to luci. The old bot gives me 404 and errors when I include it in my CL commit msgs. TBR=jam@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iecb2b9502a2f85ef5cb62bd8c0ee74d8abefe98b Reviewed-on: https://chromium-review.googlesource.com/1101848Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#567491}
-
Dave Schuyler authored
This CL adjusts the placement of the icon and text to align icons whether MD Refresh is enabled or disabled. AiS refers to Answers in Suggest which is what the bug was reported on. Bug: 852450 Change-Id: I48633f3e799d50b0f0bd73a1b8ce713115142c8e Reviewed-on: https://chromium-review.googlesource.com/1101971Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567490}
-
Tom Anderson authored
This is necessary to reland [1]. Libuuid is now a dependency of fontconfig, which is statically linked on Linux builds. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1095538 BUG=787020 R=dpranke Change-Id: I42a747359a4dd39e1a8ebad26e1db67467d73620 Reviewed-on: https://chromium-review.googlesource.com/1102009Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#567489}
-
Alex Newcomer authored
Per UX Request: For all MenuShowSource types, show a highlight when a menu is shown. This was already working for touch menus. This also fixes the bug where the ink drop bubble was "Bursting" regardless of the prior ink drop state. Bug: 844779 Change-Id: I715300a7447ad099b6a610b34e8a30a2170d6e4c Reviewed-on: https://chromium-review.googlesource.com/1095637Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567488}
-
Istiaque Ahmed authored
We neither copy LazyBackgroundTaskQueue instances, nor we need to. Delete its copy operators. Bug: None Change-Id: I759fe181e9c1d561769922b299043463fe7e5cd0 Reviewed-on: https://chromium-review.googlesource.com/1036613 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567487}
-
Donn Denman authored
Minor cleanup of stale TODOs and other cruft in ContextualSearchManager.java. BUG=635567, 607127 Change-Id: If71b43ef07f0e2aaaa581b9481765b6ae551d315 Reviewed-on: https://chromium-review.googlesource.com/1100976Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#567486}
-
Bruce Dawson authored
This reverts commit ef1fe502. Reason for revert: It's not clear that the underlying bug was fixed and this change may have made ICU initialization failures happen silently, leading to later misbehavior. To be clear, this adds back code to help debug bug 445616. I'm also taking ownership of the TODO items. Original change's description: > Remove code that was added to debug bug 445616 > > Looks like the bug was fixed, so we don't need this. > > Bug: 445616 > Change-Id: Id33ecc6249b1e68337650c733d0877e3326732bf > Reviewed-on: https://chromium-review.googlesource.com/885021 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532612} TBR=dcheng@chromium.org,sergeyu@chromium.org,scottmg@chromium.org,jshin@chromium.org Bug: 445616 Change-Id: I2f5dad591791dea8d1427fdceddbf873efbf5f22 Reviewed-on: https://chromium-review.googlesource.com/1099980Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#567485}
-
Chris Hamilton authored
This is necessary in order for it to work when the PageAlmostIdle feature is enabled. BUG=829933 Change-Id: Ic3158a984713ceef849788eaa758ecaa255eba5a Reviewed-on: https://chromium-review.googlesource.com/1097421Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#567484}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/75359664993b..9491e5ebed98 git log 75359664993b..9491e5ebed98 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 geofflang@chromium.org Generate framebuffer IDs used in DXGISwapChainWindowSurfaceWGL. Created with: gclient setdep -r src/third_party/angle@9491e5ebed98 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852399 TBR=cwallez@chromium.org Change-Id: I6616599386646d5d6fc021fdb20052993c4aef84 Reviewed-on: https://chromium-review.googlesource.com/1101717Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567483}
-
Ryan Hansberry authored
PromotionManager is no longer used, and there are no future plans to use it. This CL also removes the flag that controlled the feature, and its associated metadata. R=khorimoto@chromium.org TBR=jhawkins@chromium.org Bug: 824568, 752273 Change-Id: I6ac7cfe8391ce050b1d1f9217ffc6ec95160746d Reviewed-on: https://chromium-review.googlesource.com/1101703Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567482}
-