- 13 Oct, 2020 40 commits
-
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I0b455344c6e8add0a36fc4a7944b720755d4b73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816433}
-
Mike Jackson authored
DesktopPWAsWithoutExtensions has shipped and tests have been migrated, so removing dead code. Bug: 1065748 Change-Id: If97523669db16f8e0a833b5e8a0fd4546b5cf2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466510 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#816432}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic071a7fe6685a22a4c8d004627f620c2eb290c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467001Reviewed-by:
-
Josiah K authored
Steps: 1. Run third_party/closure_compiler/roll_closure_compiler 2. Remove newly added chrome.fileSystemProvider lines (conflicts with definitions in third_party/closure_compiler/externs/file_system_provider.js) 2. Revert README.chromium Change-Id: I3e7dab78b8694e25e53d20661528a093f13c9844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461053 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#816430}
-
Kenichi Ishibashi authored
This CL attempts to fix flakiness of some service worker browsertests. Before this CL, we destroyed ServiceWorkerContextWrapper in TearDownOnMainThread() without waiting for all callbacks are executed. This caused DCHECK hit in mojo callbacks of ServiceWorkerStorageControl because destroying the wrapper also destroys a mojo connection to ServiceWorkerStorageControl. Mojo callbacks need to be executed before the corresponding remote is destroyed. Bug: 1137529 Change-Id: I3060d5ba687e8164c6f29f1e24395ce09c26abfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467037Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816429}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aa7048b18b2f..538433c72064 2020-10-13 thestig@chromium.org Explain why kFuncTag/kClassTag should remain as strings. 2020-10-12 thestig@chromium.org Bump up `kMaxFormLevel`. 2020-10-12 thestig@chromium.org Add a pixel test with many layers of form xobjects. 2020-10-12 tsepez@chromium.org Garbage collect last CFWL_ classes. 2020-10-12 tsepez@chromium.org Comment some fields as allowed for stack only types. 2020-10-12 nigi@chromium.org Disable FPDFFormFillEmbedderTest.FormText on Windows for Skia and SkiaPaths. 2020-10-12 tsepez@chromium.org Put CFWL_FontManager into its own .cpp/.h files 2020-10-12 tsepez@chromium.org Nest CFWL_FontData in CFWL_FontManager. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:972999 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7d8faeaa07277bb97ca5c60dfb7c953d3b627284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467061Reviewed-by:
-
ssid authored
BUG=870813 Change-Id: I0203d93bcc2b38358804f5f6bf15379598016027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467059Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#816427}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a587865e0537..720508005564 2020-10-13 bsalomon@google.com Revert "Reland "Revert "Use ManagedBackendTexture in place of TestUtils backend texture helpers.""" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I02cce366e8144715237f5b54d753bab694ef14fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467063Reviewed-by:
-
Ben Reich authored
Initialize value_id_ to 0 (spotted by MSAN bots). Note message id 0 is safe to use: it is never sent by DevToolsListener to chromium devtools in a CDP command and thus, never in the devtools command response. Bug: 1113941 Change-Id: I3cfb82464c6d1fffed5d4e653dcfc8968d3df945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466572 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816425}
-
ziyangch authored
-Increase FFmpeg demuxer memory limit to 152M. -Increase audio meory limit to 5M for AC3, EAC3, AAC(more than five channels) codecs. -Increase video meory limit to 80M for VP9, HEVC, DolbyVision codecs. Bug: internal b/76206878 Merge-With: eureka-internal/454376 Test: DemuxerMemoryLimitCastTest, CQ Change-Id: I32325b5014cb141cf2ea128be66ccb89fcba0fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234996Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#816424}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602435952-232be9ce3683aa917ade383918bb42eb3e64b0d9.profdata to chrome-win32-master-1602514791-92b25c346599f1253fe4b5957e8929536703cfb0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06e73c05722d7144498f7e9ab4c6a1c91c69fb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465869Reviewed-by:
-
Zhaoliang Ma authored
Bug: None Change-Id: I36c33b2b6322e9d588971eef1bb029d98d939b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434798Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#816422}
-
Xing Liu authored
BookmarkItemsAdapter currently uses the backend data class BookmarkItem as its data object. This is not flexible to add decorative or non bookmark ViewHolders to its recycler view. Also the sync promo header uses null to identify itself to the recycler view, which is kind of hacky, and UI logic assumes null is the place holder for sync promo header. This CL introduces BookmarkListEntry, which can represent any kind of ViewHolders, and carries different kind of data objects. Sync promo header also has a BookmarkListEntry object. Bug: 1128074 Change-Id: Id11c0164eb06cf3a59b35eb6cad7e33e4f9d19f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461724 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#816421}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd2eebd327e3..b9b0de8c80ca 2020-10-12 eroman@chromium.org Use flexbox CSS layout in NetLog viewer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026294 Tbr: nuskos@google.com Change-Id: Ibbb5d6e321b66276fb1839293e34cc305a13c532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466718Reviewed-by:
-
Yuichiro Hanada authored
The pointers of aura::Window stored in |task_id_to_arc_app_window_info_| are expected to be cleaned in OnTaskDestroyed(). However, it's possible to use it after the aura::Window is destroyed, but before OnTaskDestroyed() is called. This CL fixes use-after-free by clearing the pointers in OnWindowDestroying(). Bug: b:168775950 Test: atest --iterations 30 android.server.wm.MultiDisplayActivityLaunchTests Change-Id: I27526cb92722799f46046a7ccdffbd577e4c9355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466013Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#816419}
-
Clark DuVall authored
This metric measures code loading time for WebLayer, and reuses the logic from the WebView startup test. Bug: 1137468 Change-Id: I9045bb47b119470881c1500650a9ed9127295afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466482 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#816418}
-
Aaron Colwell authored
There are a few cases where a SiteInfo parameter and an is_guest parameter are passed into a function and the SiteInfo does not reflect the guest information if is_guest is true. This is inconsistent with most other callers of the same methods. This change simply updates these calls so they pass in the guest SiteInfo. This technically is a behavior change, but the paths that are executed when is_guest is true do not actually rely heavily on the SiteInfo param. In cases where they do check something in the SiteInfo, it isn't possible for the methods to return anything different than what the is_guest param check would return. An extra check in RenderProcessHostImpl::IsSuitableHost() was also added to explicitly prevent a non-guest host from being considered suitable for a guest request. This code was relying on the fact that all callers would pass in a guest host for all guest requests. Bug: 1085275 Change-Id: I3c77045d6b1447dc21a860f9872c510f7e67defd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446718 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816417}
-
David Dorwin authored
Previously, the relative paths for multiple boot images were appended. For example, for the default `'checkout_fuchsia_boot_images': "qemu.x64,qemu.arm64"`, the latter's path would be //third_party/fuchsia-sdk/images/x64/qemu/arm64/qemu/. Change-Id: Id89c58e0e3a10beaabc0f84278861a0412568d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466837Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816416}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602525418-afe56390c440c08698d6b71f1c497e873e6a051a.profdata to chrome-linux-master-1602546992-ba4d1f5ead4061da7fd3853f89c3c9703bc786ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie81fbc90498c8add25ca469956eeeb02ae7af886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467060Reviewed-by:
-
Daniel Ng authored
Bug: 1106149 Change-Id: If45d22a6f86fec21a3b666ff06bde258b2304ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467036 Auto-Submit: Daniel Ng <danielng@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#816414}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I915c62a8bdb0233dedeab08277198baeb038ef87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467196Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816413}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602525418-295b1a16e5c5eb1a611980e5afdf689a2be9286a.profdata to chrome-mac-master-1602546992-4541e834d35741f8358d6360b79d19523776e3ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3131be67528b610555601bc6876242259482081b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467057Reviewed-by:
-
dpapad authored
Leverage latest improvements to autogenerate WebUI .grd files for optimized builds as well. Bug: 1132403 Change-Id: Idb3a80ac6336521397b111902f375ae7bbcc83b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465096 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816411}
-
Lukasz Anforowicz authored
The "RequestInitiatorSiteLockEnfocement" feature is enabled on desktop platforms in M87, because we want to be more careful on Android, since a mojo::ReportBadMessage might lead there to renderer kills (if NetworkService is hosted in the Browser process, something that never happens on desktop platforms). Since the M87 data so far looks good so far [1], this CL enables the enforcement on all platforms for M88. [1] https://docs.google.com/document/d/132ZPqDZdH-rcvBvHEAd-m86P2udVCi07ccnI0DXmJgE/edit# Bug: 920634 Change-Id: I5f27d9402b3e60668305312aa437252554890bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465803 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#816410}
-
Hsinyu Chao authored
This reverts commit 21620925. Reason for revert: The Bluetooth WBS feature has been enabled for 2+ releases and doing well. We think it's the good time to make BT mic auto selected instead of waiting for user to manually selecting it. Bug: b/170388719 Original change's description: > Lower the priority of Bluetooth mic even in wideband > > Bug: b/156333981 > Change-Id: Ieec9421a98119684f3ad901b16c1ad8dbe8998ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196082 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Commit-Queue: Hsinyu Chao <hychao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772093} TBR=hychao@chromium.org,jennyz@chromium.org,cychiang@chromium.org,yshavit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/156333981 Change-Id: I855eb8f92c94d72f54379b4bdac15ff07c410c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462901Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816409}
-
Maggie Cai authored
This reverts commit 052bc3e7. Reason for revert: Suspect this CL causes build failure in mac-arm64-rel that closed the tree (https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/2680). Original change's description: > Update V8 to version 8.8.74. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/ba88e59b..7bb48090 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I95a61574ebdaa9fcab1866231cd4a46092517bd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462181 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#816339} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40e3934738ef5889554da388738b4dfd2b8a979f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467043Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816408}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4efaf5e9fead..a587865e0537 2020-10-13 michaelludwig@google.com Enable new GrClipStack for flutter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ia3de534048166f7d5f070b02c02b8c5966bccaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465059Reviewed-by:
-
Avi Drissman authored
For apps compiled against the macOS 11.0 SDK, TCC will crash if the NSBluetoothAlwaysUsageDescription string isn't available and Bluetooth APIs are called. Provide an NSBluetoothAlwaysUsageDescription string. For now, just reuse the generic IDS_RUNTIME_PERMISSION_OS_REASON_TEXT string, but in the future, perhaps better strings could be used. Bug: 1126246 Fixed: 1134360 Change-Id: I6252d43fb98ce5bd4be0504260347b933c09834b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466148Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816406}
-
Lei Zhang authored
In OutOfProcessInstance::HandleUpdateScrollMessage(), the messages received from JS sometimes contain integers and sometimes contain doubles. As such, check validate them with is_number() rather than is_int(). Bug: 1136983 Change-Id: Id3112e660a96d596b9da92c453caa5f697e5a5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466514Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38f6d78eae8f..d21d9e8681bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com,mahmadi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1081649,chromium:1100278 Tbr: mxcai@google.com,mahmadi@google.com Change-Id: Ib69942f61138041997fb61e0abee6f2fa89e6025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466820Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816404}
-
Peter Boström authored
This enables removing overrides to CalculatePreferredSize() that try to return a fixed size to fit within a specific dialog width. It also fixes infinite recursion in such overrides where there's no LayoutManager and GetHeightForWidth() defaults to calling GetPreferredSize(), which calls the CalculatePreferredSize() override that calls GetHeightForWidth(). Bug: 1128500 Change-Id: I75508e790cd6d7fdc31a40b5dad96366ddf8545c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466141 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816403}
-
Charlene Yan authored
Changing dragging collapsed group header tests to checking that the group expands when drag starts. There are other tests for dragging an expanded header. It was also bugged since functionality was added to auto create a bubble on tab group creation, and the tests were not updated. Change-Id: I456b4b1c0e6b834fcc553b1dfd7619b8a7e5c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457370Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816402}
-
Maggie Cai authored
This reverts commit c67306a2. Reason for revert: This breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage Original change's description: > [filesapp] Add a browser_test for DevToolsListener class > > Test that JS code coverage of a JS IFFE injected in a WebContents gets > collected by DevToolsListener and stored in a ScopedTempDir. > > Test: browser_tests --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I8f04f2e704d677823ffa154272605798b7046f77 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461602 > Commit-Queue: Ben Reich <benreich@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816064} TBR=noel@chromium.org,benreich@chromium.org Change-Id: I2d838b427cd407a19ac7eb82bae1cf3ffe13592a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467039Reviewed-by:
-
Maggie Cai authored
This reverts commit 4734ecf2. Reason for revert: https://crrev.com/c/2461602 breaks build Linux ChromiumOS MSan Tests in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20900 Failed test is DevToolsListenerBrowserTest.CanCollectCodeCoverage Original change's description: > [filesapp] Add missing includes and fail if host crashed > > Adds #include's that were missing from the initial patch, and FAIL the > test if the DevToolsAgentHost attached to crashes during the test. > > Fix HostString() helper to *actually* take an optional prefix: use C++ > c++17 {} style initializer. > > Test: browser_test --gtest_filter="*DevToolsListener*" > Bug: 1113941 > Change-Id: I5901019add9fea92b6e3a8b5b881b8d3d197b6c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465456 > Commit-Queue: Ben Reich <benreich@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816070} TBR=noel@chromium.org,benreich@chromium.org Change-Id: I87ec9b3db970807af8fc75ca137fc83397f775bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466016Reviewed-by:
-
Michael Bai authored
SentNodes is a wrapper of HeapHashSet and has little value be a separated class. This patch also moves SentNodes to TaskSession, it was used to share the SentNode between the different ContentCaptureTasks, but ContentCaptureTask will never be recreated. Bug: 1137463 Change-Id: Ic8f958a8ae4da957fd3ab49e1b65faa9508acac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466505Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816399}
-
Dale Curtis authored
Wrapped frame should always take precedent and the DCHECK prevents wrapping frames that have textures. R=ccameron, sandersd Bug: None Test: Passes existing tests. Change-Id: Ibfbc5b329918a9223699dc6b01187a3b283d126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466838 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#816398}
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2425623 Bug: 1134800 Change-Id: I95d8508a817e2b2d32885db84c5ce5129eee52d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464443 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#816397}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/182a24a6540b..9103d0e4fc9b 2020-10-12 jegarc@microsoft.com Fix enum sending telemetry for issues panel opened resource. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135327 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I584a23c314f481ffde4d9b05cc1d30646db735b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466172Reviewed-by:
-
Anupam Snigdha authored
Removed the keyboard bounding rectangle from geometrychange event. The keyboard rectangle is now a property of virtualKeyboard object. It gets updated when the geometrychange event is fired. The keyboard rectangle can also be captured from CSS env variables: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/VirtualKeyboardAPI/explainer.md#virtual-keyboard-visibility-change-css-environment-variables This was also a feedback from TAG: https://github.com/w3ctag/design-reviews/issues/507#issuecomment-665473068 Bug: 1127749 Change-Id: Id7f19b0e091b820fa45ba4181d482559846d40ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466402 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816395}
-
Gyuyoung Kim authored
This CL replaces all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy to reduce unnecessary type conversion. Bug: 1097943 Change-Id: I16cbe3223fcfd62375cd7fac1e697cdb90d2b248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463049 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
-
