GitLab

There is no point in trying to return to the same server, if that server
is no longer handling requests.

Review URL: https://codereview.chromium.org/186293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255293 0039d316-1c4b-4281-b951-d872f2087c98

As part of eliminating Signin-related notifications, move SigninTracker to
observing the SigninManager.

BUG=349375
TBR=thakis

Review URL: https://codereview.chromium.org/180743018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255292 0039d316-1c4b-4281-b951-d872f2087c98

This will be used to know when a module has been added so that I can
download needed modules.

BUG=none
TEST=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/187653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255291 0039d316-1c4b-4281-b951-d872f2087c98

Converts bookmarks and bookmarkManagerPrivate event related functions
to use the schema generated classes instead of manually constructing
JSON objects.

BUG=

Review URL: https://codereview.chromium.org/185293019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255290 0039d316-1c4b-4281-b951-d872f2087c98

It's POSIX-only and redundant.

R=phajdan.jr@chromium.org
TBR=brettw@chromium.org,jam@chromium.org,gene@chromium.org

Review URL: https://codereview.chromium.org/187993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255289 0039d316-1c4b-4281-b951-d872f2087c98

to allow broken alternate protocol mappings to be expunged.

R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/187693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347900
TEST=run_webkit_tests.sh http/tests/filesystem/\*
TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\*

Review URL: https://codereview.chromium.org/187393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255287 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/187893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255286 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup to https://codereview.chromium.org/148523013.

BUG=none

Review URL: https://codereview.chromium.org/179293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255277 0039d316-1c4b-4281-b951-d872f2087c98

RenderWebColorChooserImpl is owned by blink::ColorChooserUIController so it should not be destroyed in RenderViewObserver::OnDestruct

BUG=342735

Review URL: https://codereview.chromium.org/181233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255276 0039d316-1c4b-4281-b951-d872f2087c98

This change adds RenderThread::GetShutdownEvent() to the public content API.
This is required for code outside of content/ that wants to safely use
interfaces like SyncChannel.

BUG=

Review URL: https://codereview.chromium.org/186973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255275 0039d316-1c4b-4281-b951-d872f2087c98

This prevents a crash when a token on the via header
is fewer than four characters.

BUG=349020

Review URL: https://codereview.chromium.org/187273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255274 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that if the user was set to use the Gaia profile info, then we ignored any custom profile names that were synced. We shouldn't do that :) 

BUG=343730,348187,349000

Review URL: https://codereview.chromium.org/186803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255273 0039d316-1c4b-4281-b951-d872f2087c98

WaitSyncPoint(0) does not do anything, so return early. Accelerated video code
path frequently calls WaitSyncPoint(0).

BUG=N/A

Review URL: https://codereview.chromium.org/185393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255271 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025
TEST=content_unittests --gtest_filter="WebCryptoImpl*"

Review URL: https://codereview.chromium.org/118623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255270 0039d316-1c4b-4281-b951-d872f2087c98

Renamed the char* argument to 'data' and the string argument to 'str'.
Cleaned up the comments on the char* overload (avoid using
string-specific terms and mentioning null byte). Mentioned that this
algorithm is also in Blink.

Added a test case testing that null bytes cause the hash to change.

BUG=347393

Review URL: https://codereview.chromium.org/182253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255269 0039d316-1c4b-4281-b951-d872f2087c98

Remove un-necessary Dr. Memory exclusions for the now-fixed 349443. Add exclusion for TranslateManagerRenderViewHostTest.*.

BUG=349443,349778
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/183053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255268 0039d316-1c4b-4281-b951-d872f2087c98

I created a group for this item in r254287, but forgot to add it in
render_view_context_menu.cc.

BUG=348379
Test=Select some <text> in webpage, right click to see context menu,
  "Search Google for <text>" should appear in the list now.

Review URL: https://codereview.chromium.org/187923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255267 0039d316-1c4b-4281-b951-d872f2087c98

Removes extra left border from wrench menu buttons. This seems to have been broken in https://codereview.chromium.org/82113004.

BUG=349063
TEST=Visual inspection - see screenshots in the bug. The buttons should have rounded corners.

Review URL: https://codereview.chromium.org/185233017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349416,64887
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/188453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/187963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255264 0039d316-1c4b-4281-b951-d872f2087c98

This flag used to cause a crash on startup. As of Xcode 5 this doesn't
appear to happen anymore.

BUG=341484
TEST=None

Review URL: https://codereview.chromium.org/187823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255263 0039d316-1c4b-4281-b951-d872f2087c98

Modified chrome.bluetooth API code to use the new discovery session API for
device discovery.

BUG=346982
TEST=1. unit_tests, browser_tests
     2. Use multiple running extension instances with the bluetooth permission and check for the following behavior:
        - Only one session per extension. Calling chrome.bluetooth.stopDiscovery from one running app should fail if that app never called chrome.bluetooth.startDiscovery.
        - An app's discovery sessions should get cleaned up if that app crashes or unloads.
        - Use bt_console and run "power off". This should cause all discovery sessions that have been assigned to apps to get marked as inactive. Verify by requesting a new discovery session from apps, which should succeed.

Review URL: https://codereview.chromium.org/179123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346862

Review URL: https://codereview.chromium.org/181063036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348137
NOTRY=true

Review URL: https://codereview.chromium.org/186843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255258 0039d316-1c4b-4281-b951-d872f2087c98

The changes from login_unittest.py include:
* Removed testOobeLocalization since it's very specialized.
* Apply test.Enabled('chromeos')
* browser.Start() is no longer necessary.


BUG=NONE
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/183923029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/182283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332239, 338501
R=navabi@google.com

Review URL: https://codereview.chromium.org/184873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255230 0039d316-1c4b-4281-b951-d872f2087c98

This is upstreaming a Gentoo Linux patch.

BUG=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/184293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349628
TEST=gpu_unittests
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/183883026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349463

Review URL: https://codereview.chromium.org/187443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255227 0039d316-1c4b-4281-b951-d872f2087c98

The Blink-side change is here: https://codereview.chromium.org/180273020/

BUG=345839
NOTRY=true

Review URL: https://codereview.chromium.org/183743016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344589,341231
TEST=none
NOTRY=True

Review URL: https://codereview.chromium.org/181063034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255224 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/183793009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255223 0039d316-1c4b-4281-b951-d872f2087c98

This allows applications to draw to multiple render targets at the same time.

BUG=318019

Review URL: https://codereview.chromium.org/182213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349634
TBR=phoglund@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/180183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255219 0039d316-1c4b-4281-b951-d872f2087c98

Test is failing because FileManagerFileTasksComplexTest.FindFileHandlerTasks
doesn't initialize URL system request context. But URL fetch was started due
to misprint.

BUG=343589
TEST=unit_tests
NOTRY=true

Review URL: https://codereview.chromium.org/187603009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255218 0039d316-1c4b-4281-b951-d872f2087c98

What's removed:
 - The idea of unique_id's (these were for the now-gone webUI taskmanager).
 - The GetResourceExtension() method, which the tests no longer need.
 - The IsBackground getter, which is not used.

BUG=348836

Review URL: https://codereview.chromium.org/186153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227247

Review URL: https://codereview.chromium.org/178883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255215 0039d316-1c4b-4281-b951-d872f2087c98