- 04 Nov, 2020 40 commits
-
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/9RB3jeFjhWq4kvS Bug: 889763 Change-Id: I5393f7e64ecc5251ab31127f9337ebe2b579a417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517402 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823898}
-
Nicholas Hollingum authored
When shutting down the VM we must invalidate the current context. We support that in this CL by unconditionally requesting concierge to shut the vm down (which is fine to do even if the vm is not running). Any queued callbacks are invoked with the new kCancelled status. Bug: b/172006764 Change-Id: I8e9d5817728ede618967392959ec78b6f7d595f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513807 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#823897}
-
Josiah K authored
Bug: 1131153 Change-Id: I959958dbfe5d81cac99bd3f747170fd60921e415 AX-Relnotes: Adds Docked Magnifier support for active-descendant focus-following Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465491 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
Peter Kvitek authored
Having non canonical forward slashes in log file name causes problems with sanbox file name pattern handlign on Windows. Bug: 859676 Change-Id: I8e00eb72db3bd7959b7e8d493fa90c5069727ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518879 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#823895}
-
Alexander Dunaev authored
webui::GetFontFamily() had a Linux-specific piece of logic that was disabled for Ozone because use of pangocairo was not enabled for Ozone. However, since [1] pangocairo is enabled for desktop Linux Ozone platforms. This CL removes the check for Ozone in webui::GetFontFamily(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2366901 Bug: 320050 Change-Id: I2fe8a9cc12db183e5299f953f720c4241cb43cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505752 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823894}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/227d345692cc..6ea2dd438732 2020-11-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9fe71c2142e66baaa2014b3c9a3a855cfaa3644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823893}
-
Hiroki Nakagawa authored
This CL renames PrerenderTabHelper to NoStatePrefetchTabHelper. See the design doc for the overall plan: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing Bug: 1144577 Change-Id: I5629d556e5a5269da007f1fa32a36d0e2ce48fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516679Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823892}
-
Melissa Zhang authored
This CL adds the sharesheet zero state png. This image will be displayed in the sharesheet when no targets are available. Bug: 1138037 Change-Id: Ie234ccb2d4c884641194d2c7dc80123d96913e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515505 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
Tim Song authored
This is a reland of 3dcbf868 BUG=1138137,1106937, 1145157 TBR=yoshiki@chromium.org,khorimoto@chromium.org,isherman@chromium.org Original change's description: > [CrOS PhoneHub] Add notification metrics. > > We add metrics for PhoneHub notification actions by introducing' a new > PHONE_HUB notification type. This way, metrics will be logged into > existing histograms. > > Additionally, this CL also adds a new Ash.PhoneHub.NotificationCount > histogram counting the number of active PhoneHub notifications. > > BUG=1138137,1106937 > > Change-Id: I4529eb6cc0d861ec9eb720e4eeac5c6d2d6257ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505728 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823474} Bug: 1138137 Bug: 1106937 Change-Id: I89dedf4d97ed65aee8330f7251ad20a4c9afe62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518784Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823890}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This CL also includes a simplied flow by consolidating TpmAttestationDoesKeyExist and TpmAttestationGetCertificate, of which results come from the same methods of attestation service anyway. BUG=b:158955123 TEST=unit_tests. Change-Id: Ib1f9de5a6db041e8c3a86c5d90a0f55b8e4d8285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515800 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823889}
-
Matt Menke authored
When PrefetchedSignedExchangeCache encountered subresource integrity failures, it was using an empty NetworkIsolationKey to try and send NEL reports. This CL makes it use the correct NetworkIsolationKey, taken from the ResourceRequest used for the navigation. Fixed: 1144776 Change-Id: I83f6dc1e1e9826071c8367e0ae7af91e68f03287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514363Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#823888}
-
Francois Doray authored
These histograms are not actively used. Most of the time, no tab is discarded in a 10 minutes interval. To assess the impact of future changes to the discarding logic, it would be more useful to report the number of discards and reloads per day. Bug: 1088709 Change-Id: Ia1b2573c154e0b01c9b6d6039a9b2c041db94b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514467Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#823887}
-
Minoru Chikamune authored
For the most part in this CL, existing InterfaceProvider instantiations simply use the default per-thread task runner for no behavior change. However, //content/renderer now binds per-frame interfaces on a per-agent task runner as part of updating the Blink architecture to support MBI. Bug: 1105403 Change-Id: I168ace2f06675a0e7559663a8be3b51cd250e2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498961 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823886}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic3a9f7301ba0c015b24ee828d31c5f6649b7b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518820Reviewed-by:
-
Leo Lai authored
It is not necessary anymore after attestation's GetKeyInfo is used. BUG=b:158955123 TEST=chromeos_unittests. Change-Id: I4d288c8de7227b94941da116267a3253f4a71439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513950 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Francois Doray authored
Fixed: 1089560 Change-Id: I95a1b7565c9ec244b8cbc5e4a6b11553282c2c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511883Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I06832a1ea00f9a3fa50567d40836c249eb7046d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518813Reviewed-by:
-
Kyle Williams authored
Chromebox for Meeting is separated from mainline chromium and this causes slight confusion when updating mojoms. As such update the owners group to dedicated members of the CfM team with a process to approve changes to CfM supplemented by a Meet leads review and chromium launch bug security review. BUG=chromium:1105567 TEST=N/A Change-Id: I6b1d036ab60a439e6ee5a57091e9ea37642ff917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448682 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823881}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: If2a7e175b41c47e004a14eaad9290e11ab937209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519192Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823880}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/af6371f32764..33001e2632db 2020-11-03 tsepez@chromium.org Remove pointer to isolate from CFXJSE_Value 2020-11-03 tsepez@chromium.org Move some more binding logic out of CFXJSE_Value. 2020-11-03 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetDocMDPPermission() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5dede778da26b769032709fd5cd0dc1a4b539cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518645Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbc60b7e9ed2..0e54309477ac 2020-11-03 csmartdalton@google.com Merge GrStrokePatchBuilder into GrStrokeTessellateOp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: If26ce2559bb18d5bca893410fc8857b7ba7d0a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518644Reviewed-by:
-
Aleks Totic authored
This rewrite fixes several bugs: - if no cell's are baseline aligned, baseline should be bottom content edge of non-baseline aligned cells. - if row is empty, and has css block size, its baseline should be top of the row. Interesting incompatibility with FF: FF applies css height only if at least one row is non-empty. I also have exhaustive baseline tests that are not part of this CL. I can add if you'd like: external/wpt/css/css-tables/tentative/baseline-table.html Bug: 958381, 1143297 Change-Id: I5e6fe3d6e96f8da9d5305e4366111ee303918ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515266 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#823877}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59eb5dd0e10d..31e28d20f878 2020-11-04 capn@google.com Switch Chromium/Fuchsia to use the LLVM ORCv2 JIT 2020-11-03 nicolascapens@google.com Clarify the ICD/loader compatibility 2020-11-03 swiftshader.regress@gmail.com Regres: Update test lists @ b5bf8269 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1140854 Tbr: swiftshader-team+autoroll@google.com Change-Id: I1355e52ce61e1892e77fc2eac85754413caf0b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517995Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/39adaeb09df0..3980b1f815aa 2020-11-04 ianelliott@google.com Refactor FrameCapture.cpp to use common utility 2020-11-04 syoussefi@chromium.org Vulkan: Fix use of uninitialized data in staged clears 2020-11-04 geofflang@google.com Revert "Vulkan: Add features to modify sampling parameters" 2020-11-03 courtneygo@google.com Fix presubmit failure with recent glslang update 2020-11-03 jmadill@chromium.org Gold Trace Tests: Handle test filter. 2020-11-03 jmadill@chromium.org Enable writing histogram-set-json-format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1144491 Tbr: courtneygo@google.com Change-Id: I658e05ac0c88bd64665dc11ab328d037222e7bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518719Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibb7f3b7b51e73fe66eea94e9abfbea1dba50e2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518902Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604361545-95869d864c8b2bd48e03f9a16b21429d633a6ea4.profdata to chrome-win32-master-1604415585-a805ae049e5b36d9f91fb3f359143964051762d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I85c6ae79807cd273ce56c4e350dc93c4b7f83290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517706Reviewed-by:
-
Nancy Wang authored
SetAcceptCallback for the pause app dialog only quarantines the callback function is called when the OK button is clicked. When press 'esc' to dismiss the dialog, the callback is not called. For the pause app dialog, the callback function should be called when: 1: the OK button is called 2: 'esc' is pressed to dismiss the dialog, The dialog view needs 2 separate callback functions for Accept and Close cases separately, however, we have 1 callback only. So we don't use the dialog view's function, but create the local closed_callback_ variable, and when the pause app dialog is destroyed, call the closed_callback_, so both the above 2 scenarios can call the callback function. The browser test is modified to test the above 2 scenarios. BUG=1144386 Change-Id: I5dd7accfd4e16fcafb7d019877c648b25d71b881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515864 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#823872}
-
Hiroki Nakagawa authored
This test occasionally times out on Linux and Win bots. Bug: 1145424 Change-Id: I448093d26d39167f2c2653b314d34b36d7ef1d09 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518307Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823871}
-
Hiroki Nakagawa authored
Bug: 1144410, 1144666 Change-Id: I340cdd5d160b926a715f69dd841fcc68dda7d74f Tbr: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517206Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5bd41121e18..b8b4d61dd32f 2020-11-04 yuhengh@chromium.org Implement webuiMetric If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099917 Tbr: sadrul@google.com Change-Id: I888eca3b9d394c57660eb72295b9b09867329b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518816Reviewed-by:
-
Dale Curtis authored
Logs exceeding these limits are just dropped on the remote side, so there's no reason to send them in the first place. This removes the UnlimitedSize workaround and fixes a test which was generating a ton of log events due to misconfiguration. R=dcheng, tmathmeyer Bug: 1141985 Change-Id: I178a2214005ca82f1f253bb7d59f43f0a79396a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518208 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
Previously, the default value for the last seen milestone was the current milestone. This default seems to be used more often than we expect, resulting in the notification being very hard to trigger in manual testing. Change this to use the milestone that the profile was created in instead. This should have the same result that the notification will not show up if the user has just come through the OOBE (profile just created), but will trigger for our manual testing of letting device autoupdate to latest dev channel. Bug: b/168769221 Change-Id: Iccdcc71b58a01b05ce3282c3ae0bc070a49bad0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515821 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#823867}
-
Etienne Bergeron authored
This CL is adding sanity check to ensure no components in chrome are using incorrectly the RenderText API. We recently observed a crash (crbug/1124118) that was caused by setting a property outside of the text bounds. The RenderText API assume correct uses of these properties. With this CL they will be reported as a crash reports. Bug: 1142020 Change-Id: I58d19bbbfeca97ad8425706eb85a825105db9f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518895 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#823866}
-
Patrick Monette authored
All of the implementations of ChangeVote() already reuse the same VoteReceipt as it is more efficient. This means that this feature of the interface is not worth the complexity cost. Change-Id: I434edb1d77acaecb6b2a151c86ac3b79453ec3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506393 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#823865}
-
Patrick Monette authored
This class is currently unused. Also, the ability to switch out the VoteReceipt in ChangeVote() will go away in a future CL, rendering this class obsolete. Bug: 971272 Change-Id: Ie5d59b3d6ebba10acbb312e63aaaa701b20690ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518207 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d529e880053d..227d345692cc 2020-11-04 changhaohan@chromium.org Add keyboard accessibilities to CSSAngle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126178 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iecf6ba17d9355480eafa89c9c9e768235f849d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517992Reviewed-by:
-
Eric Orth authored
Converted GetIntegrityResultsForTesting() into a shared GetExperimentalResultsForTesting(). HTTPS records result in a `true` experimental result if successfully parsed. Records parsable enough to recognize as HTTPS but without parsable rdatas result in a `false` experimental result. In order to determine up the stack if Chrome receives HTTPS records with unparsable rdatas (as opposed to completely unparsable responses), created a new MalformedHttpsRecordRdata type. This is minimally added into HttpsRecordRdata because the plan is to remove it again once we have completed initial query experiments. Note: Discovered that all the HostResolverManagerDnsTest.*_WrongType tests were not actually testing what we thought they were because they all queried the wrong name. Oops! Fixed them, and their mocked responses, and had to slightly adjust DnsResponse to allow creating those mocked responses. Bug: 1138620 Change-Id: I9f95d659b2d044b4e702e6db965acd14a86c0848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508337Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#823862}
-
Hiroki Nakagawa authored
This disables following tests: - testModeBrowserDynamicPseudo - testModeBrowserDynamicPseudoSamplePartial - testModeBrowserDynamicPseudoSampleEverything Bug: 1145008 Change-Id: I50601d9f4ecf04592046a34399e357ae8cebab42 Tbr: boliu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517205Reviewed-by:
-
Ian Kilpatrick authored
As per recent CSSWG resolution in: https://github.com/w3c/csswg-drafts/issues/4659#issuecomment-577211422 Change-Id: I088059bc4092da07047a89cb19ac1193bb4e8c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012957 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823860}
-
Takuto Ikuta authored
This reverts commit 1585878b. Reason for revert: https://crbug.com/1144638 https://crbug.com/webrtc/12126 Original change's description: > [DEPS] update luci-go > > Bug: 1142713 > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822547} TBR=yyanagisawa@google.com,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713, 1144638, webrtc:12126 Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#823859}
-
