- 26 Nov, 2019 40 commits
-
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=sky@chromium.org, dpranke Bug: 953861 Change-Id: Ie70184db86a0fa19af7b3f2de67867d46e23a523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934775 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719182}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=avi@chromium.org TBR=dpranke Bug: 953861 Change-Id: I324303b817f72ac38fa253609785565aec0c241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932667Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719181}
-
Yun Liu authored
Will ssh to bot if still nothing printed. Bug: 1027818 Change-Id: I98147da43689d2b4ea9db0ee8643312eac6fc72b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935860 Auto-Submit: Yun Liu <yliuyliu@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719180}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ff260580c07e..6807a2568cda git log ff260580c07e..6807a2568cda --date=short --first-parent --format='%ad %ae %s' 2019-11-26 rharrison@google.com Rolling 5 dependencies (#908) Created with: gclient setdep -r src/third_party/shaderc/src@6807a2568cda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I6b00cd5a0d92c8e32d1dd376bc6a5a742bae154f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719179}
-
John Abd-El-Malek authored
This reverts commit a6b47782. Reason for revert: some of the reenabled tests are flaking, see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel?limit=100 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9718 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9717 Original change's description: > Explicitly shut down LoginDisplayHost in OOBEConfigurationTests > > It should remove flakiness upon shutdown. > > Bug: 997685 > Change-Id: I7258be4a2be53e6e42e9fc0cebc23bd0d78d6fad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934342 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719139} TBR=antrim@chromium.org,rsorokin@chromium.org Change-Id: I047b469ed5df1b5d181349e9a34ec5306ddac8c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937128Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719178}
-
danakj authored
R=bokan@chromium.org Bug: 954011, 1028284 Change-Id: I852b389c12b5bb96cbe2bdef52516b546fe6fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934651Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719177}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01adcafce0bf..b71b5729688e Created with: gclient setdep -r src-internal@b71b5729688e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1021528 Tbr: jbudorick@google.com Change-Id: I773b2380db8a20ab3d306c8cba6bf223d7e16071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936948Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719176}
-
Nektarios Paisios authored
TableView would fire a focus event every time the active row or column changed, e.g. every time an NVDA user would use the arrow keys to navigate around the view. However, Task Manager updates its displayed information very frequently and so by the time NVDA would process the focus changed event, the AXVirtualView object corresponding to the focused item would no longer be available. Task Manager marks every item as changed every time it refreshes its display, thereby causing the corresponding AXVirtualView object to be destroyed and re-created. To work around this issue, we delay firing the focus changed event after OnPaint. R=dmazzoni@chromium.org, sky@chromium.org Bug: 811277 Change-Id: I941cda49fefdc5becdbd7baf8f2cca26104d1aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930061Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719175}
-
Dominic Battre authored
Note that this is just reusing a string that already exists for Android and Desktop. This is not a new string. Bug: 1028095 Change-Id: Ie9e1fecfd17dfffc2626032e6667667033588b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936771 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719174}
-
David Roger authored
This feature has been enabled by default for some time and is no longer needed. Change-Id: I6b0ce810f3177114cf3575866713014411c06982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932901Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719173}
-
Gyuyoung Kim authored
This CL converts all uses of ServiceWorker interface as below, - Convert ServiceWorkerRequest to PendingReceiver<ServiceWorker> Bug: 955171 Change-Id: I196d5bdf6f568694a1c93aa2453f28b44c04fc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932141Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719172}
-
Denis Kuznetsov authored
Bug: 981472 Change-Id: I9e73a1d482d7c796e0987b3b54c0ca606479c4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932544 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#719171}
-
Dave Tapuska authored
Calling clone on a detached document would create a new agent. The agent should be the same. To reproduce create an iframe and detach it while still holding onto the document reference. Clone it and then document.open it. It will fail because the iframe gets detached and loses its parent reference so the documents end up with different WindowAgents. BUG=1020787 Change-Id: I2df68953659eb45799f261e0562750f0daf150e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924592 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#719170}
-
behdad authored
This script can be used to look at the last 30 runs of representative perf tests on each platform and updated the upper limits using the 95 percentile of the recorded data. After calculating the new upper limits the script updates the representatives_frame_times_upper_limit.json file. This will prevent failures as a result of gradual regressions. https://docs.google.com/document/d/15B33ChC7omps62EsxhCWmKTE9N8FakKNQ_IoUo8f4E0/edit?usp=sharing Bug: chromium:953895 Change-Id: I007f6d3b858049726c2e86321cbb9bc2297ee1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918829 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719169}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef4ab7682b6c..fdaba6cf16f3 git log ef4ab7682b6c..fdaba6cf16f3 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 danilchap@webrtc.org Use std::atomic for RefCounter Created with: gclient setdep -r src/third_party/webrtc@fdaba6cf16f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I27aa023934660b7abf97c03d23efd1fe639c630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719168}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ae3c27d5c5c3..663dcefa22ea git log ae3c27d5c5c3..663dcefa22ea --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bclayton@google.com Reactor: Work around new MSVC brokenness. 2019-11-26 swiftshader.regress@gmail.com Regres: Update test lists @ f2637d0d Created with: gclient setdep -r src/third_party/swiftshader@663dcefa22ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If4a7b3a89cbe6124d6d37083376e1ff2015a58a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719167}
-
Rohit Rao authored
This works around issues where overlapped tabs confuses VoiceOver. BUG=979803 Change-Id: I45f9fafa5b14187cc83ab935a3be385886ff8cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933729Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#719166}
-
Tim Schumann authored
It's failing a lot on linux-chromeos-dbg TBR=alemate@chromium.org Bug: 1028606 Change-Id: Id0565b1bcaad544d5ef983aeeffb09b8c377afb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936493Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719165}
-
Robert Sesek authored
Under the V2 sandbox architecture, there is technically nothing that runs "pre-sandbox startup". But we hypothesize that deferring the initialization of VideoToolbox to the first use is leading to hangs, which the watchdog turns into crashes. By forcing initialization at this call site, the GPU watchdog thread is not running, which is what happens under the V1 sandbox architecture. Bug: 871280 Change-Id: I7c1173ecf7752307c19ac15f81e9b1c699d4523b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932166Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719164}
-
Egor Pasko authored
The bot has been using --new-commit-flow for a while now (see http://crbug.com/908406). Make this the default to later remove and make it less confusingly not new. Bug: 1028600 Change-Id: Iebbb7f5362083155b7c53bdb2da4624b713236bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936494 Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#719163}
-
Aaron Tagliaboschi authored
Adding changes to client hint lifetimes <https://github.com/httpwg/http-extensions/commit/7d24ea40f02ba791c13e5fd70d6932079abf14cf> under the client hint feature policy flag. Bug: 1017166 Change-Id: Ia4d63777c4a4fcb150d4e854312851105fa0a11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919953Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#719162}
-
Tao Bai authored
This reverts commit 5347b384. Reason for revert: The downstream has rolled to my change, this patch should be good to go. Original change's description: > Revert "Upstreaming ContentCapture" > > This reverts commit edc475ed. > > Reason for revert: Causes compilation failure: > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8895755054118235408/+/steps/compile/0/stdout > > ../../clank/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderForQ.java:26: error: method does not override or implement a method from a supertype > @Override > ^ > > > > Original change's description: > > Upstreaming ContentCapture > > > > Related downstream change: > > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 > > > > Binary-Size: all added code was from downstream, the size increase is expected. > > Bug: 951275 > > Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603 > > Reviewed-by: Changwan Ryu <changwan@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Tao Bai <michaelbai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718894} > > TBR=michaelbai@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org > > Change-Id: Id904c28aa48d561ccea36942da1f507982a698dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 951275 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935578 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719031} TBR=michaelbai@chromium.org,yosin@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org Change-Id: I1aeb6ccb43989d58aa872860d2048b1eff2815ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936969Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#719161}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e78d04eb..1da43bc4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic561beb4f0df5f437767b07c1451714019941e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936847Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719160}
-
Yoav Weiss authored
Resource Timing entries' `workerStart` attribute exposes the time it took for a service worker to get started. In the case of cross-origin iframes, this means that the parent frame becomes aware of whether a child frame has a Service Worker installed. It shouldn't do that without an explicit opt-in from the iframe, in the form of a Timing-Allow-Origin header. Bug: 1026404 Change-Id: Ibf86bc2c4fc2657411dc07515ce1405e5e133766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924520Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#719159}
-
Mihai Sardarescu authored
CoreAccountId objects should not be constructed directly by the clients of the IdentityManager. Instead they should be using the IdentityManager API to create CoreAccountId objects. This CL only allows tests to directly create CoreAccountId objects. Bug: 1028182 Change-Id: I3b893e0d24cacfcc85536e8781cd354e22566cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926501Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#719158}
-
Vladimir Levin authored
This patch removes the published WPT tests for intrinsic-size, since we believe that the feature as it stands isn't as useful as we initially thought. R=chrishtr@chromium.org Change-Id: Ie6cb1ebdd7e36be9cfc039406563ba8c603c37a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934244Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719157}
-
bungeman authored
https://chromium.googlesource.com/external/github.com/libexpat/libexpat.git/+log/25d3c190c69e..63abbcdb3b74 $ git log 25d3c190c..63abbcdb3 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 bhargava.shastry CMake: Enable oss-fuzz integration 2019-11-17 bhargava.shastry parsebuffer fuzzer: Bail out on empty fuzzer input 2019-11-04 luzpaz Fix source comment typos 2019-10-26 sebastian xmlparse.c: Improve warning regarding lack of high quality entropy (#172) Created with: roll-dep src/third_party/expat/src R=bungeman@chromium.org,dcheng@chromium.org Change-Id: I3601728881f639c6109607993e508ff5eda9a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931537Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719156}
-
W. James MacLean authored
Since the test fails even when the embedder WebContents and the iframe for the text area both have focus (in the browser process), then next theory is that focus hasn't had time to propagate to the DOM in some cases. This CL adds a retry mechanism in the JS code that tests for initial focus in the iframe containing the text area. TBR=alexmos@chromium.org Bug: 1024672 Change-Id: I4a35a6e1c7858b207b65d41d954b3e5a618a2af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935023Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#719155}
-
Andrew Grieve authored
TBR=agrieve # Markdown Change-Id: I83ddd80a0e334470f1752a6d2d9b6a25673322ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927129Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719154}
-
Vasiliy Telezhnikov authored
This CL adds TextureQuads5x5SameTex to viz_perftests to test batching of DrawQuads. It draws 25 simple TextureQuads with the same resource_id so they can be batched in one draw call. Change-Id: I107e6cd8aaddcc67e1fc3afbcf8fe2e60767ace2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936529Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719153}
-
Andrew Grieve authored
And fix last few warnings that crept it. Bug: 894616 Change-Id: I5d6d43e585c9fff1f0672a7f95b17a0d2e900194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933769 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#719152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1cb75450db1..01adcafce0bf Created with: gclient setdep -r src-internal@01adcafce0bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icf3bc3bf72f51e86fe3650774c24f82e2eb12fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935939Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a88655daf934..ef4ab7682b6c git log a88655daf934..ef4ab7682b6c --date=short --first-parent --format='%ad %ae %s' 2019-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdce3460..65c32b57 (718772:719106) Created with: gclient setdep -r src/third_party/webrtc@ef4ab7682b6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d1fa007ef9ed85e350239defb4cbea9bddea952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719150}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d0dd9068ec64..b62621c1dd8e git log d0dd9068ec64..b62621c1dd8e --date=short --first-parent --format='%ad %ae %s' 2019-11-26 tneda@google.com perfetto-ui: Moving heap profile flamegraph to details panel Created with: gclient setdep -r src/third_party/perfetto@b62621c1dd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idf2e710b54627fbdb303fe22556224e701d3de5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719149}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=dtapuska@chromium.org Bug: 1023677 Change-Id: I56b64adfb8db9789f58acdc4a210299c32430b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927002 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719148}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ab63fd28450a..4cef8a49b49d git log ab63fd28450a..4cef8a49b49d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 lehoangq@gmail.com Metal: Support depthRange near > far Created with: gclient setdep -r src/third_party/angle@4cef8a49b49d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7e2140478e2ad8c39fe57b4fbde4d83d22b8471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719147}
-
Benoît Lizé authored
Bug: 979638 Change-Id: I7ea71dbe79489648fe418f439224a2e2fa11a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930737 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719146}
-
Greg Thompson authored
This change introduces the //rlz:rlz_lib_no_network source_set for use by Chrome's installer on Windows. This breaks a dependency on a slew of networking pieces that bloat setup.exe. Results from building chrome/installer/setup at r718552: - before: 6536 build targets -- 2,590,720 bytes - after : 2390 build targets -- 2,298,880 bytes - 4,146 fewer build targets (63.43% reduction) - 291,840 bytes smaller (11.26% reduction) BUG=1026780 Change-Id: I99892e6b0b9f730e1467a9af1af55c42ddeb8903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932803Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719145}
-
Sebastien authored
Created a new DataFilesParser class which wraps the file IO operations, allowing us to mock these calls in unit tests. The file reading operation is kicked-off in a task posted on the thread pool to make sure we're not blocking the calling thread. In this CL, the highlighted game is simply the first game in the catalog. A future CL will update that logic. Bug: 1018201 Change-Id: Ic7bb5795344a7a3b4017587d7041ace77d921b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928205 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719144}
-
Kinuko Yasuda authored
Change-Id: Ib180117dea189876c2e095a114277b6e2d1ba6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935972 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719143}
-