GitLab

In JavaScript (and v8), functions and arrays are both considered
objects. However, for the sake of argument matching in extension APIs,
we shouldn't consider them as such. This is to help in our ambiguous
argument matching, where we allow optional inner parameters.

For instance, given an API function that takes an int, an optional
object with no required properties, and an optional callback, the
system wouldn't necessarily be able to tell that, given a call of
foo(1, function() {}), it was passed the callback rather than the
object. This is exactly the scenario that arises with tabs.sendMessage.

While we could potentially make our matching more intelligent to
account for this case, it doesn't seem worth the extra complexity (and
speed cost). Instead, simply don't allow functions or arrays as
object parameters.

Add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2621883002
Cr-Commit-Position: refs/heads/master@{#442671}

BUG=654071

Review-Url: https://codereview.chromium.org/2617413003
Cr-Commit-Position: refs/heads/master@{#442670}

Previously, an oscillator would start at the nearest sample frame
boundary.  This can produce noticeable effects.

Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.

BUG=631576
TEST=Oscillator/start-sampling.html

Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#442669}

BUG=678828

Review-Url: https://codereview.chromium.org/2619813002
Cr-Commit-Position: refs/heads/master@{#442668}

The session type will be used to restrict extension features to
auto-launched kiosk sessions - kiosk session that are launched
automatically from the login screen, without user interaction.

To be able properly est auto launched flag, browser process
feature session type initialization is moved to
AppLaunchController, class which controls kiosk app launch.

Also, move browser process feature session type initialization
from ChromeUserManager::UpdateLoginState to
UserSessionManager::PerformPostUserLoggedInActions (for regular
users), which seems like a more suitable place.

BUG=676213

Review-Url: https://codereview.chromium.org/2601803003
Cr-Commit-Position: refs/heads/master@{#442667}

Review-Url: https://codereview.chromium.org/2618133002
Cr-Commit-Position: refs/heads/master@{#442666}

Removed all related code, we converted all call sites to
CustomTabActivity.

BUG=673522

Review-Url: https://codereview.chromium.org/2587193002
Cr-Commit-Position: refs/heads/master@{#442665}

https://pdfium.googlesource.com/pdfium.git/+log/3128d1c45d8b..d18b8674378b

$ git log 3128d1c45..d18b86743 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 tsepez Remove some CFX_ArrayTemplate in fpdfapi and fpdfdoc

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2622893004
Cr-Commit-Position: refs/heads/master@{#442664}

This should help reducing the flakiness of this test, which is currently ~65%:
http://test-results.appspot.com/flakiness/dir/http/tests/inspector/network. The
text diff shows that actual number of items that are cached is different from
the expected: https://justpaste.it/11bq3.

R=allada@chromium.org
BUG=673378,678486

patch from issue 2570553002 at patchset 180001 (http://crrev.com/2570553002#ps180001)

Review-Url: https://codereview.chromium.org/2620793002
Cr-Commit-Position: refs/heads/master@{#442663}

Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed.  Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.

AudioParam should get processed so that time progresses.  Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs).  Then we just need to update the AudioParams, without having
to do the full processing associated with the node.

See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are
processed.  There are no conditions on when this happens.

BUG=647974
TEST=audioparam-processing.html

Review-Url: https://codereview.chromium.org/2420983002
Cr-Commit-Position: refs/heads/master@{#442662}

This is more idiomatic and cleaner.

BUG=673883

Review-Url: https://codereview.chromium.org/2623723002
Cr-Commit-Position: refs/heads/master@{#442661}

Revert of Fix getUserMedia so that failure is reported for invalid audio sources. (patchset #2 id:250001 of https://codereview.chromium.org/2622643006/ )

Reason for revert:
Reverting for later reland (and review)

Original issue's description:
> Reland of Fix getUserMedia so that failure is reported for invalid audio sources. (patchset #1 id:1 of https://codereview.chromium.org/2626533002/ )
>
> Reason for revert:
> Preparing reland
>
> Original issue's description:
> > Revert of Fix getUserMedia so that failure is reported for invalid audio sources. (patchset #2 id:20001 of https://codereview.chromium.org/2623443002/ )
> >
> > Reason for revert:
> > Revert due to WebRTC tests failing:
> >
> > https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56312
> >
> > [4832:364:0109/131325.673:4351226:ERROR:browser_test_utils.cc(147)] Cannot communicate with DOMMessageQueue.
> > c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(66): error: Value of: ExecuteScriptAndExtractString(shell(), javascript, &result)
> >   Actual: false
> > Expected: true
> > Failed to execute javascript callAndRenegotiateToVideo({audio: true}, {audio: true, video:true});.
> > From javascript: (nothing)
> > When executing 'callAndRenegotiateToVideo({audio: true}, {audio: true, video:true});'
> > c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(90): error: Failed
> >
> > and
> >
> > [4704:4156:0109/131352.840:4378402:ERROR:browser_test_utils.cc(147)] Cannot communicate with DOMMessageQueue.
> > c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(66): error: Value of: ExecuteScriptAndExtractString(shell(), javascript, &result)
> >   Actual: false
> > Expected: true
> > Failed to execute javascript getUserMediaInIframeAndCloseInSuccessCb({audio: true});.
> > From javascript: (nothing)
> > When executing 'getUserMediaInIframeAndCloseInSuccessCb({audio: true});'
> > c:\c\win\src\contentrowser\webrtc\webrtc_content_browsertest_base.cc(90): error: Failed
> >
> > Original issue's description:
> > > Fix getUserMedia so that failure is reported for invalid audio sources.
> > > This changes getUserMedia to wait for initialization of local
> > > audio sources before issuing the completion callback (either success or
> > > failure).
> > > Previously, if an error occurs between attempting to start a local
> > > audio source and the render side OnStreamCreated callback, getUserMedia
> > > would report successful completion with an audio track but no audio
> > > would actually be delivered for that track.
> > >
> > > BUG=679210
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > >
> > > Review-Url: https://codereview.chromium.org/2623443002
> > > Cr-Commit-Position: refs/heads/master@{#442323}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/81cb66acf3f8099e416c7fc5ecbcaabf6d5c3c04
> >
> > TBR=jochen@chromium.org,guidou@chromium.org,xhwang@chromium.org,tommi@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=679210
> >
> > Review-Url: https://codereview.chromium.org/2626533002
> > Cr-Commit-Position: refs/heads/master@{#442373}
> > Committed: https://chromium.googlesource.com/chromium/src/+/f05caaa1349e44abd44a00f88506bf140a0bc887
>
> TBR=jochen@chromium.org,guidou@chromium.org,xhwang@chromium.org,dewittj@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> BUG=679210
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2622643006
> Cr-Commit-Position: refs/heads/master@{#442628}
> Committed: https://chromium.googlesource.com/chromium/src/+/5d02cf8e38acafeea410906105d5fc11c3e3395b

TBR=jochen@chromium.org,guidou@chromium.org,xhwang@chromium.org,dewittj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679210

Review-Url: https://codereview.chromium.org/2628603003
Cr-Commit-Position: refs/heads/master@{#442660}

Move the inherited property -webkit-rtl-ordering and its enum, EOrder,
to be generated in ComputedStyleBase, and updated enum values to the
new k-prefix style. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase, and changed
the naming from RTLOrdering to RtlOrdering to be consistent with the
naming of other methods.

BUG=628043

Review-Url: https://codereview.chromium.org/2622623003
Cr-Commit-Position: refs/heads/master@{#442659}

https://codereview.chromium.org/2022303002 removed references to this field trial from Chromium

BUG=None

Review-Url: https://codereview.chromium.org/2620033002
Cr-Commit-Position: refs/heads/master@{#442658}

The billing addresses in the dropdown contain edit required information
and are sorted by completeness.
Select incomplete address brings up address editor.
Select previously selected address or null if user cancels from address editor.
Select and add the newly added or completed address to the top of the dropdown.

BUG=675686

Review-Url: https://codereview.chromium.org/2614193002
Cr-Commit-Position: refs/heads/master@{#442657}

https://skia.googlesource.com/skia.git/+log/0ab977f2314d..356f7c2600ef

$ git log 0ab977f23..356f7c260 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 reed support external raster handles
2017-01-10 mtklein remove xbyak experiment
2017-01-10 msarett Make SkImage_Base::onReadPixels() pure virtual

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2616353005
Cr-Commit-Position: refs/heads/master@{#442656}

- use a cursors.Cursor rather than a node; sometimes, nodes are destroyed when the Panel receives focus. A cursor will resolve to the ancestors of the destroyed node
- ensure event handlers are always unregistered
- fix the pending callback to ensure we always set focus to the right search hit

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2621773003
Cr-Commit-Position: refs/heads/master@{#442655}

This resulted in ash drawing the title for chrome windows when it
shouldn't have.

BUG=none
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2624733004
Cr-Commit-Position: refs/heads/master@{#442654}

TaskSchedulerImpl can't be destroyed without being joined first.

BUG=553459

Review-Url: https://codereview.chromium.org/2628533003
Cr-Commit-Position: refs/heads/master@{#442653}

This adds a new ClipNode type (EXPANDS_CLIP) and uses such nodes to
account for the fact that certain kinds of effects have output that
depends on pixels that later get clipped out.

BUG=653631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/5e48a2e0284b930c68e73f44ea15807a9ffab541
Cr-Original-Commit-Position: refs/heads/master@{#429050}
Review-Url: https://codereview.chromium.org/2423483003
Cr-Commit-Position: refs/heads/master@{#442652}

BUG=679551

Review-Url: https://codereview.chromium.org/2620823002
Cr-Commit-Position: refs/heads/master@{#442651}

It's only got one value, and there are no plans to add more.

BUG=679789

Review-Url: https://codereview.chromium.org/2621103002
Cr-Commit-Position: refs/heads/master@{#442650}

This should narrow some dialogs in settings, and have no functional
affect on history.

R=dpapad@chromium.org
BUG=640092
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623673003
Cr-Commit-Position: refs/heads/master@{#442649}

Use the window to get the correct display instead.

BUG=625089

Review-Url: https://codereview.chromium.org/2615793003
Cr-Commit-Position: refs/heads/master@{#442648}

BUG=620813

Review-Url: https://codereview.chromium.org/2583223002
Cr-Commit-Position: refs/heads/master@{#442647}

Unit test must cleanup after themselves if the register a test
ChromeBrowserStateManager with the ApplicationContext. Introduce
IOSChromeScopedTestingChromeBrowserStateManager to help with the
registration by using RAII.

BUG=None

Review-Url: https://codereview.chromium.org/2622913002
Cr-Commit-Position: refs/heads/master@{#442646}

BUG=672340

Review-Url: https://codereview.chromium.org/2614023003
Cr-Commit-Position: refs/heads/master@{#442645}

R=alokp@chromium.org,yzshen@chromium.org
BUG=crbug.com/665118
TEST=cast_shell_unittests

Review-Url: https://codereview.chromium.org/2621793003
Cr-Commit-Position: refs/heads/master@{#442644}

Adding example test with render tests to FYI bot. If everything
works as intended, will enable this on all bots. Will also switch
implementation from needing to be configured by manually setting
render_results_dir to detecting the render_results_dir automatically.

Review-Url: https://codereview.chromium.org/2625673003
Cr-Commit-Position: refs/heads/master@{#442643}

Revert of Make helpful announcement when there's no focus (patchset #1 id:1 of https://codereview.chromium.org/2585943002/ )

Reason for revert:
Interferes with ARC++; blocked on native ARC++ ChromeVox support.
BUG=679760

Original issue's description:
> Make helpful announcement when there's no focus
>
> BUG=638705
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/c689031affc2246cb94c98a707d5ab7c7b737993
> Cr-Commit-Position: refs/heads/master@{#439606}

TBR=dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=638705

Review-Url: https://codereview.chromium.org/2626683002
Cr-Commit-Position: refs/heads/master@{#442642}

Revert of A simple, practically zero cost fallback crash handler for Crashpad handler process. (patchset #13 id:240001 of https://codereview.chromium.org/2596463002/ )

Reason for revert:
Failing on Win10 Tests x64 bot on main waterfall.

Original issue's description:
> A simple, practically zero cost fallback crash handler for Crashpad handler process.
>
> This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking.
>
> BUG=678959
>
> Review-Url: https://codereview.chromium.org/2596463002
> Cr-Commit-Position: refs/heads/master@{#442596}
> Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678959

Review-Url: https://codereview.chromium.org/2621113002
Cr-Commit-Position: refs/heads/master@{#442641}

Currently there is no UI for media metadata and controls on
WebView. Therefore we should disable the API on WebView. It is
reasonable to let the host app show the UI itself on WebView.

The API intent to ship is still pending approval so it's not
enabled on any platform by default yet. After getting approved,
the next step is to just enable the API on Android and WebView
will be excluded because of this CL.

Intent to ship (pending approval):
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xIpJ_303phw

BUG=678979

Review-Url: https://codereview.chromium.org/2613133003
Cr-Commit-Position: refs/heads/master@{#442640}

BUG=

Review-Url: https://codereview.chromium.org/2609713002
Cr-Commit-Position: refs/heads/master@{#442639}

Fix several bugs related to the menu items displayed in CCT, including:
1. The text message shown on the snackbar for bookmarked page is
incorrect. Current text message displayed is "Open in [Chrome Dev]" and
the correct one should be "Bookmarked in [Chrome Dev"].
2. "Find in page", "Add to Home screen",  "Request desktop site" and
"Open in browser" items should not be displayed in Media Viewer CCT.
Hide these items if it is Media Viewer and also add a test case for it.
3. Disable download item if CCT loads a chrome native page.

BUG=679255,679256

Review-Url: https://codereview.chromium.org/2620763004
Cr-Commit-Position: refs/heads/master@{#442638}

This is the complement to the Precache.CacheStatus.NonPrefetch UMA. It
helps us to answer oft-asked questions about where the service is
providing the most benefit.

BUG=679543

Review-Url: https://codereview.chromium.org/2628513002
Cr-Commit-Position: refs/heads/master@{#442637}

BUG=673814
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2616403004
Cr-Commit-Position: refs/heads/master@{#442636}

The Java API to fetch histograms provides several timeout
values we can set - specifically, the connect time timeout
can be set separately.

Add a separate histogram to measure this to understand
what the data from the wild is like - especially on slow
connections.

BUG=632199

Review-Url: https://codereview.chromium.org/2619383003
Cr-Commit-Position: refs/heads/master@{#442635}

Start to remove usage of native device_display_info.h and eventually
removing it altogether.

RenderWidgetHostViewAndroid uses the primary display size to calculate
the max texture size. Loop over all Displays and use the largest one to
calculate this instead.

Note need to add storage for physical size in Display, since there are
rounding errors if the physical size is computed from float scale and
integer dip size.

BUG=625089

Review-Url: https://codereview.chromium.org/2617623002
Cr-Commit-Position: refs/heads/master@{#442634}

testSyncTypedURLDeleteFromServer test failed with timeout waiting for
FakeServer to receive updates. I'm trying to verify if it happened because of
the slow hardware in the lab. To do so I'm increasing kSyncOperationTimeout to
10 seconds.

BUG=672286
R=bzanotti@chromium.org

Review-Url: https://codereview.chromium.org/2624543003
Cr-Commit-Position: refs/heads/master@{#442633}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2623533003
Cr-Commit-Position: refs/heads/master@{#442632}