- 05 Oct, 2018 40 commits
-
-
Becca Hughes authored
Add an ArcMediaSession bridge that will send an AudioFocusManager mojo pointer to Android. This will allow us to access the media session service in Chrome from Android and in the future allow us to delegate audio focus requests. BUG=883958 Change-Id: I5a00e93ce1a1e4608d3f934522188b6252906cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1225607Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#597191}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I00a5e946eff9d7eeba32bfe0a45a7fd6fc804827 Reviewed-on: https://chromium-review.googlesource.com/c/1265157Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#597190}
-
Paul Jensen authored
Bug: 892666 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ic9a5cedb520d339b458c2208a6dbb6e57be4cc34 Reviewed-on: https://chromium-review.googlesource.com/c/1264898Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597189}
-
Clark DuVall authored
These test the basic proxy usage and headers. We can add more tests here if necessary to help track what's not working with network service. Bug: 721403 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I09c0181ee4cdac97b4c532630f274f2418858d5d Reviewed-on: https://chromium-review.googlesource.com/c/1263038Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597188}
-
James Wallace-Lee authored
The benchmark was not completely removed in crrev/c/1143595. Bug: 769809 Change-Id: I131b226b7388d97eb380943275b6b16c222d2260 Reviewed-on: https://chromium-review.googlesource.com/c/1257669Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#597187}
-
Tom Anderson authored
This CL fixes a bug after [1]. The issue was setting "window_mapped_in_client_ = false" after XIconfiyWindow(). Despite the ICCCM spec requiring the state transition "Iconic -> Normal - The client should map the window" [2], the window is not actually placed in an unmapped state. Instead, the _NET_WM_STATE_HIDDEN property is set. [1] https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65 [2] ftp://www.x.org/pub/current/doc/xorg-docs/icccm/icccm.html BUG=891376 R=sky Change-Id: Ibfcc66a54249bad8926d23cd4eabf1e6979f7d07 Reviewed-on: https://chromium-review.googlesource.com/c/1263431Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597186}
-
Alexandr Ilin authored
content::PreconnectUrl() is about to be removed and AuthPrewarmer is the last caller. This CL makes AuthPrewarmer to use NetworkContext::PreconnectSockets() for prewarming a connection to the signin server. Bug: 875238 Change-Id: I0865d6d9566b13f71ee0ac59e8a583bc7c401099 Reviewed-on: https://chromium-review.googlesource.com/c/1261717 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#597185}
-
Jonathan Metzman authored
This reverts commit 01602d56. Reason for revert: /O1 is not the clang-cl equivalent of -O1 Original change's description: > [libFuzzer][Windows] Enable optimize_for_fuzzing > > Bug: 890639 > Change-Id: Icb2be76982816119a30925fa92121445b5ca5141 > Reviewed-on: https://chromium-review.googlesource.com/c/1253023 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596757} TBR=thakis@chromium.org,scottmg@chromium.org,mmoroz@chromium.org,metzman@chromium.org Change-Id: Ic407400440a3e6c58940b77708ab5334736242bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890639 Reviewed-on: https://chromium-review.googlesource.com/c/1264680Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597184}
-
Dan Harrington authored
DCHECK(committed_error_page_info_->auto_reload_triggered) was failing. This is possible because when assigning a new value to committed_error_page_info_, the auto load timer can still be active. R=jianli Bug: 881208 Change-Id: I361df3e17bef122f143331107a76d04487b32fea Reviewed-on: https://chromium-review.googlesource.com/c/1240872Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#597183}
-
Robert Ogden authored
I got a crash earlier today where WillProcessResponse was being called on a non-preview page without response headers, so the DCHECK failed. Moving up the early return makes the navigation throttle more robust against this in the future. Bug: 864635 Change-Id: Ief8e3b2b0ac9179d2ba16ff8f04c950b08f9564d Reviewed-on: https://chromium-review.googlesource.com/c/1265059 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Tarun Bansal authored
To speed up page loads from CCTs, data reduction proxy enabled check is removed from preconnect. Bug: 850609 Change-Id: I111bc05c453a54c4c6d200186c04876faaec063e TBR: lizeb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1264075Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5476e805a321..8efa341839a6 git log 5476e805a321..8efa341839a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 geofflang@chromium.org Suppress EXTBlendFuncExtendedDrawTestES3.FragmentArrayOutputLocationsAP on MacOS 2018-10-05 jmadill@chromium.org GL back-end error refactor. 2018-10-05 syoussefi@chromium.org Vulkan: Safer struct initialization Created with: gclient setdep -r src/third_party/angle@8efa341839a6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ia6926da32ec25e3a307c14617b00c7bdd36fc295 Reviewed-on: https://chromium-review.googlesource.com/c/1265015Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597180}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/032f2756df64..ba651682ae85 git log 032f2756df64..ba651682ae85 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 brianosman@google.com Fix two bugs in GPU special image read-back 2018-10-05 fmalita@chromium.org [skottie] Remove temporary ResourceProvider::load() fallback 2018-10-05 reed@google.com isolate users of SkFindAndPlaceGlyph.h 2018-10-05 robertphillips@google.com Expose the SkYUVAIndex version of the SkImage factories 2018-10-05 brianosman@google.com Remove redundant test Created with: gclient setdep -r src/third_party/skia@ba651682ae85 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I5cb0744e655d18db0a6eea6a421c54f5ba8ab6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1264743Reviewed-by:
-
Kyle Horimoto authored
This CL replaces the placeholder setup page with the real page which includes the logic for choosing a multi-device host phone. As part of this CL, WizardController now decides whether or not to show the setup flow based on whether setup is applicable and needed for the GAIA account under question. Bug: 884065 Change-Id: I8f3be643b77890fb249516369d76f5c392a568a9 Reviewed-on: https://chromium-review.googlesource.com/c/1255591 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Tatiana Buldina authored
Add support with remote connection for methods: SetWindowRect(), SetWindowPosition(), MaximizeWindow(), MinimizeWindow() and FullScreenWindow() Bug: chromedriver:1855 Change-Id: I452cd54d2fea79763f87a30edb1d034851ed0eea Reviewed-on: https://chromium-review.googlesource.com/c/1263567 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597177}
-
John Chen authored
Group the command endpoints based on the sources that defined the commands, to improve maintainability. Change-Id: I0bdf68bc2bd56703fa87ca8486f1550ca6bb3c86 Reviewed-on: https://chromium-review.googlesource.com/c/1263875Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597176}
-
Jaeyong Bae authored
If any of sizes or purpose are missing in ImageResource, provide default values for 'purpose' and 'sizes'. Bug: 868875 Change-Id: I2e88144e1d098a18c740ffeaf9a2fb474db031a1 Reviewed-on: https://chromium-review.googlesource.com/c/1244176 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#597175}
-
Christopher Cameron authored
This fix has two parts. First, call -[NSView addSubview:] in views::NativeViewHostMac, instead of calling it in views::BridgedNativeWidgetHostImpl. This will set up the browser-side NSView hierarchy, even when the browser-side NSViews are not visible (because the app-side NSViews are). Second, in BridgedNativeWidgetHostImpl::OnWindowGeometryChanged, update the geometry of the browser-side doppelganger NSWindow to match the geometry of the app-side true NSWindow. This ensures that the context menu appears in the right place. Both of these fixes are band-aids on the larger issue that we should change the gfx::NativeView and gfx::NativeWindow types to be a wrapper interface that will clearly delineate the where the native types are actually manipulated, and where the native types are just plumbed through. Bug: 859152 Change-Id: I8428166dd889f45888432220be70de340574c385 Reviewed-on: https://chromium-review.googlesource.com/c/1263592Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#597174}
-
Adam Langley authored
These are needed in order to avoid unpleasant snake-casing around numbers in, for example, 'webgl_2' caused by a subsequent change that will will use NameStyleConverter more uniformly in bindings generation. Change-Id: I58ac7ca03bf169fdca1c2918848c9f0e3450d422 Reviewed-on: https://chromium-review.googlesource.com/c/1261963 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#597173}
-
Marijn Kruisselbrink authored
This reverts commit 7d7cc8da. Reason for revert: The new browser tests are very flaky and fail regularly, for example in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29408: [9182:775:1005/081300.634221:INFO:CONSOLE(4)] "Throttling navigation to prevent the browser from hanging. See https://crbug.com/882238 and chrome://flags/#disable-ipc-flooding-protection", source: (4) ../../content/browser/navigation_browsertest.cc:1281: Failure Expected equality of these values: 100 count_replace_state Which is: 202 Original change's description: > Prevent renderer process flooding the browser with IPC. > > Some javascript function called in an infinite loop can cause the > browser process to be flooded by IPC and become unresponsive. > > Limit the number of IPC sent to 10 per second per frame. > > This was already done for: > - history.pushState() > - history.replaceState() > > This is extended to: > - history.back() > - history.forward() > - history.go() > - navigations... > > 3 tests added. > > Bug: 882238 > Change-Id: I821ff742307ab471ca52f27c6003d003ee978a46 > Reviewed-on: https://chromium-review.googlesource.com/c/1230067 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596715} TBR=palmer@chromium.org,dcheng@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org Change-Id: I27843365fff5da639091524af85791af0af9ce6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882238 Reviewed-on: https://chromium-review.googlesource.com/c/1265060Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597172}
-
Sebastien Marchand authored
Bug: 876348 Change-Id: Ib932652af7814f421009be79a7e9a1e5413fffd7 Reviewed-on: https://chromium-review.googlesource.com/c/1228505 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#597171}
-
Victor Costan authored
Switching from enum to class enum removes the implicit conversions to int. This CL also switches DeliveryType members from SHOUTY_CASE to kModernConstCase and de-virtualizes a few AppCacheJob methods with a simple implementation. These changes are intended to improve the code's readability. Change-Id: I35f8e8007f7abce2371c3cc8200c9e756529ba1f Reviewed-on: https://chromium-review.googlesource.com/c/1263890Reviewed-by:
-
Greg Kerr authored
Flash player DRM videos are currently broken because the V2 sandbox blocks access to the window server. This allows the access. Bug: 891823 Change-Id: I06116f1de78480fe80b01465a6b9b097066b7278 Reviewed-on: https://chromium-review.googlesource.com/c/1263282Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597169}
-
bsheedy authored
Automates all the manual tests from https://crbug.com/887523, which all relate to omnibox text entry and navigation while in the VR browser. Bug: 887523 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0db4cc10def31779b8a59f63e2a1f227cf0a6e29 Reviewed-on: https://chromium-review.googlesource.com/c/1263433Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597168}
-
Jacob Dufault authored
Change-Id: I9674404c054854d0653a0f2cd61a3b52a85707a8 Reviewed-on: https://chromium-review.googlesource.com/c/1265077Reviewed-by:
-
Nektarios Paisios authored
Reland "If the caret is at the boundary of a misspelling, getting > > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu. On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word. When any of the above keystrokes are pressed, the user hears the whole word. It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu. The result is that many screen reader users might have the mistaken believe that our spell checker is broken. Tested: Manually, unit tests, layout tests Bug: 790828 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I847419f299e1a56c4e32a7d00368f663f66072ff Reviewed-on: https://chromium-review.googlesource.com/c/1252247Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597166}
-
Henrique Grandinetti authored
Some of the tests make assetions on pref values, but they were doing so without guarantees that the latest value were available. To solve the proble, I forced the pending values to be written to the prefs and moved the assertion to the callback that is invoked when this operation has finished. Bug: 891573 Change-Id: I76411e6d93f061b12af2144cc88e9339531dd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1261995 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597165}
-
Stephane Zermatten authored
Before this patch, WebController could not find the form data if that form data was in an iframe. The logic that cleaned up the selector of the element that was clicked on to pass to GetElementFormAndFieldData didn't trigger, as the frame index reported in FindElementResult was 0. This patch takes another approach: it always only pass the last selector to GetElementFormAndFieldData, which should make sense, since we're in the same context as the element that was clicked on. With this patch, Autofill works even when forms are in an iframe. Bug: 806868 Change-Id: Ic7deaf863373659e9143c38cf01a6ca1406e6521 Reviewed-on: https://chromium-review.googlesource.com/c/1264600 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597164}
-
Tarun Bansal authored
Remove DelayRequestsOnMultiplexedConnections from field trial testing config since the experiment is now default enabled in Chromium. Bug: 836552 Change-Id: I9c0e0e233a47f9a92ea0562b77f6dcadea727e5b Reviewed-on: https://chromium-review.googlesource.com/c/1259963Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597163}
-
Xi Cheng authored
Change-Id: I6dbc74bfa3e1cd27b9893c1d55c3e9277dc08d32 Reviewed-on: https://chromium-review.googlesource.com/c/1261968Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597162}
-
Becky Zhou authored
Bug: 888996 Change-Id: I00f30d4e2ea06be82d5f8872b2e31cf6a6bd1415 Reviewed-on: https://chromium-review.googlesource.com/c/1263556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597161}
-
Stephane Zermatten authored
Before this patch, WaitForDomAction could get into situation where rounds was < 0 and crash in debug mode. This could happen if timeout_ms was very small or at the end, if the element was not found. This patch fixes the round counting and dchecks. With this patch, WaitForDomAction won't crash in debug mode when the element cannot be found. Bug: 806868 Change-Id: I308883441876df66225550b9ddc43d1894a48de6 Reviewed-on: https://chromium-review.googlesource.com/c/1264576Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597160}
-
Ben Pastene authored
If chrome crashes on startup, the test itself will fail gracefully after ~7 min. Bumping timeout let's us hit that reliably, and lets the test do some cleanup. (Instead of killing it early.) R=jbudorick Change-Id: I9c23198e3267b3a438b9a41daadb4ba70e20de4d Reviewed-on: https://chromium-review.googlesource.com/c/1262799Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#597159}
-
Robert Ogden authored
The rest of the strings in the Preview Page Info dialog don't have periods at the end, so remove this one too. Bug: 871839 Change-Id: I3d70e667aaace71df1586bf670c03e1fac55d02e Reviewed-on: https://chromium-review.googlesource.com/c/1264935Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c11f3dcc855..f8ef3c03bb5d git log 4c11f3dcc855..f8ef3c03bb5d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 lalitm@google.com Merge "trace_processor: fix sorting of events in sched tracker" Created with: gclient setdep -r src/third_party/perfetto@f8ef3c03bb5d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibd2a135f8f13d9e6401a5eb19c145500a27a766f Reviewed-on: https://chromium-review.googlesource.com/c/1264631Reviewed-by:
-
manuk authored
A line was accidentally left out when moving code in the previous cl [1] resulting in outputs from the previous query not being cleared when making a new query when the `Show incomplete results` option was enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1252324 Change-Id: I12f8465898171badff2e6c4f69fcbcaf121f680b Bug: 891303 Reviewed-on: https://chromium-review.googlesource.com/c/1264815Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#597156}
-
kylechar authored
Three video related tests are failing flakily on the Android FYI trybots. Failures have been seen on Nexus 9 and Nvidia Shield primarily, so will set them flaky for nvidia boards. TBR: kbr@chromium.org Bug: 891456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I64d768be4cabf246b6e0ab007c87c2292a8adf42 Reviewed-on: https://chromium-review.googlesource.com/c/1263037Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597155}
-
Stephane Zermatten authored
Before this patch, the overlay was displayed when Autofill Assistant was created. This is confusing: the overlay is meant to reflect the fact that scripts are running, but no scripts are running at that point and there might never be any scripts. With this patch, the overlay is only displayed when a script is run. Bug: 806868 Change-Id: I2e1916a0253efb164b4b000c92f2cfef6a1703ad Reviewed-on: https://chromium-review.googlesource.com/c/1264677Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/060ca87d..949f77f4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cfbc94e8650675582b8f2e6169b9cb6943e6e93 Reviewed-on: https://chromium-review.googlesource.com/c/1264735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597153}
-
Robert Ma authored
This reverts commit e9f339db. Reason for revert: issue has been solved. Original change's description: > [WPT export] More temporary logging to debug crash > > The working theory is that the locale isn't correctly set in the > Python process. The interactive shell on the bot does have a UTF-8 > locale, but the environment of the Python process could be different. To > verify this, we add some more logging to wpt-export. > > This CL will be reverted once the issue is resolved. > > Bug: 891831 > Change-Id: Ice6478a2b4f3805f2a68b4e2b782f0f23e9aeb99 > Reviewed-on: https://chromium-review.googlesource.com/c/1261974 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596782} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: Icf05a7a7163a948fba10ff3991df2ccc34b4865a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891831 Reviewed-on: https://chromium-review.googlesource.com/c/1265017Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#597152}
-
