- 21 Jul, 2020 13 commits
-
-
Sammie Quon authored
Modify the highlight path generator to use a round rect override so that the ink drop clipping code will pick it up. Tab close buttons use the content bounds, all other usages use the local buttons + fixed inset, so tweak the API to allow for this. Test: manual Bug: 1056490 Change-Id: I9815c50ba1f79b3a40284c628eafcf50bcd9ce58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307694 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#790197}
-
Peter Wen authored
Turn off lint for chrome_public_test_apk as it was generating a lot of warnings and errors that prevented relanding this lint CL ASAP. The baseline was generated from monochrome_bundle, which covered almost all the other lint targets with the exception of chrome_public_test_apk. Since it was only possible to easily generate a baseline from one target, it is faster to disable chrome_public_test_apk for the time being. Tbr: Submit before new errors are introduced Bug: 1107450 Fixed: 1107450 Change-Id: Id0aaeaa6eaf7d1b561617a2ff5840401599730ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308852Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790196}
-
Alex Ilin authored
This CL applies 3 minor changes to the reauth dialog style: - Left-align the title - Use the grey color for the body text - Reduce the margin the title and the body text Bug: 1107522 Change-Id: I6d37b4fc968a89dac96e94157c93a427de7ac924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307949 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#790195}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c8ae494401bc..6d0ab954e90c 2020-07-20 reed@google.com read/write m44 2020-07-20 egdaniel@google.com Make sure we free secondary command buffers we don't cache. 2020-07-20 johnstiles@google.com Reduce number of trials needed by ProcessorOptimizationValidationTest. 2020-07-20 brianosman@google.com Rearrange logic in SkRuntimeEffect::Make 2020-07-20 zepenghu@google.com update markdown files 2020-07-20 egdaniel@google.com Add support for holding onto refs for input buffers from bindBuffer calls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I984fa7f0d5a1bf4e5d54ca5d53e3794d177e2557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790194}
-
David Tseng authored
R=akihiroota@chromium.org Fixed: 1106462 AX-Relnotes: only announce a modifier once, when holding down modifiers like Search in ChromeVox Learn Mode. Change-Id: Iaa9de466462450ccef889a2b789b0c150127c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308489Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#790193}
-
Kevin McNee authored
|CrashTab| uses 0 as the exit code which makes the process appear to have terminated normally. The exit code passed to |RenderProcessHost::Shutdown| is only actually used on Windows, so this still appeared as a crash on other platforms. We now specify a non-zero exit code, so that callers of |CrashTab| observe a crash on Windows. Bug: None Change-Id: Iaafca2aeed50612ad0de01d06f65183e11d63783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303988 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790192}
-
Haiyang Pan authored
This is to see the how the builder works on 4 cores, compared with that on 8 cores. Bug: 997376, 1098111 Change-Id: Ia37109b5860be81ebf208e838a501ec6b48e6307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309131Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#790191}
-
Yoichi Osato authored
This change prevents the network service from crashing when it is unable to allocate a datapipe. Change-Id: I952b6be788bd651e443476cda634f4f633c4a38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297210Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#790190}
-
bttk authored
A change of the meaning of shared preferences starting with "HasRequestedAndroidPermission::" Without one-time permissions it was enough to remember *if* the user was asked for an Android permission. But now, we need to remember user's response. A permission that at first was granted can be later denied without any user action. This change is tested using the newest methods provided by Robolectric and androidx.test Robolectric.buildActivity is a low-level tool for managing Activity lifetime and Robolectric.setupActivity is deprecated in favor of androidx.test.core.app.ActivityScenario For the ActivityScenario to work, the Activity used in test must be declared in the AndroidManifest Change-Id: I2f809e43dd4790a09cdac08cc0e0803a6fed086e Bug: 1096085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285470 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790189}
-
Mike Dougherty authored
This test was incorrectly relying on a tap to bring up the system selection callout. Replace the tap action with a long press. Fixed: 1099361, 1078784 Change-Id: Ib8dfb5ed9fd0056b09e6844302e2ef2e9fed5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302714 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#790188}
-
Collin Baker authored
FeaturePromoBubbleView::CreateOwned() has many arguments, but only three are absolutely needed. This adds a CreateParams struct with sane defaults that is used instead. The method is also renamed to FeaturePromoBubbleView::Create(). CreateOwned() was supposed to imply the return pointer is owned by the implementation and not the client, but this is can be easily confused to mean the pointer comes with ownership. Since this function was written, we adopted the practice of using unique_ptr<> to denote owned pointers. Now simply returning a raw pointer implies lack of ownership. Bug: 1106523 Change-Id: Ic626b6cec342ddebc1f07b128f9c5757fe468e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303865 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#790187}
-
Becca Hughes authored
Change-Id: I98b421dfac9adda34448c645c0432d7a9ad2455c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303854Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790186}
-
Yuwei Huang authored
Protobuf HTTP would respond with the status message as the respond body if the request has failed. This CL makes ProtobufHttpClient directly convert that message into a ProtobufHttpStatus, so that we can get better error messages. Bug: 1103416 Change-Id: Ic82533ce4d3df51d8602550ad9fd7a77ee754e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309137 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#790185}
-
- 20 Jul, 2020 27 commits
-
-
Peter Kasting authored
These histograms have been expired for some length of time and thus are no longer recorded, so this code is dead. Bug: none Change-Id: I36356c75dbde429daa285b9f7fd894a09e3d0e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305243 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790184}
-
Courtney Goeltzenleuchter authored
Recent change reduces the number of renderpasses by using inline clears with the Vulkan backend. This appears to have found some issues with the Intel Vulkan driver on Windows. Bug: b/161553839 Bug: angleproject:4855 Change-Id: I5ebc36e20f0b9aeed6bd88b487cf860e7b52be93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307613Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790183}
-
Nasko Oskov authored
The test was flaky because it uses DidCommitUrlReplacer which expects all RenderFrameHosts it sees being deleted to have been created. The main navigation to the starting test page causes a cross-process navigation and if the test system is slow, the UnloadACK IPC can be delayed until the pointe after which the DidCommitUrlReplacer is created. If that happens, the DCHECK in the RenderFrameDeleted implementation is hit. The fix for the test is to wait for the frame to be deleted, which will guarantee that the DidCommitUrlReplacer will not see the frame deletion regardless of how slow the machine runs. Bug: 1106893 Change-Id: I3174f8c2fc11bc69db226c59065e214dfc58705c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304554Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790182}
-
Nektarios Paisios authored
AXPosition can convert positions in the DOM tree to their equivalent positions in the accessibility tree and vice versa. Ordinarily, DOM positions are produced with their corresponding affinity. However, it would be convenient to be able to retrieve DOM positions without affinity. Broken out from https://crrev.com/c/2289852 AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I9cb626d336af425f1349fab375dc22726d4f13b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308331 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#790181}
-
Mounir Lamouri authored
Initially meant to reduce flakiness but may not be related. However, the rewrite itself may not be a bad idea for readability. Bug: 1103820 Change-Id: I16420d0bbccd9665df6b3abd48139ed774ab934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304447Reviewed-by:
-
Owen Min authored
The cloud reporting extension has been deprecated multiple milestones before. Hence revoking its private extension API permission. Bug: 922140, 1107440 Change-Id: I7d2dfb5dd9d05f2bdc702505666fdfb6cff67f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307435Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790179}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia65e442d6361b1553a18ae08bdf8a96487ce2e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308690Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b655a28e1097..9949ab7a4b1c 2020-07-20 saagarsanghavi@google.com Preliminary changes to git cl and presubmit_support 2020-07-20 ehmaldonado@google.com bot_update: Refactor branch to detach and checkout. 2020-07-20 cwallez@chromium.org gclient: deprecated use_relative_hooks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104182,chromium:1107325 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ib9176861c2f0465216f9c0abe504752c1b5c6764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308869Reviewed-by:
-
Piotr Pawliczek authored
Printer URI validation fails when detected queue name does not start from a slash character. This patch corrects this problem. BUG=none TEST=tested on atlas with Brother printer Change-Id: I3aaf2b82c55ebdcd3388a7067f0005cf12c618e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306820 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#790176}
-
Ben Pastene authored
It's been enabled on a couple internal testers for a while now. This enables it for the remaining bots. No-Try: true Bug: 1057152 Change-Id: I31c53dc79e6b050212f4f349ed1948b794f6d5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308515 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#790175}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6caaa1da7bfa..a30bbb68c2e3 2020-07-20 malets@yandex-team.ru Add support for "nestable instant" events in trace importer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106270 Tbr: sadrul@google.com Change-Id: Ic08817476de6e042ae8dcb06911172679adf5d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308970Reviewed-by:
-
Karandeep Bhatia authored
BUG=1107634 TBR=michaelludwig@google.com Change-Id: I725692d4847c28540cc9fbdd540ef2846e4c01be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308937 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Tommy Nyquist authored
The test testStorageDoesNotLeakFromActivityToActivity is flaky. TBR=roagarwal@chromium.org Bug: 1107600 Change-Id: Idd775416640e0b9b9d7e2866307261397abc4d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308932Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#790172}
-
Peter Kasting authored
* IWYU * Eliminate using declarations via explicit qualifiers * Replace deprecated DISALLOW_COPY_AND_ASSIGN macro * Replace explicit GetClassName() override with View metadata macros * Prefer file-scope constants to class-scope ones * Declare constants as close to their use as possible, i.e. inline them into methods when only used once * Comment tweaks, including removing some unhelpful or inaccurate ones, adding TODOs, and being more consistent * Add utility functions CenterY(), ExecuteCommand(), UseNewWarnings() for common functionality. This also results in adding a member. * Inline ConfirmDeepScanning() and BypassDeepScanning() into their callers using ExecuteCommand(). * Eliminate |focus_ring_|, which is never set. * Re-order class members in hopes of grouping related items more closely * Set up more of |accessible_alert_timer_|'s functionality in the constructor and simplify the usage site as a result * Extract a chunk of ButtonPressed() handling relating to showing an "open download" dialog into its own function, ShowOpenDialog(), in preparation for reorganizing the caller in a subsequent CL Bug: none Change-Id: I917ac3ab195d158fa82f5a51274b8ce5563bb15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304720 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790171}
-
Kyle Milka authored
Wrap the various scan_tab layouts in a scrollview so all the options are usable on small devices. Bug: 1107575 Change-Id: I8578e0a2e018a78ed17c0eaa14e98ad6e681d0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308209 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790170}
-
Sophey Dong authored
Screencast: http://dr/file/d/1Cl221h7j9noHqAPXUU0G4H5hKrKacAwS/view Bug: 1105139 Change-Id: Ibe242764a2d5728e9c1ca006aa3ee0278ad9ae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303977 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 165e7384. With Chromium commits locally applied on WPT: 96b35d0f "Fix executor.html path in property.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib754288651de7bb12597c27e81b4a0c3136063a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308230Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790168}
-
Kenneth Russell authored
These histograms have expired and the data gathering code is causing flaky GPU process crashes. Bug: 1090360 Tbr: vitalybuka@chromium.org Change-Id: I57bc7534406ab66c413b355fcfed4d1a725c2271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302620 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#790167}
-
Daniil Lunev authored
trace: [3348438:3348438:0716/193315.071834:645381268976:FATAL:identifiability_study_settings.cc(60)] Check failed: !initialized_.IsSet(). ... BUG=none TEST=unittest Change-Id: Idd43aed91cbc864b960f91215fce7afcfdd791a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301750 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Entity suggestions inaccurately used slightly smaller font to present the 1st line of text. Bug: 1107537 Change-Id: I42c111601d2205e6ff6ae188aabf71842bcdc841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308455 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Jeff Yoon authored
Bug: 1105117 Change-Id: I0830887588653c435fbbb5748d00a9f03c5dd085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295820 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Lexi Stavrakos authored
Bug: 1088004 Change-Id: Ic606b07825aa79be971d8d97a0409573d1aecb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242846 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#790163}
-
Michael Thiessen authored
Native java unittests are going away in favor of batched instrumentation tests. This CL migrates the Omnibox tests. Note that I had to make changes to the tests that used the clipboard service, as these tests run without a focused Activity, and so calls to the real clipboard service are rejected. Bug: 1103344, 1102026 Change-Id: Iec82e26ce28e503944dff82027f3a3e083ab7742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288379 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790162}
-
Jenny Zhang authored
Bug: 1103012 Change-Id: I97894b8246edaddb610c1887954e0e7822258f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307616 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#790161}
-
Etienne Pierre-Doray authored
This reverts commit fb56fbc5. Reason for revert: Trace event creates deadlock Original change's description: > Reland "[Jobs API]: Use worker_lock in JobTaskSource." > > This is a reland of 6eb566d2 > > Reason for revert: Cause failure in CheckedLockImpl::Acquire > crbug.com/1099649 > Mark worker_released_condition_ declare_only_used_while_idle > to prevent priority queue from being acquired in ScopedBlockingCall. > > Original change's description: > > [Jobs API]: Use worker_lock in JobTaskSource. > > > > Possible race when Join(): > > - thread A: Join: worker_released_condition_->Wait() > > - thread C: WillRunTask: > > GetMaxConcurrency() returns > 0 > > - thread B: already running, finishes all the work > > GetMaxConcurrency() goes 0 > > - thread B: DidProcessTask: > > worker_released_condition_->Signal(), > > - thread A: Join returns (GetMaxConcurrency() is 0) > > - thread C: TryIncrementWorkerCountFromWorkerRelease > > worker count goes 1 > > - thread C: runs worker_task after Join > > > > To fix race when Joining, all writes to |state_| are protected by > > |worker_lock|. Memory ordering is no longer necessary. > > > > Alternative: cancel before Join returns with a compare and swap and > > loop again if new workers. > > > > Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781453} > > Change-Id: I1c7c0054a52b9b12dd6d0edd049ab2a7912df361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272942 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789526} TBR=gab@chromium.org,etiennep@chromium.org Bug: 1099649 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic765e35c5404387e9ba8771b31650414218fbf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308689Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790160}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/6af6e625573f..2105106cf8e6 2020-07-20 rharrison@google.com Roll 5 dependencies and update expectations (#1111) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I6120365db41ab8e2631fd8487001629f2c83de0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308517Reviewed-by:
-
Albert J. Wong authored
This leaves just the ref_count_ variable left as thread hostile. CL is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 See this design doc for more details on the larger motivation for this change: https://docs.google.com/document/d/1hp7h6zfD5S6mnMI4cHe1PpacRnb2rNpRRkn1gBBJHuQ/edit#heading=h.erv1bv18t616 Bug: 1083392 Change-Id: I9ab3b1d86c8e27d887b6dbb34ac4ae4fd720af0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301589 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790158}
-
