GitLab

There was some confusion about this, and one would also expect that
these build-in variables would be listed in the help under the other
built-in variables.

BUG=468991

Review-Url: https://codereview.chromium.org/2149213002
Cr-Commit-Position: refs/heads/master@{#405584}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2151643003
Cr-Commit-Position: refs/heads/master@{#405583}

BUG=627306

Review-Url: https://codereview.chromium.org/2146233002
Cr-Commit-Position: refs/heads/master@{#405582}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/627023176cd4..4d408bfe9dec

$ git log 627023176..4d408bfe9 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2152933002
Cr-Commit-Position: refs/heads/master@{#405581}

https://chromium.googlesource.com/angle/angle.git/+log/8495498..4c32feb

BUG=

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2153473002
Cr-Commit-Position: refs/heads/master@{#405580}

In later patch of https://codereview.chromium.org/2079843003/, I update the code to display AudioDevice display_name. But I forget to update the unittest. Since try server is not running in USE_CRAS, it is not detected.

BUG=628342
TEST=run in USE_CRAS building condition, it returns to work fine.

Review-Url: https://codereview.chromium.org/2150983003
Cr-Commit-Position: refs/heads/master@{#405579}

This CL restricts access to the WebApkSandboxedProcessService
IChildProcessService implementation to the host browser only. The host browser
is defined in the WebAPK's manifest. A RemoteException is thrown if an app other
than the host browser attempts to use WebApkSandboxedProcessService's IBinder
interface

BUG=625448

Review-Url: https://codereview.chromium.org/2114293003
Cr-Commit-Position: refs/heads/master@{#405578}

PathService::Get() is treated as safe-to-call from any thread, but
PathProviderMac(FILE_EXE,...) looks up the NSExecutable path, and
translates it from relative to absolute using
base::MakeAbsoluteFilePath(), which asserts that IO is allowed on the
calling thread.

This was being hit by code in NaClBrowser in developers' local debug
builds.

As per the discussion on crbug.com/259796, the one-off cost of this
IO (given PathService then caches the result) seems acceptable.

NOPRESUBMIT=true
BUG=373477, 259796

Review-Url: https://codereview.chromium.org/2145003004
Cr-Commit-Position: refs/heads/master@{#405577}

I haven't really confirmed that this solves the problem because I wasn't able to reproduce it again :-/

Note, there's a related change http://crrev.com/2143123004 which would make it so that the real os.environ isn't used in tests.

BUG=612730

Review-Url: https://codereview.chromium.org/2141093006
Cr-Commit-Position: refs/heads/master@{#405576}

This is part of the touch hud app for mustash (https://codereview.chromium.org/2092343002/).

BUG=588311
TEST=ash_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win8_chromium_gyp_dbg;master.tryserver.chromium.win:win8_chromium_gyp_rel

Committed: https://crrev.com/98caac0fdcd637a95eb27e72c9a4c0a487e72d25
Committed: https://crrev.com/fd4123fd2d8efaa85d0b2f1550ca6e70ddc7cb55
Review-Url: https://codereview.chromium.org/2118223004
Cr-Original-Original-Commit-Position: refs/heads/master@{#405296}
Cr-Original-Commit-Position: refs/heads/master@{#405506}
Cr-Commit-Position: refs/heads/master@{#405575}

  In order to roll GN 547610b2..af92718f (r405294:r405547) and pick up
  the following changes:

  af92718f GN: Use the correct defaults for templates invoked via target().
  af8a964b Allow multiple set_default calls in GN.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2149073003
Cr-Commit-Position: refs/heads/master@{#405574}

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. No new API methods were required.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2124013002
Cr-Commit-Position: refs/heads/master@{#405573}

This CL corrects the code to use the pixel format: must use
ABGR instead of the incorrect ARGB, for the JS APIs
mentioned in the title and for Android platform.

BUG=627983

Verified on N7.2, N6.

TEST= two parts, e.g. on a N5X or N6 phone:
1) Navigate to [1], open either camera, click on
grabFrame() and verify correct colours
2) Navigate to [2], click on "Start <video> playback",
then on "Create Stream..." and then on "Play back..."
and verify correct colours.

[1] https://simpl.info/ic
[2] https://rawgit.com/Miguelao/demos/master/videoelementcapture.html

Review-Url: https://codereview.chromium.org/2150453003
Cr-Commit-Position: refs/heads/master@{#405572}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74306c2f..4c68d129

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2145613007
Cr-Commit-Position: refs/heads/master@{#405571}

BUG=615893
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2136103008
Cr-Commit-Position: refs/heads/master@{#405570}

BUG=586033
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2152893002
Cr-Commit-Position: refs/heads/master@{#405569}

BUG=425060
TEST=Build test.

Review-Url: https://codereview.chromium.org/2152883002
Cr-Commit-Position: refs/heads/master@{#405568}

TBR=pdr

Review-Url: https://codereview.chromium.org/2150993003
Cr-Commit-Position: refs/heads/master@{#405567}

This makes it easier to see that copies of all relevant fields are correct,
and also makes it easier to add new state inherited on the containing block chain.

BUG=563667

Review-Url: https://codereview.chromium.org/2144733008
Cr-Commit-Position: refs/heads/master@{#405566}

roll libyuv for GN fix to chromium internal settings, enabling more warnings
and consistant with gyp build options.

Add ARGBExtractAlpha function.
Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f.
unittest fixes for Arm scaler - use J420 for J422 pointing to same row,
improving performance and accuracy.
Fix ios jpeg build error.
Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug
Fix unittests to avoid private row.h header.
Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4.

BUG=chromium:626065, libyuv:572, libyuv:575, libyuv:579, libyuv:573, libyuv:583, chromium:601140, libyuv:582, libyuv:581, chromium:601140, libyuv:578, libyuv:581, libyuv:580, libyuv:586, libyuv:590, webrtc:5006, libyuv:593, libyuv:592, libyuv:594, libyuv:595, libyuv:597, libyuv:599, libyuv:598, libyuv:600, libyuv:602, libyuv:605, libyuv:610, libyuv:612, libyuv:618, libyuv:620, webrtc:6091, webrtc:6094, libyuv:616, libyuv:623,  libyuv:624, libyuv:625
TEST=try bots pass

Review-Url: https://codereview.chromium.org/2151043002
Cr-Commit-Position: refs/heads/master@{#405565}

build/config/BUILDCONFIG.gn still asserts that target_os == host_os
for Windows build, so this currently can't be toggled without further
local changes.  No behavior change.

BUG=495204

Review-Url: https://codereview.chromium.org/2148373002
Cr-Commit-Position: refs/heads/master@{#405564}

Extracting most of gesture logic from EventHandler
and move it to the GestureManager class.

BUG=616491

Review-Url: https://codereview.chromium.org/2137113002
Cr-Commit-Position: refs/heads/master@{#405563}

BUG=372547

Review-Url: https://codereview.chromium.org/2111253002
Cr-Commit-Position: refs/heads/master@{#405562}

Creating the outputter needs to create and join a thread, which is quite costly.
This is to speed up the GPU fuzzer, which recreates a decoder (hence a
GPUTracer) for every test case.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2151673003
Cr-Commit-Position: refs/heads/master@{#405561}

Revert of Disable "taking address of packed member" clang warning. (patchset #2 id:60001 of https://codereview.chromium.org/2148283002/ )

Reason for revert:
Warning was reverted upstream again.

Original issue's description:
> Reland of Disable "taking address of packed member" clang warning. (patchset #1 id:1 of https://codereview.chromium.org/2066503004/ )
>
> Reason for revert:
> The warning was relanded upstream this morning.
>
> Original issue's description:
> > Revert of Disable "taking address of packed member" clang warning. (patchset #3 id:40001 of https://codereview.chromium.org/2059143003/ )
> >
> > Reason for revert:
> > The warning got reverted upstream.
> >
> > Original issue's description:
> > > Disable "taking address of packed member" clang warning.
> > >
> > > Pending cleanup.
> > >
> > > BUG=619640
> > >
> > > Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e
> > > Cr-Commit-Position: refs/heads/master@{#399572}
> >
> > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=619640
> >
> > Committed: https://crrev.com/f999d8350f0fbdefac8875135ca3540c64d2f3f4
> > Cr-Commit-Position: refs/heads/master@{#399686}
>
> TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,thakis@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619640
>
> Committed: https://crrev.com/805bf6aaa5de841e0cf987e0d7005f5abd7df54c
> Cr-Commit-Position: refs/heads/master@{#405538}

TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,rnk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619640

Review-Url: https://codereview.chromium.org/2145243003
Cr-Commit-Position: refs/heads/master@{#405560}

This event doesn't make sense. Frontend can clear console messages log
on navigation if it wants to.

BUG=613882

Review-Url: https://codereview.chromium.org/2146163002
Cr-Commit-Position: refs/heads/master@{#405559}

In the Issue 2130433002, Navid had to skip some pointerevent tests because they crashed for some reasons.
This patch fixes it and also remove them from the TestExpectations file.

BUG=620236

Review-Url: https://codereview.chromium.org/2127303002
Cr-Commit-Position: refs/heads/master@{#405558}

https://chromium.googlesource.com/skia.git/+log/7cf36ccb4419..64bbad360f30

$ git log 7cf36ccb4..64bbad360 --date=short --no-merges --format='%ad %ae %s'
2016-07-14 mtklein Revert of Expand _01 half<->float limitation to _finite.  Simplify. (patchset #7 id:120001 of https://codereview.chromium.org/2145663003/ )
2016-07-14 mtklein Expand _01 half<->float limitation to _finite.  Simplify.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2148403002
Cr-Commit-Position: refs/heads/master@{#405557}

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2151743002
Cr-Commit-Position: refs/heads/master@{#405556}

Instead use basic firstChild and nextSibling. This avoids a crash when
the internal layout structure is dirty.

Add DCHECK to discourage future mistakes.

BUG=627839

Review-Url: https://codereview.chromium.org/2146163005
Cr-Commit-Position: refs/heads/master@{#405555}

Fixes browser crash.

BUG=628159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150983002
Cr-Commit-Position: refs/heads/master@{#405554}

This CL:
- removes some unnecessary dependencies, following
up on a TODO
- removes unnecessary include and MEDIA_EXPORT
in recently landed code
- correct photo_capabilities.h header guard

BUG=626125, 618718
TEST=No new coded added, if it compiles, is good.

Review-Url: https://codereview.chromium.org/2148583003
Cr-Commit-Position: refs/heads/master@{#405553}

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG=622133

Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
Committed: https://crrev.com/0c3ad3287b3fae9b6329f8e7c34c0117b5c8da65
Review-Url: https://codereview.chromium.org/2140803002
Cr-Original-Original-Commit-Position: refs/heads/master@{#405211}
Cr-Original-Commit-Position: refs/heads/master@{#405424}
Cr-Commit-Position: refs/heads/master@{#405552}

Currently v8_target_cpu can only be set to one particular architecture,
and that won't work for monochrome/webview builds where we need
to be able to build two different snapshots for two different architectures.

The way things are set are also confusing for when you need to do builds
for a target_cpu that is different from the host_cpu and the value of the
v8_target_cpu might get out of sync between target and host.

This change changes all that by making the cpu that v8 targets
a function of the current toolchain (thus declaring a v8_current_cpu
and using that instead).

R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org

BUG=625353

Review-Url: https://codereview.chromium.org/2116183002
Cr-Commit-Position: refs/heads/master@{#405551}

This should have been removed in this cl:
https://codereview.chromium.org/2122993003

BUG=None

Review-Url: https://codereview.chromium.org/2151533002
Cr-Commit-Position: refs/heads/master@{#405550}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b1baa103267a..627023176cd4

$ git log b1baa1032..627023176 --date=short --no-merges --format='%ad %ae %s'

BUG=472699

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2149743004
Cr-Commit-Position: refs/heads/master@{#405549}

LayerTreeTests expect the output surface on the LayerTreeHostImpl to
be a FakeOutputSurface, but we will be changing it to be a
TestDelegatingOutputSurface in the future, with a Display, and a
FakeOutputSurface in the Display instead.

This removes the LayerTreeTest::CreateFakeOutputSurface() method, and
has tests override the LayerTreeTest::CreateOutputSurface() instead,
storing the FakeOutputSurface* themselves as needed. This also means
we don't have a null FakeOutputSurface* in pixel tests, yay.

In the future, this method will become CreateDisplayOutputSurface
or something, so that tests can control the surface in the Display (and
all the contexts), without changing the TestDelegatingOutputSurface in
the LayerTreeHostImpl.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2140383005
Cr-Commit-Position: refs/heads/master@{#405548}

Previously calling
  target("foo", "bar")
where "foo" is a template applied the defaults for the function named "target"
(since this is the function call) rather than "foo".

This change properly applies the defaults for "foo" in this case.

BUG=624564

Review-Url: https://codereview.chromium.org/2148093002
Cr-Commit-Position: refs/heads/master@{#405547}

This is related to a comment about components being source sets on Android.

A previous patch speculatively changed a build parameter with a comment
referencing the speculative test. Now we know this does affect the runtime
but not build performance, so we will keep the change and the comment needs to
be updated to reflect this.

BUG=619593

Review-Url: https://codereview.chromium.org/2152743003
Cr-Commit-Position: refs/heads/master@{#405546}

StrictMode violation was from Calendar.getInstance() reading
the /etc/timezone file. Whitelist the StrictMode violation
to be fixed.

Tests were flaky because the UI thread would not always launch
the InfoBar before calling addInfoBarAnimationFinished(). Run
the UI thread blocking so that the InfoBar has always been
launched.

BUG=625038, 577185, 627038

Committed: https://crrev.com/8fcd3f03a3a531f12bb291dc8665834d85511c23
Review-Url: https://codereview.chromium.org/2130083002
Cr-Original-Commit-Position: refs/heads/master@{#404506}
Cr-Commit-Position: refs/heads/master@{#405545}