- 14 Jul, 2017 40 commits
-
-
Ryo Hashimoto authored
HomedirMethods::MountEx was converting MountParameters to MountRequest proto. To simplify this, remove MountParameters and use MountRequest everywhere. - Construct MountRequest directly in MountEx's caller sites. - Rename FillKeyProtobuf() in homedir_methods.cc to KeyDefinitionToKey(), and make it public. BUG=741274 Change-Id: Ibb8dd4a7975f6aff87ada881938be29300e7344c Reviewed-on: https://chromium-review.googlesource.com/567844Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#486689}
-
mfomitchev authored
This CL takes advantage of the mechanisms introduced in https://codereview.chromium.org/2979933002/ to run the UI Service inside the browser process in Mushrome (i.e. when chrome is launched with --mus parameter). UI Service runs on a separate thread with high priority. For now both the UI Service and the GPU Service are moved. Once WS/GPU split if finished, GPU will need to be moved into its separate process. CrOS BrowserProcessPlatformPart owns the ImageCursorsSet used by the UI Service for cursor manipulation. BUG=722527 Review-Url: https://codereview.chromium.org/2983443002 Cr-Commit-Position: refs/heads/master@{#486688}
-
Mitsuru Oshima authored
New animation first makes copies of screen, and chagnes the rotation after these copies are made. If a device enters tablet mode while coyping it may remember the wrong rotation. BUG=742605 TEST=covered by unit tests. Also tested manually: 1) Start portrait only ARC++ app 2) Try to close and open the lid multiple times Change-Id: I835b3409f34f101dac45784eda501635f7fe085e Reviewed-on: https://chromium-review.googlesource.com/571258 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#486687}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8efa3b7d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/312 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I9bbffc01856dfa827d0230c2a5637d3e1bb1e660 Reviewed-on: https://chromium-review.googlesource.com/571480 Commit-Queue: Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink W3C Test Autoroller <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486686}
-
Tetsui Ohkubo authored
Use the title text instead of multi line message for "CAPS LOCK is ON" notification. Primarily fix for MD style notification but also works properly in the current style. BUG=740813 TEST=manual Change-Id: I9121ae49fcf77fa4e7092d4a6a354b1d1a21d04e Reviewed-on: https://chromium-review.googlesource.com/569329 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Terry Anderson <tdanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486685}
-
meade authored
Spec: https://drafts.css-houdini.org/css-typed-om/#csstranslation Additionally found during testing: - Z should not be able to be set to null - Use new CSS.px(1) syntax for inlinestyle/translation test for brevity BUG=545318 Review-Url: https://codereview.chromium.org/2961243002 Cr-Commit-Position: refs/heads/master@{#486684}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ee3e0bacc8be..83d118550f72 $ git log ee3e0bacc..83d118550 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 ethannicholas converted CircleEffect to SkSL 2017-07-13 fmalita Delete unread SkPicture mbox 2017-07-13 bsalomon Move GrAALinearizingConvexPathRenderer off GrLegacyMeshDrawOp 2017-07-13 egdaniel Add support for creating a GrContext backed by Metal. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I1c4299ac66aa68f14c8c48a83bd2aa85c2d82f0e Reviewed-on: https://chromium-review.googlesource.com/570994Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486683}
-
Sandra Sun authored
When performing a scrollIntoView, if some scrolling boxes in the chain has the smooth behavior while the others don't, the sequenced smooth scrolls shouldn't be aborted. This patch fixes the bug by setting the ScrollType to kSequencedSmoothScroll once we noticed a smooth scroll in the scroll chain, so that ScrollableArea::SetScrollOffset() will not abort the sequenced smooth scrolls. This patch also moves the first call of RunQueuedAnimations() to LayoutObject::ScrollRectToVisible() to make sure that all sequenced smooth scrolls get a chance to run. Bug: 735863 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8d72bcc873efcf82883ab7272328c3759789e7a3 Reviewed-on: https://chromium-review.googlesource.com/550237Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#486682}
-
Piotr Swigon authored
This should be a no-op functionality wise. This patch introduces CustomTabsUiType as a better way to specify the look&feel of the UI. In this and following patches I will aim to minimize number of intent EXTRAs and replace multiple booleans indicating visibility of various UI elements with a single value specifying a UI type. This patch takes care of only few low hanging fruits to make it easy to review. I plan to make a few more code structure and readability improvements on top of this later on. This refactoring is considered a prerequisite to introducing Minimal-UI PWA display mode, which is yet another UI type for Custom Tab. Bug: 604390 Change-Id: Ifa75e341dd1f7ac64cfa70c4dbb507b3df9c7f6c Reviewed-on: https://chromium-review.googlesource.com/567789 Commit-Queue: Piotr Swigon <piotrs@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486681}
-
Siddhartha authored
Discussion at crrev.com/10983063. The comments at crrev.com/10983063#msg16 says that the only issue with supporting PurgeMemory for session storage is it would set is_initial_import_done_ to false and this could potentially cause an import if GetItem is called. So, the fix should just be not setting import_done_ to false if map is empty. For the case when a SetItem is called before Purge, PurgeMemory would be noop since it has uncommitted changes. BUG=696112 Change-Id: I1a57c49dea41e030f5770b9d74742984b920f1d1 Reviewed-on: https://chromium-review.googlesource.com/560722 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#486680}
-
Alan Cutter authored
TBR: thakis@chromium.org Bug: 742670 Change-Id: I3e6bfb0d990f36c5643f3f766d63a0dae0c243c3 Reviewed-on: https://chromium-review.googlesource.com/571538Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#486679}
-
tsergeant authored
BUG=727174 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2962283002 Cr-Commit-Position: refs/heads/master@{#486678}
-
Miguel Casas-Sanchez authored
This CL moves the three standard functionality LayoutTests for mediacapture-fromelement to the external/wpt folder, adapting them accordingly and adding the necessary webmfiles. Also removes the HTMLMediaElementCapture-*.html expectations. Bug: 619625 Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 Reviewed-on: https://chromium-review.googlesource.com/566151 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#486677}
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClient, as preparation to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I4b6f21228e402973a18e07aa5d80a134b2018f58 Reviewed-on: https://chromium-review.googlesource.com/569798Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486676}
-
calamity authored
This CL refactors how mouse focus hides the focus ring by moving the listener into the app and using keyboard events to restore the focus ring instead of blur event. This reduces the number of event listeners and deals well with window focus/blur. BUG=740834 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2981503002 Cr-Commit-Position: refs/heads/master@{#486675}
-
yhanada authored
- Update obsolete comments - Remove UMA recording in virtual_keyboard_private because it's recorded in HideKeyboard. - Remove an unused method. - Move FullWidthKeyboardBoundsFromRootBounds to keyboard_test_util. - Mark some methods of KeyboardController const methods. Bug: 731537 Test: All tests pass. Change-Id: I99b1956519465c805c4e8bee3debb41f1f194817 Reviewed-on: https://chromium-review.googlesource.com/568059Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#486674}
-
Matt Falkenhagen authored
This is to help track the effectiveness of warming up the service worker for search from the omnibox. This rather unfortunately adds a public content API since all the smarts about detecting Google Search URLs are (rightly) in //chrome but we want to log the UMA in //content. I think someday a patch like https://chromium-review.googlesource.com/c/566764/ can be landed that moves the UMA entirely to //chrome. Bug: 724337, 732681 Change-Id: I1a4671111c583a30963b5a34a1c4bc605fc07f14 Reviewed-on: https://chromium-review.googlesource.com/569550 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#486673}
-
yusukes authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/e79b0c77..137ec42a $ git log e79b0c77..137ec42a --date=short --no-merges --format='%ad %ae %s' 2017-07-10 yusukes@google.com Add |create_server_socket| to arc.proto 2017-06-13 ljusten@chromium.org authpolicy: Add common_name to ActiveDirectoryAccountInfo BUG=chromium:737148 TEST=try Change-Id: Iba3d07cf332afa6b3596f508777a95ca9ae98378 Reviewed-on: https://chromium-review.googlesource.com/570884Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#486672}
-
Tarun Bansal authored
Enable NetInfo rtt, downlink, effectiveType APIs on all platforms. Currently, NetInfo API is enabled only on Android and ChromeOS platforms. To enable the rtt, downlink, effectiveType attributes on all platforms, this CL also enables NetInfo API on all platforms and then selectively disables other existing attributes (type, downlinkMax, typeChange) on non-Android, non-ChromeOS platforms. Bug: 723068 Change-Id: Ife4388240d6434aebf3f31d7a402d310bd4f587c TBR: pfeldman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/565342 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Charlie Reis (OOO until July 19) <creis@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486671}
-
Sunny Sachanandani authored
This dumps more state notably including time since last begin frame and the last few actions. TBR=brianderson BUG=622080 Change-Id: I51590aa3e2859b448ca2eafd45046f6f123e9331 Reviewed-on: https://chromium-review.googlesource.com/571286Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#486670}
-
Mohsen Izadi authored
When: - a simple gesture nav affordance is performing a complete or abort animation; and - a new overscroll is started; and - the new overscroll is going to be ignored because, for example, there is no item in the navigation history to navigate to; the overscroll updates should be ignored. Currently, they would be sent to the animating affordance until its animation is complete and the instance is deleted. An example situation this can happen is when there is no page to navigate back to, but there is a page to navigate forward to. If you start a forward overscroll with touchpad, then swipe quickly in the opposite direction, the forward overscroll will be aborted and a back overscroll will be started. However, since there is no page to navigate back to, no new affordance is created and overscroll updates would be sent to the existing animating forward affordance. This bug is introduced in r477865. BUG=668296 TEST=manual Change-Id: I110addf3a58132edd70384b881835cfe6c4c93c2 Reviewed-on: https://chromium-review.googlesource.com/565759Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#486669}
-
Tsuyoshi Horo authored
Bug: 740102 Change-Id: I250fde1868f3c244c8db51a2fcf54d30c946f470 Reviewed-on: https://chromium-review.googlesource.com/564958 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#486668}
-
Devlin Cronin authored
There are two JS hooks we used in handling exceptions in extensions bindings: - There is an exposed "handleException" method, which handles exceptions encountered in running untrusted code. - The test API allows us to set custom handlers for uncaught exceptions (so we can fail a test or verify expected errors). Implement each of these in the utilities exposed to the JS bindings, and add unittests for the same. Bug: 653596 Change-Id: I246308c78b0760f5176949c2b1d88da07dca337a Reviewed-on: https://chromium-review.googlesource.com/568692Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486667}
-
Hayato Ito authored
This is one of the efforts to organize core/dom files. See https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit?usp=sharing for details. Bug: 738794 Change-Id: I953cc0bc075fea503770af09d7dbc76f38d85b67 Reviewed-on: https://chromium-review.googlesource.com/569532Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#486666}
-
Yuqian Li authored
Bug: Change-Id: I505ff0549952be51a67ca9da38674e87a4f4fe31 Reviewed-on: https://chromium-review.googlesource.com/568086 Commit-Queue: Yuqian Li <liyuqian@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#486665}
-
Devlin Cronin authored
Use the ExceptionHandler when dispatching events to listeners, rather than a verbose TryCatch. Add unit tests for the same. Bug: 653596 Change-Id: Id510d9d3d406c68ef051d1a616d5f8e3586c6303 Reviewed-on: https://chromium-review.googlesource.com/568408 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486664}
-
Jeff Carpenter authored
Also: - Print out `git apply` error message in LocalWPT.test_patch - Add accidentally omitted return statement in WPTGitHub.pr_for_chromium_commit Bug: 737898 Change-Id: Id35454a3a5a91dd4963c7e7f0f86d5a29fb79cfd Reviewed-on: https://chromium-review.googlesource.com/571400Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486663}
-
Ramya Sharma authored
This CL creates a protected extension for BookmarkHomeViewController, so that subclasses can access the protected method and read/write properties without exposing it on the super class API. Bug: 705339 Change-Id: I1f6d447855ba5fbabd1676a7bc00bec38f4a1d8b Reviewed-on: https://chromium-review.googlesource.com/569525 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#486662}
-
Michael Martis authored
There are no logic updates in this change, only the moves/renames of components/translate/core/browser:language_model => components/language/core/browser:url_language_histogram chrome/browser/translate:language_model_factory => chrome/browser/language:url_language_histogram_factory ios/chrome/browser/translate:language_model_factory => ios/chrome/browser/language:url_language_histogram_factory (Gerrit represents this poorly) Bug: 739227 Change-Id: I439b474bb4176c7e783f6390af509713831a2fa3 Reviewed-on: https://chromium-review.googlesource.com/558763 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#486661}
-
Sam McNally authored
The previous approach of encapsulating the pref service from chrome regressed memory. Remove that encapsulation by moving the source of truth back into the browser "service" and using those PrefStores directly from the pref service, bypassing any mojo messages. Remove the control and registration interfaces which are no longer needed since the pref service is directly provided with its PrefStores. Also move the pref service to the UI thread, where the PrefStores already live. Other services may still access prefs via the pref service using the existing sync API (with a local copy of requested prefs), but are responsible for managing the increased memory footprint that could result. Change PersistentPrefStoreImpl to never start a pref read; the embedder is reponsible for ensuring the underlying PersistentPrefStore is either already initialised, or is in the process of being initialised. Change PersistentPrefStoreImpl to always observe the underlying PersistentPrefStore to detect changes originating from inside the embedder. Duplicate the update filtering from the per-connection class to ensure that each client continues to receive each update from other clients exactly once and never be notified about changes it instigated. Bug: 654988 Change-Id: I7eb9e427c9f66d1eb4526d6ea8d9ca6e61c87262 Reviewed-on: https://chromium-review.googlesource.com/554653 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486660}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2569648cdd4f..90038eee6f25 $ git log 2569648cd..90038eee6 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 simonhatch Dashboard - Add pinpoint_service 2017-07-13 nednguyen Fix webpagereplay_go binary config on Mac & enable webpagereplay_go_server_unittest Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I40e6cdcde8561f99dad02c8caab39c958c24d79d Reviewed-on: https://chromium-review.googlesource.com/571498 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486659}
-
Raymond Toy authored
When the source and the listener are at the same position, set the azimuth and elevation to zero in accordance with the panning algorithm in the spec. Add tests for this as well. Bug: 729523 Test: Panner/panner-equalpower.html Change-Id: I5787c95175fabedf0e5f4e484f315c9e10507568 Reviewed-on: https://chromium-review.googlesource.com/552821 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#486658}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I60b80c532b78646ea3f040df481289f9ddd4594d Reviewed-on: https://chromium-review.googlesource.com/571484Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#486657}
-
Tibor Goldschwendt authored
- UiRenderer is independent from GVR. Thus, it can be used on platforms other than Android. Change-Id: Ibb836799d95be28f85e6e2f84901d613858c708d Bug: Reviewed-on: https://chromium-review.googlesource.com/563776 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#486656}
-
Bugs Nash authored
This patch - Added current_shorthand to CSSParserLocalContext so that longhands whose parsing logic depends on the current shorthand can be implemented in APIs - Changed the APIs' parseShorthand methods CSSParserLocalContext argument to a use_legacy_parsing bool, because shorthand parsing does not need to be told what the shorthand is (and should not be passed this information). Diff in generated files: https://gist.github.com/54d6f19738916454fdaaa2278f221ba3/revisions Bug: 668012 Change-Id: Ide9e82fd74d17099f576ad98e0abaf2f24659b5f Reviewed-on: https://chromium-review.googlesource.com/566258 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#486655}
-
David Trainor authored
Add the infrastructure for a DownloadDriver recovery flow. This CL doesn't actually perform any cleanup or recovery of a DownloadDriver, but it just returns success. Implementing the actual recovery code will be included in a follow up, but this allows us to implement the DownloadService comprehensive recovery code without blocking on the implementation of this component in particular. BUG=736222 Change-Id: Ibbbb8d64b5114593404339d514bafb8b7d984a9b Reviewed-on: https://chromium-review.googlesource.com/569073 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#486654}
-
James Cook authored
The delegate no longer exists. Bug: 648964 Test: ash_unittests --mash Change-Id: I1b675bbe830a6e503ced7d1a3453035330dc4354 Reviewed-on: https://chromium-review.googlesource.com/571315Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#486653}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/56fc9725f05b..2b918c8d05c9 $ git log 56fc9725f..2b918c8d0 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 dsinclair Fixup naming of XFA graphics classes Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ic15d9ebad7c6121512a17762ea13980dbb1fc94c Reviewed-on: https://chromium-review.googlesource.com/571499 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486652}
-
Kevin Marshall authored
Remove File::Lock() and Unlock() under Fuchsia. Fuchsia does not support POSIX file locking, so Lock() and Unlock() have been removed. As the porting effort continues, it'll be easier to find and fix dependent code because they'll generate build breakages. Removed the unit test file from the test build target under Fuchsia. BUG: 706592 Change-Id: I585f5c2ae254c993a64ecf534feb384890971fad Reviewed-on: https://chromium-review.googlesource.com/569418 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#486651}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/04380e42329b..ee3e0bacc8be $ git log 04380e423..ee3e0bacc --date=short --no-merges --format='%ad %ae %s' 2017-07-13 bsalomon Make DefaultPathOp a non-legacy GrMeshDrawOp 2017-07-13 rmistry Revert "Re-enable uploading to partner bucket" 2017-07-12 bsalomon Make GrDrawVerticesOp a non-legacy GrMeshDrawOp 2017-07-13 jvanverth Add null check for non-cached shadows. 2017-07-13 rmistry Re-enable uploading to partner bucket 2017-07-13 fmalita Avoid unneeded picture shader color space transforms 2017-07-13 rmistry Download gitcookies from GS for RecreateSKPs bot 2017-07-12 bsalomon Make GrDrawAtlasOp a non-legacy GrMeshDrawOp 2017-07-13 reed remove dead code for legacy image encode api 2017-07-10 rmacnak Add trace events for shader generation. 2017-07-12 brianosman New zero length path GM 2017-07-13 reed Revert "Revert "Experimental blur code with 32 bit fix."" 2017-07-12 bsalomon Give GrSimpleMeshDrawOpHelper a cpp file 2017-07-05 ethannicholas SPIR-V support for more integer operations 2017-07-13 bsalomon Fix two issues in DashOp 2017-07-13 bsalomon Make ShadowRRectOp a non-legacy GrMeshDrawOp 2017-07-13 bsalomon Fail to make render target context if GrContext is abandoned 2017-07-13 reed don't test index8 -- no longer supported 2017-07-13 bsalomon Add abandoned context check to SkImage::MakeFromDeferredTextureImageData 2017-07-13 ethannicholas Re-land of "converted GrSimpleTextureEffect to sksl" 2017-07-13 scroggo Fix computeOutputColorSpace 2017-07-13 reed add guard for api change in google3 2017-07-13 reed Revert "add guard for recent api change" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I45410b0b6d03fce0c6dfee6a57b7347a4455adc2 Reviewed-on: https://chromium-review.googlesource.com/570834Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486650}
-