- 01 Dec, 2017 40 commits
-
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e2b109..a0aa5fd BUG=769026 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9ddaa99728b00be85f8759f975d4fb85161e3d77 Reviewed-on: https://chromium-review.googlesource.com/803794 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521087}
-
Luis Hector Chavez authored
This change addresses a comment that was added just before committing. Bug: None Test: git cl try Change-Id: If6d61b603b6fcaaad18ccaca795ba024c5e84c21 Reviewed-on: https://chromium-review.googlesource.com/804240Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521086}
-
Moja Hsu authored
The code will enter deadlock if the device has no JPEG decode accelerator. This CL fixes it. BUG=chromium:790838 TEST=test camera preview on minnie Change-Id: I695f80351a451614c7c830e3e31b40196fe9b457 Reviewed-on: https://chromium-review.googlesource.com/802935Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521085}
-
Kurt Horimoto authored
This will allow it to be accessible to multiple parts of the UI via a shared ChromeBrowserState. Bug: 785663 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia371a98681d27522443fbc0726fa4932e7666ae1 Reviewed-on: https://chromium-review.googlesource.com/802829 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521084}
-
danakj authored
For ui::Compositors that don't need to embed anything (eg. tooltips) they may be set to use software compositing even if the system as a whole is using gpu compositing. This adds the flag to CreateRootCompositorFrameSink plumbing, all the way through to the GpuDisplayProvider. In GpuDisplayProvider it adds code to create (for most platforms) a SoftwareOutputDevice. It renames DisplayOutputSurface to GLOutputSurface, and adds a SoftwareOutputSurface, which is created in the software compositing case. This now crashes if software compositing is forced, as the ui compositor has a null SharedBitmapManager. Once we set up the SharedBitmapManager in the viz and browser processes we should be able to get software compositing pixels. Lots of TODOs aded as appropriate. The auto-fallback on fatal error making a GL context is not implemented yet in GpuDisplayProvider. R=kylechar@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I82855e03df1c156e1a0b1c4bbc4eb35ffb3deb51 Reviewed-on: https://chromium-review.googlesource.com/798153 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#521083}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/9252115c4630..43a5c4971235 $ git log 9252115c4..43a5c4971 --date=short --no-merges --format='%ad %ae %s' 2017-12-01 simonhatch Dashboard - Parse the LOG_URLS diagnostic from histograms and log it. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I47a8baf752b26ef8890dd52ef139158d6a89109c Reviewed-on: https://chromium-review.googlesource.com/804408 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521082}
-
Tibor Goldschwendt authored
Tracks the duration from Chrome launch until the assets component is ready to use. Bug: 788768 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e500bc2ea3eb8a508aa3453dd62caad496e9e4a Reviewed-on: https://chromium-review.googlesource.com/790971 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521081}
-
Tarun Bansal authored
* Change ownership of the network properties manager in data reduction proxy: Network properties manager is now created and destroyed on the UI thread, and has access to both UI and IO task runners. This allows it to read/write the prefs on the UI task runner (next CL), while also exposing the network properties to d_r_p_config on IO thread (next CL). * State of the Data saver proxies is now persisted on the disk, and read back at the time of startup, or on connection change events. Bug: 779219 Change-Id: I0276c78541bbd84ef3a2edc5056dc943955c608b Reviewed-on: https://chromium-review.googlesource.com/756646 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#521080}
-
Julian Pastarmov authored
1. For UnsafelyTreatInsecureOriginAsSecure there is a typo in the policy_test_cases.json file: s/securex/secure/. 2. For SecurityKeyPermitAttestation the policy mapping was incorrectly put in a ifdef that excluded mac which makes it fail on mac. BUG=none Change-Id: I5f0f3b289452bf86fc66f0396cb13f82c8dcea5e Reviewed-on: https://chromium-review.googlesource.com/804314 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521079}
-
Hongchan Choi authored
Spec PR (approved): https://github.com/WebAudio/web-audio-api/pull/1445 Based on the spec change, this CL moves audioWorklet from `window` to `BaseAudioContext`. This alters the relationship between BaseAudioContext, AudioWorkletMessagingProxy and AudioWorkletGlobalScope: - Now AWMP/AWGS cannot exist without BaseAudioContext, this reduces the code complexity by removing checks. - With this clear ownership, BaseAudioContext only needs to talk to AudioWorklet. AudioWorkletMessagingProxy can be hidden. - When the script evaluation is completed, AWGS will notify the associated BaseAudioContext via AWObjectProxy - AWMessagingProxy. Bug: 786542 Change-Id: I7b55fcacf304a4a25b527bcbcd285bef80881b8d Reviewed-on: https://chromium-review.googlesource.com/779862 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#521078}
-
David Reveman authored
Version 2 additions: - set_parent request that can be used to provide an initial position relative to parent for shell surfaces. - zaura_output extension to wl_output that provides detailed information about supported scale factors. Test: compile Bug: Change-Id: I00aebee4475a7004db84f6f0e2cb5d41d8a823da Reviewed-on: https://chromium-review.googlesource.com/804354 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#521077}
-
Sergey Ulanov authored
Component build was broken on Fuchsia because base::RaiseProcessToHighPriority() was not defined. Bug: 706592 Change-Id: Ie88ffa6c7ad09729249417c6fb094e2194026854 Reviewed-on: https://chromium-review.googlesource.com/804210 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521076}
-
Peter Kasting authored
This can't be done by mucking with ShouldWindowContentsBeTransparent() as I opriginally thought; update comment there to describe better why. Instead, do this directly in TabStripImpl. The net effect of this should be that on Win 10, the titlebar background color will no longer show through the background tabs in the default theme; for white titlebars, this should make active and inactive tabs a little easier to distinguish. BUG=none TEST=none Change-Id: I1b722ba7ce887a1a32470e794e04b436bc06c22b Reviewed-on: https://chromium-review.googlesource.com/802522Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521075}
-
Yusuf Ozuysal authored
For both the initial check and the subsequent verification, we were using the url to be loaded to handle DAL verification. But DAL is for origins only, so we should instead split the path from the url before sending it for verification BUG=782905 Change-Id: I380076b3c1de5d10fdaba14238609fde9fdc3463 Reviewed-on: https://chromium-review.googlesource.com/801986 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521074}
-
Aleksei Seren authored
We have added Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows histogram here: https://codereview.chromium.org/2871793003/ Sadly, it was added to process_singleton_win.cc with mispell as: Chrome.ProcessSingleton.ProcessTerminateErrorCode.Windows This CL fixes histogram name to proper one. R=gab@chromium.org,holte@chromium.org Change-Id: Ice0989f3646aec6942138788e3cce0ebeb4dcffa Reviewed-on: https://chromium-review.googlesource.com/800630 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#521073}
-
Brett Wilson authored
This adds the new TabIcon view to the TabExperimental class and adds the associated plumbing to hook up the basic favicon and throb functionality. Rename experimental observer variables to help differentiate from the regular observers. Bug: 778461 Change-Id: I56a67a6f14d4003ee49818568bb59298e15bf1b8 Reviewed-on: https://chromium-review.googlesource.com/804206 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521072}
-
Luis Hector Chavez authored
This change: * Ensures that the Observers are notified when an Instance's connection errors out. * Relaxes the restrictions upon calling SetInstance() when there is already an InstancePtr bound. This matches the semantics prior to the ConnectionHolder refactoring. Bug: None Test: git cl try Change-Id: I933792f2846dfe614b8d71a52c9f9ebbce3f7c09 Reviewed-on: https://chromium-review.googlesource.com/797970 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521071}
-
Nasko Oskov authored
This CL disables tests failing on the Site Isolation Win FYI bot until they can be investigated and fixed. Bug: 788390 Change-Id: Ie51cd7dc3fe3559da7e2e3eec8ad9ca19169d794 Reviewed-on: https://chromium-review.googlesource.com/804146Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521070}
-
Dominik Röttsches authored
Perf bisects indicate that the hb_set changes may be the reason for seing performance regressions in issues 781794 and 782220. This is somewhat speculative as there were issues with reproducibility in the perf_bisect runs. Results from the main perf bot graphs should help figure out whether the hb_set changes were the culprit here. Bug: 782220, 781794 Change-Id: I5462b37503ca76a299c99cf41388d0d195722358 Tbr: behdad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/804374Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#521069}
-
Tom Anderson authored
This CL launches xvfb with +extension RANDR to suppress an error message of the form: Xlib: extension "RANDR" missing on display ":99". that gets printed by Xlib on every test run on the bots. This message cannot be suppressed AFAIK since it's part of libx11. R=dpranke@chromium.org Change-Id: I50e249102a082074dbbc5f501921a2a8d0d99c0b Reviewed-on: https://chromium-review.googlesource.com/802624 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521068}
-
liberato@chromium.org authored
Previously, MCVD ran on a thread that was owned by the mojo service. If the service was destroyed, then the thread would be also. This made it difficult for things to outlive MCVD (e.g., overlays). Now, it is sufficient to hold the task runner instead. This CL removes the ServiceContextRef, in favor of the task runner. Bug: 789447 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1f07382a3977685d6a92f6f13a92d5455602d6ec Reviewed-on: https://chromium-review.googlesource.com/801334Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521067}
-
Doug Arnett authored
Adds both a positive check and negative check. Bug: 787185 Change-Id: I4a5c9c450d4500604bbfc4690f7ef6fcc643c87a Reviewed-on: https://chromium-review.googlesource.com/804198Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#521066}
-
Tarun Bansal authored
flow is complete. When showing the second run promo, Chrome checks if the first run promo has completed. This CL adds a switch to disable that check if a command line switch is set. This switch would be used for UI Automator tests. Bug: 752972,752973 Change-Id: I345fbc89dd7c51cdca4ddf1203a9e1e29045cab4 Reviewed-on: https://chromium-review.googlesource.com/780264 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521065}
-
Luum Habtemariam authored
Update the GetPrintersURL call to utilize metadata_v2. This allows for certain restrictions to be placed on the model to determine whether or not the printer should be displayed Bug: chromium:773766 Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a Reviewed-on: https://chromium-review.googlesource.com/797476 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521064}
-
Qiang Xu authored
changes: When window is added to a workspace from another workspace, its current window bounds possibly is not the original-not-changed-by-user bounds, for example a resized bounds truncated by available workarea. Using a member in ash::wm::WindowState to store the windows bounds. It is used in window added to workspace event from another workspace. It is set when window is removing from a workspace and it is nullptr (using pre_auto_manage_window_bounds() if it exists otherwise current window bounds). It gets reset when window bounds is changed by user. DisplayMoveWindowUtilTest.KeepWindowBoundsIfNotChangedByUser, also tested on emulator. Not-user-resized window bounds will not affect the original bounds when moving between displays. Bug: 785017, 778438 Test: added the test coverage in Change-Id: I37d2c79238ea7200b32b5e3a9d5064addc575976 Reviewed-on: https://chromium-review.googlesource.com/770891 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521063}
-
Wenzhao Zang authored
Bug: 789509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0f25e5f282508975ba2b969c1c1f7cf74fc51c30 Reviewed-on: https://chromium-review.googlesource.com/801118 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#521062}
-
Christopher Cameron authored
Query the --enable-viz flag and plumb it to the DelegatedFrameHost. Resize the ui::Compositor along with the NSView when under viz, because otherwise it will never be resized (in non-viz, we resize it when we get compositor frames, which we no longer get). Consolidate the places that we query NSView/display properties (size, scale factor, and color space) in BrowserCompositorMac. Bug: 794839 Change-Id: I3d62f340a8c318c963f24f3732cdde4bb9328126 Reviewed-on: https://chromium-review.googlesource.com/794840 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#521061}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/fc9c67599d9bdeb2e0467085133b81a8e28f77a4..48eaa28a124e702edf373e212011cb283f0f0161 BUG=none Change-Id: I4e722641068bb53d07ad06c634657d79960faab8 Reviewed-on: https://chromium-review.googlesource.com/803840 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521060}
-
Artur Khachatryan authored
Bug: chromedriver:2105 Change-Id: I7a4274ae6f670d39071809a34e66fbac09001fba Reviewed-on: https://chromium-review.googlesource.com/803631Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521059}
-
James Cook authored
This debugging/presentation feature was tied to Ctrl-Alt-P. Usage is very low per UMA metrics. We suspect most usage was from users mistakenly hitting it when pressing Ctrl-P to print. Since it was tied to a pref the user could get stuck in this state. It also didn't work at the login screen and would turn on and off when switching multiprofile users. This feature is useful for debugging, recording videos of touch bugs, and for projecting demos. UI review suggested moving it to about:flags alongside the other touch debug flags. * Remove the pref and add cleanup code to wipe the existing value. * Remove the accelerator key. * Add --show-taps. The name is inspired by the Android OS developer option that does the same thing. TBR=rockot@chromium.org Bug: 786115 Test: existing ash_unittests Change-Id: I07579bff6ab3dd16ec5c14347df1a047b1aa935c Reviewed-on: https://chromium-review.googlesource.com/802075 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521058}
-
Aga Wronska authored
Consume fixed storage disk events in StorageMonitorChromeos. Only observe stateful partition, because it is relevant for users. Bug: 420633 Change-Id: Ia235b8f60b94c396c90da856bc68e3a61b2292dd Reviewed-on: https://chromium-review.googlesource.com/786649 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521057}
-
Joshua Bell authored
The [SecureContext] extended attribute now applies correctly to interfaces, so make sure that the StorageManager interface is not exposed in non-secure contexts, not just the `navigator.storage` entry point. Bug: 726510 Change-Id: Ie141aa4e29e261f1107af292f74f8063370c3748 Reviewed-on: https://chromium-review.googlesource.com/802676Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521056}
-
Alexander Alekseev authored
This is an update to https://chromium-review.googlesource.com/783707 that ensures that blocking GetCollectStatsConsent is used only on a blocking thread. Bug: 782641 Change-Id: I5629e00616f1ab24b4a63f1c3433f683370c3239 Reviewed-on: https://chromium-review.googlesource.com/802764 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521055}
-
https://chromium-review.googlesource.com/c/chromium/src/+/801350Peter Kasting authored
BUG=none TEST=none Change-Id: If31621b94082b463ec2d90f7f8d59f11e6052bed Reviewed-on: https://chromium-review.googlesource.com/802975Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521054}
-
rbpotter authored
PAGE_DONE is not useful on non-Windows platforms. Stop dispatching the event in these cases. Bug: None Change-Id: I317b8d7ecd265c8386d474316685bcfb7113061c Reviewed-on: https://chromium-review.googlesource.com/802822 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#521053}
-
Sky Malice authored
FieldTrials should be recorded through sync when an event logger client registers a dependency, their dependent event is recorded, and the trial is finalized. All trials are recorded whenever the FieldTrial event is emitted, which should be on a change or period, but no more. Feature [and params] exist but may never actually change. Because FieldTrials (and other imminent types) are not tied to navigations, reworked the ShouldRecordEvent() check to be more permissive, but also enforce presence (or lack) of navigation id. Bug: 719038 Change-Id: Ib62a18949dde41d194935347768b3fef0d2623d6 Reviewed-on: https://chromium-review.googlesource.com/764408 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#521052}
-
Tom Sepez authored
Distinguish between the permission errors the broker process fabricates vs. organically ocurring EPERM from a syscall. Use block-scope rather than unique_ptrs to force broker destruction. Fix a dubious use of ScopedFD(). ScopeFD's only legal bad FD value is -1, which co-incidentally happens to be -EPERM. So don't apply this where we know the file is invalid, since other negative values cause a CHECK(). Convert some ASSERTS to EXPECTS, to avoid crashes. Change-Id: I822e15e1ff386687627ba27c8f9fff158c10f316 Reviewed-on: https://chromium-review.googlesource.com/797919 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521051}
-
Sergey Ulanov authored
It is possible to set fixed sample rate in cast_shell on Linux with --alsa-fixed-output-sample-rate, but it wasn't possible on Fuchsia. Added --audio-output-sample-rate, which allows to set fixed sample rate on both platforms. For backward compatibility kept the old ALSA-specific flag, but it's marked as deprecated now. Bug: 772488 Change-Id: I0f980f09b432768ff9bb51191a9b1ec31e89274f Reviewed-on: https://chromium-review.googlesource.com/798066Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521050}
-
Christopher Grant authored
This change migrates the omnibox sizing, layout, text and colors to match UX spec. Things like rounded corners are still missing. Also, fix the UI testapp. BUG= R=bshe Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I96bc91c8c80d070dd3e09275d35eb61774468559 Reviewed-on: https://chromium-review.googlesource.com/801954Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521049}
-
Jay Civelli authored
Adding a bound accessor to service_manager::Connector so clients that require a fresh (unbound) connector can check that. Bug: None Change-Id: I555e32b71d7259713544f6283c8868827409382c Reviewed-on: https://chromium-review.googlesource.com/803907Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521048}
-