- 08 May, 2018 40 commits
-
-
Leszek Swirski authored
Bug: chromium:823663 Change-Id: Icab63d84322b136255d0ea8ca4207529087142b4 Reviewed-on: https://chromium-review.googlesource.com/1044197Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#556806}
-
Torne (Richard Coles) authored
Don't assume that there is a native library in all users of chrome_public_apk_tmpl; only define the native library version rules if there are native libraries specified. Change-Id: I3b45941c2eadae414ac1f4050a223514eac3382c Reviewed-on: https://chromium-review.googlesource.com/1048211Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#556805}
-
Dmitry Gozman authored
Some of the methods are unused, others are only used inside blink. Also removed override_url since it's not used anywhere. Bug: none Change-Id: I1dcf05a6df0ddb74f9d24634f1f9d95c445a4002 Reviewed-on: https://chromium-review.googlesource.com/1035085 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556804}
-
Christian Dullweber authored
Add components/browsing_data/ and content/browser/browsing_data/ to browsing_data watchlist Change-Id: Idfbe0037e6645fbce0a24431e07f21c9a8a45931 Reviewed-on: https://chromium-review.googlesource.com/1050248 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#556803}
-
Calder Kitagawa authored
Allows Zucchini to be built with only a subset of architectures enabled this saves on binary size at the cost of flexibility. The idea is that only the desired architectures would be compiled for a particular usecases. For example the Windows setup.exe only needs Windows support. Expected savings as a percent of total binary size at present (868.5 kB non-debug): - Remove DEX 3.13% (841.3 kB) - Remove Win 6.00% (816.4 kB) - Only Raw 9.13% (789.2 kB) Note that in the case of Raw saving could be made significantly higher by entirely removing the dependence on references and reference projection. However, at present the additional messiness of the additional buildflags all over the codebase is not worth the maintenance costs. Bug: 835007 Change-Id: I091cb9d76e8473340374be1a33a5df48137a3067 Reviewed-on: https://chromium-review.googlesource.com/1037922 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#556802}
-
Jochen Eisinger authored
BUG=831073 R=jam@chromium.org Change-Id: I100991624e40de2c947f09cd9034e63d180a5695 Reviewed-on: https://chromium-review.googlesource.com/1049386 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#556801}
-
gogerald authored
Bug: 840803 Change-Id: I3cf9698c58f8c7e885b16123c05e4a15f8ba53c8 Reviewed-on: https://chromium-review.googlesource.com/1049952Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#556800}
-
Charlie Harrison authored
This CL: - Makes the framebust infobar's OK button set the popup setting to ALLOW for that site. The OK button is changed to say "ALWAYS ALLOW". - Minor string changes to the framebust infobar - Adds "redirects" to the popup permission, this affects site details, site settings, and page info. Mocks at http://go/popup-redirect-unification-ui Screenshots are located in the linked bug. Bug: 840355 Change-Id: Idd35540d985ae9b61c81c70306868d57fc678742 Reviewed-on: https://chromium-review.googlesource.com/1043470Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#556799}
-
Friedrich Horschig authored
After having landed https://crrev.com/c/1028230, the problems of the linked bug seem to have gone (as assumed). I removed the Disabling and RetryOnFailure annotations to test on 3 devices (one physical, two emulator with different screen sizes and OS) and couldn't find a single broken test. Edit: I changed the font size recently (not finally) which seems to bother some bots - unrelated from the filed bug. Changed that back. This CL now reenables all the tests but keeps the RetryOnFailure annotation. That way, I can test whether the tests start failing on some bots again without making the sheriffs life harder. If the bots don't notice any flakiness, I will remove the RetryOnFailure annotation as well and mark the linked bug fixed. Bug: 838922 Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 Reviewed-on: https://chromium-review.googlesource.com/1044371Reviewed-by:
-
Peter Wen authored
Accidentally reversed logic in last CL so that by default every build.gradle file was generated. Consolidated logic in args.all. Bug: 620034 Change-Id: I5efe128150f688296abb1f835b3cbe7eba58f3ae Reviewed-on: https://chromium-review.googlesource.com/1048398 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#556797}
-
Jao-ke Chin-Lee authored
BUG=731378 Change-Id: I62f65eb174bd50951e05249be16be966c51db20e Reviewed-on: https://chromium-review.googlesource.com/1049265Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#556796}
-
Philipp Hancke authored
passes the test argument in promise_test and async_test so it can be used to add cleanup. followup on https://chromium-review.googlesource.com/c/chromium/src/+/1047674 using the same codemod but a better, non-regexp way to extract the script tag content. BUG=836871 Change-Id: I41905ce25e22121a6e8b53d37af86b073e020b5c Reviewed-on: https://chromium-review.googlesource.com/1049865Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556795}
-
Justin Donnelly authored
Previously, this opened a new tab in the foreground. Opening in a background tab matches the behavior of Cocoa Chrome and Safari. Bug: 838966 Change-Id: I5220c614afab0fc1894af0f39caa350529ef7634 Reviewed-on: https://chromium-review.googlesource.com/1049949Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#556794}
-
Jan Krcal authored
This CL unblocks https://chromium-review.googlesource.com/c/chromium/src/+/102589 that separates the controller delegate interface from the bridges and makes ClientTagBasedModelTypeProcessor directly implement the interface. Since the processor needs to be able to inform the bridge that sync is starting (before the bridge is ready to sync, i.e. before it gets the pointer to the bridge), this CL passes the (preliminary) bridge pointer to the processor during construction of the bridge. This CL is admittedly hacky, it only minimizes the CL size and thus the speed for landing the blocked CL. After the CL gets landed, we need to remove this hack and introduce a proper solution, probably by swapping the ownership of the bridge and the processor. Bug: 819993 Change-Id: Ie1950e6626a3ab58a583d8fbe502ba52c34319e0 Reviewed-on: https://chromium-review.googlesource.com/1042707 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556793}
-
kylechar authored
SoftwareOutputDeviceWin has two code paths to draw currently. With OOP-D there will additional implementations needed. Instead of shoehorning everything into one class, split into two separate classes and provide a function to get the correct one. This doesn't really reduce code now but it will make it simpler to add implementations for OOP-D and to remove implementations in the future after OOP-D is launched. There is shared base class with some simple logic and DCHECKs. There are then two implementations, one that draws directly the HWND and one that draws using layered window APIs. Bug: 826633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic7819261125e776ab26ce664cac47994e234948d Reviewed-on: https://chromium-review.googlesource.com/1044291 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556792}
-
Vadym Doroshenko authored
This reverts of https://chromium-review.googlesource.com/c/chromium/src/+/886707. The reason: it breaks Password Manager on almost any sites where there are simultaneously fields with ids and without ids. Fixing this properly is too difficult and risky for merging. And anyway processing of fields with empty ids will be much improved in https://crbug.com/831123 Bug: 839376, 803215 Change-Id: I91b535161335844266b0559b0ac21ecaf27faddc Reviewed-on: https://chromium-review.googlesource.com/1049926 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556791}
-
Guido Urdaneta authored
NOTRY=true TBR=nzolghadr@chromium.org Bug: 840792 Change-Id: I3b952baa48fc0280120abb61b73eb6eab2863a70 Reviewed-on: https://chromium-review.googlesource.com/1050225 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556790}
-
https://webrtc.googlesource.com/src.git/+log/823f9135f858..826738b78c6a $ git log 823f9135f..826738b78 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:840347,chromium:839860,chromium:838402 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I555e922aefb9dac0e262c32fe8562a47f7a15144 Reviewed-on: https://chromium-review.googlesource.com/1049945Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556789}
-
Kyle Milka authored
Change the hint text shown in the NTP fakebox for GM2. Bug: 837784 Change-Id: I42d74283515ac575418e49d88fbcd7be1702702f Reviewed-on: https://chromium-review.googlesource.com/1042268Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6198f39adc5c..e7df0bb900ec $ git log 6198f39ad..e7df0bb90 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 bsalomon Avoid rerunning path renderer chain when path known to require sw Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I02dbf642b36a78887c4895ab8c3a5c75f24d9d52 Reviewed-on: https://chromium-review.googlesource.com/1048983 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556787}
-
Guido Urdaneta authored
TBR=huayinz@chromium.org Bug: 829377 Change-Id: I06c5f0e19058e585a1a9460b44a8370e908ae6d0 Reviewed-on: https://chromium-review.googlesource.com/1049609Reviewed-by:
-
Devlin Cronin authored
GetCurrentBrowser() is pretty non-deterministic (returning various different browser objects depending on different circumstances). It looks like the cookies API only needs it to get at the profile associated with the extension function. Update this to just use GetProfile() instead. Bug: 809194 Change-Id: I745d17313ca77da43f164f06d55eb3ddd1840901 Reviewed-on: https://chromium-review.googlesource.com/1048392Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556785}
-
Devlin Cronin authored
Extension functions should never both set results and an error - it should always be one or the other. Enforce this more strictly in the cookies.set function. Bug: None Change-Id: I6d75973f78f46d3895abad633d8069a09c14c70e Reviewed-on: https://chromium-review.googlesource.com/1048395Reviewed-by:
-
Andrey Lushnikov authored
Currently, headless employs post task to asynchronously dispatch events. This, however, breaks the assumption that certain events should be dispatched before the message response is delivered. This patch restores the invariant. R=caseq, alexclarke Change-Id: Ie58c0ee060df7874a6e378ff6962a82c303f864b Reviewed-on: https://chromium-review.googlesource.com/1048725Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#556783}
-
Guido Urdaneta authored
NOTRY=true TBR=nzolghadr@chromium.org Bug: 840792 Change-Id: I4032cd2ec67b7158ce650927f7d78594ce09c4b2 Reviewed-on: https://chromium-review.googlesource.com/1049972 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Randy Rossi authored
Part of ongoing effort to get automation tree working in chromecast. Duplicated code will be refactored into common /extensions later. PS 1 is baseline for copied files. Modifications on top of that in PS >= 2. Bug: 73383411 Test: None Change-Id: Ie12a3e270bd3b2a289db0c92fceda34a89f7d1a7 Reviewed-on: https://chromium-review.googlesource.com/1042815Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556781}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I9b82139d30a9ae9b4071292d16adb64cd17255e6 Reviewed-on: https://chromium-review.googlesource.com/1049828Reviewed-by:
-
Vadym Doroshenko authored
This is the first step in saving with NewPasswordFormManager. Saving implementation plan is in "Implement saving with NewPasswordFormManager" in Implementation plan section in design doc go/new-cpm-design-refactoring. Bug: 831123 Change-Id: I419b4d07497c52a16409bd510bc27b671384bf17 Reviewed-on: https://chromium-review.googlesource.com/1042309 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556779}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e853531767d2..08f785343ab3 $ git log e85353176..08f785343 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 nednguyen Add simpeperf to Telemetry binary dependencies 2018-05-03 perezju [soundwave] Add --continue option and skip bugs in cache Created with: roll-dep src/third_party/catapult BUG=chromium:838658 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6b0462c2618f15ec2b694135270d5d5a8b4ae970 Reviewed-on: https://chromium-review.googlesource.com/1049172 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556778}
-
Koji Ishii authored
Following bot results are included. 5257 5261 5262 5265 5266 39 lines were removed and 13 lines were deflaked by consecutive results since 5207. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7a1884f12dd7be9ad910b8d1c8195c2a5ff2f579 Reviewed-on: https://chromium-review.googlesource.com/1049187 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556777}
-
Luke Zielinski authored
Includes a component-accessible interface for interacting with the navigation observer manager. Bug: 817377 Change-Id: I6074e9cfa53cbc7332c1f78b310124be99932abc Reviewed-on: https://chromium-review.googlesource.com/1030776Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556776}
-
Shakti Sahu authored
Bug: 830814 Change-Id: If1e12254aebabb06da1ba0b31de9500331444863 Reviewed-on: https://chromium-review.googlesource.com/1003043 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4cc719bf. With Chromium commits locally applied on WPT: 7712d138 "ReadableStreamBytesConsumer should check read results" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17157 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: I73fe65df8f8d6254392d5c58365f9a09ef60ec40 Reviewed-on: https://chromium-review.googlesource.com/1049745 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556774}
-
Jinsuk Kim authored
Java class InterstitialPageDelegateAndroid and its native class are used by content/chrome test only. This CL moves the classes to content/test/android. For this, content shell test apk is configured to have a native library of target name content_native_test_support. Bug: 617324 Change-Id: I81b757fe636e96139f61dce781d14fe55da341dd Reviewed-on: https://chromium-review.googlesource.com/1039305 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556773}
-
sebsg authored
Bug: 839859 Change-Id: I198b4cf906ed1eabb250c56282b34d96dbd53415 Reviewed-on: https://chromium-review.googlesource.com/1045174Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556772}
-
Oleh Prypin authored
TBR: hinoka@chromium.org Bug: chromium:840277 Change-Id: I2a28107bab3be476b263c65bf829c1b79259c7cd Reviewed-on: https://chromium-review.googlesource.com/1049631Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556771}
-
David 'Digit' Turner authored
When compiling Java sources into .jar files, the javac.py script will also generate a .jar.info file, used to map fully-qualified Java class names to the path of the corresponding source or .srcjar file. These are stored along the generated .jar file, e.g.: $OUT/gen/base/base_java.javac.jar $OUT/gen/base/base_java.javac.jar.info In addition to this, each APK has a final .apk.jar.info file stored under $OUT_DIR/size-info/ that corresponds to the union of all the .jar.info files of its dependencies, e.g.: $OUT/size-info/ChromePublic.apk.jar.info Before this CL, the .apk.jar.info was generated by javac.py when compiling the APK's own source files (which include things like the auto-generated resource-related .srcjar files), by passing the --apk-jar-info option to the script. Unfortunately, this made the implementation of the android_apk(), java_library_impl() and compile_java() GN templates slightly more complex (tightly coupled) than needed, making future changes more difficult. This CL tries to untangle the coupling as follows: - Add a new script (merge_jar_info_files.py) to merge one or more .jar.info file into a final .apk.jar.info. - Remove --apk-jar-info option from javac.py. The latter is now only responsible for generating the .jar.info of its final .jar file, and doesn't need to know anything about that may or may not embed it later. Similarly, remove the 'apk_name' variable from compile_java() and java_library_impl(). - Ensure that the android_apk() generates the final .apk.jar.info file by calling merge_jar_info_files.py. + Move common functionality to build/android/gyp/util/jar_info_utils.py To test the result, I manually checked that all .apk.jar.info files are identical after sorting (since they are a dump of a Python dictionary, with no guaranteed ordering: BUG=830641 R=agrieve@chromium.org, yfriedman@chromium.org Change-Id: I2051bc35aba2931947d2a30db507a4d437998238 Reviewed-on: https://chromium-review.googlesource.com/1047269 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
nednguyen authored
NOTRY=true # test covered by PRESUBMIT Bug: 840365 Change-Id: Ic064341d126c656e2acbf4224807f63a0815b601 Reviewed-on: https://chromium-review.googlesource.com/1048984Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#556769}
-
Hans Wennborg authored
Bug: none Change-Id: I74c2f8d85642291604d82eddc8ab7c0588fb8463 Reviewed-on: https://chromium-review.googlesource.com/1049613Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556768}
-
Guido Urdaneta authored
This reverts commit f1b4c43b. Reason for revert: Causes reliable failures on Win10 Tests x64 (dbg) bot Sample failed runs: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/413 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/414 Sample logs: [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 Original change's description: > The SnooperNode: Audio loopback for a single stream. > > An audio::GroupMember::Snooper that records the audio from a GroupMember > on one thread, and re-renders it to the desired output format on another > thread. Since the data flow rates are known to be driven by different > clocks (audio hardware clock versus system clock), the SnooperNode also > uses its resampler to compensate for skew and re-synchronize the audio > going into and out of it. > > Bug: 824019 > Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8 > Reviewed-on: https://chromium-review.googlesource.com/1041657 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556719} TBR=miu@chromium.org,chcunningham@chromium.org,olka@chromium.org,xjz@chromium.org Change-Id: I47750e3abb5e9387733b5fbf275d930a79a6d45e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824019 Reviewed-on: https://chromium-review.googlesource.com/1049905Reviewed-by:
-
