- 14 Oct, 2020 40 commits
-
-
Adlai Holler authored
Just a name update to keep up with Skia. Change-Id: I61118e4cf4a18f5bdadbd7005dbf1f69be12e223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470464 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#817032}
-
Fabio Tirelo authored
This is a reland of 53d410bb Original change's description: > Revert "[PM] Add FrameNode viewport intersection" > > This reverts commit cf2a7489. > > Reason for revert: > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > TBR=pmonette@chromium.org > > Original change's description: > > [PM] Add FrameNode viewport intersection > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > will allow the tracking of the visibility of each frame. > > > > Bug: 1077217 > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816728} > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1077217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817024} Bug: 1077217 Change-Id: If7f061e7722fdd6ae4a3ce37a1f51a337481dd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471261Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817031}
-
Fabio Tirelo authored
This reverts commit 53d410bb. Reason for revert: There is a CL landed after this that changes a type somewhere, reverting is not that trivial Original change's description: > Revert "[PM] Add FrameNode viewport intersection" > > This reverts commit cf2a7489. > > Reason for revert: > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS > - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 > > TBR=pmonette@chromium.org > > Original change's description: > > [PM] Add FrameNode viewport intersection > > > > This CLs plumbs the viewport intersection to the FrameNode, which > > will allow the tracking of the visibility of each frame. > > > > Bug: 1077217 > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > > Reviewed-by: François Doray <fdoray@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816728} > > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org > > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1077217 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817024} TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1077217 Change-Id: I3c36272ac57b0857400331196a506069c596d36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471259Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817030}
-
Elly Fong-Jones authored
These tests all use the PAGE_SIZE macro, which isn't correct under Rosetta until the 11.0 SDK; have them use base::SystemPageSize() instead. Bug: 1102194 Change-Id: I752462b38fc7cd33f45678e3708d6b16b23b7fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469224 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#817029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ee1c94588a..1bf2339dc0f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6a9c7d78f94d9a32ff27a351dac271d4eaf6f795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817028}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52c138e36e87..0c83e15c6b61 2020-10-14 alessiob@webrtc.org Move AGC2 config ToString to the right place and update Validate() 2020-10-14 ivoc@webrtc.org Add config options for python plots and text log to the NetEq simulator API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5afa041d94472442f78c7ae8249bbcb9c21bb0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470339Reviewed-by:
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I457a0bfebadb2b82d8f6ab7cc7ea809ec04dd0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469016 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817026}
-
Nicolas Ouellet-Payeur authored
Currently, (non-OffTheRecord) Profile objects are only destroyed when the entire browser exits. This patch adds an DestroyProfileOnBrowserClose flag, which causes the Profile object to be destroyed when the last window in that profile closes. It works, but it can cause crashes or instability in some cases, so it's off-by-default for now. This patch does not work well with ephemeral/guest profiles, or background mode. Bug: 88586, 566835 Change-Id: I73e78383cd57802deaee9ec23f6fa219881b1360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451696Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817025}
-
Fabio Tirelo authored
This reverts commit cf2a7489. Reason for revert: FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947 TBR=pmonette@chromium.org Original change's description: > [PM] Add FrameNode viewport intersection > > This CLs plumbs the viewport intersection to the FrameNode, which > will allow the tracking of the visibility of each frame. > > Bug: 1077217 > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816728} TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
Sébastien Séguin-Gagnon authored
Bug: 1099268 Change-Id: I2a0de73ed846b100a549429888dabeb8ffe2db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461217 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#817023}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ee1c94588a..1bf2339dc0f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7afffe03f8b264b2ebaa830f3496511400f0649e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471217Reviewed-by:
-
Joon Ahn authored
Bug: 1136195 Change-Id: I23b30df8776b13558acf8ff9e9824b06d4c03cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463376 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817021}
-
Colin Blundell authored
WebLayer does not use //components/history and does not want to take a dep on the (large) component, as every dep that WebLayer adds has an impact on WebView. SubresourceFilterContentSettingsManager, however, currently depends on //components/history for its optional observance of the user's deletion of URLs from history. This CL abstracts that dependency via the following changes: - Adds the ability for SubresourceFilterProfileContext to store opaque embedder data (via a simple SubresourceFilterProfileContext::EmbedderData interface) - Moves the history observance to a new SubresourceFilterHistoryObserver class that is an EmbedderData and takes in a SubresourceFilterContentSettingsManager instance to call into - Has SubresourceFilterProfileContextFactory create SubresourceFilterHistoryObserver instances to be stored by SubresourceFilterProfileContext instances In this way, WebLayer will be able to use SubresourceFilterProfileContext, AdsInterventionManager, and SubresourceFilterContentSettingsManager without taking on the //components/history dep. Bug: 1116095 Change-Id: Ic81f63447f10afef1c4946ca7751d810d0a9cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466761Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#817020}
-
Alex Turner authored
Currently, FontMatchingMetrics uses the broader IdentifiabilityStudySettings::IsActive() call for its early returns. This ensures that unnecessary computation is not performed for users not participating in the study. We update these methods to use more specific checks that allow for server-side disabling of font metrics recording. Bug: 1136938 Change-Id: I12bdbd47e8bc0e6567f796fd3b058f02f4dd105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466143Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817019}
-
Tanmoy Mollik authored
This cl adds a render test to check that sync promo is shown when the user has signed in with without sync consent. Bug: 1105800 Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I8bc65fcbc91216668fd2f711cd17beb60f63cdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454170 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#817017}
-
Koji Ishii authored
To measure the usage to help discussions. Change-Id: Iaaada2de6899c38edd3f4be5624c832dfd119a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470896 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#817016}
-
Fergus Dall authored
Bug: None Change-Id: I7f27f2dbfb8b84458bd9df3aae7bb06ed8d9252a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467579 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#817015}
-
dpapad authored
Bug: 1132403 Change-Id: Ibe0f9bd3f481b716702caa92a325533372a0f3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469375 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817014}
-
sauski authored
Added UMA logging to record when the client has successfully contacted the HaTS Next service, but the service has declined to provide a survey for display. Bug: 1110888 Change-Id: I0d376c1612efc664ca52646b17ea4f68ae69d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463618 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#817013}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602654939-1f5462f983274209ab06546353a58e9ab57d2346.profdata to chrome-linux-master-1602676072-ebb21a5d77144e96fd6267407ee41b0443253d5d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I57601dadf1e85da773c32cec604c7e08067303d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471138Reviewed-by:
-
sandromaggi authored
The action previously had its call chain hidden in the |WebController|, this CL moves the chain to the util (as e.g. |ClickOrTapElement|). This will allow us to later on easier control what a |SetFieldValue| does. This CL adds utility functions to call existing chains while handling the lifetime of the |ElementFinder::Result| oneself (instead of letting the util handle it). This is required for actions that want to resolve the element and use it for multiple web-actions (e.g. |RequiredFields FallbackHandler|). This CL refactors the |SetFormFieldValueAction| to be easier understandable by moving from index to next-Callback and generally cleaning up the code. Bug: b/168107066 Change-Id: I504865ce9e70c5a5a14c30255feaf21fc5c916fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467857 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#817011}
-
Randy Rossi authored
Fixes msan issue warning of use of uninitialized variable. ==1066560==WARNING: MemorySanitizer: use-of-uninitialized-value Bug: None Test: ran unit tests with msan Change-Id: Ia8e57144e051f639d234d9117e05c6f08236cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468437 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#817010}
-
Fabio Tirelo authored
Most likely a linter rollout caused redundant tests to be identified in third_party/blink/web_tests/TestExpectations. Removing the unnecessary lines. Example run (search for 'webkit_lint'): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/108903 TBR=tkent@chromium.org Bug: 1068610 Change-Id: Ie818535d3e8bc86cf5576ccff61db73a6708984c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471236Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I1bfe954ba61dfc6608210bcea7a293c32b58075d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453290 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d314a40a3aa..e8c80d06a62a 2020-10-14 wolfi@chromium.org [TS] Port DOMStorageModel to TypeScript 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-14 alexrudenko@chromium.org Remove old entrypoints in inspector_overlay 2020-10-14 petermarshall@chromium.org [typescript] TypeScript-ify timeline_model/TimelineJSProfile.js 2020-10-14 tvanderlippe@chromium.org Build common-legacy.js with devtools_entrypoint 2020-10-14 jacktfranklin@chromium.org Migrate emulation/DeviceModeToolbar to TS 2020-10-14 sigurds@chromium.org [ts] Type-check resources/DatabaseQueryView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f6c50a86b3db8ca0a1ce653eabeb2a84b8b627d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471177Reviewed-by:
-
Matt Falkenhagen authored
This code is for creating a shared worker. Fixes a typo from r681479. Change-Id: I3a56d8bc84d575f385a840d1e0fca5b3c275ac16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470820 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#817006}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602654939-6aaab1e7299ba115ccc1d7beffbea8c42a27a599.profdata to chrome-mac-master-1602676072-1b8a347d7aacd68f729e2321f1fc4670c7061ae9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9ab4c6a2554eea1e183ed2c36fb320ee4e881f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470747Reviewed-by:
-
Sébastien Séguin-Gagnon authored
Bug: 1131107 Change-Id: Ib7b047409a42fe5a4ad5b33ecf10825214c9089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456126 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
-
Austin Sullivan authored
- Add DidFlush() method which checks for cancellation before flush completes. - This should fix the behavior of Cancel() Bug: N/A Change-Id: I763f5f87eaed80c7a8f1962d781a749d8a63b2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456866Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#817003}
-
chrome://sync-internalsPaula Vidas authored
This CL replaces all occurrences of "about:sync" with "chrome://sync-internals", so the URL is the same everywhere. Bug: 1137739 Change-Id: I461582da8aa9d809ffe72715d09456fc7818652c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470077Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2999de2b9ad8c3039a0338fbb9e0d5e4655beabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470457Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#817001}
-
Alice Wang authored
This CL adds type information for the generic test rule in AccountPickerBottomSheetTest. Bug: 1120258 Change-Id: Ia672bf78b84a1aadfe3056fc030135310de99a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470564Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817000}
-
Rune Lillesveen authored
Wrap CSSValue and the corresponding TreeScope from MatchResult in a ScopedCSSValue passing it to StyleBuilder. Currently use a nullptr TreeScope in the cases where we don't have one to look up tree-scoped references. We do not support such names/ references in UA stylesheets. We currently support @keyframes in user stylesheets, but collect them from the StyleEngine regardless of which scope the animation-name came from. It would be possible to have a TreeScope for user sheets (and even UA sheets) and use ScopedStyleResolvers instead of extra structures in StyleEngine. For now pass null TreeScopes for UA and user style values. Bug: 336876 Change-Id: I4c5af46bde94b9fda41d676982d9e9386b652538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455609Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816999}
-
Richard Knoll authored
If an origin is capturing a screen we want to allow it to show notifications. The site knows that the user is actively presenting the screen and should mute notifications itself if it wants to. Otherwise it should be able to show notifications. Bug: 1131375 Change-Id: I455c9c8822cb6f3bda31d7f1b590f0843a336ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462076Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#816998}
-
Alexander Surkov authored
TimingUpdate::MovePolicy shadows ShadowStyle enum fields. Bug: 294205 Change-Id: Idf16e65353f4a21b2dea1ba4e74c8bb5d07c7744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468505 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816997}
-
Rayan Kanso authored
I'm not really sure why this is happening as we only store strings in the dictionary. However there have been a few crash reports. Bug: 1136031 Change-Id: I105bc90e4897ac01d3db5550382ac8b38e566347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470633Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816996}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f024b330f8..ea954d80edb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC swapnilgupta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: swapnilgupta@google.com Change-Id: Icdbf90578cde927fe1be75593bd22ec4db5df3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470743Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816995}
-
Roman Sorokin authored
Bug: None Change-Id: I40f1f737e254d7c78d9324bb95ef42b71482f374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453258Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816994}
-
Jan Wilken Dörrie authored
This change adds a fieldtrial testing config for the PasswordsWeaknessCheck feature. R=chromium-metrics-reviews@google.com Bug: 1119752 Change-Id: I214a56f8a6a986d824046eaab9ce36dc29234c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469561 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#816993}
-
