- 06 Oct, 2020 40 commits
-
-
John Abd-El-Malek authored
This was propagated only on Android and not desktop because of tests that inadvertently depended on this. -history test said it wanted no user gesture, but ui_test_utils::NavigateToURL always enabled it -dice code was setting user gesture but this wasn't propagated so it wasn't necessary -download tests: I'm unsure if the tests were correct or if there are bugs to fix in the production code. For now setting user_gesture to false to simulate old behavior before this change -signin_view_controller: no-op change since this is a browser initiated navigation so the user_gesture was always ignored Fixes: Bug: 1132491 Change-Id: Ib3486090d4d18a66e0e76f9135b45a7abcbdaf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430451Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#814091}
-
Ian Kilpatrick authored
This patch moves the layout-overflow calculation "into" NG. It does several interconnected things: - Just before a fragment is created we calculate the layout-overflow for a fragment. This is more correct than doing it for the layout object as a whole, resulting in more multi-col passes. The additional regression was caused the layout-overflow calculation hiding a bug with large column gaps (which exceed the inline-size of the container). - Once this is calculated, we run the SetLayoutOverflowFromLayoutResults function which "joins" all the layout-overflow from the fragments into the layout-object, used for JS API calls. - Finally there is the LayoutNGMixin::RecalcLayoutOverflow which allows for recalculating of layout-overflow, and correctly rebuilding the fragment-tree. Bug: 1066616 Change-Id: I25987a32b0254eafc2d7aad90ef6a36b60f1e1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333083 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814090}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ff24ae00769..da61c40e99c3 2020-10-06 kainino@chromium.org Revert "Work-around test runner & DebugAnnotator" 2020-10-06 jmadill@chromium.org Change shader compile failures into an info message. 2020-10-06 jmadill@chromium.org Test Runner: Pass dEQP args to child processes. 2020-10-06 jmadill@chromium.org Test Runner: More misc improvements. 2020-10-06 ianelliott@google.com Work-around test runner & DebugAnnotator 2020-10-05 jmadill@chromium.org KHR_debug: Fix off-by-one message length. 2020-10-05 jmadill@chromium.org Suppress failing Mac GL dEQP-GLES3 tests. 2020-10-05 vantablack@google.com Replaced allow_list with files_to_check 2020-10-05 jmadill@chromium.org Improve capture replay tests. 2020-10-05 jmadill@chromium.org Capture/Replay: Don't capture XFB 0 in MEC. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib2806471c642f8dbb846c7a85b4d8736c7938746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814089}
-
Findit authored
This reverts commit 325dbbc8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 814073 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMyNWRiYmM4NTkwM2M5NjUwMDFmNmI2NmI0MWE3YzNhMGE5NmU0OGUM Sample Failed Build: https://ci.chromium.org/b/8867218581185660560 Sample Failed Step: compile Original change's description: > [Feed v2] Allow setting feed stream data in feed internals page > > Bug: none > Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814073} Change-Id: Iddd3027f84e54727f4f0dc5f905a5e1e330b16d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450611 Cr-Commit-Position: refs/heads/master@{#814088}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d93ee76664c7..315b9a55a9b5 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I18160df4c466834b64010a5aabb3df1ebccf4c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451638Reviewed-by:
-
Kuo-Hsin Yang authored
SystemMemoryPressureEvaluator::GetMarginFileParts is replaced by GetMemoryMarginsKB, such that SystemMemoryPressureEvaluator is not required to get the margins. BUG=b:149833548 Change-Id: I948e576b5a36ce24590c48a36e0416cfc679979e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418272Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#814086}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //storage. Bug: 1113033 Change-Id: I9be522584e795c85ed77ffeccace1a088d818233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451393 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814085}
-
Minoru Chikamune authored
This CL adds CreateAgentGroupScheduler function to WebThreadScheduler so that it can be called from the content layer. Bug: 1105403, 1113102 Change-Id: I2449185c485b2d803a0f2eb5deebc2076cdac1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444620 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814084}
-
Fergus Dall authored
TBR=dgozman@chromium.org TBR=pfeldman@chromium.org TBR=caseq@chromium.org TBR=yangguo@chromium.org Bug: 1046784, 1102964 Change-Id: I44c12d89054dc27ed43a2be06a4ac77249ce696d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449514Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814083}
-
Mitsuru Oshima authored
Bug: None Change-Id: I3d360a45cd6ca9e3014a09eef417cfcb9fc5dc6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447789Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#814082}
-
Peter Kotwicz authored
Relanding now that the internal Chromium CL has landed Original change's description: > Revert "Rename font-related Chrome resources part 3/3" > > This reverts commit 5a4717f4. > > Reason for revert: Compile failures on downstream build > https://crrev.com/i/3309264 not yet rolled. > > Original change's description: > > Rename font-related Chrome resources part 3/3 > > > > BUG=1129255 > > TBR=twellington > > > > Change-Id: I7acff50f82c1a0bc0b7a2d55e09cd307b447f033 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446540 > > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#813828} > > TBR=yfriedman@chromium.org,pkotwicz@chromium.org > > Change-Id: I90d3fc2d8fb97047ca0edc3b1d955fcdfafecbd9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1129255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450919 > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813837} TBR=yfriedman@chromium.org,pkotwicz@chromium.org,chouinard@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1129255 Change-Id: Ic457609aac0fbfba5518e75e5c1efaa281151822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451521Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814081}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0508de1e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, wjmaclean@chromium.org: external/wpt/origin-isolation jsbell@chromium.org: external/wpt/encoding kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I900b84ecf7b5a5628c1aea07f0996ebf15fe3257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451532Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814080}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41d906752d13..347e5dc37127 2020-10-06 brianosman@google.com In VarDeclarations, align constructor parameter type with storage 2020-10-06 kjlubick@google.com [canvaskit] remove accidentally included API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I31c5b2667948a36413ba5bc7accc4015c28e3016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451634Reviewed-by:
-
Fergus Dall authored
TBR=collinbaker@chromium.org Bug: 1134534, 1134535 Change-Id: I94e11685ebbfbc31ec0f75296e2b12da28d16463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449658Reviewed-by:
-
Yuchen Liu authored
To avoid log spam, only show DVLOG(0, 1, 2) on debug build. Bug: internal b/170151760 Test: Build and run. DVLOG(3, 4, 5) disappear Change-Id: Ieeb415c60c952e251a551e02df467d2f7861910e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451304Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df9f8642fc27..da7feb74237d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sidereal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sidereal@google.com Change-Id: I8a25d8a1766147198f7231d04ae600f70e031d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814076}
-
Fergus Dall authored
TBR=joelhockey@chromium.org Bug: 1135410 Change-Id: I60f8130bbf2b4b7451e279ae2b344cfcd721d7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449838Reviewed-by:
-
Weilun Shi authored
Stop showing the interactive pretty print PRESUBMIT error message but still show the loading message when running the PRESUBMIT. Only show the result of the PRESUBMIT at the end of the check. Note that git cl presubmit still shows these interactive error messages. We just stop showing if the check is invoked by git cl upload. Change-Id: I4551af6f98cf80026941369137d372197d4e671f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444372 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#814074}
-
Jian Li authored
Bug: none Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#814073}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie505b39b7b2a5a3aef79f62c20047de495206b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451419Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3c9f8a5..ba1e9298 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0740d09f8c077383f0a66af482807f84b0728904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814071}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia7bfc45b8e32d36e93ae97eca0ac8fb06ea6c5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451631Reviewed-by:
-
Kent Tamura authored
|non_content_height| is always zero because UA stylesheet for the inner editor doesn't have border/padding/margin, and web authors can't specify them. This CL has no behavior changes. Change-Id: I9093a8bb33076a67730231b75ce804daadb61a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449674 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814069}
-
Matt Falkenhagen authored
To clarify that this param controls whether the optimization guide predictions are retrieved, but does not mean they are necessarily used to prefetch. We use this param for the counterfactual logging arm vs prefetching. Add a test for this as well. There is a subtle difference between the two options. |prefetch_always| only had an effect when kLoadingPredictorPrefetch was enabled, but |always_retrieve_predictions| can cause predictions to be retrieved even without prefetch enabled. One test is modified to account for this difference, as now more origins are preconnected to when the option is used. In other words, |prefetch_always| is equivalent to |always_retrieve_predictions| = true AND |kLoaderPredictorPrefetch| is enabled. Bug: 1092329 Change-Id: I575d6d40d62ebe3549bc4831479673a7aae9d9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439973Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#814068}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ic4374f32e11da55628b81d64e0ee34facbeb255d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451730Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814067}
-
Rakesh Soma authored
Bug: 1133565 Change-Id: I0a4e6a8c3310525aa02de4f6f6c726c75419e702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439676 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#814066}
-
Eric Willigers authored
The browser test helper methods in web_app_browsertest_util.cc that install PWAs (InstallWebApp, InstallWebAppFromManifest, PendingAppManagerInstall) now wait for on_registry_ready(). Bug: 1119807 Change-Id: I60c16e04b75603a8d0979fd09e9f6746335cd788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814065}
-
Josiah K authored
Change-Id: I6fbd33d3b9dcab11079a9cff4df8d8cbaeda046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451629 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#814064}
-
Kenichi Ishibashi authored
This CL: * Introduces an error code that indicates a mojo connection to the storage is disconnected. This won't happen yet but could happen in the future. It could happen due to a Storage Service crash after ServiceWorkerStorage is migrated into the Storage Service, and the Storage Service is hosted outside the browser process. * Updates GetStorageUsageForOrigin() to make sure that the callback of the method is always called. Currently it uses WrapCallbackWithDefaultInvokeIfNotRun() but we may use the different approach in the future. Other methods in ServiceWorkerRegistry also need to be updated. Subsequent CLs will do that. * Sets a mojo disconnection handler. Currently it just resets the remote. Subsequent CLs will implement crash recovery logic. See [1] for the overall plan. [1] https://docs.google.com/document/d/1RQgiuAZVbQZbYJeLOfmydBMwXTTfsL2RqZKx90yPT7U/edit?usp=sharing Bug: 1133143 Change-Id: I28cef47d66c6f95b33d7a4a8b152e7d38d32e49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437082 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814063}
-
Dirk Pranke authored
This CL rolls //third_party/catapult to 532e564f622742fc93a7f91dd3556d711e778a7e and picks up https://chromium-review.googlesource.com/c/catapult/+/2450450 which removes zipfile_2_7_13.py as a dependency. This CL also updates the corresponding Chromium .pydeps files that mentioned it. That change also added a dependency on `six`, which seems to be pervasively assumed in other parts of the catapult codebase as present in the environment; however, it isn't guaranteed to be there in the chromium compile-time python build, so this adds that as needed as well. TBR=bsheedy@chromium.org Bug: 1112471 Change-Id: I849355a5bdc18847dcbf39f3d3a9e9fbf428e3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449938 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814062}
-
Andrew Comminos authored
In the process of converting these tests to standard WPTs, fix them up to work inside of wpt_internal. Bug: 956688 Change-Id: I4685ca247091b1a64bd8da735fa42a34420e447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444793 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814061}
-
Minoru Chikamune authored
This CL adds GetCurrentAgentGroupScheduler function to WebThreadScheduler so that it can be called from the content layer. Bug: 1105403, 1113102 Change-Id: I0c78867453bf942deb4dc98fd557ad4662d4a7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444619 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Carlos IL authored
Previously forms on secure sites that submit to an insecure target, but that submitted on a new tab (with target=_blank) showed the on form warning but not the on-submit one. This CL fixes it. Pending work: Like other interstitials for navigations on new tabs, this will go back to the NTP if Go Back is selected, it might make more sense to close the new tab in this case, but in the interest of keeping the CL simple for merging, this will be done on a separate CL, which won't be merged. Bug: 1134466 Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451549 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#814059}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601920728-6028d40b51a1c3ae51d439d61f82d0425613d326.profdata to chrome-linux-master-1601942192-5610f8208d2a00c81b789319176c3ce4858b86b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12ddf6af25c4546ffc300237b2da92a6217c09e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451672Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/765c9d3a9ca4..41d906752d13 2020-10-05 brianosman@google.com Allow use of SkTHash* in skslc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ie4ec77ae5b8c6f29ce2abb5d096065c194984fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450970Reviewed-by:
-
David Tseng authored
This change precisely stipulates the events handled for each type of editable encountered through tests. R=akihiroota@chromium.org pressing 'e' would also cause sticky mode to turn off. Fixed: 1135118 AX-Relnotes: fixes an issue in Smart Sticky mode where jumping to a text field by Change-Id: I56de4cebc0a1a942d99c5d0c9445b5b33f9d4e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448053Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2266710dd28b..df9f8642fc27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sidereal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1135321 Tbr: sidereal@google.com Change-Id: I86814fdf508b39e690c117eed6dbf92243b3b000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451368Reviewed-by:
-
Fergus Dall authored
Bug: 1135405 Change-Id: I606b976fbbce6168fcdf8c6b0bf9b518f5f887ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449872Reviewed-by:
-
Oriol Brufau authored
This is a reland of d46bdb4f It was reverted because the new test could time out in Mac. Fixed by adding '<meta name="timeout" content="long">'. Original change's description: > [Editing] Fix canonical caret position at line break > > Consider this testcase: > <style>div { width: min-content; padding: 5px; }</style> > <div contenteditable>line1<wbr>line2</div> > which is rendered as > line1 > line2 > > Before this patch, when clicking at the beginning of the 2nd line, the > caret would appear at the end of the 1st one, because CanonicalPosition > would search backwards even with a downstream affinity. > > Also, when clicking at the beginning of the 1st line and pressing the > down arrow key, the caret would move to the end of the 1st line instead > of to the beginning of the 2nd one. And pressing the key again would > have no effect, the caret would refuse to go down. > > This patch fixes these problems by making CanonicalPosition take a > TextAffinity parameter which affects whether the canonical position is > first searched backwards or forwards. If no suitable candidate is found, > it will still search in the other direction. > > And then, VisiblePosition::Create takes care of deciding between the > upstream and the downstream canonical positions, depending on the > affinity and whether there is a line break. > > Bug: 1002937 > > Web tests: > TEST=external/wpt/editing/run/caret-navigation-around-line-break.html > > Unit tests: > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/0 > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/1 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/0 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/1 > TEST=VisiblePositionTest.ShadowV0DistributedNodes > TEST=VisibleUnitsLineTest.endOfLine > TEST=VisibleUnitsLineTest.isEndOfLine > TEST=VisibleUnitsLineTest.isLogicalEndOfLine > TEST=VisibleUnitsLineTest.isStartOfLine > TEST=VisibleUnitsLineTest.logicalEndOfLine > TEST=VisibleUnitsLineTest.logicalStartOfLine > TEST=VisibleUnitsLineTest.startOfLine > TEST=VisibleUnitsTest.canonicalPositionOfWithHTMLHtmlElement > TEST=VisibleUnitsTest.canonicalPositionOfWithInputElement > TEST=VisibleUnitsTest.canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter > > Change-Id: I82d86d40a87513b2e92c024735957e9f71154094 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410404 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813744} Bug: 1002937 Change-Id: Ida01b6d838f03cfbe66e4cba86472ed90499af45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450292Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#814053}
-
Fergal Daly authored
PROBLEM: It is not possible to retrieve traces from swarming with --gtest_repeat. For a file to be retrievable from swarming, it must be placed in ${ISOLATED_OUTDIR} but specifying anything for --enable-tracing-output disables the unique-filename-per-test behaviour. With this change it becomes possible to do e.g. tools/mb/mb.py run ... \ --gtest_filter=WebNavigationApiTest.Crash \ --gtest_repeat=100 --enable-tracing=*,disabled-by-default-toplevel.flow \ --enable-tracing-output='${ISOLATED_OUTDIR}/' and have unique files for each test that are retrievable with swarming collect. Also drive-by fix typo in name of function. BUG=1043616 Change-Id: Idd1bcbbdb6f18d297170f074e9409c61204fcacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445649 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
