- 22 Sep, 2016 40 commits
-
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/a939bfe3e102..fe0179ded820 $ git log a939bfe3e..fe0179ded --date=short --no-merges --format='%ad %ae %s' 2016-09-22 tsepez Rename CPDF_CountedObject to CFX_WeakPtr::Handle TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2365533005 Cr-Commit-Position: refs/heads/master@{#420481}
-
cbiesinger authored
This is necessary to avoid a DCHECK when opening the DOM inspector on any page (and is also clearly correct) R=mstensho@chromium.org,eae@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2360793002 Cr-Commit-Position: refs/heads/master@{#420480}
-
reed authored
Use SkData oriented picture serialize api, allowing us to deprecate the older api behind the SK_SUPPORT_LEGACY_STREAM_DATA flag. BUG=647756 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2343993002 Cr-Commit-Position: refs/heads/master@{#420479}
-
bokan authored
Used only in tests. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2361203003 Cr-Commit-Position: refs/heads/master@{#420478}
-
schenney authored
The codepath for compositing opaque scrollers, enabled by --enable-blink-feature="CompositeOpaqueScrollbars", was triggering two asserts. One assertion was due to querying stacking order lists when those lists were dirty. The assertion is fixed by updating the stacking order lists if needed before the query, only if we actually need to look at the list. The other assertion was a side-effect of an earlier change to remove a different assertion, https://codereview.chromium.org/2191953002. The code in question is attempting to update the shouldPaint flag of a FloatingObject when that object has had a change in selfPaintingLayer status. But because selfPaintingLayer status has already been updated, and the query for FloatingObject::shouldPaint() checks the current selfPaintingLayer status, we have no way of finding out if a floating object with a selfpaintingLayer was previously shouldPaint. We were requiring that shouldPaint return true so that we could set it false and return, but instead we were falling out of the loop and hitting an ASSERT_NOT_REACHED. The fix is to not check the previous status and just set shouldPaint to false for all FloatingObject where the object has a selfPaintingLayer, and not assert not reached as now we might exit the loop. We are no longer returning as soon as we update the shouldPaint to false because we can no longer be sure that we are actually changing the value of shouldPaint. The lack of assertions allows 2 webkit_unit_tests to pass without crashing, and prevents crashes in a slew of LayoutTests. Of note, fast/overflow/overflow-float-stacking.html no longer crashes, but does fail analogously to fast/overflow/overflow-stacking.html. In https://codereview.chromium.org/1826013002 we had decided to live with that failure as it is a manifestation of the fundamental compositing bug that users on high DPI devices have always seen. R=wangxianzhu@chromium.org,flackr@chromium.org BUG=593097,381840 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2365673002 Cr-Commit-Position: refs/heads/master@{#420477}
-
johannkoenig authored
https://chromium.googlesource.com/webm/libvpx.git/+log/4282d29355df..99ef84c65a2b $ git log 4282d2935..99ef84c65 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 angiebird Detect invalid highbd iht input 2016-09-21 johannkoenig Keep vp8 sixtap read within bounds 2016-09-21 johannkoenig predict_test: align dst buffer to 16 2016-09-07 jzern vp8: remove VP8_SET_DBG* control support 2016-09-19 jzern vp9_rtcd: remove non-existent highbd convolve fns 2016-09-19 jzern examples: quiet -Wshorten-64-to-32 warnings 2016-09-19 jzern vp8: convert some uses of unsigned long to size_t 2016-09-19 jzern vp8/encoder: quiet some -Wshorten-64-to-32 warnings 2016-09-19 jzern variance_avx2: sync variance functions with c-code 2016-08-26 johannkoenig Remove -fno-strict-aliasing flag 2016-09-08 negge Code class0 using vpx_read() / vpx_write(). 2016-09-19 aconverse Zero the whole rd_counts struct rather than the each member 2016-09-17 jzern loopfilter_mb_neon: remove unused load_8x8() 2016-09-15 linfengz Refactor lpf (size 16) NEON intrinsics optimization 2016-09-15 jzern vpx_subpixel_8t_intrin_avx2: tolerate unversioned clang 2016-09-08 johannkoenig Enable ssse3 bilinear tests 2016-09-02 johannkoenig Add vp8_bilinear_filter test 2016-09-16 johannkoenig Revert "Restore vp8_sixtap_predict4x4_neon" 2016-09-02 johannkoenig Restore vp8_bilinear_predict4x4_neon 2016-09-15 johannkoenig zero structures completely (...) Review-Url: https://codereview.chromium.org/2362513003 Cr-Commit-Position: refs/heads/master@{#420476}
-
chfremer authored
This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL1.6.2. This CL is a step towards being able to reuse the classes VideoCaptureDeviceClient and VideoCaptureBufferPool as part of the Video Capture Mojo Service, because they implement functionality that is needed there. Expressed in class-diagram form, we want to realize the cut indicated by the red line in [2]. Currently, the classes VideoCaptureDeviceClient and VideoCaptureBufferPool live in content/browser/renderer_host/media. Even though their functionality is not specific to renderer_host, their dependencies create a tight coupling to code that is. In order to use them in services/video_capture, we need to move them out of there (and probably into media/capture/video). In this CL we move the nested and private classes from video_capture_buffer_pool.h/cc into stand-alone classes using separate files. After this separation, we will be able to move the parts that do not depend on content/browser/renderer_host/media to media/capture/video and keep the other parts where they are. Additional changes: * Rename interface VideoCaptureBufferPoolBufferHandle to VideoCaptureBufferHandle Note: Code in new file comes from either video_capture_buffer_pool.h or .cc. No additions or modifications oder than the required includes and guards. BUG=584797 TEST=This is a pure refactoring. No new functionality. content_unittests still pass. [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://docs.google.com/drawings/d/1acJSbj8eCK5Lpvv9QPiU_V34t8GfgqfYSoYbA93jb5o/edit Review-Url: https://codereview.chromium.org/2343423003 Cr-Commit-Position: refs/heads/master@{#420475}
-
rajendrant authored
BUG=646184 Review-Url: https://codereview.chromium.org/2345513003 Cr-Commit-Position: refs/heads/master@{#420474}
-
lambroslambrou authored
For the record, in case we decide to bring this back, there is also an un-landed CL at https://codereview.chromium.org/1917063002/ BUG=648670 Review-Url: https://codereview.chromium.org/2358083003 Cr-Commit-Position: refs/heads/master@{#420473}
-
eostroukhov authored
R=dgozman@chromium.org, kozyatinskiy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2366433004 Cr-Commit-Position: refs/heads/master@{#420472}
-
skym authored
The first bug was we were trying to start a nested cycle cycle, which is not allowed. The logic in the worker that tries to nudge in response to encryption changing is super old, and doesn't make any sense, so this was fixed by simply not nudging. If there needs to be a commit in response to encryption changing, the processor will drive this. The second issue was that in certain cases the worker would try to commit something with an id but not a version. This isn't supposed to be able to happen. Turns out two quick commits could get us into this state because both would be created by the processor before getting valid version data. However, the WorkerEntityTracker can detect this is happening and has enough information to make things right. BUG=647875 Review-Url: https://codereview.chromium.org/2350803005 Cr-Commit-Position: refs/heads/master@{#420471}
-
yusukes authored
BUG=b:31665510 TEST=try, also manually confirmed that Always button still works Review-Url: https://codereview.chromium.org/2357983006 Cr-Commit-Position: refs/heads/master@{#420470}
-
chrome://settings/certificatesisandrk authored
Extension provided certificates currently aren't shown on the certificates page, and this is bad from a security standpoint. This CL addresses the problem. BUG=532038 Review-Url: https://codereview.chromium.org/2307373003 Cr-Commit-Position: refs/heads/master@{#420469}
-
dalecurtis authored
Otherwise this may nuke intentional playbacks from the media session. BUG=649271 TEST=playback doesn't pause after 5 seconds if play occurs. Review-Url: https://codereview.chromium.org/2363813002 Cr-Commit-Position: refs/heads/master@{#420468}
-
donnd authored
Updates and simplifies the decoding of the Contextual Cards response data: 1) Add reading of the caption and thumbnail directly from the root level. 2) Remove full JSON response decoding. BUG=647041 Review-Url: https://codereview.chromium.org/2364703003 Cr-Commit-Position: refs/heads/master@{#420467}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/fef62e1f2bbf..a939bfe3e102 $ git log fef62e1f2..a939bfe3e --date=short --no-merges --format='%ad %ae %s' 2016-09-22 dsinclair Make creation of CPDFSDK_Document clearer 2016-09-22 kcwu Fix use uninitialized value and stack buffer overflow read 2016-09-22 kcwu Fix infinite loop when calling GrowNamedColorList TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2366563003 Cr-Commit-Position: refs/heads/master@{#420466}
-
maxbogue authored
Things within a component should have a namespace that matches its name. BUG=646685 TBR=brettw Review-Url: https://codereview.chromium.org/2354613002 Cr-Commit-Position: refs/heads/master@{#420465}
-
xdai authored
BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2333283004 Cr-Commit-Position: refs/heads/master@{#420464}
-
caryclark authored
Conic to quad changes have landed in Skia, so these Layout tests can be rebaselined. R=fmalita@chromium.org BUG=647922 Review-Url: https://codereview.chromium.org/2360393002 Cr-Commit-Position: refs/heads/master@{#420463}
-
phajdan.jr authored
This reverts commit 9b9b1fe8. Original CL: https://codereview.chromium.org/788163002 Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pwyjF_jAf6I/hUtcZJSVCwAJ for context. BUG=none Review-Url: https://codereview.chromium.org/2359053002 Cr-Commit-Position: refs/heads/master@{#420462}
-
qyearsley authored
This is meant to fix http://crbug.com/639410 by making it so that if there are files that are both added and deleted (e.g. downloaded and then de-duped), they won't ever be staged since all changes would be aggregated and de-duped before running git add/rm. BUG=639410 Review-Url: https://codereview.chromium.org/2341643005 Cr-Commit-Position: refs/heads/master@{#420461}
-
puthik authored
- Remove BluetoothAdadpter::Observer::AdapterPoweredChanged as Chrome to Android BT enable/disable are implemented in ArcIntentHelperBridge instead. - Mark SetRemoteDeviceProperty() as unsupported API. - Add 120 seconds timeout to Bluetooth Device scans. - Add missing implementation in GetAdapterProperty. BUG=646584 TEST=Unit test and CTS passed on minnie. Review-Url: https://codereview.chromium.org/2354933003 Cr-Commit-Position: refs/heads/master@{#420460}
-
wangxianzhu authored
BUG=646176 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2362903002 Cr-Commit-Position: refs/heads/master@{#420459}
-
yzshen authored
WebSocket Mojo API: set reason when disconnecting a WebSocket interface because of insufficient resources. BUG=None Review-Url: https://codereview.chromium.org/2343433002 Cr-Commit-Position: refs/heads/master@{#420458}
-
dmazzoni authored
BUG=649114 Review-Url: https://codereview.chromium.org/2354413003 Cr-Commit-Position: refs/heads/master@{#420457}
-
sunyunjia authored
When a page specifies a CSP of style-src 'self', it does not allow inline style changes. However, the node under User-Agent shadow trees should be an exception as developers are not allowed to modify the inline-style, but blink may need it. So we add shadow dom elements as an exception under CSP. BUG=648589 Review-Url: https://codereview.chromium.org/2359813002 Cr-Commit-Position: refs/heads/master@{#420456}
-
yzshen authored
The corresponding fix is https://codereview.chromium.org/2342233004/ BUG=638593 Review-Url: https://codereview.chromium.org/2345383002 Cr-Commit-Position: refs/heads/master@{#420455}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/bac104605ef3..5f544345d653 $ git log bac104605..5f544345d --date=short --no-merges --format='%ad %ae %s' 2016-09-22 bungeman Remove assert that current color is never used. 2016-09-22 brianosman Support for color-spaces with multi-stop (texture) gradients 2016-09-22 mtklein GN: build skiaserve CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2358803004 Cr-Commit-Position: refs/heads/master@{#420454}
-
eostroukhov authored
BUG=649382 Review-Url: https://codereview.chromium.org/2364693002 Cr-Commit-Position: refs/heads/master@{#420453}
-
moshayedi authored
test_ime_driver wasn't built when compiling //services/ui (which requires it to function properly), so text input didn't work if we built mash:all on a clean directory. This CL fixes that. BUG=548407 Review-Url: https://codereview.chromium.org/2356363004 Cr-Commit-Position: refs/heads/master@{#420452}
-
pdr authored
This patch removes MainThreadScrollingReason::kEventHandlers which was only used in tests. BUG=644514 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2360113003 Cr-Commit-Position: refs/heads/master@{#420451}
-
sdy authored
BUG= Review-Url: https://codereview.chromium.org/2359953003 Cr-Commit-Position: refs/heads/master@{#420450}
-
maxbogue authored
- Remove IsEncryptionRequired and just use cryptographer_ instead. - Use ThreadChecker instead of NonThreadSafe. - Tweak some comments. - Simplify (without changing) the encryption handling logic in ProcessGetUpdatesResponse. - Make DecryptSpecifics not static so the cryptographer doesn't need to be passed in. BUG=648705 Review-Url: https://codereview.chromium.org/2353353004 Cr-Commit-Position: refs/heads/master@{#420449}
-
yiyix authored
Update the vector icon for tray update button, so it looks more clear on screen. This cl also updates the color of low severity tray update button from green to white. BUG=643401, 646570 Review-Url: https://codereview.chromium.org/2360933002 Cr-Commit-Position: refs/heads/master@{#420448}
-
johnme authored
Failing to find a service worker might be temporary, so we shouldn't unsubscribe in this case. Continue to unsubscribe if the Service Worker is actually not found (e.g. because it has been unregistered). Also adds more UMA in this area. BUG=642139 Review-Url: https://codereview.chromium.org/2361113002 Cr-Commit-Position: refs/heads/master@{#420447}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43687f7e..3721449f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2360783005 Cr-Commit-Position: refs/heads/master@{#420446}
-
rajendrant authored
If precache cancel happens when all manifests are fetched (top_hosts_to_fetch_ is empty), CancelPrecaching() saves all the top hosts in unfinished work. In this case, unfinished work should not have top host. Also deletes the non-precached URLs in ClearAllForReferrerHost(). BUG=626463 Review-Url: https://codereview.chromium.org/2300703004 Cr-Commit-Position: refs/heads/master@{#420445}
-
estark authored
As discussed in the bug, it's hard to imagine that memoizing on VisibleSecurityState buys us anything other than more complicated code. BUG=642576 Review-Url: https://codereview.chromium.org/2363623002 Cr-Commit-Position: refs/heads/master@{#420444}
-
hubbe authored
It seems that providing random data to the VPX parser can make it call the video frame pool with illegal parameters. This currently causes a crash, let's make it return null, and the calling code already seems to handle that well. BUG=648849 Review-Url: https://codereview.chromium.org/2360373002 Cr-Commit-Position: refs/heads/master@{#420443}
-
dpapad authored
BUG=624476 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2366683002 Cr-Commit-Position: refs/heads/master@{#420442}
-