GitLab

This patch removes the old Web Notifications code-path now
that we've switched to the new Workers-enabled path.

BUG=392187

Review URL: https://codereview.chromium.org/740543003

Cr-Commit-Position: refs/heads/master@{#305005}

BUG=434681
TEST=WebRTC demos while adding/removing Thunderbolt cable during an ongoing audio session

Review URL: https://codereview.chromium.org/743943002

Cr-Commit-Position: refs/heads/master@{#305004}

BUG=432334
TEST=Manual test on Link

Review URL: https://codereview.chromium.org/740973002

Cr-Commit-Position: refs/heads/master@{#305003}

BUG=433077

Review URL: https://codereview.chromium.org/737043002

Cr-Commit-Position: refs/heads/master@{#305002}

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/737283002

Cr-Commit-Position: refs/heads/master@{#305001}

Because the test is sandboxed, it cannot call LoadV8Snapshot(). For the same reason, LoadV8Snapshot() must have been called in PreInitializeSandbox(), so the asserts are still valid.

BUG=421063

Review URL: https://codereview.chromium.org/735283002

Cr-Commit-Position: refs/heads/master@{#305000}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/737303002

Cr-Commit-Position: refs/heads/master@{#304999}

Move the notification part out of ConsumerEnrollmentHandler so that it can be reused for unenrollment as well.

ConsumerManagementNotification is always created for owner profiles even when
there is no pending notification to show, because enrollment or unenrollment
may happen after the owner signs in.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/733613005

Cr-Commit-Position: refs/heads/master@{#304998}

This CL removes generated code for
* RunnableAdapter
* ForceVoidReturn
* FunctorTraits
* InvokeHelper
from base/bind_internal.h.

BUG=433164

Review URL: https://codereview.chromium.org/621773002

Cr-Commit-Position: refs/heads/master@{#304997}

Simplify the calling convention of ComputeSecWebSocketAccept to just return a string, and add a test for it.

BUG=
TEST=net_unittests

Review URL: https://codereview.chromium.org/683033003

Cr-Commit-Position: refs/heads/master@{#304996}

Background: WebMediaPlayerAndroid's constructor does not know
video meta data. Meta data is received in OnVideoSizeChanged().
If ShouldUseVideoOverlayForEmbeddedEncryptedVideo answers true
WebMediaPlayerAndroid's constructor postpones stream texture
creation until OnVideoSizeChanged().

Problem: When constructor sets needs_establish_peer_ = false,
TryCreateStreamTextureProxyIfNeeded() does not create a proxy.
Without a proxy OnVideoSizeChanged() cannot create a stream
texture.

Solution: Once we get meta data, create proxy AND texture.

BUG=433833
TEST=Manual,
 1. Play a Youtube clip (no black frame).
 2. Play a purchased movie at Youtube (no black frame).

Review URL: https://codereview.chromium.org/730103002

Cr-Commit-Position: refs/heads/master@{#304995}

This CL adds new functionality to the web history service to access audio history as well since accessing audio history uses the same underlying mechanism as standard web history.

This CL also removes the onChange observer for the pref so that it is entirely handled by the handler. There is no longer a need for it since the only access to the pref is through this handler (i.e., there is no more settings checkbox).

Note: The completion callbacks in the hotword_audio_history_handler will probably be updated once some additional extension apis have been added.

We may eventually shift to a newer technology but it is appearing more likely it might not be ready when we need it. However, we will continue to use this method for the accessing of the audio history pref for quite some time (it's one of the approved methods) even once the setting of the pref switches to the newer model.

BUG=426640

Review URL: https://codereview.chromium.org/687803004

Cr-Commit-Position: refs/heads/master@{#304994}

The bare pointer could cause crashes if the extension is uninstalled (thus being deleted) while the launch logic is progressing on the FILE thread; storing an extension ID prevents this.

BUG=372270

Review URL: https://codereview.chromium.org/736233002

Cr-Commit-Position: refs/heads/master@{#304993}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ac1383d..e097be5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=humper@google.com

Review URL: https://codereview.chromium.org/737253002

Cr-Commit-Position: refs/heads/master@{#304992}

Cr-Commit-Position: refs/heads/master@{#304991}

Now Browser::UpdateToolbar is called not only when the activated tab is
changed but also when, for example, a provisional document loader is
canceled. As a result of this, the Translate bubble is closed when a
navigation in an iframe happens. This is not an expected behavior. Apart
from a provisional document, I found some unexpected conditions where
the bubble is closed (e.g.
Browser::OnWebContentsInstantSupportDisabled calls UpdateToolbar).

This CL changes the logic to avoid closing the bubble on UpdateToolbar.
Instead, the logic is changed to close the bubble when the activated
tab is changed (Browser::ActivateTabChanged).

BUG=433272
TEST=manual

Review URL: https://codereview.chromium.org/739793003

Cr-Commit-Position: refs/heads/master@{#304990}

BUG=433147

Review URL: https://codereview.chromium.org/737193002

Cr-Commit-Position: refs/heads/master@{#304989}

The original implementation sent clipboard data to be written over IPC
as a map of clipboard formats to 'parameters' for that format. The
parameters were just vectors of byte vectors. Needless to say, this
logic was complicated, fragile, and prone to bugs. In the browser
process, this resulted in the IPC validation logic being scattered
between ClipboardMessageFilter and Clipboard::DispatchObject.

The rewrite adds an IPC message for each flavor of data that the
renderer is allowed to write to the clipboard. On the browser side,
the logic is simply delegated to ScopedClipboardWriter. Since the
clipboard object map is no longer under the control of an untrusted
process, this allows the removal of a lot of validation logic.
Unfortunately, bitmap handling is still a bit complicated because it's
sent over shared memory, but all the validation logic has been moved
into ClipboardMessageFilter.

BUG=319285
TBR=avi@chromium.org,jamesr@chromium.org,wfh@chromium.org

Review URL: https://codereview.chromium.org/740763003

Cr-Commit-Position: refs/heads/master@{#304988}

BUG=432720

Review URL: https://codereview.chromium.org/725853002

Cr-Commit-Position: refs/heads/master@{#304987}

Since we pass in a custom parameter, we must provide a custom
CreatePageTest class.

BUG=434981

Review URL: https://codereview.chromium.org/741853002

Cr-Commit-Position: refs/heads/master@{#304986}

BUG=416286
TEST=covered by unittets, plus tested on device. (see bug for repro step)

Review URL: https://codereview.chromium.org/738243002

Cr-Commit-Position: refs/heads/master@{#304985}

Introduce DisplayPowerServiceProvider::Delegate to get rid of dependencies to ash/ and ui/.

BUG=429354

Review URL: https://codereview.chromium.org/739123002

Cr-Commit-Position: refs/heads/master@{#304984}

BUG=248873

Review URL: https://codereview.chromium.org/743043002

Cr-Commit-Position: refs/heads/master@{#304983}

Revert of Revert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/740853002/)

Reason for revert:
Reverted from the wrong branch.

Original issue's description:
> Revert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/731873003/)
>
> Reason for revert:
> Broke the branch build. https://uberchromegw.corp.google.com/i/chrome.mobile/builders/arm%20stable/builds/7097
>
> Original issue's description:
> > ChromeBrowserProvider shouldn't own the FaviconService
> >
> > As FaviconService is KeyedService and will be deleted along with profile.
> >
> > BUG=411435
> > TBR=Tedchoc
> >
> > Review URL: https://codereview.chromium.org/739713002
> >
> > Cr-Commit-Position: refs/heads/master@{#304690}
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/8c5b8c707daa9c026540a63f6f1e1c5981f5909c
>
> TBR=michaelbai@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=411435
>
> Committed: https://crrev.com/fa4053cc550e8989991006ea59a171bc3dd8e6e3
> Cr-Commit-Position: refs/heads/master@{#304979}

TBR=michaelbai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411435

Review URL: https://codereview.chromium.org/745463002

Cr-Commit-Position: refs/heads/master@{#304982}

Attempt to fallback to some matching font in the GetMatchingDirectWriteFontForTypeface function in case we fail to find a best match via IDWriteFontFamily::GetFirstMatchingFont.

The IDWriteFontFamily::GetFirstMatchingFont call fails on some machines with E_FAIL with well known fonts like MS UI Gothic,
Segoe UI, etc. It is not clear as to why a font would be accessible to GDI and not to DirectWrite.

Added some debug alias variables to help track down these failures. We also attempt fallback to some font in the IDWriteFontList
for the font family in question. If all fail, we CHECK as before.

Next step would be to remove the CHECKS and fallback to GDI if CreateFontFromSkia fails.

BUG=434425

Review URL: https://codereview.chromium.org/737103002

Cr-Commit-Position: refs/heads/master@{#304981}

The previous version failed because we seem to have rolled in a new
version of breakpad that had an unused function error in a target
that was previously compiling fine w/ the chromium_code config.

This patch marks the target (symupload) as no_chromium_code.

TBR=brettw@chromium.org
BUG=431177

Review URL: https://codereview.chromium.org/743813002

Cr-Commit-Position: refs/heads/master@{#304980}

Revert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/731873003/)

Reason for revert:
Broke the branch build. https://uberchromegw.corp.google.com/i/chrome.mobile/builders/arm%20stable/builds/7097

Original issue's description:
> ChromeBrowserProvider shouldn't own the FaviconService
>
> As FaviconService is KeyedService and will be deleted along with profile.
>
> BUG=411435
> TBR=Tedchoc
>
> Review URL: https://codereview.chromium.org/739713002
>
> Cr-Commit-Position: refs/heads/master@{#304690}
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8c5b8c707daa9c026540a63f6f1e1c5981f5909c

TBR=michaelbai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411435

Review URL: https://codereview.chromium.org/740853002

Cr-Commit-Position: refs/heads/master@{#304979}

Review URL: https://codereview.chromium.org/719383004

Cr-Commit-Position: refs/heads/master@{#304978}

This is a complete rewrite of CodeGen from scratch, taking advantage
of the fact that a while back we changed PolicyCompiler to not require
modifying instructions after they're created.  In particular, we no
longer need topological sorting because the MakeInstruction call order
implicitly sorts instructions for us.  Additionally, we no longer need
to compute basic blocks even because they were only needed for
sorting.

It turns out that a simple greedy algorithm with basic memoization
suffices for flattening the instruction graph, and we only really need
to worry about inserting "jump" instructions when the targets are too
far away.  With just this, we're able to emit programs that are just
as efficient as the old CodeGen implementation did.

As a bonus, the new code generator is now fully deterministic because
it doesn't create any sets or maps using pointer values as keys.

BUG=414363

Review URL: https://codereview.chromium.org/699633003

Cr-Commit-Position: refs/heads/master@{#304977}

This CL adds the BlueZ Media Endpoint service provider class and its
fake class, and add the files in chromeos/chromeos.gyp.

BUG=429016

Review URL: https://codereview.chromium.org/725383003

Cr-Commit-Position: refs/heads/master@{#304976}

Loading the chime causes the page to create an audio output stream.
Setting preload=none on the audio tag prevents the chime from being
loaded on startup, and instead causes it to be loaded on demand when the
chime is played.

BUG=432699,397019

Review URL: https://codereview.chromium.org/741873002

Cr-Commit-Position: refs/heads/master@{#304975}

Previously the display rectangles are placed by display object's
x and y, with scaling. However, due to scaling the value and
flooring the scaled result, there could be 1px gap from the
expected position, therefore just clicking may cause sending
the display layout change which causes fade-out and fade-in.

This 1px gap has been there, it's tiny, but it's noticeable.
Therefore this CL rewrites the layouting of display rectangles as
follows:
- first, place the primary display
- then look up the secondary display which is sticking to the
  primary display
This way there cannot be any gaps, therefore doesn't cause any
weird fade-outs.

BUG=386401
R=xiyuan@chromium.org, oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/739413002

Cr-Commit-Position: refs/heads/master@{#304974}

Certain encoder implementations may provide memory buffers with special
properties in which clients are expected to write input frames. This
patch introduces a simple new interface allowing a VideoEncoder to
provide a factory object from which clients may obtain input video
frames. Encoder implementations are free to return null, in which case
VideoSender provides a default implementation based on VideoFramePool.

The upcoming VideoToolbox encoder implementation for OS X and iOS will
provide a custom implementation of this interface that will use the
encoder's underlying CVPixelBufferPool. The buffers vended by that pool
are backed by memory shared between the encoding process and the daemon
interfacing with the hardware video encoder. Clients that write into
these buffers will avoid a full frame copy of every input frame, which
is a substantial saving in memory bandwidth and latency for 1080p@60
video.

BUG=429057
R=miu, hclam, hubbe

Review URL: https://codereview.chromium.org/688423003

Cr-Commit-Position: refs/heads/master@{#304973}

This patch changes how PLI cleans tilings up. Previously, we'd iterate
all tilings to find the ones that match the criteria, then iterate
those and remove them in PLI.

With this patch, we ask PLTS to do most of the work. We calculate
scales that use layer information and pass it down to PLTS to
do the cleanup. PLTS, in turn, constructs a list of things to remove
and removes it, also removing it from the passed twin sets.

This allows us to remove one function from PLI and one from PLTS,
as well as hides more of the implementation details of PLTS from PLI.

R=danakj, enne
BUG=433048

Review URL: https://codereview.chromium.org/742903002

Cr-Commit-Position: refs/heads/master@{#304972}

Create a new class that takes in a list of directories, recursively scans them for image and video files, and returns the resulting list.

This is a re-do of 730353002, which fixes a flakey test.

BUG=420680
TEST=browser_test: FileManagerJsTest.MediaScannerTest

Review URL: https://codereview.chromium.org/739263003

Cr-Commit-Position: refs/heads/master@{#304971}

This patch adds a new SecurityInterstitialPage class and derives SSLBlockingPage
and SafeBrowsingBlockingPage from it. In the future, a captive portal
interstitial will also derive from this new class. In particular,
SecurityInterstitial does:

- Unify HTML generating code.
- Differentiate between different types of security interstitials for tests.
- Contain common code for showing and creating the interstitial page.

BUG=349737

Review URL: https://codereview.chromium.org/622683006

Cr-Commit-Position: refs/heads/master@{#304970}

The reboot for the devices was added because after a wipe certain settings
require a reboot to take effect. When the device is not wiped, there is no
reason to reboot it. We need the ability to have bots that will not reboot
devices, because some devices have boot-screen prompt as a security feature.

BUG=

Review URL: https://codereview.chromium.org/737033003

Cr-Commit-Position: refs/heads/master@{#304969}

Version 0.8.2.0

[ae952911d4] Change the default date used in zap_timestamp.
[0c61db4c14] SyzyASan - Fix a potential deadlock.

R=chrisha@chromium.org
BUG=

Review URL: https://codereview.chromium.org/743753003

Cr-Commit-Position: refs/heads/master@{#304968}

Introduce ProxyResolverDelegate to get rid of dependencies to content/ and chrome/

BUG=429354

Review URL: https://codereview.chromium.org/743623002

Cr-Commit-Position: refs/heads/master@{#304967}

Fix the broken page_cycler.netsim.top_10 and remove the rather ugly
clear_cache_before_ache_run class member. The fixed version should
not have the issue of affecting subsequent page_cycler runs.

R=tonyg@chromium.org
BUG=434927

Review URL: https://codereview.chromium.org/733463005

Cr-Commit-Position: refs/heads/master@{#304966}