- 30 Jun, 2020 40 commits
-
-
Jonah Ryan-Davis authored
After landing fixes for multithreaded context use in ANGLE's GL backend, this test suite can be re-enabled. Dawn gl_tests will be changed to use passthrough on Linux, because that's what's being shipped on stable. For now, Mac dawn gl_tests will continue to use the validating command decoder. Bug: chromium:1090853 Bug: angleproject:4725 Bug: chromium:1099770 Bug: chromium:1099763 Bug: chromium:1099766 Bug: chromium:1099768 Bug: chromium:1100970 Bug: chromium:1100975 Bug: chromium:1100980 Change-Id: I55bc99e95a7d66756fe305fa1e73e28f4228687b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270598 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#784132}
-
James Long authored
The code has been refactored to use MVC to communicate data throughout the page, seeing the addition of Page{Model, Controller} classes. The visualization code (renderGraph) has also been refactored into a view, with some changes made to align better with idiomatic d3 (using data joins). The simulation speed has also been modified to use a quadratic ease in/out to make the animation of new nodes more natural. Bug: 1093962 Change-Id: I47d02c7fd9135c4537cc3c715acb88240e997ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274284 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#784131}
-
Balazs Engedy authored
Make the description of PluginsAllowedForUrls and PluginsBlockedForUrls reflect that wildcards are no longer supported in patterns, and update the example. Bug: 1073883, 1101038 Change-Id: Id6e441d4b8c3989cbcdc6878de480658b221fd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270211 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784130}
-
David Bertoni authored
This test was disabled a long time ago. It passed with flying colors through 3000 iterations on the bots. Bug: 239022 Change-Id: If83572595b1b75e495796b89a496a099bff913bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264028Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784129}
-
David Bertoni authored
This test was disabled as flaky many years ago. It survived 3000 iterations on the bots without flaking. Bug: 238667 Change-Id: Iccca0a869263a8e3025b374a0f89d512ddb255c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265184Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784128}
-
Peng Huang authored
Bug: 1087063 Change-Id: I9ca40e9f4f6164157d39ae314d87addcbd3b6204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276222Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784127}
-
Kyle Horimoto authored
Prevents need for other reviewers to stamp misc CrOS files changed in a CL. Change-Id: Ib01eb2efd7d3770e9e3ca268cc13370a2b7a87b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274841 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#784126}
-
Joe Mason authored
Also fixes use after free when the decorator is removed from the graph. R=chrisha Bug: 1080672 Change-Id: I0c6a6bac4d82baa3d27b462ca3426d467cb655da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268588 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784125}
-
Charlene Yan authored
IsFirstVisibleTab is a misnomer and IsLastVisibleTab is not used. Changed name to IsTabFirst to match pattern of other methods. Bug: 1018230 Change-Id: Ib39349fbff60f1d3a39e0a708f2c1fa566ae03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275156Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784124}
-
Chris Cunningham authored
Bug: 751838 Change-Id: Id02455bb7215e048d6f1cdbf1ddcea594e54a6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273481 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784123}
-
Chong Gu authored
Fix incorrectly added tags for Fuchsia filters. Change-Id: Ic5d4b708f99f5af81b80315a00bcccf60bb324ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274330Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#784122}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/237a776bc179..7ec6f400ea25 2020-06-30 hjd@google.com Merge "ui: Unify quantization size choice" 2020-06-30 hjd@google.com Merge "ui: Fix presubmit" 2020-06-30 treehugger-gerrit@google.com Merge changes I5f127003,If0c6afe9 2020-06-30 treehugger-gerrit@google.com Merge "Add superclass field to the classes table" 2020-06-30 treehugger-gerrit@google.com Merge "Use power profile for core mappings" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia3e495d4ce7cc3a6a06b54658c56db87c13d01d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784121}
-
Gavin Williams authored
This CL creates a dedicated function for handling up/down key presses when focus is on the print preview dropdown. To match the <select> element's behavior, when at the bottom of the dropdown list, pressing down will not wrap back to the top. And vice versa. Bug: 1059607 Change-Id: I89d977617745ba2412eeed08f0312fc6f0f01d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273497 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784120}
-
Sasha McIntosh authored
When an SkImage is created with YUV planes, the caller is responsible for lifetime of those planes. This change ensures that texture backed PaintImages maintain a reference to the YUV planes |sk_planes_| used to generate an SkImage as well as the |sk_image_| itself. Bug: 1091347 Change-Id: If253b3f4d047432dc4ab48d99563168ee7d5ea1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264259 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784119}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic4e73dd90a476fee76673e6ff5c9985bde43087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784118}
-
Wei-Yin Chen (陳威尹) authored
Bug: 925965 Change-Id: Ieba151adfdfcf5b2419ba9396766426ea943703f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274973 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#784117}
-
Li Lin authored
Quick Answer result is cached when getting it from the server. The result type is then used for logging purpose. Currently, the result doesn't get reset when user select a new text. If users perform actions before the result came back from the server, the cached result type is used for logging. This CL reset the result when user select a new text and trigger QuickAnswers. Bug: b/160244136 Test: Manual test Change-Id: I526684755b7876aa0b6df12513ead9284a5454c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276513Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784116}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: If620bd17399f0e20c6a2e37b09209dcfbbe6078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159949Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784115}
-
Dylan Cutler authored
This reverts the manual instrumentation done in: https://chromium-review.googlesource.com/c/chromium/src/+/2186997 In favor of bindings-based instrumentation introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2245048 Bug: 973801 Change-Id: I0b562c6326689bd084f8a217aa805fa3495fae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267421Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#784114}
-
Becca Hughes authored
Fix the bug by checking we have not reached the end before accessing. BUG=1095560 Change-Id: I309237562ddd5058c3b3b99d58a03c526cf49b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276511 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784113}
-
Francois Doray authored
OneCopyRasterBufferProvider::Playback() acquires the GpuChannelHost, which is also acquired from high priority tasks. It should not run at background thread priority because that can cause priority inversions, as shown by Slow Reports (see the bug). A follow-up CL https://crrev.com/c/2157659 adds a DCHECK to ensure that the GpuChannelHost lock does not cause other priority inversions than the one fixed in this CL. Bug: 1072756 Change-Id: I3cd7bd9a67e15c0079db35aeab3d1805e2b61835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240141 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784112}
-
Steven Bingler authored
Increase the expiry date to M90. Bug: 1072566 Change-Id: Ic6da0060ec9717bc4733e86141abfe7a5842dcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275465Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784111}
-
Philip Rogers authored
Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, dirtying TestRunner state for the next test. A navigation to about:blank is done after every test. This patch resets the TestRunner state after the navigation to about:blank, when we are sure no test javascript can change TestRunner state. This fixes a class of flaky bugs. This behavior happened with video-overlay-scroll.html which would set a custom layout dump (setCustomTextOutput) in a fullscreenchange event handler. This event handler was not removed at the end of the test (this will be fixed in a followup), and would run a second time, after the custom text output setting was reset. This caused later tests to run with custom text output from video-overlay-scroll.html. With this patch, video-scrolled-iframe.html is no longer flaky. Code in WebFrameTestProxy::BeginNavigation to intercept navigations relied on TestRunner::PolicyDelegateEnabled being reset before it ran. This patch now skips WebFrameTestProxy::BeginNavigation when the test is not running. Bug: 1048597 Change-Id: I888f7cc2ae91d7d3cfdd143a7573f62cb052c1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275348Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/584a47eb..df954ac3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16a4e1093dcb4fe8968b434729059a93a6b809b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275463Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784109}
-
Parastoo Geranmayeh authored
This reverts commit 1c1df774. Reason for revert: the first revert didn't stop the failures, this isn't the culprit. Original change's description: > [Sheriff] Revert "[WebLayer] Reuse Chrome's InfoBarWrapper.java" > > This reverts commit b7a33c21. > > Reason for revert: possibly causing crbug/1100914 > > Original change's description: > > [WebLayer] Reuse Chrome's InfoBarWrapper.java > > > > This CL eliminates //weblayer's copy of chrome's InfoBarWrapper.java in > > favor of directly using the latter now that it has been componentized. > > There were no substantive changes introduced in //weblayer and no > > behavioral changes. > > > > Bug: 1099169 > > Change-Id: Ie9cc819f17ce30bb66085cb05040ce11696725ec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270554 > > Commit-Queue: Colin Blundell <blundell@chromium.org> > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#783894} > > TBR=blundell@chromium.org,cduvall@chromium.org > > Change-Id: I5f0fbec56bae167ccfb54ca9d9fd4b5f3fdf25ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1099169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276312 > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#783980} TBR=blundell@chromium.org,parastoog@google.com,cduvall@chromium.org Change-Id: I31c5c69c74083bf07c60b5573ac4bf2b3ff1d637 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276518Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#784108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593518062-9a8bcf79d9703750826ab2cdd2c19e0799442665.profdata to chrome-mac-master-1593539505-1242fb6afac1e074d04c68b7772a687abe4506af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I98e085aed20d7d3beaf2f52cde25b15ef0afed24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276534Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784107}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0144ebea. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/encoding skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I4f986f386122b15b24ab0e30324ee82a1b605f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784106}
-
Hazem Ashmawy authored
If the Dev UI is the WebView provider, we only show "WebView package", and "WebView version". If the Dev UI is not the system WebView provider, show "DevTools package", "DevTools version", "WebView package" and "WebView version." This should help triage bugs filed for the different WebView error message. Fixed: 1075747 Test: Manually change WebView provider to and from one package and verify correct info is shown Test: Manually verify correct text is copied when items are long pressed Change-Id: I33b8b7bbe96274ae9b5006ed1ce8e2cd1880661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266905 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784105}
-
Ben Pastene authored
They're all failing due to a problem with the virtual keyboard. This disables them until a fix is in-place. Bug: 1100710 Change-Id: I25974dc1b6ac3cd8055ed2cd01e5c5912b581067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276491Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#784104}
-
Nate Fischer authored
This captures all the requirements to be a valid WebView provider, including mapping common device configurations to the WebView providers they support. This also simplifies the related parts of the build guide. Fixed: 1083512 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I05b7966ab84363fda105ccbc3f3477e2fb7f76f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271009Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784103}
-
Lily Chen authored
Bug: None Change-Id: I8700e681e8c24c3d6ce434cda6fc5242b3bfa5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276224Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784102}
-
Lily Chen authored
Bug: None Change-Id: I27274f5c1e8e4ccc32b7ccaa3d2600ca086ea77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276240Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#784101}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Iaa91fc42cdb74cf38f6edae3b72d4e535e52ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276234 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784100}
-
Lei Zhang authored
Use base::bits::IsPowerOfTwo() and base::bits::Align(), instead of manually doing bitwise operations. Fix some lint errors along the way. Change-Id: Ib0ce4ca5bdba6ddc6368623f2105808bccdacd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253564Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#784099}
-
John Williams authored
Bug: 1095222, b/159069899 Change-Id: I387ffe8c9f560a2dbe5fd72dad3f2cbe21620692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271165 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#784098}
-
Xianzhu Wang authored
This fixes a regression caused by crrev.com/c/2183198. We should move the effect's clip to the outer synthetic effects for backdrop effects only. For non-backdrop effect we don't move effect up into the synthetic effect and can share the synthetic effect with other effects, so we should not move up the clip. Bug: 1099234 Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/162e2b2eb46e..2e50e757e3e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com,parastoog@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1058102 Tbr: davidbienvenu@google.com,parastoog@google.com Change-Id: I0eee12566cbe4e5063a37cac02351e53ef9143f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276341Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784096}
-
Daniel Hosseinian authored
If a new print composite request is introduced before PrepareForDocumentToPdf() is completed for an old composite request, the result status is |mojom::PrintCompositor::Status::kCompositingFailure|. Ignore that result if the failure is from an old request. Bug: 1100825 Change-Id: Iead7dc19ada9290732640e0e561f3b08dd2e3b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276492Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#784095}
-
inglorion authored
This is not a functional change. The list existed before, but the new name more clearly describes its purpose. Bug: 1099035 Change-Id: I6dd8435df37c4d55e6e4254fe8be7516a55ea7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275356 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#784094}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d912aa91339c..9056401df001 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I1d744b18657609fb7e4ef1ec25a25148b2936cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784093}
-