- 27 Feb, 2019 40 commits
-
-
Abhishek Bhardwaj authored
This is a rework of https://crrev.com/c/1302866 monitoring all wake locks rather than just ARC++ wake locks. This change adds functionality to support lock screen notifications for ARC++, Assistant on Chrome OS and other future clients. It adds a new module that listens to dark resume events from the power manager. It - 1. Starts a timer to check for any current app suspension wake locks. 2. After the timer in 1 expires, if no app suspension wake lock is acquired the power manager is requested to re-suspend the system. If an app suspension wake lock is acquired then another hard timeout timer is set and also an observer to the wake lock being released is set. 3. If the wake lock is released, the system is re-suspended immediately. 4. If the hard timeout in 2 expires and a wake lock is still acquired then the system is re-suspended immediately. 5. If the system transitions to a full resume all dark resume related state and timers are cleared. On top of this change - 1. Changes were added to fix linker errors by declaring static constants in the source file as well. 2. Refactored some functions in the test code. BUG=chromium:898297 TEST=Unit tests and end to end test with Android applications and Assistant. Change-Id: I695a7dc666b26fce00f6b0f5d0d2017f6556f83a Reviewed-on: https://chromium-review.googlesource.com/c/1372477 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635849}
-
Charlie Reis authored
BUG=935175 Change-Id: Id4a9198d5dff823bc3d324b9de9bff2ee86dc499 Reviewed-on: https://chromium-review.googlesource.com/c/1488152 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635848}
-
Kristi Park authored
Do not use dark mode chips (i.e. Most Visited icons, Vasco, fakebox, etc.) if a background image is applied to the NTP. This includes custom backgrounds and images from themes. In order to keep compatibility with M73 versions and Vasco, we use the negation ":not(.light-chip)" instead of a positive selector such as ".dark-chip". Bug: 928548 Change-Id: I0284e08485810ce3aad29a288ce4ad21042e7567 Reviewed-on: https://chromium-review.googlesource.com/c/1475207Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635847}
-
Sam McNally authored
https://crrev.com/510729 updated renames outside the directory tree; update renames in the directory tree to match. Also fix a "Redundant double negation" eslint spotted 40 lines away and demanded be fixed. Bug: 934683 Change-Id: I1a915fa4359e87f807ccd0cdc346f3f7b7fba664 Reviewed-on: https://chromium-review.googlesource.com/c/1488478 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635846}
-
Tien Mai authored
- Now when a user needs to reauth their local login privilege is denied and the user is removed from the user list for winlogon through a registry setting. - Sign in of the user through GCPW will unlock the user and allow them to sign in. - These permissions are only revoked during Winlogin to ensure a user's state is not completely broken by accident. - Added a new credential provider filter used mainly to ensure that the privileges for a user that needs a reauth is correctly revoked before any credential providers try to create a credential. - Correctly support "Other User" credential. when it appears. - When a user needs a reauth and an entry is not found in the user array in SetUserArray then an anonymous credential associated to this user is added so that they can sign in with gaia to reauth themselves. Bug: 924520 Change-Id: Iaed674025606dc0319a0c1a6f5cf5d4ff662f824 Reviewed-on: https://chromium-review.googlesource.com/c/1481858 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#635845}
-
Meng-Huan Yu authored
In CL:1423978, we add UMA to measure the async dbus call at server side. BUG=920850, b:124719803 Change-Id: Ia767981f0cfee72e056f2088c66b0c88f19a2053 Reviewed-on: https://chromium-review.googlesource.com/c/1477131Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Meng-Huan Yu <menghuan@chromium.org> Auto-Submit: Meng-Huan Yu <menghuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635844}
-
Joshua Peraza authored
The custom browser ptype exists to differentiate single process webview crashes from multi-process webview crashes, but was mistakenly set for child process crashes instead of browser crashes. Bug: 936243 Change-Id: I9e37f42323ae39a7a3fa8b81e71331c08aff35bb Reviewed-on: https://chromium-review.googlesource.com/c/1490891Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635843}
-
Esmael El-Moslimany authored
Bug: 935334 Change-Id: Ib82d26cda4b4056da4dfa474a376d226949e72bd Reviewed-on: https://chromium-review.googlesource.com/c/1490396Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#635842}
-
Anand K. Mistry authored
Only "very long" API calls are logged to the user's log. Regular "long" APIs are logged to the drive-internals log. BUG=904658 Change-Id: Ic959174f9927e7fe398706b8270a60c35df82e70 Reviewed-on: https://chromium-review.googlesource.com/c/1488393 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635841}
-
Kevin Marshall authored
The ids.txt file was being created without newlines between entries, preventing it from being read correctly. Also enable symbolization for binaries provided in the SDK, now that the symbolizer supports multiple sources of symbols. Bug: 772252 Change-Id: I2c0e179d09a26248f5d0c17c61bda7b2ccd05ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1488576Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#635840}
-
Salvador Guerrero authored
Some leveldb_proto clients attempt to destroy their database when it fails to initialize, this would fail because we needed to have an initialized instance in order to destroy it. This change calls the static method leveldb::DestroyDB which will try to erase the database directory. This will ensure that clients using a DB selector will be able to recover from a failed initialization Renamed wrapper to DB impl on proto_database_impl_unittest to match new class name Bug: 870813 Change-Id: I9cbf4482cde132f68abeecb3b210c289bba0b1b2 Reviewed-on: https://chromium-review.googlesource.com/c/1484086 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#635839}
-
Kyle Milka authored
Use the real local_ntp.html instead of local_ntp_browsertest.html. Previous attempts at this were flaky (see bug), this avoids the flakiness by using FocusView instead of ClickOnView to bring focus to the NTP. ClickOnView clicks the center of the page, which in tests sometimes seems to be the fakebox. Bug: 791066 Change-Id: If3d0a10a79ede06297d35ead3f389316d639b5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1468786 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635838}
-
Robert Liao authored
BUG= Change-Id: I8aa80def6c134c944a29791420a649b183acd763 Reviewed-on: https://chromium-review.googlesource.com/c/1490895 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635837}
-
Joel Hockey authored
This reverts commit c0c53eb2. Reason for revert: breaks compilation when is_chrome_branded=true OobeBaseTest::kFakeUserEmail is referenced at: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/sync_consent_interactive_ui_test.cc?l=141&rcl=95ffa536956a89b861c39e6df1c8670638dd31a0 https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?l=2010&rcl=80199d3ea8218c1e8568bcc087c6d77f0ebaf94e Original change's description: > cros: Make FakeGaia in OobeBaseTest a mixin > > We may want to just use FakeGaia directly instead of introducing a > mixin, but that can be decided later. For now let's focus on simplifying > all of the test bases. > > Bug: 912704 > Change-Id: Id4a7ab8e0c23343b7e6e59c7b7d2aefc16891515 > Reviewed-on: https://chromium-review.googlesource.com/c/1366895 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635236} TBR=antrim@chromium.org,alemate@chromium.org,jdufault@chromium.org,poromov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 912704 Change-Id: I31882d938465fb8404c90b84379e34aff7354512 Reviewed-on: https://chromium-review.googlesource.com/c/1490353Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635836}
-
Anastasia Helfinstein authored
This is a pure refactor, with no functional changes. Bug: None Change-Id: Id66cf951a8b060fdb2a0d4458dd48620d28b9d05 Reviewed-on: https://chromium-review.googlesource.com/c/1487873 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#635835}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46d32e0fcd84..009696c56169 git log 46d32e0fcd84..009696c56169 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 geofflang@chromium.org Vulkan: Support EGL_ANDROID_image_native_buffer on Android. Created with: gclient setdep -r src/third_party/angle@009696c56169 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id5afbbd8f59361160d1087b4f9a1754de1f2d7dd Reviewed-on: https://chromium-review.googlesource.com/c/1490375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635834}
-
Fernando Serboncini authored
We may have pending mojo messages after GC, so we want to drop the dispatcher as soon as possible. Bug: 929757,913964 Change-Id: I5789bcbb55aada4a74c67a28758f07686f8911c0 Reviewed-on: https://chromium-review.googlesource.com/c/1489175Reviewed-by:
-
Stefan Zager authored
It makes sense to have someone from the rendering team in OWNERS. I'm nominating myself because my code review load is not too heavy, I'm reasonably familiar with the code, and I anticipate working more in this area going forward. R=dcheng,haraken,eae,chrishtr Change-Id: Id3141c2aa100a26afaef1dd07980fbb63dea7945 Reviewed-on: https://chromium-review.googlesource.com/c/1490632Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#635832}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a502bde5ced6..ee85330e0ea1 git log a502bde5ced6..ee85330e0ea1 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 rsavitski@google.com shared ring fuzzer: clear spinlock field to not make fuzzer's read spin indefinitely. Created with: gclient setdep -r src/third_party/perfetto@ee85330e0ea1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I942ffa9f05af2a133dbf3aa33166391d570e67fd Reviewed-on: https://chromium-review.googlesource.com/c/1490674Reviewed-by:
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=seantopping@chromium.org Bug: 714018 Change-Id: I5d71bfb093f9358dace00438d21cf2d861451399 Reviewed-on: https://chromium-review.googlesource.com/c/1486152 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#635830}
-
Piotr Pawliczek authored
A list of enterpise printers is not ready immediately after creation of CupsPrintersManager. It caused a problem for testing procedure since from the level of autotest_private_api we do not know if the final list is ready or there are still some ongoing calculations. A new method called OnEnterprisePrintersInitialized() was added to the observer of CupsPrintersManager to solve this issue. Also whole code related to enterprise printers were refactored, large part of functionality was moved from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been merged into one class called CalculatorsPoliciesBinder. BUG=chromium:816996 TEST=Tested on nautilus with the use of CL:1451591 Change-Id: I50745f18beacab213216e5f367db0d023190e9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1220547 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#635829}
-
John Rummell authored
When unable to pre-provision origin IDs, it may be due to the device not being able to connect to a provisioning server. Updating the code to watch for network events. When connected to a network, try again to pre-provision origin IDs. BUG=917527 TEST=new unit_tests pass Change-Id: Ia41bbedf543556e59ecd03bef51d989c6c0f7210 Reviewed-on: https://chromium-review.googlesource.com/c/1475005 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635828}
-
Paul Dyson authored
* Add more metrics to UKM event AppListAppLaunch. * Add a new UKM metric AppListAppClickData to send the accumulated click data for an app. On an app launch click, an AppListAppClickData event is sent for the app clicked on and for five other apps chosen at random. Also makes user_activity_ukm_logger_helpers a public_dep so it can be used here. Bug: 899123 Change-Id: Ie1d6f17673b9548ef6823d05a362fea8992126b9 Reviewed-on: https://chromium-review.googlesource.com/c/1460750Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635827}
-
rbpotter authored
Bug: 935625 Change-Id: Ib2e8c1e934f213916b90354686ab42a2da3a078c Reviewed-on: https://chromium-review.googlesource.com/c/1487521Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#635826}
-
git config --global authored
There are still purple builds for fyi/ios12-sdk-simulators https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios12-sdk-simulator Bug: 933450 Change-Id: If1bdc09f9a8c4dc0d5665eeb1e40ecd927814980 Reviewed-on: https://chromium-review.googlesource.com/c/1490393Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#635825}
-
Ryo Hashimoto authored
Exo window uses custom event targter so we need to explicitly set the default targeter to correctly handle input events. Bug: 925769 Test: manually Change-Id: Ia596bd4524d2a3e8dae86e8be34821822edf9626 Reviewed-on: https://chromium-review.googlesource.com/c/1488485Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#635824}
-
Mei Liang authored
This patch adds a method in FeatureUtilities to check whether the tab group feature is enabled and available for use. Bug: 934557 Change-Id: I06677c81b772d905e5a5689536de2c1e362aa08c Reviewed-on: https://chromium-review.googlesource.com/c/1489973 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635823}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5da3a7e01dc2..f6100576bcc4 git log 5da3a7e01dc2..f6100576bcc4 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 nathanrogers@google.com Include category and name as part of flow ids 2019-02-26 benjhayden@chromium.org Add ChartBase.reducers.boldLine. 2019-02-26 rmhasan@google.com Changes the number of isolated tests sent to a job pool in Typ 2019-02-26 simonhatch@chromium.org Dashboard - Choose vr_perf_tests target for chromevr tests. 2019-02-26 benjhayden@chromium.org Add generateColors() for spa Created with: gclient setdep -r src/third_party/catapult@f6100576bcc4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:935814,chromium:935615,chromium:918193 TBR=sullivan@chromium.org Change-Id: Id03ee99f80eca3aab1790f582727009f22f3c059 Reviewed-on: https://chromium-review.googlesource.com/c/1490673Reviewed-by:
-
Yuly Novikov authored
TBR=jschuh Bug: 926235, 936194 Change-Id: I28a335b061cd1bba070e0b5c8197b82a2cf834e6 Reviewed-on: https://chromium-review.googlesource.com/c/1490510Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#635821}
-
Ben Smith authored
See intent to ship blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tD6np-OG2PU Bug: chromium:754910 Change-Id: Ic46c0404bd9b783845fbaa1e412d8b9332f65a91 Reviewed-on: https://chromium-review.googlesource.com/c/1487808 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#635820}
-
Eric Stevenson authored
This reverts commit 9b5e9e3c. Reason for revert: https://crbug.com/935964 Original change's description: > Trichrome: Remove webview deps from trichrome_chrome_apk. > > These were pulled in because trichrome uses monochrome > templates. Since Trichrome still shares the same native library > logic with monochrome it makes sense to continue using monochrome > templates, but using a variable |is_trichrome| to differentiate > trichrome from monochrome. > > This CL removes Java deps, some Java resource deps, and webview's > locale pak files from TrichromeChrome.apk. > > Validated CL changes by: > * Building the 3 trichrome apks and their downstream variants > * Installing/launching TrichromeChrome.apk > * Manually inspecting the .build_config and "unzip -l" changes > > | old (c)| new (c)| diff (c)| > total| 24.8 MiB| 23.6 MiB| -1.2 MiB| > dex| 6.8 MiB| 6.4 MiB| -392.1 KiB| > arsc| 4.9 MiB| 4.8 MiB| -101.8 KiB| > xml| 344.9 KiB| 344.9 KiB| -6 B| > res| 912.3 KiB| 908.2 KiB| -4.1 KiB| > native| 254.6 KiB| 254.6 KiB| +0 B| > asset| 11.1 MiB| 10.4 MiB| -698.0 KiB| > misc| 145.3 KiB| 142.4 KiB| -2.9 KiB| > > Bug: 932253 > Change-Id: Iedb427aa5ec05ad3bc905ac61b23f615349d579e > Reviewed-on: https://chromium-review.googlesource.com/c/1481019 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634385} TBR=torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932253, 935964 Change-Id: Ib96734d9bba049b72735f0fffd0ac31d4aea914b Reviewed-on: https://chromium-review.googlesource.com/c/1490493Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635819}
-
Ryo Hashimoto authored
View hierarchy takes the ownership of the remote view host. Replace unique_ptr with raw pointer to avoid double-free. BUG=925769 TEST=manually Change-Id: Ic34a87081782d10e4ad42ecfaa9fb6127abf52cb Reviewed-on: https://chromium-review.googlesource.com/c/1488403Reviewed-by:
-
David Trainor authored
Show a toast to the user when an inline update starts downloading. This currently has the side effect of reshowing whenever Chrome is started if we're in the downloading state. Bug: 934356 Change-Id: Ib83ac5cab8a1d66e234b5b55c0af76adbc92f72d Reviewed-on: https://chromium-review.googlesource.com/c/1483706 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635817}
-
Yuwei Huang authored
This CL implements a helper class that adapts gRPC's async unary call paradigm (i.e. the completion queue) into Chromium's callback-based paradigm. Bug: 927962 Change-Id: I15c58748a0d024dc5f6953b0312e629fcf8c24b5 Reviewed-on: https://chromium-review.googlesource.com/c/1484736 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635816}
-
Jenny Zhang authored
Bug: 933906 Change-Id: Ic8a957750e5ce4747eb7b22762c0fc7917240f6c Reviewed-on: https://chromium-review.googlesource.com/c/1487201Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635815}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/54c4772e855c..7f6f891204d0 git log 54c4772e855c..7f6f891204d0 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 sugoi@google.com VS build fix Created with: gclient setdep -r src/third_party/swiftshader@7f6f891204d0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ibdf8323240c404fa8a004054944b914a18a20e69 Reviewed-on: https://chromium-review.googlesource.com/c/1490374Reviewed-by:
-
John Delaney authored
We should determine if an ad frame size intervention would disproportionately affect video ads over other ad creatives. Measure whether ad iframes that triggered the intervention had media play in the frame at any point in it's lifetime. This will not measure frames that load video but never play. The OnMediaStartedPlaying method must be updated to propagate the RFH it occurred in to observers so we can attribute it to the frame. The is_in_main_frame flag is currently unused and will be removed. Bug: 878393 Change-Id: Ie2be74206b83da43d9e73af93b72a5092bd7688a Reviewed-on: https://chromium-review.googlesource.com/c/1481619 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635813}
-
Xing Liu authored
This CL adds a proto to serialize dynamically generated data to schedule a notification and display later. Bug: 930968 Change-Id: Iadd7ca8f820097db2dee47d664ddbf0ca4528cbf Reviewed-on: https://chromium-review.googlesource.com/c/1468341 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#635812}
-
chrome://safe-browsingDaniel Rubery authored
Changing tabs on chrome://safe-browsing updates the hash, and navigating to chrome://safe-browsing with a hash will select that hash directly. Bug: 930207 Change-Id: If19a53b1432ecf90df2b54e70d747d3f018082dc Reviewed-on: https://chromium-review.googlesource.com/c/1490218 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635811}
-
John Abd-El-Malek authored
Bug: 934983 Change-Id: Ib74d45089dc9e45ea5395be2e2ce6df43c42fccb Reviewed-on: https://chromium-review.googlesource.com/c/1490220Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635810}
-
