GitLab

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2867213004
Cr-Commit-Position: refs/heads/master@{#473358}

BUG=None

Review-Url: https://codereview.chromium.org/2886083002
Cr-Commit-Position: refs/heads/master@{#473357}

https://pdfium.googlesource.com/pdfium.git/+log/76020fc9751e..92c13a7d495c

$ git log 76020fc97..92c13a7d4 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 tsepez ASAN flags zero-length StringC in GetMapModuleString()
2017-05-19 npm Add test duplicate check in presubmit

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I40779d4316de1b4574336131c1f94b40cac28968
Reviewed-on: https://chromium-review.googlesource.com/509953
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473356}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/16b38d742568..08a6e0ac161d

$ git log 16b38d742..08a6e0ac1 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 thomasanderson Replace sanitizers:deps with exe_and_shlib_deps (catapult)

Created with:
  roll-dep src/third_party/catapult
BUG=723069


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib279c2ba7fc20fb3c3a3ad57bc62f341333d9f02
Reviewed-on: https://chromium-review.googlesource.com/510009
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473355}

The rootScroller's LayoutBox should use the view rect for clipping content
as hiding the URL bar will not increase the border box height. This also
requires invalidating compositing when the FrameView is resized (since it
may not result in a layout) or when a new Element is made the global root
scroller.

This patch fixes the issue for non-iframe rootScrollers. A follow-up patch
will make the equivalent change for iframes.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2796203002
Cr-Commit-Position: refs/heads/master@{#473354}

If a tab showing the save credit card buble is closed while the bubble
is still visible, the bubble will attempt to update the icon in the
location bar. Because the browser object is no longer available, this
causes a crash.

Note that this doesn't happen in the common case where the user
closes the tab by clicking on the tab close icon (x) because that action
closes the bubble first. But if the user closes the tab via a keyboard
shortcut or a page closes a child tab via javascript, then the crash
occurs.

BUG=694188

Review-Url: https://codereview.chromium.org/2887183005
Cr-Commit-Position: refs/heads/master@{#473353}

For the login flow, we need to be able to use the same BeaconSeeds as those
in the user preferences.

The BeaconSeeds are refreshed everytime the user logs in or unlocks their
Chromebook like the other EasyUnlock metadata.

BUG=715594

Review-Url: https://codereview.chromium.org/2863533003
Cr-Commit-Position: refs/heads/master@{#473352}

The comment used to claim that in an address list with both IPv6 and IPv4
addresses, the IPv6 addresses will come first, which is usually but not
always true. Now it correctly explains that the fallback is only used
when an IPv6 address is first.

Review-Url: https://codereview.chromium.org/2895633002
Cr-Commit-Position: refs/heads/master@{#473351}

Moves keyboard accessory feature flag from switches to feature_list.

Desired layout and animation:

https://folio.googleplex.com/chrome-ux/mocks/304-payments-zero-integration/ZI_Keyacc_Onboarding#%2F14-icon-white%20bg-no%20overlay-video.mp4

Design doc:
https://docs.google.com/document/d/1LPO-unUyQ-YEGKpxB7tYA3j8yrwblyKf_U0eaBNBFx8/edit#

BUG=724624

Review-Url: https://codereview.chromium.org/2874933008
Cr-Commit-Position: refs/heads/master@{#473350}

BUG=724293, 689520

Review-Url: https://codereview.chromium.org/2896473002
Cr-Commit-Position: refs/heads/master@{#473349}

Bug: 718548
Change-Id: I76ff108d8b84e47eeb829c533797bd3e14f0fcbd
Reviewed-on: https://chromium-review.googlesource.com/510050
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473348}

With a description of what should go in this directory. Also removes
README.chromium as we seem to prefer the md files.

R=ben@chromium.org
BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2894143003
Cr-Commit-Position: refs/heads/master@{#473347}

Specifically, this CL extracts the methods:

  _log_pending_builds
  _make_test_baseline_set_for_tests

And modifies trigger_builds.

The purpose of this change is to simplify the main execute() method and move some details into helper methods.

Review-Url: https://codereview.chromium.org/2890373003
Cr-Commit-Position: refs/heads/master@{#473346}

This sets us up to start creating a polymorphic class hierarchy for
DocumentMarker. RenderedDocumentMarker will become TextMatchMarker, and we will
also add subclasses of DocumentMarker for the other MarkerTypes as well.

BUG=715365

Review-Url: https://codereview.chromium.org/2883503004
Cr-Commit-Position: refs/heads/master@{#473345}

GN does not clear out old generated files on builds, so if a test
is removed from a test group, then an incremental build will still
pick up the old $test_runtime_deps.txt file. This results in erroneous
runtime_deps in the runtime_deps.json file, since it includes runtime
deps for targets that are not being built.

Update the runtime deps part of the generating script to only combine
deps from tests listed in the *.tests files, since these should be up to
date.

Change-Id: Id8cd04aad284209f3a7cad44f5d96896a5e76902
Reviewed-on: https://chromium-review.googlesource.com/509128Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473344}

jboolean is an uint8_t

BUG=724593

Review-Url: https://codereview.chromium.org/2890413003
Cr-Commit-Position: refs/heads/master@{#473343}

BUG=724549

Review-Url: https://codereview.chromium.org/2894163002
Cr-Commit-Position: refs/heads/master@{#473342}

This makes it consistent with the desktop implementation.
See: https://cs.chromium.org/chromium/src/components/safe_browsing_db/v4_local_database_manager.cc?l=87&rcl=6ea9ff3e27ed759a26158a6e71fd3d9ea7789aeb

BUG=653651

Review-Url: https://codereview.chromium.org/2897513002
Cr-Commit-Position: refs/heads/master@{#473341}

This patch eliminates usage of styleHeaderForUISourceCode method in
SourceFormatter.

This is a pre-step before removing the styleHeaderForUISourceCode method
from NetworkManager, which, in turn, is a pre-step before moving styles
UISourceCode management into StylesSourcemapping.

BUG=670180
R=caseq, dgozman

Review-Url: https://codereview.chromium.org/2886053002
Cr-Commit-Position: refs/heads/master@{#473340}

On Android One, the test takes about 4.5 hours, unfortunately.

Change-Id: I4ec46305fab17146a53dbe543c2a18ba2152aee7
Reviewed-on: https://chromium-review.googlesource.com/509893
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473339}

Move code that sets up the environment to run a task (task runner
handles, thread restrictions) from TaskTracker::RunTask() to
TaskTracker::PerformRunTask(). That prevents code in the overrides
of TaskTracker::PerformRunTask() to run under the thread restrictions
set by TaskTracker::RunTask().

BUG=553459

Review-Url: https://codereview.chromium.org/2899443002
Cr-Commit-Position: refs/heads/master@{#473338}

This private API is for process management of and communicating with a
media analytics process running outside of Chrome. The analytics process
uses computer vision technology to send metadata about image frames over
D-Bus, and MediaPerception events are fired on the frontend.

BUG=709180, 720495

Review-Url: https://codereview.chromium.org/2860203002
Cr-Commit-Position: refs/heads/master@{#473337}

For DataReductionProxyUseQuic experiment, add the "enable_warmup" param
to the testing config.

BUG=672334

Review-Url: https://codereview.chromium.org/2888283007
Cr-Commit-Position: refs/heads/master@{#473336}

TBR=yosin@chromium.org
BUG=722925

Review-Url: https://codereview.chromium.org/2892233002
Cr-Commit-Position: refs/heads/master@{#473335}

Previously, in the case where no swap was produced, we didn't
terminate mouse event async slices. Now we do.

This requires making some of the events blocking, as we need to know whether or not renderering was scheduled at the time we process the event ack. If the event is non-blocking, we receive a synthetic ACK immediately, and don't know whether or not rendering will be scheduled.

BUG=722807

Review-Url: https://codereview.chromium.org/2884953002
Cr-Commit-Position: refs/heads/master@{#473334}

In https://codereview.chromium.org/2887233003, I changed most of the header
includes in the third_party/WebKit/public/web directory that started with
"../platform/" to instead start with "public/platform/" in order to make
these header includes valid under a DEPS rule that's flagging new includes
of the form "../platform/" as errors. I did not change these headers in that CL
because some build targets were not building properly. I've determined that the
problem was that these targets are missing a dependency in their BUILD.gn files.
This CL adds this dependency to those build files and finishes the codemod.

Note: I have not run git cl format to put the headers in the correct order
because I ran into problems with the original CL due to this breaking fragile
code.

BUG=724264

Review-Url: https://codereview.chromium.org/2892703002
Cr-Commit-Position: refs/heads/master@{#473333}

We currently go to chrome/ to get the extension version, but we don't
need to. ExtensionRegistry in extensions/ has the info already, move
the function to ExtensionRegistry.

Also, the name GetPreviousVersion is misleading. It only gives us the
current version, so rename it to be simply GetVersion.

BUG=723754
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2892843002
Cr-Commit-Position: refs/heads/master@{#473332}

Revert of Create a unified UIElement interface for Widget, View and Window. (patchset #21 id:1020001 of https://codereview.chromium.org/2776543002/ )

Reason for revert:
Fails to compile on ChromiumOS x86-generic Compile
with error:

[903/7505] CXX obj/ash/ash/ui_element.o
FAILED: obj/ash/ash/ui_element.o
/b/c/goma_client/gomacc i686-pc-linux-gnu-g++ -B/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/ash/ash/ui_element.o.d -DASH_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/libwebp -I../../third_party/khronos -I../../gpu -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/dbus-1.0 -I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib/dbus-1.0/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/libwebm/source -I../../third_party/boringssl/src/include -I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss -I/b/c/b/ChromiumOS_x86_generic_Compile/.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/qcms/src -Igen -I../../third_party/mesa/src/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -m32 -msse2 -mfpmath=sse -mmmx -pthread -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../../.cros_cache/chrome-sdk/tarballs/x86-generic+9536.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -fvisibility=hidden -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -march=i686 -pipe -march=i686 -pipe -pipe -march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3 -D__google_stl_debug_vector=1 -c ../../ash/devtools/ui_element.cc -o obj/ash/ash/ui_element.o
../../ash/devtools/ui_element.cc: In member function 'std::string ash::devtools::UIElement::GetTypeName() const':
../../ash/devtools/ui_element.cc:37:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1plus.elf: all warnings being treated as errors

Original issue's description:
> Create a unified UIElement interface for Widget, View and Window.
>
> The unified interface will enable css_agent to set/access many
> properties of widget, view and window without the need of knowing the
> actual object type. A UIElement tree where each node can be either
> view, widget and window will be kept in sync with tree structures of
> window, widget and view objects.
>
> BUG=700024
>
> Review-Url: https://codereview.chromium.org/2776543002
> Cr-Commit-Position: refs/heads/master@{#473315}
> Committed: https://chromium.googlesource.com/chromium/src/+/bdcdb17a4fa7ffea34afed460b776cc2e5032855

TBR=sadrul@chromium.org,thanhph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=700024

Review-Url: https://codereview.chromium.org/2899503002
Cr-Commit-Position: refs/heads/master@{#473331}

The Presentation API spec recommends that the origin requesting
presentation be shown to the user when PresentationRequest.start() is
called.  This patch sets a new flag on a CastMode, isForced, that will
cause the cast mode picker to show it initially when it is rendered.
This flag is set when the Media Router UI is initialized from a
PresentationRequest (e.g., from PresentationRequest.start()).

There are a few cleanups that could be done as followup changes:

- DEFAULT cast mode is more logically PRESENTATION since the request can
  come from any PresentationRequest (not just the page-default one).
- CreatePresentationConnectionRequest and PresentationRequest are very
  similar and could be combined.
- A default content::PresentationError is initialized with type
  NO_AVAILABLE_SCREENS.  It would seem more logical to initialize with
  type UNKNOWN.

TBR jam@ for a comment only change to presentation_info.h.

BUG=704964
TBR=jam
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862393002
Cr-Commit-Position: refs/heads/master@{#473330}

The old name doesn't really make sense.

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2899473002
Cr-Commit-Position: refs/heads/master@{#473329}

Bug: 721157
Change-Id: I1aaf8ddeb0361b6680cf68729d32a80ff55c8c01
Reviewed-on: https://chromium-review.googlesource.com/502629
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473328}

BUG=chromedriver:1777

Review-Url: https://codereview.chromium.org/2890103002
Cr-Commit-Position: refs/heads/master@{#473327}

The failing bots are:

Mac Air 10.11 Perf 
Mac Pro 10.11 Perf
Mac Retina Perf
Win 7 ATI GPU Perf
Win 7 Nvidia GPU Perf 
Win 7 Perf

Bug:722367
Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540

NOTRY=true (since this doesn't affect any CQ test)
TBR=sullivan@chromium.org

Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
Reviewed-on: https://chromium-review.googlesource.com/509989
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473326}

This patch introduces the uiSourceCode.mimeType() method instead
of static NetworkProject.uiSourceCodeMimeType().

This is necessary to separate uiSourcecode's mimetypes from
NetworkProject. This is also natural since UISourceCode's mimeType
is known by its creator.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2889013002
Cr-Commit-Position: refs/heads/master@{#473325}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2883393002
Cr-Commit-Position: refs/heads/master@{#473324}

Added NOTREACHED() WebrtcVideoRendererAdapter for the case when playout
delay > 0. Also updated ConnectionTest_Video to receive 5 tests. With
this change remoting_unittests will fail if playout delay extension
is not sent by the host or is ignored on the receiving side. This will
help to prevent regressions like crbug.com/webrtc/7590 in the future.
Previously the adapter was only logging a warning in that case.

BUG=722490

Review-Url: https://codereview.chromium.org/2887183004
Cr-Commit-Position: refs/heads/master@{#473323}

Review-Url: https://codereview.chromium.org/2898483002
Cr-Commit-Position: refs/heads/master@{#473322}

-Buttons were SystemType and for this reason their images tint color was off.
-Fixed images and Added new ToolbarButtons.

BUG=683793

Review-Url: https://codereview.chromium.org/2894243003
Cr-Commit-Position: refs/heads/master@{#473321}

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897703002
Cr-Commit-Position: refs/heads/master@{#473320}

Prior to this CL, files ending with ".dmp" could potentially be simulatenously
scheduled for appending logcat data and scheduled for upload. This CL resolves
the race by requiring a ".try0" suffix to be present prior to attempting an
upload.

BUG=719129
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2862353003
Cr-Commit-Position: refs/heads/master@{#473319}