GitLab

Any modification to a Chrome installation should be done within the
scope of a SetupSingleton. There can be only one active SetupSingleton
per Chrome installation at a time.

SetupSingleton will be used to ensure that an update process doesn't
run at the same time as a process deleting old files.

BUG=310211

Review-Url: https://codereview.chromium.org/2292293002
Cr-Commit-Position: refs/heads/master@{#417051}

BUG=643523
TBR=georgesak@chromium.org

Review-Url: https://codereview.chromium.org/2317083002
Cr-Commit-Position: refs/heads/master@{#417050}

BUG=644623

Review-Url: https://codereview.chromium.org/2321573003
Cr-Commit-Position: refs/heads/master@{#417049}

Avoid logging "Unable to get cursor width capability:
Invalid argument" and "Could not initialize DRM device"
warnings, as these are expected conditions on some systems.

BUG=644796

Review-Url: https://codereview.chromium.org/2314423003
Cr-Commit-Position: refs/heads/master@{#417048}

BUG=556508

Review-Url: https://codereview.chromium.org/2304863003
Cr-Commit-Position: refs/heads/master@{#417047}

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2315313003
Cr-Commit-Position: refs/heads/master@{#417046}

BUG=635403

Review-Url: https://codereview.chromium.org/2318313002
Cr-Commit-Position: refs/heads/master@{#417045}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Referrer| type and
a |referrer| accessor method (differing by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Referrer| being the name of both the type and the accessor method
(with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312

Review-Url: https://codereview.chromium.org/2308063002
Cr-Commit-Position: refs/heads/master@{#417044}

In [1] we switched the under-invalidation color from red to semi-opaque
magenta to differentiate under-invalidation from the red that may be
present in tests. This turned out to lead to confusing results in [2]
and may get mistaken for intended test results. This patch switches to
fully opaque dark red which should be more noticeable as a bad result.

[1] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9
[2] https://codereview.chromium.org/2305023003

Review-Url: https://codereview.chromium.org/2307213002
Cr-Commit-Position: refs/heads/master@{#417043}

Replace them with vector<unique_ptr<T>>.

After this CL there will be only 3 places where ScopedVector
would still be around. Since those (language_settings_private_delegate.cc,
web_navigation_apitest.cc and chrome_content_browser_client_extensions_part.cc)
are non-trivial, I will try to remove ScopedVector from them in subsequent CLs.

BUG=556939
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2310683002
Cr-Commit-Position: refs/heads/master@{#417042}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- accessibility_extension
- echo_private
- first_run_private
- browser
- browsing_data
- commands
- developer_private
- font_settings
- chrome_direct_setting

BUG=634140

Review-Url: https://codereview.chromium.org/2298493003
Cr-Commit-Position: refs/heads/master@{#417041}

Windows buildbot failed, reverting for now.

TBR=thakis@chromium.org
BUG=630728
NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2316353002
Cr-Commit-Position: refs/heads/master@{#417040}

https://chromium.googlesource.com/skia.git/+log/5edf2908a305..62e9b145a13a

$ git log 5edf2908a..62e9b145a --date=short --no-merges --format='%ad %ae %s'
2016-09-07 robertphillips Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 id:100001 of https://codereview.chromium.org/2316593003/ )
2016-09-07 brianosman Add minimal support for readPixels in raster F16
2016-09-07 msarett Use demux API in SkWebpCodec
2016-09-07 robertphillips Add GM/slide to simulate Android-style reveal clip
2016-09-07 bsalomon Restructure flushing relationship between GrContext, GrDrawingManager, and GrResourceCache.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319773002
Cr-Commit-Position: refs/heads/master@{#417039}

Original changelist: http://crrev.com/2212853002

This change landed and was then reverted because it broke ChromeVox when
logging in when it was already enabled on the login screen. The issue was
that AccessibilityManager needed to add the component extension to each
profile.

The immediate benefit is that ComponentLoader doesn't need to depend on
AccessibilityManager - previously they both depended on each other.

The end goal is to refactor AccessibilityManager so that it can support
multiple accessibility component extensions. Rather than a separate function
in ComponentLoader to load each one, I think it'd make more sense for
AccessibilityManager to just call ComponentLoader with the appropriate
parameters like the extension id and path.

BUG=634233
TEST=Toggle ChromeVox on/off from login screen, logged-in session, and guest session. Enable ChromeVox in login screen and log in, ensure ChromeVox remains on. Try with both ChromeVox Classic and Next.

Review-Url: https://codereview.chromium.org/2291133005
Cr-Commit-Position: refs/heads/master@{#417038}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0991a2aad45a..1931d2d4322f

$ git log 0991a2aad..1931d2d43 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 eakuefner [Tracing] Fix close button in groupby picker

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2322643002
Cr-Commit-Position: refs/heads/master@{#417037}

Improve naming of PlatformScreen implementations.

BUG=none

Review-Url: https://codereview.chromium.org/2317073003
Cr-Commit-Position: refs/heads/master@{#417036}

Review-Url: https://codereview.chromium.org/2322633002
Cr-Commit-Position: refs/heads/master@{#417035}

This moves calls from the proxies that happen between
LayerTreeHostImpl's DrawLayers and SwapBuffers to happen after
SwapBuffers, and moves all code at the bottom of DrawLayers, which
is after DelegatingRenderer::DrawFrame to the bottom of SwapBuffers,
which makes it after DelegatingRenderer::SwapBuffers.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317493003
Cr-Commit-Position: refs/heads/master@{#417034}

BUG=590369

Review-Url: https://codereview.chromium.org/2316273002
Cr-Commit-Position: refs/heads/master@{#417033}

It's not used anymore after previous changes referenced in these bugs. This is working towards removing CertStore.

BUG=598073, 504347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2315443003
Cr-Commit-Position: refs/heads/master@{#417032}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ece649094b8b366432846b994819eca89d790cf9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/f0b0378318a0bca451dc05303ba3c0971b249103 Remove gerrit_rebase_patch_ref flag from bot_update API (andybons@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=612417

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2316313002
Cr-Commit-Position: refs/heads/master@{#417031}

This removes all gyp files except modules.gypi which is the only one still
used.

IDL file lists are consolidated into Source/core/core_idl_files.gni and
Source/modules/modules_idl_files.gni, eliminating lists in bindings/core and
bindings/modules.

TBR=dpranke

Review-Url: https://codereview.chromium.org/2319623003
Cr-Commit-Position: refs/heads/master@{#417030}

Regression was introduced by this change:
https://codereview.chromium.org/2294383002

The change inadvertently modified the steps performed by
HTMLCanvasElement::getSourceImageForCanvas by no longer taking
advantage of the cached rendering results of the WebGL drawing buffer.
A secondary source of regression was that the AccelerationHint was
not being propagated correctly.

BUG=644401
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
TEST=blink_perf.canvas / draw-static-webgl-to-hw-accelerated-canvas-2d

Review-Url: https://codereview.chromium.org/2320663002
Cr-Commit-Position: refs/heads/master@{#417029}

This change is mostly refactoring and deleting with just a bit of new code.

There were a few places we were still using AXObject::elementRect inside of
Blink. Fix those and replace them with the new AXObject::getRelativeBounds or
a new function AXObject::getBoundsInFrameCoordinates for cases where we do
need absolute frame-relative coordates.

There were a few subclasses of AXMockObject that didn't support
getRelativeBounds yet but weren't migrated earlier because they had no
test coverage for their bounding rects. Fix those and add new tests to
cover them.

To make it easier to implement those, I moved the implementation of
getRelativeBounds from AXLayoutObject to AXObject, and made it dependent
on a new protected virtual method layoutObjectForRelativeBounds().
If a subclass of AXObject wants its bounds computed all it needs to
do is implement layoutObjectForRelativeBounds() and the rest is done
for it.

BUG=618120

Review-Url: https://codereview.chromium.org/2287433003
Cr-Commit-Position: refs/heads/master@{#417028}

BUG=chromedriver:1495
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2319223002
Cr-Commit-Position: refs/heads/master@{#417027}

BUG=456373

Review-Url: https://codereview.chromium.org/2322603002
Cr-Commit-Position: refs/heads/master@{#417026}

Video overlay for embedded videos (aka hole punching)
was diabled in https://codereview.chromium.org/2026423002/.
This CL removes it completely.

BUG=616583

Review-Url: https://codereview.chromium.org/2299883007
Cr-Commit-Position: refs/heads/master@{#417025}

BUG=639537
TEST=Logged onto a managed account, open SysTray menu, click on
"This device is managed by ..." item.  This should briefly open
  https://support.google.com/chromebook/?p=managed
which will quickly redirect to something like
  https://support.google.com/chromebook/answer/2535613?p=managed&rd=1

Review-Url: https://codereview.chromium.org/2308613002
Cr-Commit-Position: refs/heads/master@{#417024}

To support a new HashStoreContents which needs to be passed around in
a different manner, the PrefHashStoreTransaction now has a raw ptr
instead of owning the HashStoreContents.

BUG=624858

Review-Url: https://codereview.chromium.org/2297373002
Cr-Commit-Position: refs/heads/master@{#417023}

Review-Url: https://codereview.chromium.org/2318053003
Cr-Commit-Position: refs/heads/master@{#417022}

Custom style rules can be added via the inspector. These were stored in
a stylesheet appended to <head>. That meant it was visible to the
document via CSSOM. Also, enabling/disabling the inspector would not
remember that a stylesheet was added, so the inspector started out with
a new blank stylesheet for editing, yet the existing rules still
applied.

This CL introduces a single inspector stylesheet in the StyleEngine
which takes part in the document collection to apply the rules, but it
is not appended to the document.styleSheets list. Neither is it
accessible through a <style> element in the DOM.

The stylesheet ends up after the author stylesheets in the order of
appearance. That is similar to how it was, but previously, sheets in
<body> would appear after the inspector sheet while sheets in <head>
would appear before.

The inspector sheet source is stored in a resource container like
changes for author stylesheets. This means the inspector sheet source
will persist across inspector enable/disable.

R=pfeldman@chromium.org,lushnikov@chromium.org
BUG=624139
TEST=http/tests/inspector-enabled/reattach-after-editing-styles.html

Review-Url: https://codereview.chromium.org/2312953002
Cr-Commit-Position: refs/heads/master@{#417021}

Long live GN.

R=sunnyps
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2315743005
Cr-Commit-Position: refs/heads/master@{#417020}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c9f2639b..4f2348b4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2321633002
Cr-Commit-Position: refs/heads/master@{#417019}

Instead, after unpickling the script content, put them in a WebString
on its first use (GetJsSources) in a frame. Reuse them for subsequent
frames.

The cleanup is done when UserScriptSet releases its shared memory
connection.

A completely naive test shows that on WSJ site, with ABPlus extension
installed, this reduced (24025 * 11 + 14785 * 10) = 412125 char copies!

BUG=622464
Test=No visible change is expected.

Review-Url: https://codereview.chromium.org/2278003002
Cr-Commit-Position: refs/heads/master@{#417018}

Added a new group in third_party/BUILD.gn in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.

BUG=630728

Review-Url: https://codereview.chromium.org/2296433003
Cr-Commit-Position: refs/heads/master@{#417017}

This was added to the spec in:
https://github.com/w3c/webcrypto/commit/90d9f747da7ab2dd0f88638666c2326dcb953536

BUG=630025

Review-Url: https://codereview.chromium.org/2289033002
Cr-Commit-Position: refs/heads/master@{#417016}

This CL reenables a bunch of VideoCaptureDeviceTest
test cases for Android and for the "new" APIs

For this:
- adds a |mTestMode| to VideoCapture.java, interface
 of all camera java classes. VCCamera2.java tests this
 flag and adds a capture thread if it's set.
- the C++ correspondent classes get a method to configure
 the java side for testing, and a method to test if the
 underlying platform is using the new or the old APIs.

Also:
- Removes DeAllocateCameraWhileRunning because it was
 equivalent to CaptureWithSize test case.
- Cleans up/refactors some parts of the unit tests, adds
 a few more comments etc

BUG=626857

Review-Url: https://codereview.chromium.org/2286303003
Cr-Commit-Position: refs/heads/master@{#417015}

Move DisplayList class to ui/display, display namespace.
Rename existing 'DisplayList' vector alias to 'Displays'.
Add ScreenBase class with some basic functionality.

Not strictly necessary; but seems beneficial.
( helps codereview.chromium.org/2302673002 )

BUG=NONE
TEST=Compiles; automated tests; no behavior changes.
R=oshima@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2314203002
Cr-Commit-Position: refs/heads/master@{#417014}

BUG=643878
TEST=none
R=acleung@chromium.org

Review-Url: https://codereview.chromium.org/2302373003
Cr-Commit-Position: refs/heads/master@{#417013}

When renderer is asked to do a session history navigation that is in-page,
it should verify whether it has already committed a different document
by verifying the document sequence number (DSN) matches between the one
it has and the one sent by the browser process. When there is a mismatch,
the navigation should not be treated as in-page, since that can lead to
mismatch between the origin and URL of a document.

This is a slightly modified version of
https://codereview.chromium.org/2253233002/, which was reverted and
includes a test case to reproduce the race condition causing the mismatch.

BUG=628677, 630103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2316133003
Cr-Commit-Position: refs/heads/master@{#417012}