- 14 Jun, 2019 39 commits
-
-
Daniel Libby authored
The original change to enable scrollbar latency for the composited scrollbars incorrectly used an existing member to try and determine whether a GestureScrollUpdate was the first one in an injected sequence or not. is_first_gesture_scroll_update_ was incorrect because it is only updated when input is actually dispatched to InputHandlerProxy, and the flag is cleared for all GSUs before the location where it was being read. This bug was missed because of incorrect tests. The VerifyRecordedSamplesForHistogram method doesn't actually assert or expect anything - the return value must be inspected. As part of fixing up the tests, I made a few other changes to get them passing consistently across all platforms: - turn on main thread scrollbar injection feature (in case it's ever turned off we don't want the tests to start failing) - enable mock scrollbars - disable smooth scrolling - don't run scrollbar tests on Android The composited scrollbar button test is disabled due to a bug in how the mock theme reports its button sizes, which throws off the region detection in ScrollbarLayerImplBase::IdentifyScrollbarPart (filed crbug.com/974063 for this issue). Change-Id: Ie1a762a5f6ecc264d22f0256db68f141fc76b950 Bug: 954007 Change-Id: Ib258e08e083e79da90ba2e4e4216e4879cf00cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652741 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669086}
-
Takuto Ikuta authored
This allows to use VMs with SSD in builderless pool only for builders we want to use ssd. Bug: 956776 Change-Id: I19e4612c3485c75243ec7291d94c490bf24b13b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654757Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669085}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88596beab317..853ebacf99a4 git log 88596beab317..853ebacf99a4 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 ynovikov@chromium.org Suppress Mac 10.13.6 Intel OpenGL dEQP failures 2019-06-13 dongja@google.com Vulkan: implement primitive restart 2019-06-13 syoussefi@chromium.org Vulkan: Output render pass loadOp in graph dump Created with: gclient setdep -r src/third_party/angle@853ebacf99a4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Iebac2a1a174e5422458d0c06460c6722de8a34c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669084}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8c1ab9dcdb1..f457ae77aa76 Created with: gclient setdep -r src-internal@f457ae77aa76 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I7ef49fc5f4f4f52dafdbafe35b9ffb1196339783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658646Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669083}
-
Chris Harrelson authored
This removes also one of the four callsites of FindHostChildBySlotName, which is a slow method. Bug: 971930 Change-Id: I48cc5c29786277b320cdb17094bab5ada8402e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653350Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669082}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 038a01f1. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 8bbed8ff "Reland tests from "Change ICE connection state on transceiver changes"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Iaf8eac655a69d8d48bc3a4a6cbd92bc5a154fb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659632Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669081}
-
Xida Chen authored
Right now the CSSPaintAPIArguments is not enabled by default yet. When it is disabled, the |parsed_input_arguments_| in the CSSPaintValue will be nullptr, and BuildInputArgumentValues should not happen. Bug: 946519 Change-Id: I9f58d7565bfe715bbe6f760a55c830b6c9d064b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653414Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#669080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/38c7d9e30add..1e83e141f541 git log 38c7d9e30add..1e83e141f541 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 saklein@chromium.org ExtractBuildDepsGraph: Don't enter chroot manually. 2019-06-13 saklein@chromium.org PrepareBinhostUploads: Finish updating package index before deduplication Created with: gclient setdep -r src/third_party/chromite@1e83e141f541 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iacadf5fdc60b48dc42761c78a853f08d4afc7571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659640Reviewed-by:
-
Caleb Raitto authored
LSAN doesn't currently support Windows [1]. This fixes win-asan trybot breakage caused by https://crrev.com/c/1590404. [1] https://github.com/google/sanitizers/wiki/AddressSanitizerWindowsPort#lsan Cq-Include-Trybots: luci.chromium.try:win-asan Change-Id: I62e5ee13bb0d83a414e4a0456e9ffa27129ae28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658436 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
-
Mandy Chen authored
Change string concatenation to be a complete string: "1 x 1 pixels (intrinsic: 1 x 1 pixels)". This is because not all languages use space before left bracket and use the English left bracket. Bug: 941561 Change-Id: I762fc0f743010da461e3108d41f2b17c8247b6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657037Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#669077}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce4e27f24632..92eba93b33c8 git log ce4e27f24632..92eba93b33c8 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 asweintraub@google.com Fix 12 ClangTidy - Readability findings in //pdfium/HEAD/. 2019-06-13 asweintraub@google.com Fix declaration/definition parameter name mismatches. Created with: gclient setdep -r src/third_party/pdfium@92eba93b33c8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I648cbda750fe09b4e9b66e2df9373861d493367e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659668Reviewed-by:
-
Robert Flack authored
Running LayerTreeHost::AnimateLayers from the main thread is necessary in order for the main thread KeyframeModels to progress from WAITING_FOR_TARGET_AVAILABILITY to STARTING. Failing to advance to this state results in the cc KeyframeModels never being removed as the animation is still considered current and needing to affect the pending tree. Bug: 762717,962346 Change-Id: Ia559c0a7e3c73e12cc883e64fb4adb284a924418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1256422 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669075}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d05ca1537ccd..bc23ca13f1b3 git log d05ca1537ccd..bc23ca13f1b3 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 smut@google.com [bootstrap/win] Canary Python 2.7.15 Created with: gclient setdep -r src/third_party/depot_tools@bc23ca13f1b3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:879378 TBR=agable@chromium.org Change-Id: Icd377acb9f79d773ce663f9ce5b32a3594ed376a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659639Reviewed-by:
-
Pavol Marko authored
CommandLine::RemoveSwitch should also remove the switch from argv_. Bug: 964068 Test: base_unittests --gtest_filter=*CommandLine* Change-Id: If44106642c8089b83eb897e09c98ab8cf88fa24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653929 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#669073}
-
Mandy Chen authored
Use UI.formatLocalize to embed a link inside a localizable string. UI.formatLocalized takes a string and a list of strings or DOM elements. A span element is created, and a string is appended as a text node through appendChild(createTextNode(str)), while an element is just appended through appendChild(element). Code: https://cs.chromium.org/chromium/src/third_party/blink/renderer/devtools/front_end/ui/UIUtils.js?type=cs&q=uiutils.js&sq=package:chromium&g=0&l=622 Example before vs after: https://imgur.com/XBouvPo There are other places where the same change can be applied. To keep this patch small I only modified the remote devices tab. Sebsequent patches will be made. Bug: 941561 Change-Id: Iaf1ed0451c2f748943c4b9dfc918a969e1c24d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658750 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
Nigel Tao authored
This fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="AppListClientSearchResultsBrowserTest.UninstallSearchResult"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="AppListClientSearchResultsBrowserTest.UninstallSearchResult"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: Ib6d1b8f2bf8d4bc1a7c4558618f2c49587f11144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#669071}
-
Juanmi Huertas authored
Removing when the disable deferral is applied in video. Bug: 962532 Change-Id: I70ea32aa5a9152842c4b658615f72028276eb08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647391Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#669070}
-
Darren Shen authored
VirtualKeyboardController is a class for observing changes to input devices to decide whether to enable the VK. It currently also implements the keyboard layout delegate interface (for working with displays), which is not really its responsibility. This patch moves the logic into AshKeyboardController, which will be the ash impl of the virtual keyboard interface, so it makes sense that the code is there. Bug: 845780 Change-Id: Idf2e1805fbb3b3788dce27ee0ba0b76a9d4b2989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657511 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#669069}
-
Eliot Courtney authored
Expanding/contracting a notification changes its size, which generates a new LocalSurfaceId. Creating a new LocalSurfaceId makes viz create a new viz::Surface upon submitting the compositor frame. Viz's SurfaceManager tracks the lifetime and performs garbage collection for Surfaces, which reference TransferableResources, which correspond to e.g. the notification buffers. A viz::Surface can be destroyed and deleted. Destroyed means it is marked for deletion. Deletion will happen at some point in the future during GarbageCollectSurfaces. Normally, a notification would be displayed+embedded in the message center so it will have real references to the SurfaceIds. This means that the old viz Surface can be garbage collected immediately if the notification produces more buffers. But, if the notification is producing buffers while the message centre is closed, it's not embedded in anything. In this case, Viz creates temporary references. If you expand and then contract, two Viz Surfaces are created (one for each LocalSurfaceId) but neither can be deleted - both only have temporary references. These Surfaces hold onto the associated TransferableResources, the buffers, and cause buffer starvation on the Android side. Android HWUI starts waiting on a fence for a buffer but the ANR timeout occurs before the Viz temporary reference timeout. This causes the SystemUI ANR. Because the triggers for this bug - "notifications not being visible on the Chrome side" + "receiving input on a notification on the Android side" are completely asynchronous we can't realistically prevent these triggers from occurring. Instead, this change explicitly tells Viz it can release the resources by pushing empty compositor frames when the notification becomes invisible. Test: Android applications still can produce buffers Test: Notifications appear correctly when closing/opening the message center. Test: Following the steps in b/130856284, the ANR no longer reproduces. Bug: b/130856284 Change-Id: I42529267f75d7c30a8bcb03586e6dd08f658c69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645432Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#669068}
-
Juan Antonio Navarro Perez authored
The results.failures property has been deprecated since the work to remove FailureValue was completed. Bug: 973837 Change-Id: I961e6e4c0b2f54b4c62f5ba4bd294fef9d44212e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657903 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#669067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9715559684cd..4c4945a25248 git log 9715559684cd..4c4945a25248 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 mtklein@google.com trim another instruction of I32_SWAR 2019-06-13 mtklein@google.com streamline srcover math in I32_SWAR 2019-06-13 herb@google.com Add missing header 2019-06-13 mtklein@google.com slight bugfix for shr_i16x2 in the interpreter 2019-06-13 egdaniel@google.com Fix EGLImageTest for new assert. 2019-06-13 senorblanco@chromium.org GrTessellator: fix for even/odd fill type and path holes. 2019-06-13 mtklein@google.com add JIT guardrails Created with: gclient setdep -r src/third_party/skia@4c4945a25248 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:908646 TBR=herb@google.com Change-Id: I4a80996ad32c386ff6c538e9f36bbdaaa0c671ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659669Reviewed-by:
-
Siye Liu authored
We should return true in InputMethodWinTSF::IsInputLocaleCJK() if current active input language is Chinese, Japanese and Korean. Bug: 965319 Change-Id: Iac359a9d435efc16760e0b5f28da58aa0615054b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637921 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#669065}
-
Mandy Chen authored
DevTools: Convert concatenated string and link to embedded link in string in debugging terminated screen Use UI.formatLocalize to embed a link inside a localizable string. This is a sequent patch to https://crrev.com/c/1658750 No visual change in UI: Before: https://i.imgur.com/Tbxkwe1 After: https://imgur.com/hcfsuwf Bug: 941561 Change-Id: I0d7d8e42a83b9b4f18c6b928a5af706d21f0f85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658593Reviewed-by:
-
James Cook authored
The original CL caused a null pointer dereference on |prefs_util_| in extensions::SettingsPrivateEventRouter when StartOrStopListeningForPrefsChanges() is called from the constructor. This doesn't happen in dev builds, so I suspect it requires some extension to be installed. Fix by ensuring |prefs_util_| is initialized. Add DCHECK so existing settingsPrivate api tests will cover this case. Original CL description ----------------------- This fixes a longstanding issue where guest mode users cannot change the browser's preferred language list. The main profile in guest mode is an off-the-record/incognito profile. This CL from 2.5 years ago https://codereview.chromium.org/2499093002 changed the settingsPrivate API in guest mode to use the backing ("recording") profile instead of the main incognito profile for pref writes. The languages UI continued to function because the incognito profile's preferences were "overlaid" onto the recording profile prefs. By default, all prefs were overlaid, except for a block-list. That block-list was changed to a whitelist, and the whitelisted prefs were gradually removed. This CL removed the language prefs from the list: https://chromium-review.googlesource.com/c/chromium/src/+/1174118/ which made the guest mode language section stop working. For guest mode we want to use the incognito pref store where possible. The incognito pref store is in-memory. The backing user profile is deleted after logout (it is on a tmpfs) but it's better to just avoid writing the prefs. Change the BCKSFactories to prefer the incognito profile. Return null services in tests because unit tests with TestingProfile generally don't need these services. Bug: 887383 Test: added to browser_tests, manual test in guest mode on eve Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653748 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#668434} Change-Id: Id7ddf10ed15ca3ccb5c41abecbafbf66adddc3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659024 Cr-Commit-Position: refs/heads/master@{#669063}
-
Chris Harrelson authored
Also fixed one typo I noticed along the way. Change-Id: Ifd64bf3d8388dcfc2d42ba606d5ecfa786ffa5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653651Reviewed-by:
-
Ben Kelly authored
Bug: 960012 Change-Id: I4276b1bd22d418281d21b2034166cb094040dc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653248Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#669061}
-
Maggie Chen authored
Introduced a new finch flag kGpuWatchdogV2 disabled by default. All V2 functions added in this CL are the same as V1 for now. The purpose of GPU watchdog Version 2 is to simplify the logic and reduce the number of GPU crash reports if possible Bug:949839 Change-Id: I7b6cd58425a91d379b7abc5c5452c974def905a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652561 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669060}
-
Tina Wang authored
Previously an empty device list would be shown when there is no valid remote device but multiple devices are synced. i.e. All remote synced devices are using Chrome with version earlier than M-75. Now we will hide the entry points when there is no valid device. Bug: 970896 Change-Id: I64c1d58210c7ac30d1b455ea77d8aaccf6fecb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652372Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669059}
-
David Bertoni authored
This file should have been removed in 1645984. Bug: 961836 Change-Id: I94f51d5b8eb2b001db54944de547a8af4e0caa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658935Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#669058}
-
Kristi Park authored
Depending on window size, the number of text lines might be different. Explicitly set the number of text lines. Bug: 960622 Change-Id: Iaf54a8ab7688f0454bfb34e7dd6aa61392214bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658440 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669057}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/727d7ca2730f..e502dbcca014 git log 727d7ca2730f..e502dbcca014 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 perezju@chromium.org [Telemetry] Add download path for android_n_arm64-v8a Created with: gclient setdep -r src/third_party/catapult@e502dbcca014 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867592 TBR=crouleau@google.com Change-Id: Icddd87e04d8cc3e693ef1ad72f73960db3d8f12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659671Reviewed-by:
-
Yuly Novikov authored
Bug: 973992 Change-Id: I3f6988acd705f15ade7c6a85a66095ff87515647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659616Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#669055}
-
Aaron Gable authored
I look forward to the day that this is no longer necessary, but for now masternames are still keys into the chromium_tests bot_config dictionary. TBR: jbudorick Bug: 971387 Change-Id: I2d79fb35260c615900b8ae0cd7d4b7a9cacc9711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658632Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#669054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e08b37624f8..c8c1ab9dcdb1 Created with: gclient setdep -r src-internal@c8c1ab9dcdb1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:b/133794084 TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I3ea0f99ef93229c20392f31601f15abbaa16dbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659670Reviewed-by:
-
Will Harris authored
This is required for intercepts to work very early during the initialization of the target process. BUG=750886 Change-Id: I81a4bc43fc6652d473b557ade7f55d54cdb2a6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658591 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669052}
-
Kyle Milka authored
There's only a single source of custom background images so the logic for handling multiple sources is no longer needed. Bug: None Change-Id: I0503c36ba06c258e7e5ea7e898ab1b32639037c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658931Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669051}
-
Aleks Totic authored
A followup to cbiesinger's https://chromium-review.googlesource.com/c/chromium/src/+/1653864 Fixes more cases. Bug: 968019 Change-Id: Ie379fa5e2672c0c2ed0302eb7d40c4460262c00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658657 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#669050}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5894b6aad4b1..9e25f74faab6 git log 5894b6aad4b1..9e25f74faab6 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 sakal@webrtc.org Update visibility for JNI targets in sdk/android. Created with: gclient setdep -r src/third_party/webrtc@9e25f74faab6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5473642a6a321dd7117523e672765c98d732be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658775Reviewed-by:
-
Antonio Gomes authored
... except media_stream_constraints_util_video_content_unittest.cc, which will be removed on a follow up step (it has linking problems on win dbg bots that need fixing). Namely, the following files are Onion souped, from content/renderer/media/stream to renderer/modules/mediastream. - media_stream_constraints_util_sets_unittest.cc - media_stream_constraints_util_unittest.cc - media_stream_constraints_util_video_device_unittest.cc Note that all them now leave along side with their respective implentation files in Blink. Last, the only dependency in content that these tests still had were the inclusion of content/renderer/media/stream/mock_constraint_factory.h. Following the same logic used in [1], these helper mock files were moved to Blink too as part of this CL. BUG=704136 Change-Id: I29f1cb65b80844655271979019e53afee84c9879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654128 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669048}
-
- 13 Jun, 2019 1 commit
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b988e6b45063..c21dd10cf196 git log b988e6b45063..c21dd10cf196 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 dneto@google.com Update glslc tests for -finvert-y option (#704) 2019-06-13 andrejnau@gmail.com Pass InvertY to glslang (#695) Created with: gclient setdep -r src/third_party/shaderc/src@c21dd10cf196 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Ib551e4c6dce630ac4711a91e6f01a63367938862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659628Reviewed-by:
-
