GitLab

Since third_party/libavif is only used by
third_party/blink/renderer/platform/image-decoders, it makes more sense
for third_party/libavif to be in the same component as
third_party/blink/renderer/platform/image-decoders.

Change-Id: I92c464f662065267311c412e18279e76086ac364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302941Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#789539}

Just use the general pool at best-effort priority for logging command
line and field trials during startup, since it doesn't need to be on the
UI thread.

Change-Id: I73dfb14ae67bcc953fa7c90b5840354d5b4a84b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302946Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789538}

Bug: 1105139
Change-Id: Idf56cc5a8fdc30490c750f22e3e6341100fa0370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303462Reviewed-by: Travis Skare <skare@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789537}

The crosvm args for Plugin VM were changed in http://crrev.com/i/3119886
so it no longer matches the code here.

A sample list of arguments can be seen at go/paste/6706238773526528.

Bug: 1106680
Change-Id: I98d90f2679673868e42f2911637f84626af48f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302878
Auto-Submit: Timothy Loh <timloh@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789536}

* Moves calls to UpdateAccessibleName() into UpdateMode().  The
  unconditional call in OnDownloadUpdated() is now effectively called
  earlier, and conditionally, but it only had an effect in a subset of
  the cases where UpdateMode() is called, and is unrelated to the things
  that change in the meantime*, so this is fine.
  *Except: The other existing call in GetInProgressAccessibleAlertText()
  was necessary to ensure this _was_ updated in time in that case, and
  now that it's done earlier, is no longer needed.
* Inlines the contents of UpdateAccessibleName() since it's now only
  called once.
* Adds a new helper, UpdateAccessibleAlertAndTimersForNormalMode(),
  which handles everything UpdateMode() was doing specifically for the
  kNormal case.  Refactors the existing switch significantly to reduce
  duplication.
* Removes a call to StopDownloadProgress() from the destructor which had
  no effect (since the timers were about to be deleted anyway).
* Inlines StartDownloadProgress() and StopDownloadProgress() into the
  new helper since they're now each only called once.
* Sets up parameters for various timers in the constructor so this
  helper can largely just Reset() them to start them.
* Inlines ProgressTimerFired() as a lambda into the progress timer
  constructor.
* Renames various timer-related members in hopes of greater clarity.

Bug: none
Change-Id: Ida6a1f9d607d95f190be3908d7639de8bd515990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301209
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789535}

This change migrates callbacks related to the extension networking
private API to OnceCallback. There should be no functional change.

Bug: 1007786
Change-Id: Ibd606bcce6f1c5f4eb458b4270c542d1f6b9d5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289408Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789534}

Adding an empty process that is built and installed along with GCPW.
gcpw_extension.exe process is meant to be a service process that is
installed by gcp_setup.exe.

In this change;

An empty process with basic initialization is created
Self extracting module script is modified to include gcpw_extension.exe
Adds another event category called "GCPW Extension Events"

Bug: 1101590
Change-Id: I39f0e73d266c5328b4c18d348003a9109a55fe78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278588Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#789533}

This change creates a new Polymer component network-diagnostics that
runs diagnostic routines and then displays the results.

Bug: chromium:1098405
Change-Id: I245b3378e477f4fae89d9b33201c7359cc9e8e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261189
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789532}

Trigger teardownUI with legacy startup by updating the main scene state
instead of direct call in MainController.

Bug: 1045660
Change-Id: I6ca5e3d5c9dfd5b732da64f95eabdedff0571a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231119
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789531}

android_browsertests must depend on libunwindstack directly instead of
through DFM, since loading of a partitioned library is not supported in
an APK.
(internal discussion)
https://groups.google.com/a/google.com/g/clank-components/c/ktt285Gtax4/m/yRy8qm8LAQAJ

This CL also re-enables tracing use of StackSampingProfiler, which
was accidentally disabled in https://crrev.com/784147?

Bug: 1004855
Change-Id: I5967bf3815008843ba8a77e926977e39a4ccfbd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293071Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789530}

AX-Relnotes: screen reader support for Use Suggested Password popup
Bug: 786147
Change-Id: Ic59b7c0d01da7c7258ada0761dfdbb4204bed962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300184
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789529}

There are enough of them now that I think it makes sense to split them
out.

Bug: None
Change-Id: I503872e8877fc5f623e87550f5acab3b7d8a3650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302490
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789528}

WebMessagePort::MessageReceiver::OnMessage() is documented as returning
false if passed a message that it cannot handle (e.g. because it is
malformed or unrecognised).  The default OnMessage() implementation was
instead returning true.

Also tidy up the comment for OnMessage() to document only the return-
false-on-failure path, since the converse (true-on-success) is implicit.

Change-Id: If5f72913465aff40360d3dcc9a88fb8c10fbe237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300386
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789527}

This is a reland of 6eb566d2

Reason for revert: Cause failure in CheckedLockImpl::Acquire
crbug.com/1099649
Mark worker_released_condition_ declare_only_used_while_idle
to prevent priority queue from being acquired in ScopedBlockingCall.

Original change's description:
> [Jobs API]: Use worker_lock in JobTaskSource.
>
> Possible race when Join():
> - thread A: Join: worker_released_condition_->Wait()
> - thread C: WillRunTask:
>               GetMaxConcurrency() returns > 0
> - thread B: already running, finishes all the work
>               GetMaxConcurrency() goes 0
> - thread B: DidProcessTask:
>               worker_released_condition_->Signal(),
> - thread A: Join returns (GetMaxConcurrency() is 0)
> - thread C: TryIncrementWorkerCountFromWorkerRelease
>               worker count goes 1
> - thread C: runs worker_task after Join
>
> To fix race when Joining, all writes to |state_| are protected by
> |worker_lock|. Memory ordering is no longer necessary.
>
> Alternative: cancel before Join returns with a compare and swap and
> loop again if new workers.
>
> Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781453}

Change-Id: I1c7c0054a52b9b12dd6d0edd049ab2a7912df361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272942
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789526}

This ensures that, during navigation commit, it doesn't matter whether
we are reusing a Document or not. Code that needs to catch and handle
that case can null-check LocalDOMWindow::document().

This requires adding a separate LocalDOMWindow::Initialize() step,
because LocalDOMWindow::InstallNewDocument() can no longer detect
whether this a window reuse case or not.

Bug: 1106273
Change-Id: I23021d505d6a2dc2f54f435359ce5490e4ed561e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302939
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789525}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5e7627dc3a2167304ac07257b7aacd1f82a4d215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304654Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789524}

gfx::Image is not ThreadSafe, so use gfx::ImageSkia instead when we
need to pass image between threads.

Bug:1100967

Change-Id: I7511f9b83e2a3e384c37fdb6b308bb00ab353948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299460Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789523}

Migrates EmbeddedTestServer to a TestRule-based implementation, which
allows it to be used as an @ClassRule that can be reused across batched
tests.

Also removes a bunch of unnecessary locking that probably wasn't
necessary in the first place, and almost certainly isn't necessary now.

Bug: 989569
Change-Id: I1b5454b02251c08cd085eb4c9d70859acc1ed29a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300327
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789522}

The template intent_definition requires intentbuilderc version
shipped with Xcode 11.4 or higher. Add a assertion failing at
`gn gen` time to avoid cryptic error at compilation time.

Bug: 1104769
Change-Id: I89b9a66ce8101138749bebd9f777e1e65ff3373a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302637
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789521}

PlayerGestureListener class listens to gesture events from all frames
and handles per-player logic related to them (as opposed to per-frame).

Bug: 1064011
Change-Id: If82df0060ef6170cfcf456434a80ab814244be2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299526
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789520}

This CL refines the account change observer behavior in the web
sign-in flow. The selected account in the collapsed account picker
bottom sheet should not change if it is already in the new account
list.

Bug: 1096977
Change-Id: I9921a65ecb9da76050c978e93396771c154c53a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292430
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789519}

https://android.googlesource.com/platform/external/perfetto.git/+log/c0f23a129f67..0997f358ce07

2020-07-17 lalitm@google.com tp: fix slice tracking behaviour when multiple S event occur b2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:160969198
Tbr: perfetto-bugs@google.com
Change-Id: I08354a233c1fcf8c62f3491847b24c166261f128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304792Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789518}

This reverts commit 9dc85a0e.

Reason for revert: Build bot's are still failing for the same
reason following this revert. Ex: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/16136.

Original change's description:
> Revert "Reland "Ad Density UKMs recorded in AdsPageLoad.""
> 
> This reverts commit 94f5ec57.
> 
> Reason for revert: Speculatively reverting, many unit tests including PageLoad* are failing around after this one
> 
> https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/16124
> https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/83629
> 
> Original change's description:
> > Reland "Ad Density UKMs recorded in AdsPageLoad."
> > 
> > This is a reland of 3f8e5c2d.
> > 
> > This change was reverted as it depended on main frame intersection
> > measurement which broke renderer frame intersection observation
> > (crbug/1084786). The culprit CL has been fixed and has been
> > reimplemented independent of render frame intersection observation in:
> > https://chromium-review.googlesource.com/c/chromium/src/+/2206924.
> > 
> > Original change's description:
> > > Ad Density UKMs recorded in AdsPageLoad.
> > >
> > > This change adds ads page load metrics observer processing of
> > > FrameIntersectionUpdates for ad frames. Each frame, including the
> > > main frame, stores its main frame intersection in FrameData. The new
> > > AdsArea class handles calculating the combined area of all ad frames.
> > > Density is measured over the lifecycle of a page and the maximum denisties
> > > are recorded.
> > >
> > > The two new UKMs are: MaxAdDensityByArea, MaxAdDensityByHeight. These
> > > will be used to evaluate/motivate future interventions on page ad
> > > density according to the Better Ads Standard. Height is needed
> > > explicitly to match the definition of the standard.
> > >
> > > BUG=993453
> > >
> > > Change-Id: I054a2017f56843762d39f44870848c622fc38a43
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137771
> > > Commit-Queue: Justin Miron <justinmiron@google.com>
> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > > Reviewed-by: John Delaney <johnidel@chromium.org>
> > > Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#768347}
> > 
> > Bug: 993453
> > Change-Id: I1562846669b53b2d0a0eba9392e98e63b5e66a91
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292894
> > Reviewed-by: John Delaney <johnidel@chromium.org>
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Commit-Queue: Justin Miron <justinmiron@google.com>
> > Cr-Commit-Position: refs/heads/master@{#788725}
> 
> TBR=rkaplow@chromium.org,jkarlin@chromium.org,johnidel@chromium.org,justinmiron@google.com
> 
> Change-Id: Ie7b5002da0d4f593557d65e09ec4a2762d9310f6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 993453
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301711
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788963}

TBR=kinuko@chromium.org,rkaplow@chromium.org,jkarlin@chromium.org,johnidel@chromium.org,justinmiron@google.com

# Not skipping CQ checks because this is a reland.

Bug: 993453
Change-Id: Ica3db14f7e4ed89b868720c17ab5d5135f9724b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303170Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#789517}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/086c75fa39cf..47d86db05ea3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC seblalancette@google.com,mkwst@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1106750
Tbr: seblalancette@google.com,mkwst@google.com
Change-Id: Id329ea3735e99c7f9144e1ac1b6cfe3ef2cb420d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304377Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789516}

This CL introduces a feature that when enabled causes ChromeSync not to
respect the state of the master sync toggle on Android [1]. Users who
previously had ChromeSync disabled just because of this toggle will be
migrated into a state with sync enabled.

[1] https://screenshot.googleplex.com/4BWPEDJ28F0

TBR=treib@chromium.org

Bug: 1105795
Change-Id: I3e93b1f7eba1f1188138eb805818552157af2456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299353
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789515}

https://skia.googlesource.com/skia.git/+log/c97ebe06dc1d..b228a72cf564

2020-07-17 herb@google.com remove unused calls: grGlyph and quadOffset

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC nifong@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: nifong@google.com
Change-Id: I3b89c885936f524406d29cdcf563002274814bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304790Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789514}

Fixes flakiness in ShouldSaveAndDeleteImageOnDisk
Add brief delay to TestAmbientURLLoaderImpl
Re-order expectations to avoid races

Bug: b/160720485
Change-Id: I8be82e924d592024b972c4f13a8300418a39dc3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300008
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789513}

This is a preparation CL for Onion Souping content/renderer/media/audio.
Audio code uses Frame IDs in many places and across threads in the
renderer process. This makes moving the code to Blink difficult.
This CL switches frame IDs to frame tokens, which are accessible in
Blink and simplify a future migration.

The change to Frame Tokens is largely mechanical, except for the
deregistration of AudioOutputIPCFactories in RenderFrameImpl, which is
moved from the destructor to FrameDetached() since the token is no
longer available in the destructor.

Change-Id: Ib808d7d42c0a252ab4d8210c48d8994db1113ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300442
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#789512}

Bug: None
Change-Id: Ia498c7e2c11c06d20f84c52561e9f5b2de825560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303396
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789511}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: If25a353cfa899e77303d0cdc82f958cad09a4b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304796Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789510}

Rename the local variable |explicitly_set_attr_elements_map_| to
|explicitly_set_attr_elements_map| (dropping the trailing '_').

Change-Id: I2d46f32a993c3c27b092debba48614c068c87060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303392
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789509}

Bug: 1105309
Change-Id: I5650cc61dd8e6c2b76bb0ee79d9ab2b2de97cb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303041Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#789508}

In https://chromium-review.googlesource.com/c/chromium/src/+/2297817,
dougarnett@ added a guard against the Java translate infobar
disappearing in between translation being initiated and it completing.
This CL was done in response to Chrome crashes observed in the wild.
While the root cause is not completely known, the hypothesis is that it
is due to InfoBarContainer.java invoking
InfoBarContainerAndroid::SetWebContents(null) in response to changes in
Tab state. That invocation can result in a state where the Java infobar
is gone but the native infobar is still present. Hence, if that change
in Tab state occurs while translation is happening, when translation
finishes the native infobar would receive a callback but without the
Java infobar actually being present.

This flow also occurs in WebLayer, when the Tab loses being active.
Hence this CL preemptively ports the //chrome fix to //weblayer.

Bug: 1093320
Change-Id: Ic967c3fbf2b668b8884841a4cee8c435de49ab7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302757Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789507}

TBR=alfonsogarza@google.com

Bug: 1106734
Change-Id: Id66368be74c76435600f5fcb3192ad539dcdfc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304091
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789506}

This CL fixed an issue that scheduled download can't be deleted.

Bug: 1106368
Change-Id: If5c83452917dc6a77cffe5cae79f0422a4f4f892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303853
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789505}

This CL deprecates the capture experiment for paint previews.

Bug: 1105936
Change-Id: I1bb63bc213e1c16804cf187c1a754f8a5f5c608a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299184Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789504}

When the screen passed to `constrainFrameRect:toScreen:` is nil,
AppKit does some gymnastics to select a screen, only defaulting
to the main screen if there's no result. We don't have access
to these calculations in an override, so we can't use the
screen's frame for heuristics when deciding whether to allow
the constrain to happen or not.

This change removes the previous logic in favor of trying
to test specifically for the large vertical jumps that cause
glitches when detaching tabs.

Bug: 1102925
Change-Id: Ic5653d5fd867da155605cd986ec80c5bb4afd755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298056Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789503}

This is a reland of 43713035

Accidental empty-bitmap-check-reversal undone.

Original change's description:
> Refactor DownloadItemView state transitions, part 4.
>
> Renames LoadIcon() to UpdateFilePath() and moves it to be with the other
> Update...() functions, since it doesn't unconditionally load, but rather
> updates the file path, and conditionally loads if the path has changed.
>
> With the goal of greater consistency, renames |last_download_item_path_|
> to |file_path_|, |icon_| to |file_icon_|, and OnExtractIconComplete() to
> OnFileIconLoaded().
>
> Finally, makes a few tweaks around invalidation:
> * Explicit Layout() calls should be InvalidateLayout(); this will result
>   in a SchedulePaint() if anything moves, so the explicit
>   SchedulePaint() at the end of UpdateMode() can be dropped.
> * It's not clear to me why loading the icons would schedule a paint on
>   the shelf instead of |this|.  If there are other items on the shelf
>   referring to these same icons, they have tasks of their own.  Instead,
>   just SchedulePaint() when the file icon loads (large or small).
>
> Bug: none
> Change-Id: I2a7c5af7dcbe9bc489b18bc6a58e1183477a7027
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299180
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788927}

Bug: none
Change-Id: Ia8a06b3c6516443d6cb2ab49fbc64240c9347808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303449
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789502}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/45fb1f2ebb99..89b37f84e65c

2020-07-17 sigurds@chromium.org Update Protocol Definitions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1095617
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iac1043c186f71f829e9e89587d831d0f2189f747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304379Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789501}

Adds a section for the PIN auto submit in Settings.
Enabling the feature shows a dialog to the user to
confirm their PIN. The calls go through the quick unlock
private API.

Design Doc: https://goto.google.com/chromeos-oac-pin-authentication-refinements
Screenshot: https://screenshot.googleplex.com/gmT3B3whNnB

Bug: 1075992
Change-Id: Ia8417c46ac94661fd6294282a035896a5998ce03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279886
Commit-Queue: Renato Silva <rrsilva@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789500}