- 30 Mar, 2020 40 commits
-
-
Tao Bai authored
Only pull the coordinates where the focused field's coordinates already required, this change will not trigger any new layout, so there is no performance regression. Bug: 1064420 Change-Id: I67c3e5bbafcc4852b471b22a9d8d4edcb527187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125608Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754670}
-
Ted Meyer authored
this new name is more descriptive of the error. Bug: 1043289 Change-Id: If4f095410e162f989c1e5f8c533ae8e49722adbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121423Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754669}
-
Nick Diego Yamane authored
Delegate GtkEventLoopX11 initialization to platform code so that we can get rid of the ugly hack to start it, during GtkUi initialization, for both ozone and legacy X11. Bug: 963419, 1002674 Change-Id: Ib9e9d635bed5095fb730f778cc54d8cd3c71e07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093252Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#754668}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/29d712f9de99..4da46462d786 git log 29d712f9de99..4da46462d786 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@4da46462d786 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I55dcc7d375acfef9be903efb6e140c84aa4f4d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754667}
-
adamta authored
When long-pressing an image element that is not a link, context menu title should be "[<alt-text> – ]<src>". Alt text was never used before so it is now retrieved in the js to make this possible. A function was created to get the context menu title since the logic was too coupled with the context menu dictionary function. Bug: 1064569 Change-Id: I726b8066116426df3d51e89a65f906f77d739900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122752Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#754666}
-
David Bienvenu authored
I looked into the crashes that this debugging code was added for, and ~99.9% of them were because of malware, so it doesn't seem worthwhile to keep the debugging code. More info in crbug.com/614753. Bug: 614753 Change-Id: Ifc4b1e19e8041b684cfc5402f085870956f8fa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125036 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#754665}
-
Eric Robinson authored
This CL removes the option in the subresource filter code that considered the redirect chain for safebrowsing from the codebase. That logic is now performed elsewhere, and internally, only the final CL in the chain is now considered. The metrics for measuring where in the chain an intervention would occur, however, remain in place. Change-Id: Iad5a771db275424255829d32804b9d2f4d2299f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024473Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#754664}
-
Devlin Cronin authored
Bug: None Change-Id: I468c119b936cf1c4848593cf6b2cc5a244acb3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127629Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754663}
-
Pavel Feldman authored
We are now managing download behavior on the broweser context, not the web contents level. This simplified logic a lot. This change also deprecates the Page.setDownloadBehavior and moves it to the Browser.setDownloadBehavior level. Change-Id: I0e8e11fb8fe86052dadd2df178406b8c5262f20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121741Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754662}
-
Aaron Krajeski authored
Idle tasks take much longer on worker threads because requestAnimationFrame isn't there. For this test: https://chromium-review.googlesource.com/c/chromium/src/+/2124971 Without this change worker convertToBlob takes ~400ms With this change worker convertToBlob takes ~10ms Bug: 1053477 Change-Id: I3367e4b7ce73aec34acc9dbf084d226aa1b52093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124703 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754661}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3fffd0d4592e..17111b3e43c3 git log 3fffd0d4592e..17111b3e43c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 michael.liao@microsoft.com [Elements - Styles Pane]: Fixing SR behavior for element state pane Created with: gclient setdep -r src/third_party/devtools-frontend/src@17111b3e43c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065913 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic97d2c3576b98b688d31c8a6735afcb23bd70db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127423Reviewed-by:
-
Devlin Cronin authored
The NTP overridden bubble prompts the user post-installation to ensure an extension that overrides the NTP was desired. It is currently enabled on ChromeOS and Windows; this CL enables it on MacOS as well. Already-installed extensions will be auto-acknowledged for the user so as to not be disruptive. Only newly-installed extensions will trigger the bubble. Bug: 10646707 Change-Id: I58d8ff4f610def99c28dda7c8ee4d19933870e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120744Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754659}
-
Sadrul Habib Chowdhury authored
We currently report the 'slower thread' metric in the aggregated top-level metrics (AllInteractions and AllSequences). But now that we have a 'scrolling thread' metric, report that instead. BUG=1035460 Change-Id: Ide012ecf9c92aeeaba86fcdfeb812958e85a0656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128370Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#754658}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/11f4a84bb1b3..df70c8152767 git log 11f4a84bb1b3..df70c8152767 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 ehmaldonado@google.com depot_tools: Simplify MinGW check. 2020-03-30 ehmaldonado@google.com Reland "git-cl: Remove unused and duplicate functions." 2020-03-30 ehmaldonado@google.com Add quotes around paths in bash scripts Created with: gclient setdep -r src/third_party/depot_tools@df70c8152767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3dce2f422e50f65bd6b74652c458e97ac1acae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128371Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59d5ceda. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 9e853511 "Remove broken icon rendering for loading="lazy" images while loading" aa91d8cd "[COEP] Make WPT testing reporting to have a long timeout." 06949117 "Isolate activation-gated APIs from user-activation WPTs." 8c86fa01 "[mathml] Fix logic errors in linethickness interpretation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I67ee1f3d45e7740429e4bcd53b4b5aa5437ae078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128246Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754656}
-
Klaus Weidner authored
It's illegal to destroy mojo callbacks that haven't been run while their message pipe is still open. Since ArCoreGlThread's destructor shuts down the task runner, this was causing DCHECK failures if the task runner owned a closure with a pending GetFrameData mojo callback. To fix this, have ArCoreGl retain ownership of the closure containing a mojo callback, and call it through a helper method. Bug: 1065572 Change-Id: Ice2340906da470ff2b5b69554e9e7755dd040b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127420 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#754655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/50a47bd99229..7939e367fa53 git log 50a47bd99229..7939e367fa53 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 cwallez@chromium.org Revert "Enable blob cache when debugging" 2020-03-30 cnorthrop@google.com Vulkan: Expose extension for ETC1 usage with subimage updates 2020-03-30 courtneygo@google.com Enable blob cache when debugging Created with: gclient setdep -r src/third_party/angle@7939e367fa53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Iab1326e198ec7d61236f8a42298e18440bc3a0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127762Reviewed-by:
-
danakj authored
Objects are all set up in a reasonable state at construction time already. No need to do a Reset, which also involves some IPCs back up to the browser. Change-Id: Ic4522f40bce99178c838d268af8499d36b0e5325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128240Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754653}
-
chrome://flagsbttk authored
A new configuration source of the default homepage and bookmarks. Bug: 1063948 Change-Id: Ic940ff4a0ac8b27ccf27311427557563542cf936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127890Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#754652}
-
Tommy C. Li authored
Currently, we don't pass the provider-populated (generally server-provided) subtype_identifier field into the aqs= CGI parameter. We just statically make one in the AutocompleteController AutocompleteMatchToAssistedQuery static method. This more or less works, but in our ideal system, we would have these qualities: 1. We decentralize this provider-specific logic into the providers themselves, rather than having a centralized switch statement that handles all these per-provider cases. 2. If the server passes us some special subtype_identifier, we can pass it along in our aqs= parameter without updating the Chrome binary. This CL makes AutocompleteMatchToAssistedQuery start with the provider-populated integer. It also adds a test. Ideally in the future, all of the logic within that static method could be migrated into the individual provider classes. Bug: 1064327 Change-Id: I8b56a6623f61520218f2f4001787171c300fb192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118221Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754651}
-
Natalie Chouinard authored
Bug: 1044401 Change-Id: I7b8c69a390f47e86b864360d1913bf593c8b69ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124969Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754650}
-
Antonio Gomes authored
This CL moves flexbox-with-multi-column-property.html from css3/flexbox/ to external/wpt/css/css-flexbox/. It also adds links and references to the related spec, and expected behavior. Last, it replaces uses of -webkit-column-* by their respective column-* counterparts. Relevant spec change: https://github.com/w3c/csswg-drafts/issues/1364 ([css-multicol-1][css-flexbox-1][css-grid-1] Clarify that column-* properties only apply to block containers). BUG=1063749 R=dgrogan@chromium.org Change-Id: Icd31c1974af431bd8cd6de94970e4e29137a669e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127294 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754649}
-
Justin Cohen authored
Use GetLastCommittedItemInCurrentOrRestoredSession() instead of GetLastCommittedItem() so restore session URL's aren't suppressed. Otherwise a cancelled/stopped navigation during the first post-restore navigation will always return early from Reload. Bug: 1050518 Change-Id: I352e430abcf888ae8488150b6511e8a7fd9bd4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125870Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
The tests were using chrome:// URLs to trigger SafeBrowsing warnings. They also wait until the pages are ready which is done by running JavaScript. In some cases, WebUI bindings aren't yet ready for the loaded page so executing JS fails, causing the tests to crash. This CL switches to HTTP pages instead. Bug: 1065742, 1057157 Change-Id: Ie3302e7c63bf8d4d7c9db687c95ce1e9e8da483c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127733Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754647}
-
Charlie Hu authored
This CL renames FeaturePolicyDisposition to PolicyDisposition, because it is now used for both feature policy and document policy. Change-Id: I2ff2f0a9a167ca56f5aeac14adff660f8504a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127734Reviewed-by:
-
Maggie Chen authored
Bug:949839 Change-Id: Iea808d532584089d974032e5eef3eeee8eb57a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126572Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754645}
-
Peter Wen authored
Bug: b/150400326 Change-Id: I5a4dc3c2adbc40510750b14b254dd7e998dfa404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127987 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#754644}
-
Nico Weber authored
With this, -Wunreachable-code is enabled on all platforms for chromium_code (which is the default config for all GN targets). Targets that explicitly opt out of chromium_code and into no_chromium_code don't get the warning. (libfuzzer builds also don't get the warning, that's issue 1063180). Bug: 346399 Change-Id: I88ea45eddf55d4ba5170ff89367d6afcf27891a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128189 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754643}
-
Thomas Lukaszewicz authored
Added the ability for callers of SetIdentityInfo() to specify which vector icon to fall back to in the case that an empty |image| is supplied. This allows the incognito profile menus to specify the incognito icon and color required. This is necessary as previously the incognito image was generated prior to having access to the Widget, resulting in incorrect colors. Bug: 1065294 Change-Id: I4bc78e692abb7354e6cd5fcdeccd5483dc2c964a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127410 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Marina Ciocea authored
The webrtc::FrameTransformerInterface is transitioning to using TransformableVideoFrameInterface instead of video_coding::EncodedFrame. Use new webrtc::FrameTransformerInterface methods. Bug: 1052765 Change-Id: I533118ca692e77229975874f446cdd6fde08461f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126670 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#754641}
-
Xida Chen authored
There were two tests written in the way that its test body is inside the FrameSequenceTrackerTest class. This was because there were a few APIs that were not ready at the moment. Now that we have all the instruments in the FrameSequenceTrackerTest class to access APIs in FrameSequenceTracker, this CL cleans up the test. Bug: None Change-Id: I88e09893500381669fd2d3d5bc04eccad839455c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126249 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754640}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/d52066592790..f085b9745fc1 git log d52066592790..f085b9745fc1 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 dgkoch@users.noreply.github.com Roll glslang dependency to SDK-candidate tag (#1024) Created with: gclient setdep -r src/third_party/shaderc/src@f085b9745fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ibcacdccaeeca5394a82e1636a3b523f142ae4ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127759Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c24b6b7815ce..1d0faee9aa1a git log c24b6b7815ce..1d0faee9aa1a --date=short --first-parent --format='%ad %ae %s' 2020-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dfa4a7a6..a0d7df33 (754373:754491) 2020-03-30 kerl@google.com Add packet rate plots to event_log_visualizer. Created with: gclient setdep -r src/third_party/webrtc@1d0faee9aa1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie3b14edbd07512b756fe040fd2f811e1588037c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127758Reviewed-by:
-
Antonio Gomes authored
This CL moves negative-overflow.html from css3/flexbox to external/wpt/css/css-flexbox. <link ref=help|match> tags were added, as well as <title>. CSS and JS referenced paths were also updated. BUG=1063749 R=dgrogan@chromium.org Change-Id: I4091fc870f51a31ac9fbac51b42eaa6cd33a16de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127607 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Scott Violet authored
BUG=none TEST=none Change-Id: I5baa25638f3f46f057be4c560b8ce37fbb497f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125301Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754636}
-
Martin Kreichgauer authored
Pass request parameters from the native side to BLEHandler and through to CableAuthenticator on the Java side, and use them when making FIDO API requests. From the responses to those API requests, pass values back to the native side and return them in the CTAP response. This also includes using parameters from the googleAndroidClientData extension and handing back clientDataJSON in the response. Bug: 1002262 Change-Id: I6c5b202f9fa1df5e90f53fe3140cfbc1fc4b589a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127516 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#754635}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/81d8c2ada561..45755df21024 git log 81d8c2ada561..45755df21024 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 capn@google.com Eliminate the legacy PowerVR SDK 2020-03-30 capn@google.com Integrate PowerVR OpenGL ES samples 2020-03-30 capn@google.com Fix completeness test of OpenGL ES immutable textures 2020-03-30 cwallez@google.com Revert "MetalSurface: set layer.device to a ref of the system default device." Created with: gclient setdep -r src/third_party/swiftshader@45755df21024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I075049127a2746022b411204c25409def6273b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127760Reviewed-by:
-
Charlie Hu authored
Previous fix to the failing test was to add a setTimeout on resize javascript so that the initial frame can be rendered before the resize. (https://chromium-review.googlesource.com/c/chromium/src/+/2090457) It turns out setTimeout is not a reliable way to force layout. This CL uses |runAfterLayoutAndPaint| to force multiple layouts happening instead of only once at the end by default for pixel tests. Bug: 1061539, 1060776 Change-Id: If068a63655eaacf1300b963e60e441a04fc59784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124888 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#754633}
-
Nico Weber authored
This reverts commit 916ac566. Reason for revert: apparently mb.py now using the go client means we depend on this change. And I don't want to revert the switch to the go client since it's so much faster. So let's reland this, land https://chromium-review.googlesource.com/c/chromium/tools/build/+/2127067 and then hopefully quickly find a fix for the regression that the deterministic bots now miss some stuff. Original change's description: > Revert "compare_build_artifacts.py use *.runtime_deps" > > This reverts commit 0f71cedd. > > Reason for revert: .runtime_deps currently aren't always in > the root build dir, see > https://chromium-review.googlesource.com/c/chromium/tools/build/+/2127067/1#message-9a3c93e50651dc80dfbfefb762db5841ef159b13 > (Also, https://crbug.com/1065750) > > Original change's description: > > compare_build_artifacts.py use *.runtime_deps > > > > *.isolate file is deprecated. > > use *.runtime_deps file, generated by gn, instead. > > > > Bug: 972075 > > Change-Id: I5bc47cbe058c1550fdca4d1d89928c3daf4bc0e5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061575 > > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#745827} > > TBR=maruel@chromium.org,thakis@chromium.org,ukai@chromium.org,tikuta@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1065750,972075 > Change-Id: I49426f0a40d013f6ffacc9524120b1b58db2f03b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128186 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754587} TBR=maruel@chromium.org,thakis@chromium.org,ukai@chromium.org,tikuta@chromium.org Change-Id: Iff3934bc722eebbfe023f10f65704387626d1806 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065750, 972075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127894Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#754632}
-
Sammie Quon authored
This reverts commit c3f6c6c0. Reason for revert: Causes regressions in the below linked bugs. Original change's description: > overview: Fade the crostini window back in if it fails to close. > > The crostini installer (and other non-closeable) windows will reverse > their animations in overview if the CloseWidget call fails to close > the window. > > Test: manual > Bug: 970196 > Change-Id: I7aeab07c9d7f2f5e94a34ac8b3a43bdde3610b6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121346 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753660} TBR=xdai@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id0a29e92c3711a79771a22a59a8301a1fa5a43f1 Fixed: 1066167, 1066169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128230Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#754631}
-
