GitLab

This timed out on the waterfall and is failing on unrelated tryjobs runs
as well.

TBR=jsbell@chromium.org
BUG=380910

Review URL: https://codereview.chromium.org/316383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/316373002

git-svn-id: svn://svn.chromium.org/blink/trunk@175614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=175416

BUG=none
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/315423002

git-svn-id: svn://svn.chromium.org/blink/trunk@175613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175388

BUG=371640
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/314283004

git-svn-id: svn://svn.chromium.org/blink/trunk@175612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename ElementData's attribute related methods for clarity:
* length() -> attributeCount()
* isEmpty() -> hasAttributes()
* getAttributeItem(name) -> findAttributeByName(name)
* attributeItem(index) -> attributeAt(index)
* getAttributeItemIndex(name) -> findAttributeIndexByName(name)
* addAttribute(name, value) -> appendAttribute(name, value)
* removeAttribute(index) -> removeAttributeAt(index)

This is inpired by the following WebKit revision by benjamin@webkit.org:
http://trac.webkit.org/changeset/162394

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/313973003

git-svn-id: svn://svn.chromium.org/blink/trunk@175611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Prepare to move AbstractSQLStatement, SQLStatement, and SQLCallbackWrapper<T> to Oilpan heap.

SQLCallbackWrapper has code to call ExecutionContext::deref() in the origin
thread. This is unnecessary in Oilpan because implementation classes of
ExecutionContext are already on-heap and they are always destructed in their
origin threads.

This is a prepration to make ExecutionContext GarbageCollected.

BUG=357163

Review URL: https://codereview.chromium.org/311273005

git-svn-id: svn://svn.chromium.org/blink/trunk@175610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Keep a traced Member reference to the Element that's recorded as
the Document's CSS target. When that Element is removed from the
tree, the Member will be explicitly cleared.

R=
BUG=357163

Review URL: https://codereview.chromium.org/315333002

git-svn-id: svn://svn.chromium.org/blink/trunk@175609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since rAc was adopted into the standard, we revisited this and decided
to do it a different way. This "revert" does keep the minor change
about removing the extra param to
WebAutofillClient::didRequestAutocomplete.

BUG=354897

Review URL: https://codereview.chromium.org/293853002

git-svn-id: svn://svn.chromium.org/blink/trunk@175608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381364
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/322443003

git-svn-id: svn://svn.chromium.org/blink/trunk@175607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows the file to be compiled with C++11.

BUG=

Review URL: https://codereview.chromium.org/316113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381471
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/317283002

git-svn-id: svn://svn.chromium.org/blink/trunk@175605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381464
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/314113004

git-svn-id: svn://svn.chromium.org/blink/trunk@175604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes cases where a node that previously had a >1 multiplier ceases to have direct text children.  This can happen if its text content is removed in script, or if its 'display' style is changed from inline to block.  (There are probably other ways for it to happen also.)

Previously such a node would have a "stale" multiplier, since the autosizer only updated multipliers on text nodes and their immediate parents.  In theory the stale multiplier should not have affected the rendering, but:

- it is observable through the lineHeight property, and
- due to http://crbug.com/380903 the stale multiplier on an ancestor might be used to render text, even when the text node has the correct multiplier

BUG=378959

Review URL: https://codereview.chromium.org/319013003

git-svn-id: svn://svn.chromium.org/blink/trunk@175603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dominicc
NOTRY=true

Review URL: https://codereview.chromium.org/319093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Not having this can cause problems in the test harnass, where some of the
FrameLoaderClients do substantially more work than they do in a non-test
environment.

BUG=357283

Review URL: https://codereview.chromium.org/317513002

git-svn-id: svn://svn.chromium.org/blink/trunk@175601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The IDB spec defines that transactions are created 'active' and become
'inactive' when control returns to the event loop. The way this was
implemented, transactions created within microtasks (e.g. Promise
callbacks) were not deactivated.

Flip the order of microtasks and deactivation, and add tests.

BUG=380910
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/321433002

git-svn-id: svn://svn.chromium.org/blink/trunk@175600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some async layout tests use waitUntilDone() and notifyDone() by
themselves, without setting window.testIsAsync to true.

This may be either unnecessary or incorrect, depending on which of the
test's notifyDone() and text-based-repaint.js's notifyDone() executes
first. If the latter executes first, the test may finish before it's
done causing what the test want to test not fully executed.

BUG=381242

Review URL: https://codereview.chromium.org/316193003

git-svn-id: svn://svn.chromium.org/blink/trunk@175599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381451
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/321493002

git-svn-id: svn://svn.chromium.org/blink/trunk@175598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was added in http://src.chromium.org/viewvc/blink?view=revision&revision=80584.
It didn't have tests, so I'm not sure how to test this.
But plugins always have a RenderLayer, so there should be no
need to schedule a layer update anymore.

Review URL: https://codereview.chromium.org/318773003

git-svn-id: svn://svn.chromium.org/blink/trunk@175597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=falken@chromium.org,jkarlin@chromium.org
BUG=374822

Review URL: https://codereview.chromium.org/311233007

git-svn-id: svn://svn.chromium.org/blink/trunk@175596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

needed to be updated. Long press on text will no longer show a context menu.

BUG=381152

Review URL: https://codereview.chromium.org/320453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/319813003

git-svn-id: svn://svn.chromium.org/blink/trunk@175594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381373
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/319803002

git-svn-id: svn://svn.chromium.org/blink/trunk@175593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=peter@chromium.org
BUG=381364

git-svn-id: svn://svn.chromium.org/blink/trunk@175592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ojan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/314243002

git-svn-id: svn://svn.chromium.org/blink/trunk@175591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a bug where the load gets blocked by preload == 'none'
eventhough JavaScript has called play() after setting the src
attribute. This particular bug only appears if play() is called before
the JavaScript code relinquishes control back to the UA.

Tests cases were added to make sure that immediate load() and play()
calls both trigger loading. Before this change, only immediate load()
calls ignored the preload == "none" state.

BUG=177870
TEST=LayoutTest/media/video-preload.html

Review URL: https://codereview.chromium.org/313173008

git-svn-id: svn://svn.chromium.org/blink/trunk@175590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380054

Review URL: https://codereview.chromium.org/317813003

git-svn-id: svn://svn.chromium.org/blink/trunk@175589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The virtual mac-antialiasedtext and windows-directwrite test suites
both test antialiased text and both use the same subsets of text.
Merge both into a new antialiasedtext test suite now that directwrite
is always enabled (for tests) on windows.

BUG=379590
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/303133007

git-svn-id: svn://svn.chromium.org/blink/trunk@175588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For example, android can set the background color of a WebView to be
transparent. This sets the mainframe base background color to be transparent.

The internal bug is b/15373310
BUG=375864

Review URL: https://codereview.chromium.org/315763003

git-svn-id: svn://svn.chromium.org/blink/trunk@175586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The contents of 'will-change: contents' elements are expected
to change frequently (e.g. every frame). Consequently, the
creation of composited layers within a 'will-change: contents'
subtree should be avoided where possible. This CL suppresses
compositing for animations and for will-change in descendants
of elements with 'will-change: contents'.

BUG=365885

Review URL: https://codereview.chromium.org/298723011

git-svn-id: svn://svn.chromium.org/blink/trunk@175584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add iterator object to iterate efficiently over an Element's attributes instead
of using ElementData::length() / ElementData::attributeItem(index).

This is a bit more efficient as it avoids implicitly calling
ElementData::isUnique() for each loop iteration.

This is based on the following WebKit revision by benjamin@webkit.org:
http://trac.webkit.org/changeset/162394

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/298253009

git-svn-id: svn://svn.chromium.org/blink/trunk@175583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test was already marked as flaky on release retina bots, but is flake
on other Mac bots as well.

TBR=dcheng@chromium.org
BUG=380167

Review URL: https://codereview.chromium.org/317783011

git-svn-id: svn://svn.chromium.org/blink/trunk@175582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175562

BUG=374119
TBR=davve@opera.com

Review URL: https://codereview.chromium.org/316193002

git-svn-id: svn://svn.chromium.org/blink/trunk@175581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381035

Review URL: https://codereview.chromium.org/317843002

git-svn-id: svn://svn.chromium.org/blink/trunk@175580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik,sergeyv
NOTRY=true

Review URL: https://codereview.chromium.org/315213003

git-svn-id: svn://svn.chromium.org/blink/trunk@175579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With new touch hit testing in compositor, which looks through all
the layers hitting the point, we don't need touch regions on overlay
layer anymore.

Note, that we still need main-thread scrolling to stay in sync with
page contents.

BUG=304271

Review URL: https://codereview.chromium.org/305383002

git-svn-id: svn://svn.chromium.org/blink/trunk@175578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We will have two descendants of TimelineModel - one based on trace events and another one based on the timeline agent events. This change extracts the latter one.

I left WebInspector.TimelineModel.RecordType to keep the patch short. Will move it to WebInspector.TimelineModelImpl.RecordType later.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/313333002

git-svn-id: svn://svn.chromium.org/blink/trunk@175577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm about to use this useful script in Source/modules, so a common
denominator location seemed like a good idea. As well, I added a
namespace option as the upcoming use in modules/serviceworkers will be
in WebCore not blink.

R=jochen@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/311343002

git-svn-id: svn://svn.chromium.org/blink/trunk@175575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<integer>, <angle>, <number>, <length> and <percentage>.

BUG=377503,339899

Review URL: https://codereview.chromium.org/302643004

git-svn-id: svn://svn.chromium.org/blink/trunk@175574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/315223002

git-svn-id: svn://svn.chromium.org/blink/trunk@175572 bbb929c8-8fbe-4397-9dbb-9b2b20218538