GitLab

Bug: 779988
Change-Id: I79a8f22ac7f0eabf3efe2805ee7a19b9403b84fc
Reviewed-on: https://chromium-review.googlesource.com/747078Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512925}

This change fixes the ASAN crash on clang-phone bot.

TBR=junov@chromium.org

Bug: 779533
Change-Id: Ia69bd71bb7845e87609550f0b6889445fa27eb60
Reviewed-on: https://chromium-review.googlesource.com/747564Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512924}

This patch changes the APIs to take Position parameters to better support
mapping non-text anchored positions to LayoutNG canonical text.

To better cope with the modified APIs, this patch also adds a helper method
LayoutText::CaretOffsetForPosition() for converting Position back to caret
offset. It also helps consolidating overrides of CaretMin/MaxOffset in
LayoutTextFragment, by overriding CaretOffsetForPosition() instead.

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iff7e4e3388e70e8ee7d8412f7d62a829ebc9efb7
Reviewed-on: https://chromium-review.googlesource.com/740702Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512923}

This change implements the first half of the velocity model for
swipe suppression. Swipes with a high velocity will not cause the
bottom sheet to open (max 0.2dp/ms).

BUG=779615

Change-Id: If0c12e8ba87c6d4d8b8ee7c53e96acb553199692
Reviewed-on: https://chromium-review.googlesource.com/744585
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512922}

This also removes the mojo_common_unittests filter, which was no longer
required.

Bug: 772031, 754029
Change-Id: Ia7e28b27319ade4762a4c803ee1c4697a0f7c1ef
Reviewed-on: https://chromium-review.googlesource.com/744581
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512921}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3d0190fc620bf65484c87ee6f013cd502b30d419
Reviewed-on: https://chromium-review.googlesource.com/747084
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512920}

ShellPortMash is no longer always created. The code path this code
calls is only applicable to mash, so can early out for mus.

BUG=none
TEST=none

Change-Id: I55c58c353c0ebeba70cfec313a62c845e00faee9
Reviewed-on: https://chromium-review.googlesource.com/747204Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512919}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5803c09738210be2b38edab0ae07929eec2eedc4
Reviewed-on: https://chromium-review.googlesource.com/747049
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512918}

It indicates that the report is finished and TriggerManager can release
references to ThreatDetails. This will ensure ThreatDetails lives long
enough to finish its work.

Bug: 776149,777915
Change-Id: I1a1a5876edb51420889a91aa48833bf99d81a217
Reviewed-on: https://chromium-review.googlesource.com/738290
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512917}

This will allow us to track exactly when ObjectPropertiesSection
content changes. A followup will use this to invalidate console
text cache.

Bug: none
Change-Id: I81c105639e072c0ffff3410937e722a644d72dd7
Reviewed-on: https://chromium-review.googlesource.com/732725Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512916}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic72c931500743fda96bd75e74fca1531a3e8d1cc
Reviewed-on: https://chromium-review.googlesource.com/747004
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512915}

This adds unittests for the changes made in
crrev.com/a6a3f1e8

This requires a small refactoring to allow unittests to fake the
current time for the WebrtcFrameSchedulerSimple class.

Bug: 773894
Change-Id: I00e1204b1eab446e18e5d8796770dbd64623abfc
Reviewed-on: https://chromium-review.googlesource.com/729565
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512914}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iee78d40a42947ff63c32f7e33f1d4b4547c03386
Reviewed-on: https://chromium-review.googlesource.com/747048
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512913}

These methods - UsesImageContainerSize and ImageHasRelativeSize - are
only simple wrappers for similarly named methods on Image. Callers have
access to Image without any hoop-jumping, so just fold these methods.

Bug: 773272
Change-Id: Ie6a02b7e1c4643c5ebfafa0b6281503194904852
Reviewed-on: https://chromium-review.googlesource.com/747102Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#512912}

They practically have zero usage and are a footgun for most users as
custom layouts are entirely untested on modern versions of Android. By
removing the command line flags, we simplify our Web Notification
display style to:

  Android J, K, L, M: custom layouts
  Android N, O; big image notification: default layout

BUG=

Change-Id: Ia1b47681fe67ebc66e9ba856fa5d2df82bdb2e07
Reviewed-on: https://chromium-review.googlesource.com/747422Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512911}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I09303f54cd1e91d3703cd680ecb07952cac9b7b9
Reviewed-on: https://chromium-review.googlesource.com/747091
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512910}

Attempting to reland
https://chromium-review.googlesource.com/c/chromium/src/+/722067

Differences include: Not changing --id to --bot, removing the sys.executable as an argument to the subprocess, and changing --dump_json to --dump-json

BUG=chromium:758632

Change-Id: I91bad09256a7e87972c448039c89e308ee5db7f5
Reviewed-on: https://chromium-review.googlesource.com/747074Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512909}

These are meant to be 13pt, not 12pt.

Bug: 610428
Change-Id: I3718197e67e2eef26611572dfcbfdb40ffcce405
Reviewed-on: https://chromium-review.googlesource.com/746367
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512908}

This reverts commit 91c22dbf.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=768886#c34

I'm puzzled as to why but it seems removing hang watching of unused BrowserThreads causes a spike in hang reports of remaining watched threads...

Original change's description:
> Remove hang watching of deprecated BrowserThreads.
> 
> This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/705775
> 
> That CL caused issue 768886 (spike in hang reports). I suspect this
> was caused by a change in enum IDs rather than this change to the
> hang watching code and this CL will help narrow down the cause.
> 
> R=​asvitkine@chromium.org
> 
> NOPRESUBMIT=TRUE (shuffling of code using deprecated BrowserThread IDs)
> 
> Bug: 689520,768886
> Change-Id: Id7bf1c7b5f5d34c4b1e7b1e71e9b015725695997
> Reviewed-on: https://chromium-review.googlesource.com/743846
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512509}

TBR=gab@chromium.org,asvitkine@chromium.org
NOPRESUBMIT=TRUE

Skipping CQ checks because CL landed > 1 day ago.

Bug: 689520, 768886
Change-Id: I164eceed2a2354b3fa82d6ff73899417530aa3a5
Reviewed-on: https://chromium-review.googlesource.com/747661
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512907}

base::CommandLine works around the fact that std::map did not previously
support lookup by a key type other than the one stored in the map (like
const char* or base::StringPiece), and maintained a second map to allow
lookup by StringPiece without allocation. This can now be done directly
on |switches_| using C++14 heterogeneous lookup.

Sites which refer to base::CommandLine::SwitchMap without using the alias
are rewritten to refer to the alias, since this affects the type of the
map. (This is more concise anyhow.)

Bug: 554717
Change-Id: Ieee179206cc5a35b4ab9ded183d5f46529a730ce
Reviewed-on: https://chromium-review.googlesource.com/616262Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512906}

DevTools: introduce Page.getFrameTree that would be public and can be used instead of getResourceTree.

Change-Id: I451842c1e0feb3c35c1ad0ed588733a855b21954
Reviewed-on: https://chromium-review.googlesource.com/744978Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512905}

For go/mustash we're putting code in //ash into a separate process, so
code in //chrome/browser cannot call directly into it. Restrict DEPS in
//c/b/extensions to make that clearer.

Bug: 678705
Test: checkdeps
Change-Id: I22c707564930c3dce70f5c2576c3dfacc44c1d22
Reviewed-on: https://chromium-review.googlesource.com/747062Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512904}

Bug: 757243
Change-Id: Iba827221e50dea80eeeabb341d1af6067cdb249a
Reviewed-on: https://chromium-review.googlesource.com/747046Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512903}

Bug: 768373
Change-Id: I1db4191eacb7370afb0abd6c820d52057430fb00
Reviewed-on: https://chromium-review.googlesource.com/705214
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512902}

https://pdfium.googlesource.com/pdfium.git/+log/367e7de07ec3..994f20cfb76f

$ git log 367e7de07..994f20cfb --date=short --no-merges --format='%ad %ae %s'
2017-10-31 rharrison Fix FPE in XFACodecFuzzer

Created with:
  roll-dep src/third_party/pdfium
BUG=779890


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If2f5607a9e9c06be34cb76b545d74311b076792f
Reviewed-on: https://chromium-review.googlesource.com/747070
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512901}

This change removes legacy-srgb mode from the code base.

Bug: 637288
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibaee28da77fdc9e216cc055e74e6725255eebc29
Reviewed-on: https://chromium-review.googlesource.com/738534Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512900}

Because ui_devtools_dom_agent.(h|cc) are already in ui_devtools
namespace, UIDevToolsDOMAgent class can be simplified as DOMAgent.
Dependent files will change accordingly.

BUG=752601
R=sadrul@chromium.org, thanhph@chromium.org
Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: Ide16bd0e4589021deb19d90abacd5437fcb1d589
Reviewed-on: https://chromium-review.googlesource.com/727481
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512899}

Remove ScreenIsLocked and ScreenIsUnlocked from
SessionManagerClient::Observer. Callers should use
ash::SessionObserver (in ash) or
session_manager::SessionManagerObserver (in the
browser) instead.

Update the following classes to do that:
- ash::PowerEventObserver
- chromeos::ExtensionSystemEventObserver
- TetherService

Bug: 778888
Change-Id: I9792338a8c5cce6f0aeaddb11dad8adfd951683c
Reviewed-on: https://chromium-review.googlesource.com/741262
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512898}

No change to production logic, only WebView shell.

This changes a String comparison to use `.equals()` instead of `==`. We
were already returning the same String object, so reference comparison
was probably technically correct as-written, but this change gets rid of
a compile warning from errorprone.

Change-Id: Iaa763f9f48173fd39831a17485ae9ac70dc0cf98
Reviewed-on: https://chromium-review.googlesource.com/745244Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512897}

Bug: 643565
Change-Id: I3ad3aede53c90ba83f630626a6539daa104ef3a9
Reviewed-on: https://chromium-review.googlesource.com/747042Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512896}

We were using the "raw" form of the fragment, meaning that any percent-
encoded fragments would not resolve correctly.

Bug: 779420
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic091e775589fd59d25ad1878115f2ad2593bc733
Reviewed-on: https://chromium-review.googlesource.com/746885Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#512895}

Translators may be null (e.g. for passthrough, or in case of failure), so only
AddRef them if they are valid.

Bug: 779954
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f0039eaf2bdaf76a58e74317af68c13d252bdd5
Reviewed-on: https://chromium-review.googlesource.com/746993Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512894}

On tablets where first run experience activity shows in a dialog, there
is a UI glitch (flash of white) when ChromeTabbedActivity (or any similar
fillscreen activity) transitions to FRE.

CTA transitions to FRE in onCreate(), aborting CTA launch and canceling
currently running window animation midway. By the time onCreate() is
called, the CTA window is already partially visible, so its removal is
perceived as a flash.

This CL introduces TabbedModeFRE activity, which has the same background
as CTA, but renders its content in a FRE-like dialog on tablets. Because
the background is the same, transition from CTA window looks smooth, and
since content is laid out as a dialog, the end experience looks like FRE
dialog appearing on top of starting CTA activity.


Bug: 771545
Change-Id: I4709a83de147e04ce94ba319cfa820a2ec6dea17
Reviewed-on: https://chromium-review.googlesource.com/723725
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512893}

This partially reverts
https://chromium-review.googlesource.com/c/chromium/src/+/739743
that added crash code to investigate the BUG.

TBR=dalecurtis@chromium.org,wolenetz@chromium.org
BUG=778363,779379

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I246f7f3f82763b8dc6ae5c00eb01714419e5fdec
Reviewed-on: https://chromium-review.googlesource.com/742229Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512892}

https://chromium.googlesource.com/catapult.git/+log/1aada706148c..764d38bb9584

$ git log 1aada7061..764d38bb9 --date=short --no-merges --format='%ad %ae %s'
2017-10-30 simonhatch Pinpoint - Use google-signin component to do clientside oauth2.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If27f23bf100d587276a00157cbf508965696e5e5
Reviewed-on: https://chromium-review.googlesource.com/747277
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512891}

Bug: None
Test: None, cleanup.
Change-Id: I3c93a64cbd5e998487b8aee729860231d44009e5
Reviewed-on: https://chromium-review.googlesource.com/744323Reviewed-by: catmullings <catmullings@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512890}

There are duplicated lines of _autocorrectionType but the second one is
supposed to be _keyboardAppearance. UIKeyboardAppearanceDefault is the
default value so we weren't seeing bugs before.

Change-Id: I3c91a3496e62f778259c13fd6132ffbc28633ebd
Reviewed-on: https://chromium-review.googlesource.com/744979Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512889}

This reverts commit 844a031c.

Reason for revert: This CL causes failures when generating Xcode project on iOS platform, please see comments inline.

Original change's description:
> [GN] Remove a duplication of a source type check
> 
> There was a duplication of the source type checking. It may lead
> errors when a type set will be changed for a language.
> 
> R=​dpranke@chromium.org
> 
> Bug: None
> Change-Id: Ieab8885899446e625cfe20c1650418a085b937ee
> Reviewed-on: https://chromium-review.googlesource.com/702414
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506763}

TBR=dpranke@chromium.org,vladbelov@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I5dd0a68f9dd9ac1edd6b94e248bdf5959f83b3ab
Reviewed-on: https://chromium-review.googlesource.com/747087Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512888}

Should be a handful of trivial layout test changes.

By adding and using the srcover_bgra_8888, one of the cc unit test golden images
needs to change just a little bit (literally, one bit of one pixel as far as I 
can tell).  This new fused stage does the srcover blend math in [0,255] bias 
instead of [0,1], so the rounding can change ever so slightly.

Change-Id: I5e2d526496b030d06e5820dd9f3dd56a1fc571f6
Reviewed-on: https://chromium-review.googlesource.com/737859Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512887}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/61050011..540ab10e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0f337fbe63b7f6435c0965c1fad63e3851122edd
Reviewed-on: https://chromium-review.googlesource.com/746376Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512886}