- 16 Jan, 2020 40 commits
-
-
Stefan Zager authored
The presumptive scenario is remote iframe inside a throttled iframe inside an active top document. The top document runs a lifecycle update, which succeeds (i.e., the return value from LocalFrameView::UpdateAllLifecyclePhases is 'true'); but the middle frame is throttled and doesn't update, so we can't do a hit test on it. In that case, just give up on trying to compute occlusion information. BUG=1041252 R=chrishtr@chromium.org Change-Id: If7fadc9daf033bceda9f8a01edc6c3cabf71c066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003259Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#732489}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5bddf6a45982..b446206d9331 git log 5bddf6a45982..b446206d9331 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 mathias@chromium.org Make sort test work as intended 2020-01-16 mathias@chromium.org Simplify regular expressions in utilities.js 2020-01-16 tvanderlippe@chromium.org Migrate workspace_diff/ to ESM internally 2020-01-16 tvanderlippe@chromium.org Remove Puppeteer installation Created with: gclient setdep -r src/third_party/devtools-frontend/src@b446206d9331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1032561,chromium:848823 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id793bdb8aa8b1d1a0e42c607711072864d614fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732488}
-
Markus Handell authored
This change brings the MediaRecorder onstart behavior to spec compliance, as per https://github.com/w3c/mediacapture-record/pull/190. The change carries updates to web tests related to the following: - PeerConnection MediaRecorder tests have been added to cover the both spec wording related to avoiding transcoding and the normal transcoding use cases. - A test that shows that audio recording cannot happen without a sink tag has been added. - With this change, Chrome passes all the mime type tests. Bug: 1013590 Change-Id: I0001673fce20e995a3fe67336a7c9e87d70adc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893855Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#732487}
-
yilkal authored
This cl updated supervised user error page strings. Bug: 850328 Change-Id: I5d4f888cbb81e3da137c82a48837c882a6b3cb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002681Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#732486}
-
Wenyu Fu authored
Two of the files are serving as util classes to the rest of of the components, merging them into one for the visibility and less redundancy. Change-Id: Iec5a039d7caeaa9ef78f7e7dfcb1b82caef63117 Bug: 1042487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003923 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732485}
-
Dmitry Gozman authored
When we have created incognito profiles managed by DevToolsBrowserContextManager and did not explicitly close them before shutdown, we keep these profiles and their browser windows open. This leads to forceful renderer process terminations and crash notifications shown to the user. To fix this, we manually close all browser windows when original profile is gone. Bug: none Change-Id: I3befc91e6c8ed6ab7baf9b4af0ef92377bf38ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001262Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732484}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 1041419 Change-Id: I3d2049d684bba4a4a5bb99837af05479793564b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997704 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732483}
-
gogerald authored
This CL also fixes the new tab button is missing on start tab switcher surface. Screenshots: https://drive.google.com/a/google.com/file/d/1R4_oyeIz6_VuwMellLzPI7zQ2ef04AWX/view?usp=sharing https://drive.google.com/a/google.com/file/d/1R0ASrrY8v50Z9E2bbGI-al_kKrjlI16p/view?usp=sharing Bug: 1042006 Change-Id: Ie9663daf6cc0cb32c63975d65adfce9bb990ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003289Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#732482}
-
Francois Doray authored
This histogram will be used to assess the impact of window occlusion, which is not shipped yet. Fixed: 1037420 Bug: 1037420 Change-Id: Iaa565ef3ef0b57b16bc9c83b6f9b81030a49b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002941 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732481}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=palmer@chromium.org Bug: 1041419 Change-Id: I412b3025323df87cc68c59dfd79d5c2f83e5c242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997997 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732480}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=aleventhal@chromium.org Bug: 1041419 Change-Id: Iac2cd6da8c44de88fadf500b6cd3f34ba5016a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993856 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732479}
-
Adithya Srinivasan authored
Prevents focus from advancing inside a portal frame from the renderer process, and adds an security check in the browser process. Bug: 1030838 Change-Id: I1e82d2163142ba357aa4d7adb4f0b66d0fb5b676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951767 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
This reverts commit 7e9c0cd6. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1042758 Original change's description: > Optimize disabling ARB_texture_rectangle > > In https://crrev.com/c/1991969 I added a new, faster way to disable > ARB_texture_rectangle support in ANGLE's shader translator. This change > starts using it in Chrome, replacing the earlier change introduced in > https://crrev.com/c/1842223 > > Bug: angleproject:3770 > Change-Id: Ica718828581b49efc34230f9f53f28fdec77eb67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732221} TBR=geofflang@chromium.org,kbr@chromium.org,jdarpinian@chromium.org Change-Id: If28e90472d21c3f3f1dbfb01abdd8102dc413258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003030 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#732477}
-
Ionel Popescu authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL adds an inner 2px padding to the focus ring in order to improve its visibility. For now the inner padding is used for all elements, but this is going to be refined based on feedback. Bug: 1026553 Change-Id: I890118cce5f86c53ae410316bbf315ee1a2874c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995887 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#732476}
-
Chris Hamilton authored
This is analogous to the Java org.chromium.content_public.MessagePort and is the interface that embedders should use for talking to Javascript. It hides away the fact that the implementation is currently via Mojo, and allows the implementation to be changed without changing embedder code. A further CL will rework the Fuchsia code to use this instead of raw mojo message pipes, before subsequently flipping over all clients to use MessagePortDescriptors internally. BUG=980533 Change-Id: I4a68ed51179c96bae4b12b7001cecb686302973d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978944 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732475}
-
Caleb Rouleau authored
Also remove gpu_perftests isolate target since it apparently isn't used anymore as a result of this change (plus the work in crbug.com/921353 set this up to be run on Nexus 5 as part of the performance_test_suite isolate) (and PRESUBMIT told me to). Bug: 1042439 Change-Id: I35518250466a68ebcaa0a2c195f8ffdc8d4dd8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003767Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732474}
-
Tom Anderson authored
|event_task_runner_| may be nullptr when the browser is passed both --single-process and --disable-gpu, so a null check is needed. R=msisov Change-Id: Ic045be1a70dfa98f269f47df7b9ccbb553a181d7 Bug: 1042170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004073 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#732473}
-
Raul Tambre authored
Doing the encode() when writing the file avoids needing to add it to all callsites. Removed where it was previously added. There should be no behavioural changes. Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 464, in GenerateFiles self.WriteWithComment(self._GenerateModuleSharedHeader(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 234, in WriteWithComment self.Write(contents, filename) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 226, in Write WriteFile(contents, full_path) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 115, in WriteFile f.write(contents) TypeError: a bytes-like object is required, not 'str' Bug: 941669 Change-Id: I0669c2021e71077f28f156a3e055e5746da246c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994882 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#732472}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 1041419 Change-Id: I8881810cdb7a748263c8cef903207d92f45c2d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997902 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732471}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pennymac@chromium.org Bug: 1041419 Change-Id: I1c20f1c82c2897118b67995697eae165a2f35d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995846 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732470}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1041419 Change-Id: Ia5c37b7458d97cc02b04c25a073c8027e37688f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997699 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732469}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jsbell@chromium.org Bug: 1041419 Change-Id: I9bd76424e221848d518996431fd4e9fd2381725f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998037 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732468}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=palmer@chromium.org Bug: 1041419 Change-Id: I6a009e9f579bd7536f7ac24518c506823d792a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997993 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Roger Tawa authored
Bug: 999150 Change-Id: I7f2d8ea797f06fde21713e47f18528218e56c115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935837 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=msw@chromium.org Bug: 1041419 Change-Id: Id5fd33ee7d25b36a3197b763f8c08d3f5cdd24c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998032 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732465}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1041419 Change-Id: Ic101be4bcd915eee3dfdd21fa4b81df1fd63aac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997810 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#732464}
-
Mike Wittman authored
This reverts commit 3b0ecec8. Reason for revert: the original change doesn't seem responsible for the flaky Clusterfuzz CHECK failure. The flakiness actually got 25x worse with the revert in place. Original change's description: > Revert "[Sampling profiler] Minimize use of loader lock on profiled threads" > > This reverts commit bab78c6c. > > Reason for revert: temporarily reverting to check whether this CL triggered the flaky Clusterfuzz CHECK failure in https://crbug.com/1034896. > > Original change's description: > > [Sampling profiler] Minimize use of loader lock on profiled threads > > > > Saves off the function pointer obtained from ntdll.dll so that we don't > > need to repeatedly query its module handle and take the loader lock > > while doing so. > > > > Bug: 1028808 > > Change-Id: I25c0dd2872524a28a87df7c4bf2db7551eab6311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940882 > > Auto-Submit: Mike Wittman <wittman@chromium.org> > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#719811} > > TBR=wittman@chromium.org,brucedawson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1028808, 1034896 > Change-Id: Ifbda46060fbac279bee2289a6ac8f1df6afb0cbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998008 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730687} TBR=wittman@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028808, 1034896 Change-Id: If72cdc37cb7b6f22331220f840785ae1c902cd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003367Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732463}
-
Alison Maher authored
It was discovered that creating a custom layout for an element with only text as children causes a crash. This reason being that these text children were not getting blockified. To fix this, LayoutNGCustom::AddChild()/RemoveChild() should go through LayoutBlock::AddChild()/RemoveChild() in the above case to ensure that the text children become blockified. (https://chromium-review.googlesource.com/c/chromium/src/+/1745396/12/third_party/blink/renderer/core/layout/custom/layout_custom.cc) Bug: 1038501 Change-Id: I0816dab025f70613634a7c968f3d8abfe46ae01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992213Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#732462}
-
Gayane Petrosyan authored
Removes all the flags and finch features used for Richer Picker/Colors launch. It also removes Colors related configs passed to JS, but defaults to true for Richer Picker config. Richer Picker bit is a bit more complicated to remove and will be done in follow up. Bug: 1022548 Change-Id: I87522150028d063d756961d44314ad9ed8bfa61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003074Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#732461}
-
Gayane Petrosyan authored
screenshot: https://screenshot.googleplex.com/7195BT4gJFQ.png Bug: 993920 Change-Id: Id6d013e7046c8cdb59c0cbf79836188fb4d9962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953568 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732460}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=schenney@chromium.org Bug: 1041419 Change-Id: I18cfb646296e2ba5ed9edda14e7a51ffb7990712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998687 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#732459}
-
Jan Wilken Dörrie authored
TBR=masonfreed Bug: 1042694 Change-Id: Ia8dadfe7f64d50deb2caeca8d4159f3e351b1de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002817Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732458}
-
Connie Wan authored
Similar to crrev.com/c/1975035 Change-Id: I3a124fee1dc82932301a8bcf16b6a0b5628ee61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003356 Auto-Submit: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732457}
-
Markus Handell authored
This change adds an additional unit test for the case encountered in crbug.com/1040339. It's verified to crash if the fix for 1040339 is reverted. Bug: 1040339 Change-Id: I940aef360589eb917b49e91f6eb84ad4014e0e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003175Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#732456}
-
Stefan Zager authored
This adds a fast path for the common case of an IntersectionObserver where the root element is a scroller, observing elements that scroll with the root's contents. In that case, we cache the state of the target's geometry prior to applying the scroll offset and clip of the root element. For subsequent intersection calculations, if the only thing that has changed is the scroll offset of the root element, we can use the cached geometry and just apply the new scroll offset, skipping a lot of heavy lifting. Running a release build of chrome on my linux workstation, this patch decreases the running time of perf_tests/intersection-observer/scroller.html by ~60%. Note that this optimization does not affect implicit-root observers, even for targets in the top document. It should be possible in a future CL to extend the cache-ing mechanism to handle that (even more common) case. Change-Id: I104672703783835bb9f85c637cefad802ba2b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972784 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732455}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mattreynolds@chromium.org Bug: 1041419 Change-Id: Ib1ee8d1b1861e40d422f5836045216d36822f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997956 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
kylechar authored
//ui/compositor doesn't need a dependency on //components/viz/service. Only test code should have the dependency at this point. Remove unused includes and dependency. Also make //components/viz/service and //components/viz/host have a public_dep on //components/viz/common. //components/viz/client already has the appropriate public_dep. Bug: 936425 Change-Id: Icbcb2a23a897be68c09d8a544a2cc29243b1ea53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000330Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732453}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59e7ca81..c06633ee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7598fc79e64e1b74ed384ef9955782fe00063588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004693Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732452}
-
Vladimir Levin authored
This patch ensures that we don't enter infinite recursion when trying to text-fragment navigate in a document that has locked subtrees. R=bokan@chromium.org, chrishtr@chromium.org Bug: 1041866 Change-Id: I6c0a7be555fb8b78a8332ccbfe9fc09e48c9d7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001389Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1041419 Change-Id: I4b2a38df9f4ec3c86b5cf57380f44a1bd271a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994439 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732450}
-
