- 17 Oct, 2019 40 commits
-
-
Miyoung Shin authored
This CL converts AndroidOverlay{Ptr, Request} in media to the new Mojo type, and uses pending_receiver<AndroidOverlay> in android_overlay.mojom. Bug: 955171 Change-Id: I2b9e348196879baf63003f7c94dbaf5c79bfc2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865154 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706812}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a0049f96a77..6e48505301f4 git log 2a0049f96a77..6e48505301f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ukai@google.com put goma client in depot_tools Created with: gclient setdep -r src/third_party/depot_tools@6e48505301f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: I56312f235f0bcf4e91112f6f8e52df6e16da4b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706811}
-
Miyoung Shin authored
This CL converts AndroidOverlayClient and Binding<T> in media to the new Mojo type, and uses pending_remote<AndroidOverlayClient> in android_overlay.mojom. Bug: 955171 Change-Id: I1c224864438978fb4445c4c57cb7ec4099534ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865152 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
This CL converts AndroidOverlayProvider{Ptr, Request} in content and media to the new Mojo type. Bug: 955171 Change-Id: I77b964ffa895c4e1260f25f8e8de1a9c1b8e9348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864775Reviewed-by:Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 969596 Change-Id: I7c7f209b7bad770fe94ae6d7baeaec57e3d329a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864754Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706808}
-
Miyoung Shin authored
This CL converts AudioDecoder{Ptr, Request} in media and content to the new Mojo type, and uses pending_receiver<AudioDecoder> in interface_factory.mojom. Bug: 955171 Change-Id: I6a5cdc5a6c7c41be286baa8cd7235cb6adf33e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864787Reviewed-by: -
Xiaocheng Hu authored
CompositeEditCommand::MoveParagraphs() serializes part of the DOM tree, remove it, and then re-parse and reinsert it at another place. Currently, this may result in unexpected script running, including XSS injections. As there's no valid use case of putting script inside contenteditable, this patch simply blocks scripts from being parsed here to ensure no unexpected script running. Bug: 1011950 Change-Id: I542538ee864535f1253d7f09a929d5dcfe598ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863757Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706806}
-
Yuki Shiino authored
Introduce TextNode, which is just like LiteralNode, and abandon SimpleNode. This patch could be interpreted as replacement of SimpleNode with TextNode. SimpleNode was introduced in constrast with SequenceNode, but it doesn't make a good sense now IMHO. LiteralNode and TextNode make better sense. Bug: 839389 Change-Id: I9cd4b3f66658443eb1ae88a8e183e559fa36ef20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863049 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706805}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e27799ab. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I2d43185949ac176f04aefa3fe02ff6659f65dffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866031Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706804}
-
Carlos IL authored
The actual mixed-autoupgrade document still needs to be updated before launch, this just changes the console strings in chrome to remove the experiment wording. Bug: 872446 Change-Id: If6c9ca4ac1926daa8627176949783313adb9d992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865398 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#706803}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97afd2e21cbf..d5153bb05a6b git log 97afd2e21cbf..d5153bb05a6b --date=short --no-merges --format='%ad %ae %s' 2019-10-17 hcm@google.com update formatting, add links Created with: gclient setdep -r src/third_party/skia@d5153bb05a6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I09cdffbf02e095fd46ffe510aa0df0cda548c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866272Reviewed-by:
-
Giovanni Ortuño Urquidi authored
We are seeing instances where the OS Settings apps fails to be installed because the extension got disabled. Adding logging to figure out the reason why the extension got disabled. Bug: 1014166 Change-Id: Ic13505048e6bdb2b0657d63658f2e5c35b42938c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866095Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#706801}
-
Roman Sorokin authored
So we won't miss it TBR=antrim@chromium.org Bug: 1000606 Change-Id: Ib52151c761b269d253c62a0e08b8c54f657e6709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864773Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706800}
-
Takashi Toyoshima authored
After the enterprise policy change, NetworkContextParams needs to set enable_cors flag to enable the OOR-CORS even for testing. Following tests failed at linux-oor-cors-rel bot. - NetworkContextTest.HangingHeaderClientAbortDuringOnHeadersReceived - NetworkContextTest.HangingHeaderClientAbortDuringOnBeforeSendHeaders Bug: 1015289 Change-Id: I2c2dd3cd205e5e7b4520895bb3403a76a01750da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865926 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706799}
-
David Grogan authored
NG had BoxPainterBase subtract the borders, which does so without paying attention to collapsed borders. Legacy subtracted the (collapsed) borders first, then passed the results to BoxPainterBase. This patch ports that behavior to NG. Bug: 1006241 Change-Id: I61b0f464f0e63d1dac84239e1e45a596cbad1cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862721 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706798}
-
Yutaka Hirano authored
Add histograms for the size of the URL and request headers of each keepalive request. Bug: 952452 Change-Id: I224eb0df8ddd4142f4e7a2045a41ab0007baefa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864507 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#706797}
-
Noel Gordon authored
cr.ui.Tree assumes the rowElement of the TreeItem is one to indent via style (padding-inline-start) to give the appearance of a tree. The inner structure of TreeItem is known to the using app and it might be that a child element the rowElement should be indented, and not the rowElement itself, to give the appearance of a tree. Allow cr.ui.Tree/TreeItem using apps to customise TreeItem's row style using an optional rowElementDepthStyleHandler. No change in behavior, no new tests. Bug: 992819 Change-Id: Ifb5762ed97b265602df2e50e482045fd5d3f3151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859796Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706796}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/edf765329fe2..730cf55c47c3 git log edf765329fe2..730cf55c47c3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 saklein@chromium.org SdkService: Add delete endpoint. 2019-10-17 jrosenth@chromium.org lib/git: return unicode strings by default 2019-10-17 jrosenth@chromium.org lib/git: rename pretty parameter to Log to format 2019-10-17 jrosenth@chromium.org lib/gob_util_unittest: remove HTTP 409 test 2019-10-17 jrosenth@chromium.org lib/gob_util_unittest: Open temporary file in w+ mode Created with: gclient setdep -r src/third_party/chromite@730cf55c47c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If5d0ebeb08bbe9eddf85ac6982a018a709a0ed9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865047Reviewed-by:
-
Hirokazu Honda authored
This is a follow up CL of crrev.com/c/1855142. The CL causes failures in image_processor_test, because a layout of planes is not specified in ImageProcessor initialization, and the adjusted planes are not exposed in LibyuvImageProcessor. This CL fixes those mistakes. Bug: 1005636 Test: image_processor_test on atlas Change-Id: I481d0ca8d276721103030a9ba89d2b590050885d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863065 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#706794}
-
rhalavati@chromium.org authored
Tab.Count.Incognito UMA was previously added in crrev.com/c/1647854, but the Android implementation was missing. It is added in this CL. Bug: 966747, 1014018 Change-Id: I1f51550d7ad6844a0f53039a00625d33b53fcf69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863799 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#706793}
-
Maksym Onufriienko authored
Example of error: https://chrome-swarming.appspot.com/task?id=47e61333eed2f710 Bug: 1011851 Change-Id: I598615ac07cac20294e7171f81c6fb1ec07ed2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862245Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706792}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7f426898efe0..31bde9585709 git log 7f426898efe0..31bde9585709 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 enga@chromium.org perf_tests: Replace WaitForGPU with maxStepsInFlight argument Created with: gclient setdep -r src/third_party/dawn@31bde9585709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I1741c81ea8ecbdff7ed22796e9490754e690c137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865046Reviewed-by:
-
Hiroshige Hayashizaki authored
Before this CL, only `imports` parts of import maps were tested. Chromium side: - This CL makes ImportMap::ToString() to output the whole import map, rather than only the `imports` value. - This CL removes white spaces for pretty printing, to simplify the logic. WPT side: - This CL checks the whole import maps in `jest-test-helper.js`. - Reflect the upstream changes in https://github.com/WICG/import-maps/pull/190 to `builtin-support.tentative/imported/resources/parsing-scope-keys.js`. Test expectation changes: - This CL exposes new test failures in `parsing-scope-keys.tentative.html` on Chromium due to the spec-inconformant behavior of Chromium's URL parser. - Other test expectation changes are just converting `x` to `{imports: x, scopes: {}}`. Bug: 990561, 927181 Change-Id: Ic6a0171298636170d2fd96db2ac1a8d60e3ff345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863854Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706790}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91024cf94428..6ee22f8f2e9b Created with: gclient setdep -r src-internal@6ee22f8f2e9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I61b1e58bf0c20eaec2bfaa4b36913dfa52913f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865706Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706789}
-
Kuo Jen Wei authored
For photo mode, filter out preview size exceeding screen size. For video mode, follow order of preferred resolution, 1080p, 720p, rest of resolution sorted by size. Bug: b/142523663 Test: Verify preview resolution used in photo and video mode are correct. Change-Id: Iadb5c70ff00a65ee6cdbc4d71b790d7567d8b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864508Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#706788}
-
Alan Cutter authored
This CL implements the final part of the ManifestUpdateTask process where the web app is reinstalled with new manifest data. Bug: 926083 Change-Id: I291b64d3e7c05b24a50761acc40ee4d007821a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811402 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706787}
-
Simon Que authored
Previously this was reverted due to infrastructure issues that have since been resolved. This CL is the same as the previously landede CL: https://chromium-review.googlesource.com/c/chromium/src/+/1780983 ============================================= CI/try builders migrated: - mac-code-coverage-generation - mac-hermetic-upgrade-rel - mac-mojo-rel - mac-osxbeta-rel - Mac Builder / mac-rel, mac_chromium_10.12_rel_ng, mac_chromium_10.10, mac_chromium_compile_rel_ng - Mac Builder (dbg) / mac_chromium_dbg_ng, mac_chromium_compile_dbg_ng - GPU Mac Builder / mac-rel See migration schedule of when this is expected to land: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I6d19e6043b3d1776321e512a348395c325ed3484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860856Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#706786}
-
Kazuki Takise authored
We don't want to apply ComputeFlungPosition() for PIP resize. send a wrong bounds at the end of resize anymore. Bug: b/142105182 Test: Resized a PIP window very quickly and confirmed Chrome didn't Change-Id: Ie1d6b1288f4ff16175ee013edbc5dd2e3660f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849750Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#706785}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9e4f6d03f2f7..a959deb00750 git log 9e4f6d03f2f7..a959deb00750 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 johnkslang@users.noreply.github.com Merge pull request #1933 from dj2/runtest Created with: gclient setdep -r src/third_party/glslang/src@a959deb00750 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: I97b1b86b20b98748613685503c3d498687cee636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866025Reviewed-by:
-
Jinsuk Kim authored
The public method |initialize| is deliberately separated from the constructor as an initialization step that gets TabObserver-inherited objects notified to do their own initialization. This CL makes the API package-private and moves it into TabBuilder to reduce its visibility. There is no functional change in the behavior. Bug: 995903 Change-Id: Ibdde4bb257c532e5a29a1e6650329ef219374df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843994 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706783}
-
Joey Arhar authored
Previous to this CL, and after [1], if a form Submit button had an onclick handler that also called form.submit() and did not call event.preventDefault(), the form would get submitted twice. The second request was eventually cancelled, but not before it hit the network. This behavior is specified in [2], through the "plan to navigate" mechanism. In the case of this bug, the "click" event occurs first, and changes the "planned navigation". Then, because the click handler does not preventDefault(), the default submit action is executed, which changes the "planned navigation", replacing the navigation queued by the onclick handler. Therefore, only the default submit navigation is performed. Note that there are other potential interactions which are less clearly specified, and which are not addressed in this CL. For example: <iframe id="test" name="test"></iframe> <form id=form1 target="test" action="click.html"></form> <a target="test" onclick="form1.submit()" href="href.html">Test</a> In this case, clicking the <a> link first submits the form (to click.html), and then queues a navigation to href.html. Because the navigation to href.html is specified (in [3]) to "queue a navigation", independently of the planned navigation specified in [2], it is unclear when/whether the form submission should take place. The spec ([4]) does have provisions for canceling existing navigations, but that leaves room for the form to still get to the network in this case, before getting canceled. [1] https://chromium.googlesource.com/chromium/src/+/6931ab86f19aa79abbdd0c1062084e16b5c4f0f6 [2] https://www.w3.org/TR/html52/sec-forms.html#form-submission-algorithm [3] https://html.spec.whatwg.org/#following-hyperlinks [4] https://html.spec.whatwg.org/#navigating-across-documents Bug: 977882 Change-Id: I693f3bdccb17c5e64df75c2e569fab589c02e88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850358 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#706782}
-
Justin Cohen authored
Bug: 987646 Change-Id: Iaa13ee085aec001158ac46151a50d5ab3cbfa46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862994 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706781}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3800252a84f8..edf765329fe2 git log 3800252a84f8..edf765329fe2 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mmortensen@google.com Handle android branch/target/version for boards without android. 2019-10-17 ahassani@chromium.org auto_updater: Retry GetUpdateStatus on failure Created with: gclient setdep -r src/third_party/chromite@edf765329fe2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie2d1a68f6d1c13d8f248403817c0b03ec7c0c79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866066Reviewed-by:
-
Kai Ninomiya authored
Note: Some of the tests in the WebGPU CTS right now require runtime compilation of GLSL to SPIR-V. Those tests are currently excluded from the variants list in cts.html to avoid importing glslang yet. Bug: 984818 # Tracking issue Bug: 1014785 # Expectations bug # Actual WebGPU bugs Bug: 1014734, 1014735, 1014738, 1014740 Bug: 1014744, 1014750, dawn:243 Change-Id: Ibb42565565afd29e428f72cc5f26d149b784cdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860509 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#706779}
-
Alex Keng authored
The current implementation (which uses border-radius: 20px 0px 0px 20px for the value part) has two issues: 1) when the value is large (ex 99%), the flat end overlaps the rounded edge. 2) when the value is small (ex 1%), border-radius doesn't render correctly. (see the associated bug for details) The new implementation achieves the rounded corner effect using clip-path which is applied to a new container div (-internal-meter-clip) added between -webkit-meter-bar and -webkit-meter-*-value. test: fast/forms/controls-new-ui/meter/meter-extreme-values.html Bug: 1013977 Change-Id: I1d50a42bfa9903952664f5f9cac265021e57b642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858295Reviewed-by:
-
Darren Shen authored
We used to have a JSON-based rulebased API, where we needed to escape certain characters in the protocol. We then added an API based purely on Mojo types. However, the code for the JSON one was copied for the Mojo one, so we also escaped certain characters. This means that we actually insert escaped characters rather than the characters themselves. For example, typing "\" gives "\\". We delete the escaping code and add tests to prevent this in the future. Bug: 1014384 Change-Id: I8865869aa020b94c961c71826fa72d6cf2c96b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859809Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#706777}
-
Nicholas Verne authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1862337 This fixes an uninitialized member variable in a test fixture found by msan. Adds UpgradeContainer logic to CrostiniManager. A call to UpgradeContainer can start off a long-running upgrade process via the Cicerone daemon. A dbus signal UpgradeContainerProgressSignal is used to communicate progress to Chrome, including the final success or failure of the upgrade itself. Bug: 930901 Change-Id: I18ae12c5706f9a989c5c8247ca8ba223d25cf41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862883Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706776}
-
Jeevan Shikaram authored
This CL renames the labels of App Management's localized strings to prevent overlap with other settings' localized string labels. It also removes any unused strings. Bug: 1014815 Change-Id: I52b20363b140d1abc7839f763013eeeff6d31513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862888Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#706775}
-
Justin Cohen authored
Record the time taken to read a stored session window, or write one to a file. Bug: 1007337, 1010609 Change-Id: I8f98348c51b8b407b60d9514008431c2fa564d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860303Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706774}
-
Ahmed Fakhry authored
- Make SetEnabledForTest/Dev() simulate a device physical tablet state, which is closer to reality. - This CL also fixes an issue with the overview button, where it should show after transitioning to UI tablet mode finishes. More follow-up CLs are planned for this feature. BUG=925087 TEST=No change in behavior, all tests must pass. Change-Id: I451b40a4f0da5814893d5e2e4cb618d7d4cf2aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865543 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706773}
-
