- 08 Jun, 2018 40 commits
-
-
Tao Bai authored
Bug: 849870 Change-Id: Ib51b8fbb51c107e4cd31910b4c342e8c2186402b Reviewed-on: https://chromium-review.googlesource.com/1091462 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565678}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I4572bf52fb31840cdb6006d8821bc29c2fd071f3 Reviewed-on: https://chromium-review.googlesource.com/1079567 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565677}
-
Rayan Kanso authored
The switch will be deleted in a follow-up CL. Bug: 826257 Change-Id: I288e4bc5050714357c10b2d04e95586e23df44f4 Reviewed-on: https://chromium-review.googlesource.com/1089057 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#565676}
-
Darren Shen authored
Currently Undo/Redo are not added when there are menu items before it. This was to deal with autocorrect/selected text items. However, when we add Emoji as a menu item, we still want Undo/Redo to show. This patch makes an exception for this. Test: Is tested in crrev/1090408 Bug: See crrev/1090408 Change-Id: I960e064e2829e97b61e6fa8be31091dd6f671f24 Reviewed-on: https://chromium-review.googlesource.com/1092214 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565675}
-
Hans Wennborg authored
After upstream change r334036, LSan started printing a warning to stdout, breaking the test expectations. Bug: 850867 Change-Id: I9a5857a3175f7520ffe448f41fb260d5722c62d4 Reviewed-on: https://chromium-review.googlesource.com/1092740 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565674}
-
Elly Fong-Jones authored
This change: 1) Adds focus rings to the tab-close button 2) Moves the new tab button to last in the TabStrip's focus order if it is not in LEADING position so that the keyboard focus order within the TabStrip is correct Positioning the ring for the tab-close button requires some finesse: the tab close button has its margins adjusted, but the focus ring only needs to draw around the visible part of the button. Bug: 848299 Change-Id: I226683d3a8829f5a88e9bf102b4c8ba4ecfae459 Reviewed-on: https://chromium-review.googlesource.com/1091131Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565673}
-
Ben Pastene authored
TBR=jbudorick@chromium.org Change-Id: Ie11ee477222ea041c0f5d558306d52b3b83c2c32 Reviewed-on: https://chromium-review.googlesource.com/1093267Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565672}
-
Xiaohan Wang authored
Fix a copy/paste error in the previous CL. Bug: 849846 Change-Id: I32440d9c8a8e8879f262d6e3b8b51547301fcec2 Reviewed-on: https://chromium-review.googlesource.com/1093271 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#565671}
-
Samuel Huang authored
This reverts commit b1d35c01. Reason for revert: Speculative revert did not fix problem. Original change's description: > Revert "Fix browser menu button flood fill effect always originating from center" > > This reverts commit 25016613. > > Reason for revert: Speculative revert for > virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html > failure under WebKit Linux Trusty (dbg) . > > Original change's description: > > Fix browser menu button flood fill effect always originating from center > > > > The MenuButton::PressedLock used to be always created with a null > > event from MenuController::Run() causing it to eventually call > > AnimateInkDrop() with a null event, which then used to clear > > the inkdrop host's `last_ripple_triggering_event_` which is > > used as the point from which the flood fill is generated. > > > > This CL passes the current located event (if any) to > > MenuButton::PressedLock. > > > > BUG=819878 > > > > Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8 > > Reviewed-on: https://chromium-review.googlesource.com/1089495 > > Reviewed-by: Trent Apted <tapted@chromium.org> > > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#565538} > > TBR=tapted@chromium.org,afakhry@chromium.org > > Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 819878 > Reviewed-on: https://chromium-review.googlesource.com/1092249 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565654} TBR=huangs@chromium.org,tapted@chromium.org,afakhry@chromium.org Change-Id: I6a7b6243c363699a3d7620190409022ba8d58a03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819878 Reviewed-on: https://chromium-review.googlesource.com/1093354Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565670}
-
Vasilii Sukhanov authored
The automatic password generation is still not launched. I checked that the Views prompt works all right on Mac. We are gonna invest time only into the Views UI. Let's make it simpler. Bug: 832676 Change-Id: Ic8bff3d267579df976072cfde762f73054747190 Reviewed-on: https://chromium-review.googlesource.com/1088607Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565669}
-
Rune Lillesveen authored
- Base layout parent computed style on traversing the DOM instead of the layout tree. - Moved top layer check for ::backdrop to CanGeneratePseudoElement(). - Moved CanHaveGeneratedChildren() to layout tree building. This means we may generate pseudo elements which may not generate boxes for their pseudo elements, but the boxes will still not be created. First-letter is still relying on layout objects. Will address that later. Bug: 836126 Change-Id: I4f283a09db597bc44d1b32d1007b4aa65e83f2e0 Reviewed-on: https://chromium-review.googlesource.com/1092692Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#565668}
-
Ted Choc authored
The BookmarkModelObserverTask added a bookmark model observer on a background thread, which is not allowed. In both cases of Remove and Update, there is no need for listening to the observer as we can just track whether we are updating the bookmark node internally. This is consistent with how AddBookmarkTask already worked. BUG=838988 Change-Id: I43bf054b70e78907a99ba2a11fac62df0af6bc67 Reviewed-on: https://chromium-review.googlesource.com/1089497Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#565667}
-
Nico Weber authored
This ensures that the memory and clang tot bots run the same tests as the main waterfall bots. Everything running on the main waterfall must be tested with clang/tot too to make sure compiler updates don't break anything. This change makes it impossible for things to get out of sync (on linux). No behavior change, the chromium_linux_gtests and chromium_linux_clang_gtests were identical already. Also rename chromium_linux_clang_and_gl_gtests to chromium_linux_and_gl_gtests and add a comment for it. Bug: 843511 Change-Id: Idf95d837cdae5247d2011c85f2c19961d29bd195 Reviewed-on: https://chromium-review.googlesource.com/1093062Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565666}
-
sczs authored
This fixes an issue where the section header was being duplicated on collapse/expand. Whenever we collapse and expand a section on iOS10, a sectionHeaderFooterView is added on top of the existing one. This causes the sectionHeaderViews to stack on top of each other leading to bad UI and test failure. More info on the bug link. BUG = 850814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I743d4dff1c81d389f3313fda4d0c92a202fb4b5e Reviewed-on: https://chromium-review.googlesource.com/1092233 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565665}
-
stkhapugin@chromium.org authored
Fixes the tests broken by enabling the refresh location bar, introducing helpers as necessary. Bug: 834345, 821821 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifb767a192c3f4d3f35bf4714768352a83d4a1d99 Reviewed-on: https://chromium-review.googlesource.com/1070147 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565664}
-
Nico Weber authored
Bug: 850464 Change-Id: I06e41f5f1d06d4397182b57883543d8a9e0680bf Reviewed-on: https://chromium-review.googlesource.com/1093063Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565663}
-
Xiaoqian Dai authored
The reason for this crash is when a window is destroying, it's still regarded as an "activatable" window in MRU window list and is then put in overview by SplitViewController::OnWindowDestroying(), which will then cause crash when trying to adjust its bounds in overview. (Currently the crash is only observed on Chrome built on linux workstation, not reproducable on real devices) To fix this, we observe OnWindowDestroyed() instead of OnWindowDestroying() in SplitViewController. Bug: 835925 Change-Id: Ieda91eb3f8ab12e2120365b0804a30aeef8d8f2f Reviewed-on: https://chromium-review.googlesource.com/1091534 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565662}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Change-Id: I8598961fa8007bac98164dfe4ce96cf52e655a5e Reviewed-on: https://chromium-review.googlesource.com/1091148Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565661}
-
Chris Hamilton authored
BUG=749785 Change-Id: Id9e7bf25b421199bdb0f6b0dc41d617792a64bbb Reviewed-on: https://chromium-review.googlesource.com/1093019Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#565660}
-
Sammie Quon authored
Some states were not reset after successful fling. Test: manual Bug: 850806 Change-Id: I826501e6921163b9f5eaa36dd7a1c6d5de940e94 Reviewed-on: https://chromium-review.googlesource.com/1092152Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#565659}
-
Ryan Landay authored
The Android horizontal tab switcher is currently using the same clipping/visibility logic as the existing overlapping tab switcher. This logic is largely unnecessary and is in fact causing a bug in RTL mode when we try to clip a tab from the left side as it goes off-screen (ContentLayer doesn't properly support clipping the live layer in this case). This CL splits up the visibility/clipping logic for the overlapping and non-overlapping tab switchers. For the non-overlapping tab switcher, the only logic we need is a performance optimization to only draw at most four tabs, based on which tab is currently centered. Bug: 849930,831359 Change-Id: Ia000e91b91615acf9f6b071b2d501ee55da231cc Reviewed-on: https://chromium-review.googlesource.com/1091164Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#565658}
-
Carlos IL authored
When iframe upgrades were moved out of crrev.com/c/1067846 and into crrev.com/c/1086005, some non iframe specific code was also moved by mistake, this is that code, along with the tests. Change-Id: I41aece313c1dd6504e9a27bb85fb810c975e8167 Reviewed-on: https://chromium-review.googlesource.com/1091184Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#565657}
-
Ryan Sturm authored
This adds frame pausing when new frames are created. This also changes the browsertests to use the infobar. Bug: 835895 Change-Id: I79d92bd91ad0482f41a26b0f1ceaddd88d798abb Reviewed-on: https://chromium-review.googlesource.com/1091496 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#565656}
-
Alexandros Frantzis authored
Update the 'value' member variable of the DrmProperty class to be a uint64_t since this is the type expected by the DRM APIs. Bug: None Test: Chrome on Ozone-DRM Change-Id: I51fe25d1d70e0ffbeda72312b8910c1dd8d41527 Reviewed-on: https://chromium-review.googlesource.com/1091317Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#565655}
-
Samuel Huang authored
This reverts commit 25016613. Reason for revert: Speculative revert for virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html failure under WebKit Linux Trusty (dbg) . Original change's description: > Fix browser menu button flood fill effect always originating from center > > The MenuButton::PressedLock used to be always created with a null > event from MenuController::Run() causing it to eventually call > AnimateInkDrop() with a null event, which then used to clear > the inkdrop host's `last_ripple_triggering_event_` which is > used as the point from which the flood fill is generated. > > This CL passes the current located event (if any) to > MenuButton::PressedLock. > > BUG=819878 > > Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8 > Reviewed-on: https://chromium-review.googlesource.com/1089495 > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565538} TBR=tapted@chromium.org,afakhry@chromium.org Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819878 Reviewed-on: https://chromium-review.googlesource.com/1092249Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565654}
-
Christian Fremerey authored
This reverts commit 53e1a9c3. Reason for revert: This appears to cause compile to fail on several Android builder bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc.fyi/Android%20Builder/16413 Original change's description: > Created @TraceEvent annotation and corresponding processor > > When a method has the @TraceEvent annotation, it will be transformed to include > TraceEvent.begin() and TraceEvent.end() at the start and end of the method. > The function body is moved to a new helper method, while the old function's new > body looks like the following: > ``` > TraceEvent.begin("Foo.bar"); > try { > wrappedByTraceEvent$bar(); > TraceEvent.end("Foo.bar"); > } catch (Throwable e) { > TraceEvent.end("Foo.bar"); > throw e; > } > ``` > > Used the following code to test building various methods: > ``` > @TraceEvent > public static void basic() {} > > @TraceEvent > public void takesArguments(boolean arg1, long arg2, float arg3) {} > > @TraceEvent > public int returnsPrimitive(int arg1, byte arg2, Object arg3, TraceEvent arg4) { > return 10; > } > > @TraceEvent > public Object returnsObject(char arg1, short arg2, double arg3) { > return null; > } > > @TraceEvent > public int throwsError() throws Exception { > throw new Exception(); > } > ``` > > Bug: 818267 > Change-Id: I11127203662bf84de4a890da29a09676e760e621 > Reviewed-on: https://chromium-review.googlesource.com/1066173 > Commit-Queue: Tiger Oakes <tigero@google.com> > Reviewed-by: Biao She <bshe@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565624} TBR=bshe@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tigero@google.com Change-Id: I211510f4d7e1d301ad8982f5190972730ddbec1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 818267 Reviewed-on: https://chromium-review.googlesource.com/1092248Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565653}
-
Christopher Thompson authored
This simplifies history backend tests where some page transitions types were created with FromInt(GetQualifier(TYPED)), which is equivalent to simply using PAGE_TRANSITION_LINK directly (as the qualifier bits are all zero). However, semantically these tests make more sense using TYPED transitions in these cases (although the outcome of the tests work either way). This is followup work from comments on crrev.com/c/1048826. Change-Id: Ief02ad7fde7a92f05ebaf9b30ad58886cc5d1672 Reviewed-on: https://chromium-review.googlesource.com/1091273Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#565652}
-
Chris Lu authored
This will visualize the world default favicon for collections that use FaviconLoader. Bug: 847795 Change-Id: I0d0b3cfacd79bcf0510bed3b98397cc00ee57c6d Reviewed-on: https://chromium-review.googlesource.com/1089882Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#565651}
-
Marc-Antoine Courteau authored
- only disables the "spellcheck" section when spellchecking is disabled by policy, but not if disabled by the user; - disables the context menu entry if spellcheck is enforced by policy. This is a second attempt at landing this. The first attempt was reverted due to the CrSettingsLanguagesPageTest.Spellcheck test failing. Bug: 814318 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8f3da717f63ca00eedd82deff8fdbe6d60b10e34 Reviewed-on: https://chromium-review.googlesource.com/1091175Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#565650}
-
Xiaohan Wang authored
Now the CDM is not running in a plugin, there's no need for MediaBrowserTest to watch for plugin crash. For the record, see the original CL that added this: https://codereview.chromium.org/206693004 Bug: 772160 Test: Remove obsolete code. No functionality change. Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7 Reviewed-on: https://chromium-review.googlesource.com/1091888Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565649}
-
Kyle Milka authored
Change-Id: I15ff2424bbc5773eae3bbfe847a83d574eceb066 Reviewed-on: https://chromium-review.googlesource.com/1093014Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#565648}
-
Eric Boren authored
Bug: skia:8060 Change-Id: I7440c4560c788a2c179ddf43fbde8bd9a121272b Reviewed-on: https://chromium-review.googlesource.com/1092751Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#565647}
-
Daniel Bratell authored
There were two small (identical) helper functions in content/browser named CreateMemoryCoordinatorHandle(..). One in gpu and one in render_host, and with no obvious place to put a shared copy. These two cause problems in some extreme jumbo configurations so this patch renames them according to how they are user. Change-Id: I508530b6290606a01046ec0378d8da7d9f8c164b Reviewed-on: https://chromium-review.googlesource.com/1092696 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565646}
-
Kyle Milka authored
When the browser is resized to be very narrow the picker should resize to two columns. Bug: 850338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If73628d85df3bba6860a03949cdfa8b995651264 Reviewed-on: https://chromium-review.googlesource.com/1090997Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#565645}
-
Navid Zolghadr authored
Bug: 797860 Change-Id: I8b9fd75051fa22040ff81defe252eb6de62c0b91 Reviewed-on: https://chromium-review.googlesource.com/1091690Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565644}
-
Steven Bennetts authored
This CL fixes a number of inconsistencies with input style and overall dialog appearance. Bug: 832177,829272 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb5bdd4245073d3c8db5100ebc3bca1a8b4f1b17 Reviewed-on: https://chromium-review.googlesource.com/1091166 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565643}
-
Raphael Kubo da Costa authored
The platform-specific side is now in services/device/generic_sensor. While here, fix a small typo ("intrefaces" -> "interfaces"). TBR=alexander.shalamov@intel.com Change-Id: I810dce6ba28ad9fc6a5b7417431543df8f4b5a5d Reviewed-on: https://chromium-review.googlesource.com/1093072Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#565642}
-
Matt Falkenhagen authored
The test is slow because it does a lot of registrations and updates. Bug: 850842 Change-Id: I5782e4e426e571a604929da7369c8474ffda88e5 TBR: robertma Reviewed-on: https://chromium-review.googlesource.com/1092958Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565641}
-
Nico Weber authored
Relands parts of https://chromium-review.googlesource.com/c/chromium/src/+/1088754 headless tests can't run on the memory waterfall yet because of bug 844865. This adds them to the linux clang tot bots. (They already run on the mac and win clang tot bots, and on the main waterfall.) TBR=kbr Bug: 843511,843732 Change-Id: Iec20d59c425b9d847fa2d3f076f907b69ba0e795 Reviewed-on: https://chromium-review.googlesource.com/1093051Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565640}
-
Michael Thiessen authored
The static member variable to keep track of whether the black overlay is added can fail when we switch Activities while entering VR when the black overlay is added. In practice without other bugs this should be borderline impossible to make happen, but it crops up now and again, like in the linked bug. We should instead just track the overlay per-activity. Bug: 850741 Change-Id: I8849786972f216d7b628e2c8938579261ecd66b6 Reviewed-on: https://chromium-review.googlesource.com/1091699Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565639}
-