- 27 Mar, 2018 40 commits
-
-
David Valleau authored
R=skau@chromium.org Change-Id: Id5bdb2bc28e96d3eef3fa1cd950f0927b4776ec7 Reviewed-on: https://chromium-review.googlesource.com/981528Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#545981}
-
Ken Rockot authored
WebRequest API only supports exposing information about file and raw byte upload data types. URL requests which include other types of upload data should not result in log spam. Bug: 823488 Change-Id: I9ab9a680bf747dd0867809a6c3aed6a996b8d175 Reviewed-on: https://chromium-review.googlesource.com/980747Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#545980}
-
Sidney San Martín authored
See the bug for screenshots of the problem. Change-Id: I1db68491c72833efd979696cc98359e1c59acdfb Bug: 825848 Reviewed-on: https://chromium-review.googlesource.com/979194 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#545979}
-
Marijn Kruisselbrink authored
Depending on the state the blob under construction is in, the CancelBuildingBlob call in BlobUnderConstruction::TransportComplete could result in BlobUnderConstruction being deleted (via the newly added BlobBuildAborted method from https://crrev.com/543773). This fixes that by verifying that |this| isn't deleted before accessing it again. Bug: 825721 Change-Id: Id1255e755958755fd21e7e0caa7d0a84747b361d Reviewed-on: https://chromium-review.googlesource.com/981081Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#545978}
-
Mike Dougherty authored
Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie3a724f08e5beb6f3aa93b850832bf133a2db240 Reviewed-on: https://chromium-review.googlesource.com/979335 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545977}
-
Bin Wu authored
- The new QuicFlagSaverImpl saves quic flag values on construction and restore them on destruction. - The QuicFlagChecker is currently a Chromium specific class to make sure all quic flags are on their default values. We can move it to platform/api when the need arises. R=rch@chromium.org Change-Id: I12d817d60f3f3b935403f0c6b147cdb3966429cc Reviewed-on: https://chromium-review.googlesource.com/977947 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#545976}
-
https://chromium.googlesource.com/catapult.git/+log/bffbf166f004..767f070f1df4 $ git log bffbf166f..767f070f1 --date=short --no-merges --format='%ad %ae %s' 2018-03-26 eakuefner [Telemetry] Add more diagnostics to benchmark_total_duration 2018-03-26 dtu [pinpoint] Add descriptions to try job dialogs. 2018-03-22 laszio [Telemetry] include story tags in benchmark_runner list 2018-03-26 dproy Get navigation info without using FrameLoader snapshots 2018-03-26 nednguyen Supress Telemetry pylint error 2018-03-26 eakuefner Revert "HistogramSet - Only merge histograms with stories." Created with: roll-dep src/third_party/catapult BUG=chromium:819969,chromium:824761,chromium:819969 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9b5458944cce2430a96f4d92854bed716b4b23ed Reviewed-on: https://chromium-review.googlesource.com/981594Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545975}
-
Shakti Sahu authored
This CL builds on top of the previous CLs where upload support have been added in driver, client, model and entries. There are few changes in controller to enable upload : 1 - Tracking the entries for whom upload data have been requested but not received. A timeout task was scheduled at 30 seconds. 2 - No retry for failed entries having upload. After an interruption or browser restart, we should delete the entry right away. Bug: 812327 Change-Id: Id6ed456272c714af8c6b915e2491827e869d1110 Reviewed-on: https://chromium-review.googlesource.com/919495 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#545974}
-
Yuly Novikov authored
Because BufferSubDataBenchmark.Run/gles_float4_every1 crashes in Adreno driver and it is impossibile to skip just one test on a specific device. TBR=kbr@chromium.org BUG=angleproject:2433 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I94204874b381b7a074f74fb43606c495b9e526a0 Reviewed-on: https://chromium-review.googlesource.com/981553 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#545973}
-
Ken Rockot authored
Lets the test run longer (i.e. until the child actually closes its Channel) before asserting that we receive a message from the child. Bug: 821254 Change-Id: I629d994baf5655899dbd95177b997b97fd112e32 Reviewed-on: https://chromium-review.googlesource.com/981445 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#545972}
-
Clifford Cheng authored
Bug: 826072 Change-Id: Ifb817974924f60bfe68b5304f78f5412a367f154 Reviewed-on: https://chromium-review.googlesource.com/981526Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545971}
-
https://pdfium.googlesource.com/pdfium.git/+log/3ae75c2f2e57..5098b2528487 $ git log 3ae75c2f2..5098b2528 --date=short --no-merges --format='%ad %ae %s' 2018-03-26 hnakashima Reland "Add FPDFAnnot_CountAttachmentPoints" 2018-03-26 hnakashima Revert "Add FPDFAnnot_CountAttachmentPoints" 2018-03-26 hnakashima Do not call CPDF_PageObjectList directly in fpdfeditpage.cpp. 2018-03-26 ralf.sippl Add FPDFAnnot_CountAttachmentPoints Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I05345a1c5c32ead266cf8b49a6e24a6e162059bb Reviewed-on: https://chromium-review.googlesource.com/981447Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545970}
-
Alex Moshchuk authored
Not having FrameReplicationState::has_received_user_gesture in the struct traits caused it to not propagate through IPCs properly, and was caught by a couple of autoplay layout test failures, which had been failing with site isolation enabled. Thanks to mustaq@ for the analysis that led to the discovery of this bug. FrameReplicationState::active_sandbox_flags was similarly missing from the struct traits, so that member is fixed as well. Bug: 794631 Change-Id: I3ebdb51ff887b79c18c4a7c593fac33bb3333a0d Reviewed-on: https://chromium-review.googlesource.com/981306Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545969}
-
https://chromium.googlesource.com/angle/angle.git/+log/822a84b1959f..84fdc62c6160 $ git log 822a84b19..84fdc62c6 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 jiawei.shao Fix a compile error when ANGLE_D3D9EX == ANGLE_DISABLED 2017-10-03 geofflang Implement robust resource initialization for OpenGL. 2018-03-20 oetuaho Clean up checkCanBeLValue 2018-01-27 kbr Update stencil validation rules for WebGL 2018-03-19 oetuaho Rely on hash to check for some mangled name matches 2018-03-23 oetuaho Clarify aliasing rules in CHROMIUM_bind_uniform_location 2018-03-26 geofflang Check result of D3D11 map operation in Blit11::copyAndConvert. 2018-03-22 oetuaho Move ReplaceVariable to tree_util directory Created with: roll-dep src/third_party/angle BUG=chromium:693090,chromium:806557,chromium:823856,chromium:825503 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Ib864a0492b29de58564d5522977c11d6623dad4a Reviewed-on: https://chromium-review.googlesource.com/981675Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545968}
-
Ulan Degenbaev authored
Blink document leak detector has similar coverage. Bug: chromium:775635 Change-Id: I871ee0e8337dde3b326dab75d4d3af9ebb47ebe7 Reviewed-on: https://chromium-review.googlesource.com/980875 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#545967}
-
Alexei Filippov authored
Change-Id: I2e99c62e8316b4ee4f8543275f6e6b20c3035dfc Reviewed-on: https://chromium-review.googlesource.com/978864Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545966}
-
Hirokazu Honda authored
The limitation of the number of concurrent allocated protected buffers in a single ProtectedBufferAllocator is set to 48, expecting 16 for protected input buffers and 32 for protected output buffers. This is helpful to retain ARC++ container from allocating many protected buffers without deallocating previouly allocated protected buffers. BUG=b:72354215 BUG=chromium:804687 TEST=Play Secure video using EXO Player. TEST=GtsMediaTestCases Change-Id: Idabae800a7e87796d83b5bd132f8d6a5fba01bcf Reviewed-on: https://chromium-review.googlesource.com/979673 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#545965}
-
Shimi Zhang authored
A cleanup to use only mContext in AwContents#createContentViewCore() Bug: None Change-Id: I919697bbb6db20d9c957e425b575d8045511ff6d Reviewed-on: https://chromium-review.googlesource.com/981442Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#545964}
-
Avi Drissman authored
BUG=268984 TEST=no changes TBR=sky@chromium.org Change-Id: I80b45655bf30d714458494220bd36fce745e0d98 Reviewed-on: https://chromium-review.googlesource.com/979192Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545963}
-
Matt Mueller authored
Technically, any of the functions which call g_nss_singleton.Get() could end up initializing NSS. Currently EnsureNSSInit gets called first, but that may not always be the case after some of by later changes in this patch chain. (Of course we want to remove the ScopedAllowIO entirely, but this lets us work towards that incrementally.) (ScopedAllowIO is deprecated, so need to skip the presubmit. Can't easily switch to ScopedAllowBlocking since it needs to friend the caller and NSSInitSingleton is in an anonymous namespace.) NOPRESUBMIT=true Bug: 59847 Change-Id: I3d18a2a51a99d9ec7c48303af76383be3910a18c Reviewed-on: https://chromium-review.googlesource.com/965245Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#545962}
-
Joel Einbinder authored
When editing the tag of an Element, the user pressing space indicates that they want to move on to editing an attribute. We have similar logic in the StylesSidebar when the user presses : or ;. Bug: 701336 Change-Id: Ib087a6e5a898ba9fb7c599f3d60ef3126ce66f4e Reviewed-on: https://chromium-review.googlesource.com/976816Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#545961}
-
Bence Béky authored
Also add some unrelated test expectations. Bug: 825231 Change-Id: I04c26e6ddd7ab2ad340ab8dd6f333d5589547a73 Reviewed-on: https://chromium-review.googlesource.com/979092Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545960}
-
Becky Zhou authored
Bug: 822952 Change-Id: I23a567488375f4308cbbef8de63c2ae60c1bcfac Reviewed-on: https://chromium-review.googlesource.com/979259Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545959}
-
Ryan Tseng authored
Bug: 790280, 731523, 790264 Change-Id: Ied8154a60ef959c2d6196213f37da0eaa045107a Reviewed-on: https://chromium-review.googlesource.com/981529Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#545958}
-
Christopher Grant authored
This change restructures URL bar and omnibox code in several ways: - Change all buttons to have transparent backgrounds, such that the UX-specified hover colors look correct. - Enable background color animation on ALL buttons. - Simplify the omnibox into a layout of transparent-background elements, with a single backblane (one element with rounded corners, background color and shadow). - Make better use of layouts to remove instances of anchoring. - Introduce helper functions to translate UX spec colors to constants. BUG=821946 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0dd6c9064cdec520ba45f0ad62aedf8fb4ad1364 Reviewed-on: https://chromium-review.googlesource.com/981050 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545957}
-
khmel@google.com authored
This is required to run finch experiment for dogfooders. Test: Manually + unit test Bug: 824447 Change-Id: I84f8a32df7c40c41e4327d2db709f2998c448113 Reviewed-on: https://chromium-review.googlesource.com/976371 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#545956}
-
Joel Einbinder authored
Input handler was recieving the page scale after a frame was rendered, which caused a race when sending mouse events after the page scale was change but before the next frame was rendered. This patch listens directly to the page scale changes. Bug: 826012 Change-Id: I40ea7342f075aacde762a65dda7f71257f584a11 Reviewed-on: https://chromium-review.googlesource.com/969717 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545955}
-
Robert Sesek authored
There was an off-by-one error in parsing escape sequences. Bug: 825067, 489301 Change-Id: Ic7a99b7c590cc3146b38a35d61e4c980e4e8e9a1 Reviewed-on: https://chromium-review.googlesource.com/981240Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#545954}
-
edchin authored
Previously there was a bug where there was a mismatch of internal states between the page control and the scroll view. It is important that they both are synchronized with the same current page. This CL fixes the lack of synchronization. TBR=marq@chromium.org Bug: 825898 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I284460d9581a05f780057ef53715484254978859 Reviewed-on: https://chromium-review.googlesource.com/981302 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#545953}
-
Ian Vollick authored
With this change you can, via a long press, summon the in-use permissions while in WebVR presentation. In order to distinguish between the initial state when the indicators are shown (web-vr-is-good-to-go/no-long-press) from the state right after releasing the button, we need to know the previous value in the binding, so I've introduced a variant of the setter that can be passed the previous value. Bug: 825354 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad5696607e275169353695bb9d58d2b6a925478f Reviewed-on: https://chromium-review.googlesource.com/978665Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545952}
-
Joshua Bell authored
The [Global] extended IDL attribute is used to mark up types like Window and WorkerGlobalSope that get special treatment, like attribute getters exposed as own-properties rather than on the prototype. This was accidentally applied to a couple of Web Audio interfaces thanks to the magic of copy/paste and obscure documentation, but was revealed by new idlharness tests. Yay tests! Bug: 823431 Change-Id: I1e79a8942e2e6bb9072ac1cf7b5d39ead5f88047 Reviewed-on: https://chromium-review.googlesource.com/969798 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545951}
-
Ehsan Chiniforooshan authored
Startup tracing is broken for several reasons: 1. When renderers are forked from a Zygote process, --trace-startup flags are ignored. 2. In a non-zygote mode, when --trace-config-file is used, it is ignored since sandboxed renderers do not have access to file system. 3. Another bug is that --trace-config-file is always passed to renderer processes, even if they are created after tracing is stopped, e.g. via DevTools. 4. Startup tracing flags are not passed along to the ppapi plugin and utility processes. This CL fixes 1, 3, and 4 and partially fixes 2 by passing categories and record mode of a trace config file using flags to sandboxed renderer processes so that they do not need to ready these information from a file. Obviously, this does not work for complex trace config files, but should be enough to resolve existing telemetry issues (please see discussions in crbug.com/809833). Bug: 809833 Change-Id: I6723664fd477117262763476c0a86fd6881b94a7 Reviewed-on: https://chromium-review.googlesource.com/972145Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545950}
-
Yoshifumi Inoue authored
This patch introduces tests for hanling of "inline-block" and "float" of |TextIterator| to avoid regression for improving code health. This patch is a preparation the patch[1]. [1] http://crrev.com/c/737981 Simplify word granularity handling Bug: 778507 Change-Id: I9259afac827cbfdd95a60da7d10c9e0844235e54 Reviewed-on: https://chromium-review.googlesource.com/979748Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545949}
-
Charlie Harrison authored
Bug: 648992 Change-Id: Ida40b9d927d851af5d8ba700bfd6a6aeb41281d6 Reviewed-on: https://chromium-review.googlesource.com/977952Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545948}
-
Daniele Castagna authored
With crrev.com/c/964984 we always scanout an opaque fb when we're using legacy KMS. HardwareDisplayPlaneManager::IsCompatible was still testing that scanout buffer was compatible using a non opaque format. This caused issues when we landed crrev.com/c/976961 and would cause pageflip on samus (RGBA not supported) to fail. This patch overrides HardwareDisplayPlaneManager::IsCompatible for the Legacy HardwareDisplayPlaneManager and checks using the opaque format. Bug: 821944, b/74997524 Test: samus ui with crrev.com/c/976961 works. Change-Id: I6fd77ba55832a2d77d1652e81a77f1f0555cffa1 Reviewed-on: https://chromium-review.googlesource.com/981239Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#545947}
-
Tim Zheng authored
This is an initial implementation of the integration of Crostini apps onto the Chrome OS shelf. With this change, when a Crostini app starts to run, a new shelf item will be added to manage it. The icon will be the default Crostini app icon. Coming changes will identify specific Crostini apps and use their respective icon when possible. Design Doc: go/crostini-shelf BUG=chromium:819444 TEST=Manually tested on an eve device. Change-Id: Ibe5c731ffd602a493caa49a4928ddeba253a2663 Reviewed-on: https://chromium-review.googlesource.com/965586Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545946}
-
Matt Reynolds authored
This reverts commit 4e043583. Reason for revert: Broke geolocation for NetworkLocationProvider Original change's description: > Reland "Move WifiPollingPolicy to a global instance" > > This is a reland of bd9b9ea0 > Original change's description: > > Move WifiPollingPolicy to a global instance > > > > The WifiPollingPolicy controls how frequently the network location > > provider will initiate Wi-Fi scans. Previously, the policy was attached > > to the WifiDataProvider, which is destroyed when there are no active > > geolocation API calls. Destruction of the provider causes us to lose track > > of our polling policy. > > > > The policy allows the first scan to be performed immediately and schedules > > subsequent scans at regular intervals. When the provider is destroyed and > > recreated rapidly it considers each scan to be "first", which allows many > > Wi-Fi scans to be performed in a short window. > > > > This change moves the policy state to a global instance so it can be saved > > when the provider is destroyed and recreated. The new policy allows the > > first-ever scan to be performed immediately, and subsequent scans may also > > be performed immediately if enough time has lapsed since the previous scan. > > In all other situations, the configured polling interval is enforced. > > > > The global policy instance is leaked at shutdown. > > > > BUG=764954 > > > > Change-Id: If16c73dfd7d6535346e86d0fab5df24f0c7b297d > > Reviewed-on: https://chromium-review.googlesource.com/850444 > > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#527219} > > Bug: 764954 > Change-Id: I394a671cdbcdb58d6e80c201777465d1d304987b > Reviewed-on: https://chromium-review.googlesource.com/860778 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528466} TBR=reillyg@chromium.org,mattreynolds@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 764954 Change-Id: I402e6085d966e4ed0c385515b6edcedb0119bb69 Reviewed-on: https://chromium-review.googlesource.com/978422Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#545945}
-
Greg Thompson authored
The operation ("what time is it?") is conceptually const, so make the method so. Implementations that mutate their state now have such state expliclty marked as mutable. This change was inspired by review comments on product code that uses a TickClock for the sake of testability, in which the reviewers wondered why a TickClock* class member was not const. Prior to this change, the answer was "because it can't be". Following this change, the answer can be "because I forgot to do that. Thanks!" BUG=none Change-Id: I813c5359b143c52d86306200ef50eeac4a0003d1 Reviewed-on: https://chromium-review.googlesource.com/980052Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#545944}
-
Dale Curtis authored
http://crrev.com/477537 was the last attempt at this, it was reverted due to perf regressions and an MTBR reduction on YT. We'll watch this CL closely to ensure it doesn't cause any similar regressions to the first attempt. Here are the differences from the last attempt: - Only offloading 1 extra frame instead of 3. - No waiting for Reset() to complete (unnecessary). - GpuMemoryBuffer upload stage is in parallel now. This behavior only works with decoders that have synchronous Reset() and Decode() calls, which is all of our software decoders, but most importantly VpxVideoDecoder, which is the only offloaded video decoder at the moment. With this change the total time to read 4000 frames improves by 3x, from 11659350us to 3427885us and drops zero frames on average when running at 4K60 with https://www.youtube.com/watch?v=1La4QzGeaaQ BUG=731841, 801245 TEST=new tests, manual verification. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I20852897044c504088a83434d6bde60104822864 Reviewed-on: https://chromium-review.googlesource.com/945029 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545943}
-
Paul Dyson authored
Bug: 820883 Change-Id: Ia587c6747c6f954802308385676a29420533fa25 Reviewed-on: https://chromium-review.googlesource.com/974662Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545942}
-