- 09 Nov, 2019 6 commits
-
-
Sean Kau authored
Adding Printing.CUPS.HighestIppVersion which will record the largest version a printer supports when it is queried during setup. Bug: chromium:1020016 Change-Id: I7180ed1f147b812d660903381af7aaba6e500bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892193Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#714028}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c03ce008b9fe..ef55c4e738de git log c03ce008b9fe..ef55c4e738de --date=short --no-merges --format='%ad %ae %s' 2019-11-08 chrisforbes@google.com Fix PointCoord builtin Created with: gclient setdep -r src/third_party/swiftshader@ef55c4e738de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140680704 Change-Id: I8036cbeb1c31a3bb2dad59def390e9a701550bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714027}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdd7f421..f2af41c8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id703966e518bee4da60a2cc5a2ffccb599619fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714026}
-
Austin Orion authored
A couple of pixel-diff web tests that load videos are flakily failing when the video thumbnail doesn't load before the test completes. This change adds a call to requestAnimationFrame(), this will delay test completion until the next paint event which should ensure the thumbnail has time to render. These are the specific tests and examples of this failure: media/track/track-cue-rendering-vertical.html Actual output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=f442e58feefd4b369fe10ad79d0a08fd06c52e98&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Ctrack%5Ctrack-cue-rendering-vertical-actual.png Expected output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=1825086dd5eba7e7f44f92eb65f8a7d96d4d96a9&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Ctrack%5Ctrack-cue-rendering-vertical-expected.png media/video-display-toggle.html Actual output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=8af52e11ce9cde942897c679774a0cb7ee7defe2&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Cvideo-display-toggle-actual.png Expected output: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a3189550a01f577a6eb50ff52c912dee59a840bc&as=layout-test-results%5Cvirtual%5Caudio-service%5Cmedia%5Cvideo-display-toggle-expected.png Change-Id: I005c4795bf08a26dd3555f7e5050172897660dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901643Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714025}
-
Josh Karlin authored
What: Measures FCP of third-party iframes on pages. Note that this will be a bit wonky at times, as lazy-loaded frames will have a very long FCP. Why: So that we can measure the impact of triple-keying the cache on loading subframes. How: Added a third_party_metrics_observer metric. The class records third-party origin iframes FCP and remembers that the RenderFrameHost has been recorded so that it's not recorded again. Change-Id: Ib4b053eee81210a5ea0a2fec167d4f5995e29967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890996Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714024}
-
Wei-Yin Chen (陳威尹) authored
INITIAL_SCROLL_INDEX_OFFSET was not properly set if tab restoration finishes after tab switcher is shown. Bug: 1022289 Change-Id: I63d18d0fae7b6e6d40865667f7bd0fecdd684f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903526 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714023}
-
- 08 Nov, 2019 34 commits
-
-
Jon Mann authored
There was a 10px margin at the top of each collapsible section which was not included in the animation used when collapsing. This lead to a smooth animation for most of the collapse, followed by an awkward jump for the end of it. Fixed: 1009978 Change-Id: I04b94a4c8f497fe0d6e7574f201fae389b626d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907198Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#714022}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/814821a14375..5eb17d38f7f7 git log 814821a14375..5eb17d38f7f7 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 tsepez@chromium.org Better testing of CJS_Icon from JavaScript 2019-11-08 awscreen@chromium.org [FXCRT] Add unit tests for CFX_FloatRect::GetOuterRect() 2019-11-08 tsepez@chromium.org Remove bWillCommit argument from OnField_Format() methods. 2019-11-08 tsepez@chromium.org Cover some JS public methods that do not "commit". 2019-11-08 shwali@microsoft.com Fix nits in FPDFAnnot_SetAP 2019-11-08 tsepez@chromium.org De-virtualize CBC_OneDimWriter::RenderTextContents(). Created with: gclient setdep -r src/third_party/pdfium@5eb17d38f7f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1019026 Change-Id: I02c04c3f9bdff76dfc54dc080ef4789eef783c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907285Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Simplify ReturnToChromeTest before adding more tests to it in http://crrev.com/c/1903526. Bug: 1022289 Change-Id: I5faa1814addfa58f3cb5729b7176025ae3092fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904958 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#714020}
-
Chris Mumford authored
Switching to using a base::OnceClosure when calling RemotingDataStreamSender::set_connection_error_handler as it explicitly accepts a base::OnceClosure (see mojo/public/cpp/bindings/interface_ptr.h). TBR=erickung@chromium.org Bug: 1007810 Change-Id: I02aa1ea954c961b1a1158fc817969d5404936e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880147Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#714019}
-
Matt Menke authored
This was once used by a perftest, but that test was deleted over 2 years ago in https://codereview.chromium.org/2752713002 Bug: 701387 Change-Id: Ied2cc55f89bff9a13cf9fc07f9dc5fa64e115c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906304Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714018}
-
Peter Kotwicz authored
WebappActivity is the only class which extends SingleTabActivity. BUG=1022819 Change-Id: I1f837d2251f45e97b8dec8cbde2a53056867cb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906312 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714017}
-
Clark DuVall authored
This matches what the aidl processor will do in google3 and the behavior described in https://developer.android.com/guide/components/aidl. Change-Id: I849664d28642dfecd615ec1b4ae66821367312d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906305Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714016}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=tobiasjs@chromium.org Change-Id: I0f1ac37df2afda909b8fe018192197cce64a0e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906212Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714015}
-
James Cook authored
The build flag was introduced when we supported the app list on Windows, Mac and Linux. However, the app list currently only works on Chrome OS and it's been that way for years. Eliminate the separate build flag. This exposes some dead code (e.g. app list support for desktop linux) and unused art assets. We also don't need Title Case translations, since Chrome OS uses sentence case. This CL cleans up everything except chrome/test/BUILD.gn and chrome/chrome_paks.gni. For chrome/browser/extensions/component_extensions_whitelist: TBR=benwells@chromium.org Bug: 1022886 Change-Id: I6ddb06a27565f2ef765156b1db6b2fb2da7e420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906936Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714014}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=haraken@chromium.org Change-Id: I4b898b0988dfb741f6bb59544684ca69ff5f6b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887693Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714013}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility (slightly) and allows upcoming changes to gmock_mutant.h (switch away from base::Bind()). TBR=dimich@chromium.org Bug: 1007833, 806952 Change-Id: I47ece0d764fd503846ba788e5be5e0d53a8bce34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873399Reviewed-by:
-
Tommy Li authored
The previous way we counted async match changes in AutocompleteController was wrong, because I misunderstood how AutocompleteResult::CopyOldMatches works. Previously, CopyOldMatches would actually *move* the matches from the old result to the new result. This operation cleared out |last_result|. Since we determine if a match position has changed by comparing |last_result| to the new |result_|, this overinflated the number of changed matches. I've verified this by adding detailed logging on my test machine. This CL makes CopyOldMatches take a const parameter, and copy over the old matches without mutating |last_result|. I think there's no way for us to do this type of logging while still doing the destructive-move from |last_result|, and I suspect doing a copy instead of a move will have a negligible performance impact, and no memory impact. Bug: 398135 Change-Id: I0e1c5f58c6264b5be4c3d12366ae6e3c66f2a04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899314Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#714011}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16787735601c..39b4b38f4f36 git log 16787735601c..39b4b38f4f36 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 ellyjones@google.com mac newsdk: build glfw with -Wno-objc-multiple-method-names Created with: gclient setdep -r src/third_party/dawn@39b4b38f4f36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:973128 Change-Id: I2029461d55d6453b8dcdfbc21d836707bea8408c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906715Reviewed-by:
-
Felix Zhu authored
As part of FTP-048, unions will be migrated to use explicit ordinals. This updates all FIDL unions to use the explicit ordinal syntax. Bug: fuchsia:40859 Change-Id: Ie4cab2101cd7340affe8148cad7989a86776bbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899910Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Felix Zhu <fcz@google.com> Cr-Commit-Position: refs/heads/master@{#714009}
-
Nektarios Paisios authored
Every accessibility object has an ID that is used to identify the object in accessibility events, calls to methods that navigate the accessibility tree, such as IAccessible::get_accChild and get_accParent, etc. Before this patch, we were erroniously exposing an ID of -1 in the accessibility data of every View instead of its correct ID. R=aleventhal@chromium.org Change-Id: I77f31c2a3c0138ff505ff386999c60bf7465fac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907428Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#714008}
-
Victor Vasiliev authored
quic_transport_simple_server is a simple QuicTransport server that can discard or echo back all of the traffic it receives, depending on how it's configured. Note that I've not tested the functionality of this server fully (as I don't have a corresponding client binary), but it does correctly parse ALPN and reject HTTP/3 when offered. R=rch@chromium.org Change-Id: I6396e95d180a41a9afdb185f0891c787d0c67c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903958 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#714007}
-
Toni Barzic authored
Removes HomeScreenDelegate::UpdateAfterHomeLauncherShown, which was only updating expand arrow visibility, and move the logic to HomeScreenDelegate::OnHomeLauncherTargetPositionChanged. The method was used to update expand arrow visibility when home launcher is shown. Given that OnHomeLauncherTargetPositionChanged is expected to get called during the same sequence, expand arrow visilibity can be moved there without losing much, and reduces the number of methods that need to be called while using gestures to show/hide home launcher. Also, updates how app list progress is calculated when app list is scaled in tablet mode to ignore app list translation that was added during scaling (without this, if arrow is painted while app list view is scaled down, it might be slightly bent). BUG=1022530 Change-Id: Ie284b413bdc576121757c1c4bb1b4280c97e06b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904235Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#714006}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9709db85ca9..c1e84c789f8d git log e9709db85ca9..c1e84c789f8d --date=short --no-merges --format='%ad %ae %s' 2019-11-08 oysteine@google.com Merge "Re-land "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence"" Created with: gclient setdep -r src/third_party/perfetto@c1e84c789f8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3cc3f4de7db752e95d241ba91ac7fa25ede12bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907277Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ic8d59cb796fe30a71d4ed21abe9eda9202411ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906526Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#714004}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I394f1a6db39649ceab7eda3f0950425c5b0c0d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906122Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714003}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/50919254cbc7..c2f1f6188127 git log 50919254cbc7..c2f1f6188127 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 lehoangq@gmail.com Always use MTLPixelFormatBGRA8Unorm for SurfaceMtl. 2019-11-08 jonahr@google.com Reset texture swizzle state to default after LUMA workaround Created with: gclient setdep -r src/third_party/angle@c2f1f6188127 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1022080 Change-Id: I8e90d828cd012b89d9946f042bf4d838952c7f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907276Reviewed-by:
-
Etienne Bergeron authored
This test is broken due to the way the metrics are computed in RenderText Harfbuzz. Assume we have a text with 1) SUPERSCRIPT 2) NORMAL 3) SUBSCRIPT The NORMAL text is using a font 12px, and the SUBSCRIPT and SUPERSCRIPT are using a font 7 px. The metrics of both font will differs (not the same Ascent and Descent) and not same font-height. The baseline offset of 1) will be negative (e.g. -3) and the baseline offset of 2) will be positive (e.g. 3). The test is checking that the size of the text is within a bounding box. But the computation of that box is wrong. The TOP is the SUPERSCRIPT baseline + superscript_font.ascent. The BOTTOM is the SUBSCRIPT baseline - subscript_font.descent. The current computation is trying to find the max_ascent and max_descent and offset them on baseline. This computation is not giving the right bounding box. Bug: 459812 Change-Id: Id72f37888dfd2de4db2dc3b8704f06da01797cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906631 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714001}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a53e47fe9483..4135cf0b57c2 git log a53e47fe9483..4135cf0b57c2 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 mtklein@google.com use round() instead of trunc() to f32->unorm 2019-11-08 jlavrova@google.com Yet another build fix 2019-11-08 mtklein@google.com rename to_i32 -> trunc, and add round 2019-11-08 mtklein@google.com avoid redundant clamps 2019-11-08 mtklein@google.com don't clamp alpha, it's already [0,1] Created with: gclient setdep -r src/third_party/skia@4135cf0b57c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I8cd2dcd82d71352dc997d353334512e79c3a677c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906297Reviewed-by:
-
evliu authored
Bug: 997813 Change-Id: I08cab88280f727a67cd22ddc06b109e8663430c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904613 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713999}
-
Min Qin authored
If a download is interrupted in a terminal state, the information will be written to both history DB and in-progress DB. And the in-progress DB info will later be erased when download history is loaded. However, if Chrome crashes during the write, history DB could contain more recent information. If the same download is resumed in reduced mode later, loading the history DB could delete that download, causing Chrome to delete the DownloadFile object on UI thread while it is reading data on download task runner. This CL fixes the issue by: 1. Force in-progress DB to write download information immediately if a download is in a terminal state. 2. If a download is in terminal state in history DB and an in-progress DB version is already in-progress, ignore the history DB version and request it to be deleted. This matches the existing behavior if only history DB is used. (If only history DB is used, a crash before download terminal state is written to disk will make the download to be able to resume, even if a failed notification is already shown). BUG=1009839 Change-Id: Ic8621754e4961f665f3d42452a4e3794cbbc82bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898647 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713998}
-
Manu Cornet authored
Bug: 1021691, 1017435, 1019531 Change-Id: I62368e4167a747227007543118d1a0ed2bf9ffbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905746Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0db29887459d..f0ec2f973421 Created with: gclient setdep -r src-internal@f0ec2f973421 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7824298c5ed4c5d7b44272a3bdea6c97a2f69a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906720Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713996}
-
Xiaohan Wang authored
- Move ExpectRendererInitialization() into StartPipeline* to avoid having to call this in most tests. - Simplify audio/video DemuxerStream creation. Bug: 1018372 Test: Add new tests Change-Id: I834b40fe8b475ce94661162edec9ed576d161d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906256 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#713995}
-
Philip Rogers authored
LayoutObject::HasDistortingVisualEffects will crash if there are no local border box properties. This patch updates HasDistortingVisualEffects to mirror HasNonZeroEffectiveOpacity which has a check for no local border box properties. Bug: 1012596 Change-Id: Ib1c5260c3335c70098d9462c9c626774e3ed0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906709Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713994}
-
Yutaka Hirano authored
This is needed to start the experiment on beta. Bug: 1018081 Change-Id: I753809054a6f4d5119401ddc79439dcd3ca60713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902173 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Klaus Weidner authored
Copying a node's children happened asynchronously, resulting in them getting inconsistent worldMatrixDirty values and objects being rendered at the wrong place. Change-Id: If5bd6f166f24eabbcb628f70fba8f01b5a810490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907274 Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713992}
-
Fan Yang authored
Roll src/net/third_party/quiche/src/ 7a4d20901..ac35d459a91137d44e9418cc41e808a6d9bb466d (14 commits) https://quiche.googlesource.com/quiche.git/+log/7a4d20901fbb..ac35d459a91137d44e9418cc41e808a6d9bb466d $ git log 7a4d20901..ac35d459a91137d44e9418cc41e808a6d9bb466d --date=short --no-merges --format='%ad %ae %s' 2019-11-08 fayang Remove unused this from lamda function in QuicSentPacketManagerTest.RtoNotInFlightPacket 2019-11-08 fayang Loose the expectation of EndToEndTestWithTls.SendAndReceiveCoalescedPackets 2019-11-08 fkastenholz Handle case where crypto stream is not immediately available. 2019-11-07 nharper Add IsResumption method to QUIC client handshakers 2019-11-07 wub gfe-relnote: (n/a) Add pop_front_n and pop_back_n methods to QuicCircularDeque. Code not used yet. 2019-11-07 fayang gfe-relnote: In QUIC, do not inject bandwidth in BbrSender::AdjustNetworkParameters. Also use min rtt instead of srtt when calculating new cwnd. Protected by gfe2_reloadable_flag_quic_bbr_donot_inject_bandwidth. 2019-11-07 fayang gfe-relnote: In QUIC, call NeuterHandshakePackets() at most once per connection. Protected by gfe2_reloadable_flag_quic_neuter_handshake_packets_once2 which replaces gfe2_reloadable_flag_quic_neuter_handshake_packets_once. 2019-11-07 renjietang Remove QuicStream::read_side_closed(). 2019-11-07 renjietang Cleanup unused code in QuicStream. 2019-11-07 quiche-dev Fix invalid iterator bump in ValueSplittingHeaderListTest 2019-11-06 renjietang Remove member "perspective_" in QuicStream. 2019-11-06 dschinazi Add pretty-print logging for MessageResult 2019-11-06 renjietang Remove QuicStream::WritevData(). 2019-11-06 dschinazi Remove unimplemented method 2019-11-06 quiche-dev Internal QUICHE change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I233f0866873ce9f8e949a8de5fa768297b665427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906634Reviewed-by:
-
Kenneth Russell authored
The following tests are enabled: ContextLost_MacWebGLMultisamplingHighPowerSwitchLosesContext ContextLost_MacWebGLPreserveDBHighPowerSwitchLosesContext GpuProcess_mac_webgl_backgrounded_high_performance GpuProcess_mac_webgl_high_performance GpuProcess_mac_webgl_low_power GpuProcess_mac_webgl_terminated_high_performance Pixel_WebGLHighToLowPower Pixel_WebGLLowToHighPower Bug: 681341 No-Try: True Tbr: ccameron@chromium.org Tbr: jdarpinian@chromium.org Change-Id: I996cc9e195eb4d398691ee816cbf6c404be3f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906881 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713990}
-
Anastasia Helfinstein authored
In preparation for future changes, change the behavior of how Switch Access checks if a child node is a group from initializing a field on construction to implementing an abstract function. Bug: None Change-Id: I9a0657c19fcd7b3428ddfecb108d52a9cd0b2250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907192Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#713989}
-
