- 17 Mar, 2018 40 commits
-
-
Gabriel Charette authored
Scripted cleanup for upcoming CL. Removes browser_thread_impl.h from all files that didn't have "BrowserThreadImpl". TBR=jam@chromium.org Bug: 815225 Change-Id: Ica66babda894ef3f43981227f48e84f659a57897 Reviewed-on: https://chromium-review.googlesource.com/967545Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543922}
-
Karan Bhatia authored
This reverts commit 1f76c848. Reason for revert: WebViewTests/WebViewTest.DownloadCookieIsolation_CrossSession/0 is flaky with network service. Original change's description: > Fix webview tag's using an on-disk directory with the network service enabled. > > Bug: 769401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ia9ad46583b00f88631eccbc65c23cf6864134f26 > Reviewed-on: https://chromium-review.googlesource.com/965921 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543837} TBR=creis@chromium.org,jam@chromium.org,mmenke@chromium.org Bug: 769401, 822999 Change-Id: I0feb3dcddc8c7a767b1026c9f3a206419ab89225 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/967056Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543921}
-
Avi Drissman authored
It's unclear how much the "Start Speaking" on the whole page is used. It was implemented only three years ago and has never worked correctly. It's not clear what it even means to speak the entire web document for modern web pages. However, this makes a decent attempt at doing so. BUG=659753, 584798, 585164, 819773 TEST=as in 659753 Change-Id: I252f38c7c7879173c3c4e0afd9dc3a42c81b8a64 Reviewed-on: https://chromium-review.googlesource.com/956029Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543920}
-
Karan Bhatia authored
BUG=821547 TBR=hajimehoshi@chromium.org Change-Id: I6be988b01770624e793d5571e2dc37400e99c0bd Reviewed-on: https://chromium-review.googlesource.com/967511 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Saman Sami authored
As long as DevTools eyedropper tool is concerned, a snapshot is useless if any sort of downscaling has happened on it. Add an option to disable auto-throttling so that we get the highest resolution possible in any circumstances. Also added a missing call to SetMinSizeChangePeriod. Bug: 813929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9cca167e6f015bd12d8ce64c9ba04d87847f1c44 Reviewed-on: https://chromium-review.googlesource.com/963309 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543918}
-
Michael Giuffrida authored
AppShell's ShellNetworkDelegate shouldn't return a null pointer from GetWebRequestInfo() when ShellNetworkDelegate::OnBeforeURLRequest() hasn't been called for the request. This was happening when a <webview> had a URL like "ftp://example.com". AppShell was erroneously claiming that the URL would be handled by an external protocol handler, so ShellNetworkDelegate::OnBeforeURLRequest() wasn't called. Later, ShellNetworkDelegate::OnCompleted() would get called, where we expected to have already seen the URLRequest. A secondary fix is to stop pretending to support external protocol handlers. Bug: None Test: WebViewAPITest.TestLoadAbortUnknownScheme Change-Id: I776c6eaed4cfb58166ad7bf87bd87183507942f9 Reviewed-on: https://chromium-review.googlesource.com/966589 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#543917}
-
https://chromium.googlesource.com/catapult.git/+log/2fb447197524..fa0f0f2dd7e9 $ git log 2fb447197..fa0f0f2dd --date=short --no-merges --format='%ad %ae %s' 2018-03-16 nednguyen change ActualPageRunEndToEndTests.testTrafficSettings to use good3g for slow case Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I9ad46712f784b86c61d22f0aebc2489c337edc46 Reviewed-on: https://chromium-review.googlesource.com/967542Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543916}
-
Rob Dodson authored
Image: https://imgur.com/pv5mo8l Bug: 817199 Change-Id: I3f2fbdde41f5126be392e6197edbf5cf9cc44744 Reviewed-on: https://chromium-review.googlesource.com/961881Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Rob Dodson <robdodson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543915}
-
Sammie Quon authored
Last one of spec. Animates the "drag to use splitview" labels (slide in and out and also fade in and out). Create a new child view, which is the one which will get a rotation transform. The parent view will be the layer that gets translated. Note: p1 p2 p3 are called "splitview: Animate phantom window". Test: manual Bug: 808283 Change-Id: I95e1cef7056c1ab4272c05fc8a1a32187576e6bd Reviewed-on: https://chromium-review.googlesource.com/961497Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#543914}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9f6698fc..dd20cd72 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7bc857ad8e939cc326bf76dae61458890d87c12a Reviewed-on: https://chromium-review.googlesource.com/967517Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543913}
-
Donn Denman authored
Updates some experiment names for the field trial testing config to match what we want to use on the server. BUG=822087 Change-Id: Ieb710725624a7e8a1134d195fc8208b33d864336 Reviewed-on: https://chromium-review.googlesource.com/967347Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543912}
-
https://pdfium.googlesource.com/pdfium.git/+log/502e85921306..30e0498962e8 $ git log 502e85921..30e049896 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 thestig Add more tests for FPDFText_CountRects(). Created with: roll-dep src/third_party/pdfium BUG=821305 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id8e1d30ede2827a56fe5df4d626a9ce81b353e82 Reviewed-on: https://chromium-review.googlesource.com/966965 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543911}
-
Eugene But authored
Progress track used to be a part of download state icon. Now that state icon is programatically drawn the track should be a part of RadialProgressView. Bug: 820178 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b20faa6fbbc622de2763b962cc40539b22d24fc Reviewed-on: https://chromium-review.googlesource.com/966936 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543910}
-
Scott Chen authored
As of the time of this CL (M66), window's unload event doesn't not fire when the user navigates away with the back button. To make the behavior consistent between tab-closinng/reload/back, we instead listen to the beforeunload event. Bug: 806912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I319683f14284e4d6884aa22c84c78fea08ac78ef Reviewed-on: https://chromium-review.googlesource.com/965251 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543909}
-
Xiangjun Zhang authored
Add the video capture client implementation for the Mirroring service. It requests to start video capturing through the media::mojom::VideoCaptureHost interface, and receive the captured video frames through media::mojom::VideoCaptureObserver interface. Bug: 734672 Change-Id: I8007d9c8cbca1639eee8c5659f0b34a30c85e375 Reviewed-on: https://chromium-review.googlesource.com/954056Reviewed-by:
-
Maks Orlovich authored
This may hopefully make the next person seeing reports of strange 1-byte range requests for previously truncated files less flabbergasted. (And also documented some fields at high-level). Bug: 820862 Change-Id: I3bbb8fc46c2c5a015bf8669165add631df289486 Reviewed-on: https://chromium-review.googlesource.com/964981Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#543907}
-
Qiang Xu authored
changes: Per UI review, change snap height from 16 to 32. Bug: 812313 Test: manual test Change-Id: Ib55687b9105bd705ed081ccea9cb52d97f5442ff Reviewed-on: https://chromium-review.googlesource.com/963593 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#543906}
-
Mitsuru Oshima authored
ash is cros only so we don't need suffix any more. done by mass-rename.sh script. Display_animator_chromeos will be handled in a separate CL as I have to merge two files. BUG=None TEST=All test should pass. Change-Id: I824b69de4db0c787de926963a562cfb0dde64d70 Reviewed-on: https://chromium-review.googlesource.com/967457Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543905}
-
Karan Bhatia authored
This reverts commit 07737e12. Reason for revert: The CL did not resolve the issue. It seems the tests need to be suppressed in the LeakExpectations file instead. Original change's description: > Marking failures of layout tests on Webkit Linux Trusty > > Bug: 821547 > Change-Id: Idd4bd103a12935599a811a3d02b6f0071637543d > Reviewed-on: https://chromium-review.googlesource.com/961443 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Luna Lu <loonybear@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542892} TBR=loonybear@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821547 Change-Id: I9fa56a82a2ddd4e2f7c1b77aa8fce09a8b01b428 Reviewed-on: https://chromium-review.googlesource.com/967521Reviewed-by:
-
Ahmed Fakhry authored
Moving from a tab of a display that has more modes to a tab of another display that has less modes, where the selected mode of the first display has index >= max index of the second display's modes, this would result in the first display's mode changing to the previous one in the slider. This CL fixes this issue by ignoring change callbacks when the various parameters of the currently selected display are still out of sync. BUG=822248 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I97d1a55b87ad99d9d6821270618609a7c4a880a7 Reviewed-on: https://chromium-review.googlesource.com/965630 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543903}
-
James West authored
Introduce a new CmaBackend interface that is used by the CMA pipeline instead of the public MediaPipelineBackend interface. The two implementations of CmaBackend are MediaPipelineBackendWrapper and MultizoneCmaBackend. Use AudioDecoderSoftwareWrapper to wrap MediaPipelineBackend::AudioDecoder in AudioDecoderWrapper instead of wrapping the audio decoder in the pipeline so that AudioDecoderSoftwareWrapper no longer wraps MultizoneAudioDecoder, which never requires upstream software decoding, and MultizoneAudioDecoder no longer has to handle creating an AudioDecoderSoftwareWrapper in passthrough mode. Bug: internal b/62147653 Test: cast_media_unittests and manual Change-Id: I63fedd14065cd665d89cef7917dcc44f21ce1fd0 Reviewed-on: https://chromium-review.googlesource.com/963493 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543902}
-
Charles Harrison authored
These experiments have all landed as enabled by default. Bug: None Change-Id: I47f27ae2074d66e1a6454884253baae4443ab64f Reviewed-on: https://chromium-review.googlesource.com/965933Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543901}
-
https://skia.googlesource.com/skia.git/+log/0a86820f2fe3..876dd31483bc $ git log 0a86820f2..876dd3148 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 1c08cbb39..dfebe9b2d (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Iba52824b31f8095f04a7912b5611425f323512d6 Reviewed-on: https://chromium-review.googlesource.com/967460Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543900}
-
Muyuan Li authored
Bug: 820255 Test: Manual Change-Id: Ib0a2227350acceb2214e0ed77195473a546f245a Reviewed-on: https://chromium-review.googlesource.com/923179 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543899}
-
Victor Vasiliev authored
Update the values of the feature flags Set FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2 true Set FLAGS_quic_reloadable_flag_quic_disable_version_37 true Set FLAGS_quic_reloadable_flag_quic_disable_version_38 true FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay is deprecated. FLAGS_quic_reloadable_flag_quic_use_control_frame_manager is deprecated. Identify QUIC streams which should not be registered with the write blocked list using a constructor argument of the stream instead of checking the static_streams_ map in the QuicSession, which is not correctly populated when the check is performed. protected by FLAGS_quic_reloadable_flag_quic_register_streams_early2. Merge internal change: 188654154 https://chromium-review.googlesource.com/c/967182/ Remove unused typedef from BandwidthSampler code Merge internal change: 188514269 https://chromium-review.googlesource.com/c/967108/ Expore an accessor to initalized_ in QuicClient Merge internal change: 188509171 https://chromium-review.googlesource.com/c/967106/ In QUIC, stop sending a redundant PING every 20 acks, because a WINDOW_UPDATE is guaranteed to be sent. Protected by FLAGS_quic_reloadable_flag_quic_remove_redundant_ping. Although this WINDOW_UPDATE and PING will be bundled in the same packet, it is better to remove it. Merge internal change: 188486725 https://chromium-review.googlesource.com/c/967012/ Add bool return value to QuicSentPacketManager::OnIncomingAck() and ::OnAckFrameEnd() to indicate if a new packet has been ACKed. Merge internal change: 188389208 https://chromium-review.googlesource.com/c/967000/ Add IETF-format framer/deframer for the STOP SENDING Frame. Work done in preparation for developing the IETF version of QUIC Merge internal change: 188356015 https://chromium-review.googlesource.com/c/966998/ Let QUIC always discard outgoing packets after connection close. Protected by FLAGS_quic_reloadable_flag_quic_always_discard_packets_after_close. Merge internal change: 188341773 https://chromium-review.googlesource.com/c/966462/ Add Framer/Deframer for IETF QUIC Stream Reset frame Merge internal change: 188331903 https://chromium-review.googlesource.com/c/967002/ Replace a personalized TODO with a bug ID reference Merge internal change: 188320993 https://chromium-review.googlesource.com/c/963772/ Call OnSuccessfulVersionNegotiation earlier on server The server already has cases where version negotiation is completed without verifying authenticity of the packets from the client, but there was one case where it waited to do that before finishing. This changes the order of processing so that version negotiation (on a server) always completes before we have to decrypt a packet. This allows using OnSuccessfulVersionNegotiation as the signal to set the initial crypters for IETF QUIC. Changes when QUIC version negotiation completes on a server. Protected by FLAGS_quic_reloadable_flag_quic_server_early_version_negotiation Merge internal change: 188255217 https://chromium-review.googlesource.com/c/964806/ Deprecate FLAGS_quic_reloadable_flag_quic_use_control_frame_manager. Merge internal change: 188223533 https://chromium-review.googlesource.com/c/963855/ Fixed 3 DeadCode findings in 3 paths: //net/quic/quartc/quartc_stream.cc //net/quic/quartc/quartc_stream.h //net/quic/quartc/quartc_stream_interface.h * connection_error appears to be dead. (3 times) Merge internal change: 188124383 https://chromium-review.googlesource.com/c/964724/ Add QUIC_FLAG_COUNT macros for two flags The macros are added for FLAGS_quic_reloadable_flag_quic_store_version_before_signalling and gfe2_reloadable_flag_delay_quic_server_handshaker_construction. Merge internal change: 188083245 https://chromium-review.googlesource.com/c/964721/ Small refactor. Not flag protected. - Add WRITE_STATUS_MSGSIZE to gfe_quic::WriteStatus. But it is not set anywhere yet. - Add IsWriteError(WriteStatus status) to tell if |status| is an error. It is equivalent to the existing "status == WRITE_STATUS_ERROR" check since WRITE_STATUS_MSGSIZE is not set anywhere. - Add a QuicConnection::IsMsgTooBig(const WriteResult& result). It is equivalent to the existing check since WRITE_STATUS_MSGSIZE is not set anywhere. Merge internal change: 188062461 https://chromium-review.googlesource.com/c/964701/ Deprecate FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay. Merge internal change: 188050187 https://chromium-review.googlesource.com/c/963223/ R=rch@chromium.org Change-Id: Ib28a94eddbd95abff0b6b267c37d7f9f0a97bc95 Reviewed-on: https://chromium-review.googlesource.com/967100Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#543898}
-
Esmael El-Moslimany authored
Bug: 819996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab8fa2d66ab07cc0f8c0c9c4509f40563dfe0dd6 Reviewed-on: https://chromium-review.googlesource.com/956242 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543897}
-
Pavel Feldman authored
Change-Id: Ibf1a705b7106ea2a04d45f553819b20d1a37fc3e Reviewed-on: https://chromium-review.googlesource.com/965602Reviewed-by:
-
Mitsuru Oshima authored
These will be used for ARC++ windows. This also moves the back button asset to ash/public/cpp/vector_icons where they should be. BUG=822960 Change-Id: Ie26b11c1eacbef8cce9e6f07a17ba8daf2c80754 Reviewed-on: https://chromium-review.googlesource.com/966942Reviewed-by:
-
Kyle Horimoto authored
See go/unified-better-together-cros for an outline of this service. This CL does the following: (1) Creates a Mojo interface for the service, adding only a single function for now. (2) Creates the MultiDeviceSetupService and MultiDeviceSetupImpl classes which implement this interface, as well as a test for the service. (3) Registers the service in the browser process via ProfileImpl. (4) Generates JavaScript files for the interface; because these files are the first resources generated in //chromeos, this CL also adds a new chromeos_resources.grd. (5) Adds the new "multidevice_setup" capability to the content_browser manifest file so that it can be used by content_renderer. (6) Adds a new button on the chrome://proximity-auth debug WebUI page which makes a Mojo call to the service. Change-Id: I0b74373b78a1c92fe01d789028342707321c2134 Reviewed-on: https://chromium-review.googlesource.com/954010Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#543894}
-
Esmael El-Moslimany authored
Bug: 819996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a9fff7afcc4fa17f742bcad6bb102a8f6271881 Reviewed-on: https://chromium-review.googlesource.com/963694 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#543893}
-
rbpotter authored
Make custom margins draggable and allow for updates with text boxes. Does not yet update margins ticket item or limit margins values based on page size. Bug: 773928, 812095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifa0e270bb32cc77c420788dae2daecf7817c063f Reviewed-on: https://chromium-review.googlesource.com/961483 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/bf3dbb4a692f..317a5228766f $ git log bf3dbb4a6..317a52287 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie886c3b21a2a5959e36cefb06dc8bb4a00670339 Reviewed-on: https://chromium-review.googlesource.com/967005Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543891}
-
https://chromium.googlesource.com/catapult.git/+log/16322a374abb..2fb447197524 $ git log 16322a374..2fb447197 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 dtu [pinpoint] Show "my jobs" only. 2018-03-07 konkers [fuchsia] Add thread state to fuchsia importer. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6f741503c19384b9f52577ecd66b1ddb2708084c Reviewed-on: https://chromium-review.googlesource.com/967257Reviewed-by:
-
Zhiling Huang authored
Bug: 790142 Change-Id: I77f5fa5dc4a45248af2dbe527d20f5ccdffa8eac Reviewed-on: https://chromium-review.googlesource.com/967004 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543889}
-
https://pdfium.googlesource.com/pdfium.git/+log/9d7c7ff0a5f0..502e85921306 $ git log 9d7c7ff0a..502e85921 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 thestig Rename some variables in FPDFTextEmbeddertest. 2018-03-16 thestig Fix methods that have definition with different parameter names. 2018-03-16 hnakashima Fix typo in doc of FPDFDest_GetDestPageIndex. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia8803889d774c214787128411580a40dc131580b Reviewed-on: https://chromium-review.googlesource.com/967368 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Jose Dapena Paz authored
CHECK() implementation for arm, arm64, x86 and x64 includes asm() statements. Recently added bounds checks using it on constexpr methods are breaking GCC build, as GCC follows more strictly C++14/11 standard, that explicitely forbids calling asm from constexpr. But GCC does not complain if the asm statement is not directly called from constexpr, but through a function call. So wrap the GCC asm calls for IMMEDIATE_CRASH in a lambda function. Bug: 821357 Change-Id: I9b806fa09eda872fb2b8e81cc79d8a4ea20e3e0b Reviewed-on: https://chromium-review.googlesource.com/960861 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Scott Violet authored
This reverts commit d13c288b. Reason for revert: Two serious issues have come up: 822917 and 822577. Original change's description: > reland attempt 3: Adds WindowService-ChromeOS fieldtrial > > I'm not sure on the name here. I went with WindowService-ChromeOS as > at some point we will launch the WindowService on other platforms, but > that won't be anytime soon and is likely to be very different. So, I'm > thinking later on we have the field trial WindowService-Desktop. > > BUG=814898 > TEST=none > TBR=rkaplow@chromium.org > > Change-Id: I555c9cea0f59c28b2e6124196f362ac3231104fc > Reviewed-on: https://chromium-review.googlesource.com/962877 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543156} TBR=sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814898 Change-Id: I2290fd6ee56d985117b772f4554eac6e2e658b99 Reviewed-on: https://chromium-review.googlesource.com/966694Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543886}
-
Aleks Totic authored
Root cause of missing invalidations: LayoutObject::AdjustStyleDifference was not marking LayoutText with NG rendering as NeedPaintInvalidation. This caused invalidation not to propagate to document. It was not marked because LayoutObject:1789 ToLayoutText(this)->HasTextBoxes() always returned false for NG. The fix was to make HasTextBoxes() NG-aware. This caused 2 callers of HasTextBoxes() to behave incorrectly. Created HasLegacyTextBoxes(), and added a TODO to remove them. Bug: 819372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If2c4ddc0c9c707d11bb9115ef26ac578387c8359 Reviewed-on: https://chromium-review.googlesource.com/961526 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543885}
-
Sandeep Vijayasekar authored
Besides setting this flag at creation time, it can be useful to enable later. Bug: internal b/69007670 Test: none Change-Id: I95d1eaa557e91c9c7e4ed29787928adbdb388ee2 Reviewed-on: https://chromium-review.googlesource.com/961543 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
-
Charlie Reis authored
This reverts commit 431c6dbf. Reason for revert: r543765 caused more test failures, tracked in https://crbug.com/822980. Original change's description: > Revert "Disable wheel scroll latching in failing content_browsertests." > > This reverts commit f2bf009a. > > Reason for revert: There has been a few bug fixes related to oopif and > latching, I will enable the latching flag to see if the failing tests > are fixed or not. If not I will disable the tests again addressing crbug.com/822764 bug as well. > > Original change's description: > > Disable wheel scroll latching in failing content_browsertests. > > > > I cannot reproduce the test failures on my local official windows build, > > in this cl I force wheel scroll latching to be disabled in the tests to > > see if it changes the test results on Win official or not. > > > > Bug: 800822 > > Change-Id: Ife07a29617ca5e0142e75f926967685cb61e2a08 > > Reviewed-on: https://chromium-review.googlesource.com/895842 > > Reviewed-by: James MacLean <wjmaclean@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#533347} > > TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 800822, 822764 > Change-Id: I563672dfbcb01298324a2b884cbed0e69c220339 > Reviewed-on: https://chromium-review.googlesource.com/966687 > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543765} TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org Change-Id: Ie0212e01b308826c96eac54b86168ce9d1d04231 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800822, 822764 Reviewed-on: https://chromium-review.googlesource.com/967522Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#543883}
-
