GitLab

TBR=xjz@chromium.org

Bug: 754872, 806715
Change-Id: Iea4cdc3fd17315ad688b48312a0185c114cc8908
Reviewed-on: https://chromium-review.googlesource.com/892053Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532691}

Chrome doesn't compute descendant name on focus in this case.

Bug: 795275
Test: manually on twitter.com using j/k. Verify all text gets read.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3bf48846aac498655cae8488331df09b65ff9b53
Reviewed-on: https://chromium-review.googlesource.com/881884
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532690}

R=pfeldman@chromium.org

Bug: none
Change-Id: I101d69a1b9efdb399a1ced589e3e7f74602ff576
Reviewed-on: https://chromium-review.googlesource.com/889919Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532689}

This CL implements URLLoader::OnCertificateRequested for network
service. It adds a mojo interface OnCertificateRequested for
NetworkServiceClient, and also adds a SSLPrivateKey mojo interface
to be implemented by browser side and used on the network side.

The design doc is at:
https://docs.google.com/document/d/1H6tdoFgx1JP0fjnVUWxmhwidKz1_DUemTxzteztOhaQ/edit

Bug: 783996
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I29ac6ab766d18d3ffbbaf2ca9512039b778d03b0
Reviewed-on: https://chromium-review.googlesource.com/848303Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532688}

Bug: 807038
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I499028acf6ccfc8fbeb07fc32bc703593c030325
Reviewed-on: https://chromium-review.googlesource.com/892046Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532687}

* Allow --mus on all channels (canary, dev, beta, stable).
* Allow --mash on everything but stable.
* Ensure only one copy of the --mus flag if the user specifies
  both --mus and --mash. The build will run in --mash mode.

Bug: none
Test: about:flags has both options separately
Change-Id: Ic111189e288a8784718f4df0a99bae865734fe6f
Reviewed-on: https://chromium-review.googlesource.com/891624Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532686}

If a [Root]CompositorFrameSinkImpl in FrameSinkManagerImpls
|compositor_frame_sinks_| wasn't deleted before FrameSinkManagerImpl
is destroyed then we can end up running the CompositorFrameSinkSupport
destructor twice. It looks like flat_map::clear() runs the
CompositorFrameSinkSupport destructor before removing the items from the
map, so when CompositorFrameSinkSupport calls back into
FrameSinkManagerImpl::UnregisterCompositorFrameSinkSupport() the entry
is still in the map and gets removed, running the
CompositorFrameSinkSupport destructor a second time.

Separate the map that contains SinkAndSupport into two maps. This will
avoid future errors using iterators after they've been invalidated.
|sink_map_| can be removed with OOP-D when all CompositorFrameSinks are
owned inside FrameSinkManagerImpl.

This is a different approach to https://crrev.com/c/874813 which was
reverted.

Bug: 803405
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I92c230e57dc471f4b16125b0edb3a0618c01930f
Reviewed-on: https://chromium-review.googlesource.com/891424Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532685}

r531270 refactored HeaderChecker to use an atomic counter to track the number of
header-checking tasks.  The main thread waits on the task count becoming zero,
and the task counter is decremented whenever a task completes.  However, the
main thread didn't increment the task counter when it created a task, so the
counter would count into negative values and never reach zero, hanging gn
indefinitely.  The fix is to increment the counter when posting a task.

R=dpranke
CC=fdoray

Change-Id: Id55f943cf0e2af3e9e5af5f3dddf8a7b7671eaac
Reviewed-on: https://chromium-review.googlesource.com/889930Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532684}

Simplifies logging by always appending the current location
(i.e. function name) when LOG() or LOG_ERRNO() are called.

This makes client code smaller and easier to write / read at
the same time.

BUG=NONE
R=pasko@chromium.org,agrieve@chromium.org,rmcilroy@chromium.org

Change-Id: I820c2584eee4cd476bda7e6fb99bbd27782858d7
Reviewed-on: https://chromium-review.googlesource.com/891233Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532683}

Remove dezippering from delayTime.  The value will now change
immediately instead of gradually changing from the old to new
value.

Chromium Feature: https://www.chromestatus.com/features/5287995770929152
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ

Bug: 550533
Test: Delay/dezipper.html
Change-Id: Id3ce76401d4342205c5d67079f6684514ae7e2a2
Reviewed-on: https://chromium-review.googlesource.com/609443
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532682}

This CL was uploaded by git cl split.

R=patricialor@chromium.org

Bug: 177475
Change-Id: Idae699da611562f3d75fdd07c915265c204b74c7
Reviewed-on: https://chromium-review.googlesource.com/891884Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532681}

https://skia.googlesource.com/skia.git/+log/caaf211e8dd0..b0c427b1f286

$ git log caaf211e8..b0c427b1f --date=short --no-merges --format='%ad %ae %s'
2018-01-29 halcanary SkQP: error image now opaque
2018-01-29 fmalita [skottie] Layer clip support
2018-01-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e4741fd0f..37b697edf (1 commit)
2018-01-29 bungeman Don't add lines that don't fit on the page.
2018-01-29 halcanary SkQP: ResourceFactory
2018-01-29 reed check that rect is finite before jamming our bounds
2018-01-29 fmalita [skottie] Time start, time stretch
2018-01-29 reed handle conics in 1D patheffect

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I67956b1063bc8f706e37d84eba1950c98ba7c37d
Reviewed-on: https://chromium-review.googlesource.com/891625
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#532680}

This CL was uploaded by git cl split.

R=pkotwicz@chromium.org

Bug: 177475
Change-Id: I0b25a266bda563f3ad25524cb337f8b6b6a30564
Reviewed-on: https://chromium-review.googlesource.com/891501Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532679}

See BUG for more details. With this CL, for a given key system, the
first registered CDM will always be used for handling the capability
query, and for creating the CDM instance. Hence, there's no way for any
inconsistency to happen (as described in the BUG).

This means that a later registered CDM will not be used until browser
restart (e.g. component updated CDM), which should be fine in most
cases.

BUG=599588

Change-Id: I9390f4ea73e5f40395ab8f87fc1d9c1c1f5c75ad
Reviewed-on: https://chromium-review.googlesource.com/889982Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532678}

https://boringssl.googlesource.com/boringssl/+log/94cd196a80252c98e329e979870f2a462cc4f402..a62dbf88d8a3c04446db833a1eb80a620cb1514d

Bug: crbug.com/boringssl/183

Change-Id: I37c7e11dab9c445fa9588fee4291dba597ad3223
Reviewed-on: https://chromium-review.googlesource.com/891698
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532677}

Bug: 799101
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If760fdaf17dfe79b54510c0eaa2e670dfb326a2c
Reviewed-on: https://chromium-review.googlesource.com/882665
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532676}

This CL corrects the wrong UV ordering for the call to x010ToAR30() in
GpuMemoryBufferVideoFramePool, and also corrects the IOSurface format
used for creation, from 'R10k' to 'l10r' [1], the latter having the
correct channel endianness (i.e. XR30 == BGRX2101010 [2] .

tested via e.g.
./out/gn/Chromium.app/Contents/MacOS/Chromium 'http://crosvideo.appspot.com?codec=vp9.2&loop=true'
./out/gn/Chromium.app/Contents/MacOS/Chromium 'http://crosvideo.appspot.com?codec=vp9.2&loop=true' --disable-mac-overlays

both showing correct colors :-)

[1] https://github.com/phracker/MacOSX-SDKs/blob/HEAD/MacOSX10.13.sdk/System/Library/Frameworks/CoreVideo.framework/Versions/A/Headers/CVPixelBuffer.h#L83
[2] https://github.com/torvalds/linux/blob/master/include/uapi/drm/drm_fourcc.h#L98

Bug: 797347
Change-Id: I56c06fc06bef950ba2053750cdd7aee937e3c00b
Reviewed-on: https://chromium-review.googlesource.com/891521Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532675}

Bug: 784451
Change-Id: I62f97469bc9cf4c1aad0cc9ed5695b8a20012e18
Reviewed-on: https://chromium-review.googlesource.com/888262Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532674}

TBR=falken@chromium.org

Bug: 807014
Change-Id: I14f0ed5edfe3ace787c74b9f518c46c154477a45
Reviewed-on: https://chromium-review.googlesource.com/892038Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532673}

Do not place magic constant before the sampled allocations.
This have the following benefits:
  - Much simpler logic of allocator hooks.
  - Will later allow easily hook Oilpan allocator and PartitionAlloc
    as they do not allow shimming, but just provide observers interface.

The only negative effect is lower performance, but it will be addressed
in an upcoming patch.

BUG=803276

Change-Id: Ia3de003f0b7286a1be4e62a33be28b1770f73018
Reviewed-on: https://chromium-review.googlesource.com/890819
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532672}

This CL was uploaded by git cl split.

R=mfoltz@chromium.org

Bug: 177475
Change-Id: Ie99aa136b2a0d27de3e24ae1e9b737edd0c6e875
Reviewed-on: https://chromium-review.googlesource.com/891921Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532671}

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 177475
Change-Id: I30f6a677a1010ecd066fc06255aa0270e9f540fe
Reviewed-on: https://chromium-review.googlesource.com/891479Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532670}

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/887970.

MSAN use-of-uninitialized-value should be fixed.

Change-Id: I392ad1a83a269b47ff0c8583f6c72e18a4a0e5b9
Reviewed-on: https://chromium-review.googlesource.com/891302
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532669}

Change-Id: I8e9916fdd83b22f998f666f34df56a3d2552094b
Reviewed-on: https://chromium-review.googlesource.com/891809
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532668}

This CL was uploaded by git cl split.

R=qinmin@chromium.org

Bug: 177475
Change-Id: Ia84c9f7e74db4c035d44db9df84c3113474d74b4
Reviewed-on: https://chromium-review.googlesource.com/891901Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532667}

Bug: 807045
Change-Id: I6c834af2f380719959fc5650693f73c87d7a8a36
TBR: skyostil
Reviewed-on: https://chromium-review.googlesource.com/891600Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532666}

Adds code to download the VR Keyboard APK alongside the other VR test
APKs, and modifies the Telemetry benchmarks to install it before a
test.

Bug: 807022
Change-Id: I3c7030bb9b8399e74d136dedc5e8b4e6630d90b1
Reviewed-on: https://chromium-review.googlesource.com/891576Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532665}

This CL was uploaded by git cl split.

R=msw@chromium.org

Bug: 177475
Change-Id: I3aa4567f8f5ffd0b25369015475545918ecf48cd
Reviewed-on: https://chromium-review.googlesource.com/891747Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532664}

Remove dezippering from the frequency and detune attributes. The values
are changed immediately instead of gradually changing from the old
value to the new.

Chromium Feature: https://www.chromestatus.com/features/5287995770929152
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ

Bug: 752987
Test: Oscillator/dezipper.html
Change-Id: I58df869ca99a24f6429c9cc50c1af2101dbdf03d
Reviewed-on: https://chromium-review.googlesource.com/609095
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532663}

I took peak memory usage stats for top3 largest binary link using the same args.gn with linux_chromium_rel_ng.
229MB chrome: 2.22 GB peak memory
260MB browser_tests: 2.56 GB peak memory
258MB unit_tests: 2.57 GB peak memory

So 3GB is sufficient.

This will help to speed up build like below.
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634117
ninja trace: https://chromium-build-stats.appspot.com/ninja_log/2018/01/29/slave645-c4/ninja_log.slave645-c4.chrome-bot.20180129-023145.30339.gz/trace.html
Some newlib_pnacl related binary prevent mksnapshot to be linked due to small link pool and many targets indirectly depends on mksnapshot.


Change-Id: I7c58aec10949c350bbce0a97704048caf44f5b96
Reviewed-on: https://chromium-review.googlesource.com/891043Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#532662}

This CL is a speculative fix for the observed flakiness of this
test on TSAN linux. It seems that the old method of waiting for the
scroll data to propagate back to the browser, namely using a
UpdateResizeParamsMessageFilter to wait for the frame rects to
change, is no longer sufficient to synchronize. It's also necessary to
wait for the child-frame to draw its compositor frame so that the
transform functions used in TouchSelectionControllerClientChildFrame's
DidScroll() method will work properly (they rely on the compositor
surfaces to reflect the scroll changes).

Bug: 805017
Change-Id: I69ec3f318af8adb224d7fb54be1d00ec3c6caae8
Reviewed-on: https://chromium-review.googlesource.com/889864
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532661}

According to the spec, https://www.w3.org/TR/css-scroll-snap-1/,
:target/scrollIntoView()/etc should take scroll-margin, into account.

This patch also unifies the logic of ScrollIntoView() in PaintLayerScrollableArea,
LocalFrameView and RootFrameViewport, so that the new_scroll_offset is calcultated
directly by ScrollAlignment::GetScrollOffsetToExpose()


Bug: 803606
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie790bc58f7dcc0a2744768ddca0d07b24bbf6681
Reviewed-on: https://chromium-review.googlesource.com/875008Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532660}

This warnings should always be fixed in new code.

Bug: 801256
Change-Id: I6089a070efc7a5dfa276417f6035b3109e5dc565
Reviewed-on: https://chromium-review.googlesource.com/891483Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532659}

VC++ PGO builds crash deep inside memmove, as called by
message_center::InnerBoundedLabel::GetSizeForWidthAndLines which calls
base::JoinString and then ultimately basic_string<>::append and memmove.
Inspection of the stack and the generated code shows that
base::JoinString is called correctly but that base::JoinString (or the
inlined JoinStringT and three other levels of inlining) fail to read
separator off the stack correctly - they read it from an address that is
four bytes too early. This leads to copying too many bytes from the
wrong address.

Fully disabling optimizations in VC++ builds for the affected function
seems like the right fix. If time permits then a reduction and VC++ bug
will be created. However if this is a PGO-only bug then...

Bug: 804884
Change-Id: I80fd8e693a35b26a386cd99a1b17c54bede95d5c
Reviewed-on: https://chromium-review.googlesource.com/891569Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532658}

Change-Id: Ibbc3203a8d6107879cfa16e9970e6d7d69f422c0
Reviewed-on: https://chromium-review.googlesource.com/889649
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532657}

TBR=jochen@chromium.org

Change-Id: Ib27f59fe20674f81a077895c69cff28f753bb705
Reviewed-on: https://chromium-review.googlesource.com/887461Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532656}

GetFactoryLocale returned set value.
verified GetFactoryLocale returned set value.

Bug: internal b/72610561
Test: Set ro.product.locale through factory partition, verified
Test: Set ro.product.locale.language/region through factory partition,
Test: Left properties unset, verified GetFactoryLocale returned "en-US".
Change-Id: Ia0e48dd77a2825e6eed09d1e04331b713afb32a3
Reviewed-on: https://chromium-review.googlesource.com/889935
Commit-Queue: Bryan Henry <bryanhenry@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532655}

Removes the "nosync" testing since this no longer applies to the new tab
capture impl (because it is necessarily triggered by OnBeginFrame's).
Also, added a call to BrowserTestBase::UseSoftwareCompositing() when the
non-GPU variants are run to ensure the GPU compositor is not being used.

TBR=xjz@chromium.org

Bug: 806400, 567848
Change-Id: I1d00a5f95ee6d3ac8caf0e5d1191c7bb03ca8064
Reviewed-on: https://chromium-review.googlesource.com/892049Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532654}

This CL:
- Removes ChildProcessLauncherHelper#mCreationParams
- Moves public static ChildProcessCreationParams accessors from
  ChildProcessLauncherHelper.java to ChildProcessCreationParams.java
- Changes type of
  ChildProcessLauncherHelper#sSandboxedChildConnectionAllocatorMap
  from
    Map<String, ChildConnectionAllocator>
  to
    ChildConnectionAllocator
  (The map is no longer needed because WebAPKs no longer have special
   ChildProcessCreationParams)
- As there is now just one sandboxed ChildConnectionAllocator we now no
  longer free the allocator when the last connection is freed. This matches
  what we do for
  ChildProcessLauncherHelper#sPrivilegedChildConnectionAllocator

Deleted tests:
- Tested creating multiple allocators
  - testAllocatorForPackage()
  - testCustomCreationParamDoesNotReuseWarmupConnection() introduced in
    https://codereview.chromium.org/2705133002
- Tested that ChildConnectionAllocator is freed when last sandboxed connection
  was freed
  - testSandboxedAllocatorFreed() introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/513587
  - testSandboxedAllocatorFreedWith2Connections() introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/588380

BUG=797999

Change-Id: I2147ae24d99a7e8b2d93bb7f5a4a2b5ae37172f8
Reviewed-on: https://chromium-review.googlesource.com/884621
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532653}

This CL adds a check to WasRecentlyAudible before adding a mute icon to
a tab to avoid always showing a mute icon when a tab is muted. This also
adds the fade animation to the (mute icon)->(no icon) transition. Since
adding the fade animation breaks a TabTest unit test (which worked under
the assumption that each of its transitions was instantaneous), this CL
also manually stops fade animations in that test.

Bug: 785406
Change-Id: I0d7fd732b605f634f9df59b736dd7f19c382a09e
Reviewed-on: https://chromium-review.googlesource.com/889178Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532652}